[SSSD] [sssd-1-13] [PATCH] UTIL: Backport error code ERR_ACCOUNT_LOCKED

2016-02-17 Thread Lukas Slebodnik
ehlo, Attached patch fixes failures in 1.13 branch http://sssd-ci.duckdns.org/logs/job/37/45/summary.html LS >From 9db80c419a357f6b147e3595e1e063f6d0e2a2ff Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 17 Feb 2016 17:58:10 +0100 Subject: [PATCH] UTIL: Backport error c

[SSSD] Re: [sssd-1-13] [PATCH] UTIL: Backport error code ERR_ACCOUNT_LOCKED

2016-02-18 Thread Lukas Slebodnik
On (17/02/16 18:04), Michal Židek wrote: >On 02/17/2016 06:01 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Attached patch fixes failures in 1.13 branch >>http://sssd-ci.duckdns.org/logs/job/37/45/summary.html >> >>LS >> >> > >LGTM, will wai

[SSSD] Re: [PATCH] sss_idmap-tests: Fix segmentation fault

2016-02-18 Thread Lukas Slebodnik
On (17/02/16 18:38), Sumit Bose wrote: >On Wed, Feb 17, 2016 at 05:37:51PM +0100, Sumit Bose wrote: >> On Wed, Feb 17, 2016 at 05:29:50PM +0100, Lukas Slebodnik wrote: >> > ehlo, >> > >> > simple patch is attached. >> > >> > I can reproduc

[SSSD] [PATCH] CLIENT: Retry request after EPIPE

2016-02-18 Thread Lukas Slebodnik
I ran mini_cron reprodurer for a week and it didn't fail. LS >From 43d4982ed6e578fbb489da96d8fd71fcb5e6cd2a Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 17 Feb 2016 15:21:55 +0100 Subject: [PATCH] CLIENT: Retry request after EPIPE We have a function sss_cli_check_socket which

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-02-19 Thread Lukas Slebodnik
On (01/02/16 14:33), Lukas Slebodnik wrote: >On (01/02/16 09:31), Lukas Slebodnik wrote: >>On (30/01/16 00:00), Jakub Hrozek wrote: >>>On Fri, Jan 29, 2016 at 08:24:00PM +0100, Lukas Slebodnik wrote: >>>> On (29/01/16 18:50), Jakub Hrozek wrote: >>>>

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-02-19 Thread Lukas Slebodnik
On (19/02/16 16:06), Michal Židek wrote: >On 02/19/2016 02:44 PM, Lukas Slebodnik wrote: >> >>+static void try_open_krb5_conf(void) >>+{ >>+int fd; >>+int ret; >>+ >>+fd = open("/etc/krb5.conf", O_RDONLY); >>+if (fd

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-19 Thread Lukas Slebodnik
On (18/02/16 13:34), Petr Cech wrote: >On 01/29/2016 02:55 PM, Lukas Slebodnik wrote: >>On (29/01/16 14:15), Lukas Slebodnik wrote: >>>On (06/01/16 13:47), Petr Cech wrote: >>>//snip >>>>Lukas, thanks for careful review. >>>> >>>>The

[SSSD] Re: [PATCH] krb5_child: Warn if user cannot read krb5.conf

2016-02-19 Thread Lukas Slebodnik
On (19/02/16 17:01), Michal Židek wrote: >On 02/19/2016 04:17 PM, Lukas Slebodnik wrote: >>On (19/02/16 16:06), Michal Židek wrote: >>>On 02/19/2016 02:44 PM, Lukas Slebodnik wrote: >>>> >>>>+static void try_open_krb5_conf(void) >>>>+{ >&

[SSSD] Re: proposed libipa_hbac changes

2016-02-22 Thread Lukas Slebodnik
On (22/02/16 10:01), Jakub Hrozek wrote: >Hi, > >during my work on pam_hbac I ran into some issues in libipa_hbac that I >would like to fix. And before doing the work I wanted to check if anyone >is opposed to these changes. > >I would like to: >1) Stop using C99 in libipa_hbac. pam_hbac can ru

[SSSD] Re: proposed libipa_hbac changes

2016-02-22 Thread Lukas Slebodnik
On (22/02/16 10:28), Jakub Hrozek wrote: >On Mon, Feb 22, 2016 at 10:19:31AM +0100, Lukas Slebodnik wrote: >> On (22/02/16 10:01), Jakub Hrozek wrote: >> >Hi, >> > >> >during my work on pam_hbac I ran into some issues in libipa_hbac that I >> >would li

[SSSD] Re: SSSD Status Tool

2016-02-22 Thread Lukas Slebodnik
On (19/02/16 14:34), Pavel Březina wrote: >I'm sending this on behalf of Pavel Reichl... > > >Hi, > >during devconf week Jakub asked us to send a few overview paragraphs about >features we will be working on in forth coming months. Implementation details >will be discussed in design documents as us

[SSSD] Re: proposed libipa_hbac changes

2016-02-23 Thread Lukas Slebodnik
On (22/02/16 10:44), Jakub Hrozek wrote: >On Mon, Feb 22, 2016 at 10:35:21AM +0100, Lukas Slebodnik wrote: >> On (22/02/16 10:28), Jakub Hrozek wrote: >> >On Mon, Feb 22, 2016 at 10:19:31AM +0100, Lukas Slebodnik wrote: >> >> On (22/02/16 10:01),

[SSSD] Re: [PATCH] Fix typos reported by lintian

2016-02-23 Thread Lukas Slebodnik
On (22/02/16 12:50), Pavel Březina wrote: >On 02/15/2016 09:22 AM, Lukas Slebodnik wrote: >>On (15/02/16 09:09), Lukas Slebodnik wrote: >>>ehlo, >>> >>>lintian can find typos in strings in binary files. >>>Attached patch should fix them. >>>

[SSSD] Re: [PATCHES] UTIL: Provide varargs version of debug_fn

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 12:30), Jakub Hrozek wrote: >On Fri, Feb 12, 2016 at 11:33:34AM +0100, Pavel Březina wrote: >> On 01/15/2016 12:44 PM, Lukas Slebodnik wrote: >> >On (15/01/16 12:03), Pavel Březina wrote: >> >>On 01/12/2016 10:15 AM, Lukas Slebodnik wrote: >> >&

[SSSD] Re: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"

2016-02-23 Thread Lukas Slebodnik
On (17/02/16 13:55), Lukas Slebodnik wrote: >On (25/01/16 12:00), Lukas Slebodnik wrote: >>ehlo, >> >>The first patch fixes regression introduced in 1.13.2. >>https://fedorahosted.org/sssd/ticket/2493 >> >>I'm sorry I didn't catch it in revi

[SSSD] Re: [PATCHES] UTIL: Provide varargs version of debug_fn

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 13:15), Jakub Hrozek wrote: >On Tue, Feb 23, 2016 at 12:41:04PM +0100, Lukas Slebodnik wrote: >> On (23/02/16 12:30), Jakub Hrozek wrote: >> >On Fri, Feb 12, 2016 at 11:33:34AM +0100, Pavel Březina wrote: >> >> On 01/15/2016 12:44 PM, Lukas Slebodnik wr

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 13:37), Jakub Hrozek wrote: >On Thu, Feb 18, 2016 at 02:04:54PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> It took me some time to reproduce issue with cron. >> It occured very rarely in my case (twice in a week). >> >> Therefore I pre

[SSSD] Re: [PATCHES] UTIL: Provide varargs version of debug_fn

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 13:38), Jakub Hrozek wrote: >On Tue, Feb 23, 2016 at 01:32:19PM +0100, Lukas Slebodnik wrote: >> On (23/02/16 13:15), Jakub Hrozek wrote: >> >On Tue, Feb 23, 2016 at 12:41:04PM +0100, Lukas Slebodnik wrote: >> >> On (23/02/16 12:30), Jakub Hrozek wrote:

[SSSD] Re: [PATCHES] UTIL: Provide varargs version of debug_fn

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 13:38), Jakub Hrozek wrote: >On Tue, Feb 23, 2016 at 01:32:19PM +0100, Lukas Slebodnik wrote: >> On (23/02/16 13:15), Jakub Hrozek wrote: >> >On Tue, Feb 23, 2016 at 12:41:04PM +0100, Lukas Slebodnik wrote: >> >> On (23/02/16 12:30), Jakub Hrozek wrote:

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 08:28), Petr Cech wrote: >On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: > >[...] > >>>>Hello Lukas, >>>> >>>>thank you for careful code review. I addressed all comments and I found >>>>memory leak in original colondb tool.

[SSSD] Re: [PATCH] Revert "DEBUG: Preventing chown_debug_file if journald on"

2016-02-23 Thread Lukas Slebodnik
On (23/02/16 15:33), Jakub Hrozek wrote: >On Mon, Jan 25, 2016 at 12:00:11PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> The first patch fixes regression introduced in 1.13.2. >> https://fedorahosted.org/sssd/ticket/2493 >> >> I'm sorry I didn'

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 12:47), Petr Cech wrote: >On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: >>On (23/02/16 08:28), Petr Cech wrote: >>>On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: >>> >>>[...] >>> >>>>>>Hello Lukas, >>>>>&

[SSSD] Re: [PATCH SET] TEST_TOOLS_COLONDB: Add tests for sss_colondb_* public API

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 14:01), Lukas Slebodnik wrote: >On (24/02/16 12:47), Petr Cech wrote: >>On 02/23/2016 03:28 PM, Lukas Slebodnik wrote: >>>On (23/02/16 08:28), Petr Cech wrote: >>>>On 02/19/2016 04:33 PM, Lukas Slebodnik wrote: >>>> >>>>[...]

[SSSD] Re: [PATCH] build: detect endianness at configure time

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 17:18), David Disseldorp wrote: >From: David Disseldorp > >WORDS_BIGENDIAN, HAVE_BIG_ENDIAN and HAVE_LITTLE_ENDIAN are needed by >Samba. See Samba's byteorder.h header for an example. > >Signed-off-by: David Disseldorp >--- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > >

[SSSD] Re: [PATCH] build: detect endianness at configure time

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 17:47), Lukas Slebodnik wrote: >On (24/02/16 17:18), David Disseldorp wrote: >>From: David Disseldorp >> >>WORDS_BIGENDIAN, HAVE_BIG_ENDIAN and HAVE_LITTLE_ENDIAN are needed by >>Samba. See Samba's byteorder.h header for an example. >

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-02-24 Thread Lukas Slebodnik
On (24/02/16 16:43), Jakub Hrozek wrote: >We don't know the group name at that point yet, so better not print >"null" in the debug message.. >From ffdc00755a9fbaeb54f781956a0025719e532b11 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Tue, 26 Jan 2016 16:29:08 +0100 >Subject: [PATCH] LDAP: D

[SSSD] Re: CI build-deps error

2016-02-25 Thread Lukas Slebodnik
On (24/02/16 23:16), Dan Lavu wrote: >I was wondering if somebody could provide me some makefile guidance. I've >found a couple of syntax errors when setting up CI, the second run of dnf/yum >adds -- that causes the command to fail, and the dependencies with versions >are missing quotes. > >I've tr

[SSSD] Re: [PATCH] sdap: improve filtering of multiple results in GC lookups

2016-02-25 Thread Lukas Slebodnik
On (25/02/16 12:50), Jakub Hrozek wrote: >On Tue, Feb 23, 2016 at 12:53:25PM +0100, Sumit Bose wrote: >> Hi, >> >> this patch fixes and issue during initgroups in AD forests. Please see >> the commit message for details. >> >> To reproduce this you can create a new user outside of CN=Users on the

[SSSD] Re: [PATCH]: test ldap provider with TLS or SSL

2016-02-26 Thread Lukas Slebodnik
On (26/02/16 11:53), Jakub Hrozek wrote: >On Thu, Feb 25, 2016 at 05:18:09PM -0500, Dan Lavu wrote: >> Here is a patch for https://fedorahosted.org/sssd/ticket/2820 >> >> First real patch... criticisms to for what I need to improve on are welcome, >> including concepts that I should learn, thanks.

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-02-26 Thread Lukas Slebodnik
On (23/02/16 14:28), Lukas Slebodnik wrote: >On (23/02/16 13:37), Jakub Hrozek wrote: >>On Thu, Feb 18, 2016 at 02:04:54PM +0100, Lukas Slebodnik wrote: >>> ehlo, >>> >>> It took me some time to reproduce issue with cron. >>> It occured very rarely in

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-02-26 Thread Lukas Slebodnik
On (26/02/16 16:22), Lukas Slebodnik wrote: >On (23/02/16 14:28), Lukas Slebodnik wrote: >>On (23/02/16 13:37), Jakub Hrozek wrote: >>>On Thu, Feb 18, 2016 at 02:04:54PM +0100, Lukas Slebodnik wrote: >>>> ehlo, >>>> >>>> It took me some t

[SSSD] Re: CI build-deps error

2016-02-28 Thread Lukas Slebodnik
On (28/02/16 20:12), Dan Lavu wrote: >Rereading the initial message, what I wrote previously is a little unclear. >So this is my effort to clarify what I'm running into and get help. So >setting up CI tests upstream, the complete run and setup is done by issuing > >sssd.git/contrib/ci/run > >This c

[SSSD] Re: [PATCHES] Add new default PAM services for AD GPOs

2016-02-29 Thread Lukas Slebodnik
On (26/02/16 13:30), Stephen Gallagher wrote: >[PATCH 1/2] GPO: Add Cockpit to the Remote Interactive defaults > >The Cockpit Project is an administrative console that is gaining in >popularity and is a default component on some operating systems (such >as Fedora Server). Since it is becoming more

[SSSD] Re: [PATCHES] Add new default PAM services for AD GPOs

2016-02-29 Thread Lukas Slebodnik
On (29/02/16 09:54), Lukas Slebodnik wrote: >On (26/02/16 13:30), Stephen Gallagher wrote: >>[PATCH 1/2] GPO: Add Cockpit to the Remote Interactive defaults >> >>The Cockpit Project is an administrative console that is gaining in >>popularity and is a default componen

[SSSD] [PATCH] CI: Use yum-deprecated instead of dnf

2016-02-29 Thread Lukas Slebodnik
ou. > Attached patch should fix issues with installation of package on fedora. http://sssd-ci.duckdns.org/logs/job/38/32/summary.html LS >From d103280e0fe468830144665d047829ef86d9ec5e Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 29 Feb 2016 10:41:50 +0100 Subject: [PATCH] CI

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-02-29 Thread Lukas Slebodnik
On (29/02/16 18:54), Nikolai Kondrashov wrote: >On 02/29/2016 06:31 PM, Lukas Slebodnik wrote: >>On (28/02/16 20:12), Dan Lavu wrote: >>>>Rereading the initial message, what I wrote previously is a little unclear. >>>>So this is my effort to clarify what

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (29/02/16 20:30), Nikolai Kondrashov wrote: >On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: >>On (29/02/16 18:54), Nikolai Kondrashov wrote: >>>On 02/29/2016 06:31 PM, Lukas Slebodnik wrote: >>>> The rest of the required packages CI will attempt to install itself,

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 13:30), Nikolai Kondrashov wrote: >On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: >>On (29/02/16 20:30), Nikolai Kondrashov wrote: >>>On 02/29/2016 07:27 PM, Lukas Slebodnik wrote: >>>>On (29/02/16 18:54), Nikolai Kondrashov wrote: >>>>

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 15:07), Nikolai Kondrashov wrote: >On 03/01/2016 02:56 PM, Lukas Slebodnik wrote: >>On (01/03/16 13:30), Nikolai Kondrashov wrote: >>>On 03/01/2016 10:46 AM, Lukas Slebodnik wrote: >>>>On (29/02/16 20:30), Nikolai Kondrashov wrote: >>>>>

[SSSD] Re: [PATCH] CI: Use yum-deprecated instead of dnf

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 08:48), Dan Lavu wrote: >Thanks Nikolai and Lukas, > >Related to the run script, what version of Debian should we be testing >against? Seems like Wheezy is missing libnss-wrapper package in it's default >repos. > Wheezy is old stable and does not have all required dependencies. In read

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 15:54), Pavel Reichl wrote: >I added one more similar patch. > >sss_idmap_calculate_range can accept domain SID or range identifier on its >input. Previous parameter name was misleading. Could you explain why it need to be in two separate patches? LS _

[SSSD] [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (31/01/16 11:53), Simo Sorce wrote: >Expired != Disabled >this change is intentional. > Yes, but explain it to Active directory :-) Attached is patch with workaround/hack regression with expired AD users. LS ___ sssd-devel mailing list sssd-devel@lis

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 17:45), Lukas Slebodnik wrote: >On (31/01/16 11:53), Simo Sorce wrote: >>Expired != Disabled >>this change is intentional. >> >Yes, but explain it to Active directory :-) > >Attached is patch with workaround/hack >regression with expir

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-01 Thread Lukas Slebodnik
On (01/03/16 12:05), Simo Sorce wrote: >On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: >> On (01/03/16 17:45), Lukas Slebodnik wrote: >> >On (31/01/16 11:53), Simo Sorce wrote: >> >>Expired != Disabled >> >>this change is intentional. >>

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (01/03/16 17:05), Pavel Reichl wrote: > > >On 03/01/2016 04:54 PM, Lukas Slebodnik wrote: >>On (01/03/16 15:54), Pavel Reichl wrote: >>>I added one more similar patch. >>> >>>sss_idmap_calculate_range can accept domain SID or range identifier on

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 12:48), Pavel Březina wrote: >On 03/01/2016 03:54 PM, Pavel Reichl wrote: >>I added one more similar patch. >> >>sss_idmap_calculate_range can accept domain SID or range identifier on >>its input. Previous parameter name was misleading. > >Ack to both. They can sure be squashed before

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 13:02), Pavel Reichl wrote: >On 03/02/2016 12:53 PM, Lukas Slebodnik wrote: >>On (02/03/16 12:48), Pavel Březina wrote: >>>On 03/01/2016 03:54 PM, Pavel Reichl wrote: >>>>I added one more similar patch. >>>> >>>>sss_idmap_calcul

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 13:45), Pavel Reichl wrote: >On 03/02/2016 01:10 PM, Lukas Slebodnik wrote: >>On (02/03/16 13:02), Pavel Reichl wrote: >>>On 03/02/2016 12:53 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 12:48), Pavel Březina wrote: >>>>>On 03/01/2016 03

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 13:43), Petr Cech wrote: >On 03/02/2016 01:10 PM, Lukas Slebodnik wrote: >>On (02/03/16 13:02), Pavel Reichl wrote: >>>On 03/02/2016 12:53 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 12:48), Pavel Březina wrote: >>>>>On 03/01/2016 03:54 P

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 15:02), Pavel Reichl wrote: >On 03/02/2016 02:59 PM, Lukas Slebodnik wrote: >>On (02/03/16 13:45), Pavel Reichl wrote: >>>On 03/02/2016 01:10 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 13:02), Pavel Reichl wrote: >>>>>On 03/02/2016 12:53

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-02 Thread Lukas Slebodnik
On (01/03/16 18:28), Simo Sorce wrote: >On Tue, 2016-03-01 at 18:22 -0500, Simo Sorce wrote: >> On Tue, 2016-03-01 at 22:34 +0100, Lukas Slebodnik wrote: >> > On (01/03/16 12:05), Simo Sorce wrote: >> > >On Tue, 2016-03-01 at 17:51 +0100, Lukas Slebodnik wrote: >

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 15:13), Pavel Reichl wrote: >On 03/02/2016 03:07 PM, Lukas Slebodnik wrote: >>On (02/03/16 15:02), Pavel Reichl wrote: >>>On 03/02/2016 02:59 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 13:45), Pavel Reichl wrote: >>>>>On 03/02/2016 01:10

[SSSD] Re: [PATCH] IDMAP: Make parameter name more descriptive

2016-03-02 Thread Lukas Slebodnik
On (02/03/16 16:00), Pavel Reichl wrote: > > >On 03/02/2016 03:43 PM, Lukas Slebodnik wrote: >>On (02/03/16 15:13), Pavel Reichl wrote: >>>On 03/02/2016 03:07 PM, Lukas Slebodnik wrote: >>>>On (02/03/16 15:02), Pavel Reichl wrote: >>>>>On 03/02/20

[SSSD] Re: [PATCH] cache_req improvements

2016-03-03 Thread Lukas Slebodnik
On (02/03/16 18:22), Jakub Hrozek wrote: >On Tue, Mar 01, 2016 at 01:05:48PM +0100, Pavel Březina wrote: >> On 02/26/2016 01:47 PM, Jakub Hrozek wrote: >> >On Wed, Feb 24, 2016 at 12:41:24PM +0100, Pavel Březina wrote: >> From f61d0192b8254247802167ea385b52f65d4e175d Mon Sep 17 00:00:00 2001 >

[SSSD] [PATCH] GPO_CHILD: Create directories in gpo_cache with right permissions

2016-03-03 Thread Lukas Slebodnik
ehlo, review is appreciated. LS >From 812846b5ddd5b786a776f9813ac58b9735bba1ce Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Thu, 3 Mar 2016 13:34:26 +0100 Subject: [PATCH 1/2] GPO: Soften umask in gpo_child MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Trans

[SSSD] Re: [PATCH] Use refcount to keep track of server structures returned from failover

2016-03-03 Thread Lukas Slebodnik
On (23/10/15 10:22), Jakub Hrozek wrote: >On Wed, Oct 21, 2015 at 11:50:07AM +0200, Pavel Březina wrote: >> On 10/11/2015 10:00 PM, Jakub Hrozek wrote: >> >Hi, >> > >> >the attached patches are my proposal to fix >> >https://fedorahosted.org/sssd/ticket/2829 >> > >> >I haven't tested them past make

[SSSD] Re: [PATCH] Use refcount to keep track of server structures returned from failover

2016-03-03 Thread Lukas Slebodnik
On (23/10/15 10:22), Jakub Hrozek wrote: >On Wed, Oct 21, 2015 at 11:50:07AM +0200, Pavel Březina wrote: >> On 10/11/2015 10:00 PM, Jakub Hrozek wrote: >> >Hi, >> > >> >the attached patches are my proposal to fix >> >https://fedorahosted.org/sssd/ticket/2829 >> > >> >I haven't tested them past make

[SSSD] Re: [PATCHES] util: Continue if setlocale fails

2016-03-03 Thread Lukas Slebodnik
On (04/11/15 09:13), Lukas Slebodnik wrote: >On (04/11/15 09:06), Lukas Slebodnik wrote: >>On (03/11/15 14:48), Michal Židek wrote: >>>On 11/03/2015 12:25 PM, Lukas Slebodnik wrote: >>>>On (30/10/15 16:06), Michal Židek wrote: >>>>>On 10/30/2015

[SSSD] Re: [PATCH] FO: Use tevent_req_defer_callback() when notifying callers

2016-03-03 Thread Lukas Slebodnik
On (07/12/15 16:15), Jakub Hrozek wrote: >On Thu, Dec 03, 2015 at 02:24:19PM +0100, Pavel Březina wrote: >> On 11/23/2015 06:39 PM, Jakub Hrozek wrote: >> >On Thu, Nov 19, 2015 at 05:35:07PM +0100, Jakub Hrozek wrote: >> >>--- a/src/tests/cmocka/test_fo_srv.c >> >>+++ b/src/tests/cmocka/test_fo_srv

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-04 Thread Lukas Slebodnik
On (02/03/16 10:02), Simo Sorce wrote: >On Wed, 2016-03-02 at 15:34 +0100, Lukas Slebodnik wrote: >> On (01/03/16 18:28), Simo Sorce wrote: >> >On Tue, 2016-03-01 at 18:22 -0500, Simo Sorce wrote: >> >> On Tue, 2016-03-01 at 22:34 +0100, Lukas Slebodnik wrote: >

[SSSD] [PATCH] TOOLS: Prevent dereference of null pointer

2016-03-07 Thread Lukas Slebodnik
ehlo, simple aptch is attached. LS >From b0f5ccffb400d6dc8b23208239adc6522b0622c0 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 18:57:22 +0100 Subject: [PATCH] TOOLS: Prevent dereference of null pointer VAR_CHECK is called with (var, EOK, ...) EOK would be returned

[SSSD] UTIL: Fix warning misleading-indentation

2016-03-07 Thread Lukas Slebodnik
ehlo, There are new warnings with gcc-6.0 LS >From 2561af75f5d0ccff51ed8f88a48fb685b83e91e1 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 15:15:20 +0100 Subject: [PATCH 1/2] UTIL: Fix indentation in dlinklist.h --- src/util/dlinklist.h |

[SSSD] [PATCH] BUILD: Remove unused include directories

2016-03-07 Thread Lukas Slebodnik
ehlo, We do not have the "include" directory in git and such directory is not generated by autotools in build directory either. LS >From af446928a2a18ebc17f17f33a2563dd2dd0c637c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 5 Mar 2016 19:05:46 +0100 Subject: [PATCH]

[SSSD] Re: RFC: Remove conditional build for sudo?

2016-03-07 Thread Lukas Slebodnik
On (07/03/16 12:48), Pavel Březina wrote: >I'm just reviewing Petr's sudo rule invalidation patches and when I hit > >>+case TYPE_SUDO_RULE: >>+type_string = "sudo_rule"; >>+#ifdef BUILD_SUDO >>+ret = sysdb_search_sudo_rules(ctx, dinfo, >>+ f

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

2016-03-07 Thread Lukas Slebodnik
On (07/03/16 12:12), Pavel Březina wrote: >On 03/07/2016 10:14 AM, Lukas Slebodnik wrote: >>ehlo, >> >>simple aptch is attached. > >When there, can you also talloc_free(attrs) on error? Thanks. See updated patch LS >From 7e70c88277d7ae3f7b953af51da4e97917923fda

[SSSD] [PATCH] SPEC: Run extra unit tests with epel

2016-03-07 Thread Lukas Slebodnik
ehlo, simple patch is attached. LS >From 1a6bb8a3adf99bdc0b81202c568c56302ebdf9ad Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 7 Mar 2016 14:59:16 +0100 Subject: [PATCH] SPEC: Run extra unit tests with epel libcmocka and cwrap is available in epel which is used by mock. T

[SSSD] [PATCH] BUILD: Simplify build of cwrap tests

2016-03-07 Thread Lukas Slebodnik
ehlo, Attached patch should speed up build a little bit. But the main purspose is to sipmplify src/tests/cwrap/Makefile.am LS >From dd85774c081ff4ae1f1eb968018b8396c56232b9 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 7 Mar 2016 16:39:12 +0100 Subject: [PATCH] BUILD: Simplify bu

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-07 Thread Lukas Slebodnik
On (04/03/16 16:42), Simo Sorce wrote: >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: >> On (02/03/16 10:02), Simo Sorce wrote: >> >On Wed, 2016-03-02 at 15:34 +0100, Lukas Slebodnik wrote: >> >> On (01/03/16 18:28), Simo Sorce wrote: >> >>

[SSSD] Re: [PATCH] KRB5: Discern between expired & disabled AD user

2016-03-07 Thread Lukas Slebodnik
On (07/03/16 11:29), Simo Sorce wrote: >On Mon, 2016-03-07 at 16:58 +0100, Lukas Slebodnik wrote: >> On (04/03/16 16:42), Simo Sorce wrote: >> >On Fri, 2016-03-04 at 21:27 +0100, Lukas Slebodnik wrote: >> >> On (02/03/16 10:02), Simo Sorce wrote: >> >>

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-08 Thread Lukas Slebodnik
On (25/02/16 11:06), Jakub Hrozek wrote: >On Wed, Feb 24, 2016 at 06:05:11PM +0100, Lukas Slebodnik wrote: >> On (24/02/16 16:43), Jakub Hrozek wrote: >> >We don't know the group name at that point yet, so better not print >> >"null

[SSSD] Re: [PATCH] NSS: Move a DEBUG message so that it's less confusing

2016-03-08 Thread Lukas Slebodnik
On (04/03/16 12:14), Pavel Březina wrote: >On 03/04/2016 12:08 PM, Jakub Hrozek wrote: >>On Fri, Mar 04, 2016 at 11:56:03AM +0100, Pavel Reichl wrote: >>> >>> >>>On 03/04/2016 11:46 AM, Jakub Hrozek wrote: Hi, the attached patch would hopefully make analyzing of NSS logs files in a >>>

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-08 Thread Lukas Slebodnik
On (08/03/16 18:14), Jakub Hrozek wrote: >On Tue, Mar 08, 2016 at 09:34:29AM +0100, Lukas Slebodnik wrote: >> On (25/02/16 11:06), Jakub Hrozek wrote: >> >On Wed, Feb 24, 2016 at 06:05:11PM +0100, Lukas Slebodnik wrote: >> >> On (24/02/16 16:43), Jakub Hrozek wrote:

[SSSD] Re: [PATCH] IPA SUDO: download externalUser attribute

2016-03-08 Thread Lukas Slebodnik
On (08/03/16 18:21), Jakub Hrozek wrote: >On Fri, Mar 04, 2016 at 02:01:54PM +0100, Pavel Březina wrote: >> This allows configuration with id_provider = proxy >> and sudo_provider = ipa when someone needs to fetch >> rules for local users. > >> From a6f23fd5ab16d7903b8388d90eb3bb995c4426d0 Mon Sep

[SSSD] Re: [PATCH] IPA SUDO: download externalUser attribute

2016-03-09 Thread Lukas Slebodnik
On (09/03/16 10:23), Jakub Hrozek wrote: >On Tue, Mar 08, 2016 at 11:03:40PM +0100, Lukas Slebodnik wrote: >> On (08/03/16 18:21), Jakub Hrozek wrote: >> >On Fri, Mar 04, 2016 at 02:01:54PM +0100, Pavel Březina wrote: >> >> This allows configuration with id_provider =

[SSSD] Re: [PATCH] memberof: Don't allocate on a NULL context

2016-03-09 Thread Lukas Slebodnik
On (09/03/16 15:21), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 11:32:39AM +0100, Pavel Březina wrote: >> On 02/26/2016 02:03 PM, Jakub Hrozek wrote: >> >On Fri, Feb 26, 2016 at 11:08:45AM +0100, Pavel Březina wrote: >> >>On 02/24/2016 03:19 PM, Jakub Hrozek wrote: >> >>>Hi, >> >>> >> >>>the atta

[SSSD] [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-09 Thread Lukas Slebodnik
ehlo, I read log files from latest 1.13 today and it was a small challenge due to missing line feed after some ldb messages. LS >From c9f7e99fb933706663948efc659937299ec54077 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 9 Mar 2016 17:14:16 +0100 Subject: [PATCH 1/2] UTIL: M

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-10 Thread Lukas Slebodnik
On (09/03/16 18:47), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote: >> I'm fine either way. > >OK, see the attached patch. >From ea49df6b0816845ec667392a170f4176e759731f Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Wed, 9 Mar 2016 18:44:43 +0100 >Subjec

[SSSD] Re: [PATCH] memberof: Don't allocate on a NULL context

2016-03-10 Thread Lukas Slebodnik
On (09/03/16 18:36), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 05:37:12PM +0100, Lukas Slebodnik wrote: >> On (09/03/16 15:21), Jakub Hrozek wrote: >> >On Wed, Mar 09, 2016 at 11:32:39AM +0100, Pavel Březina wrote: >> >> On 02/26/2016 02:03 PM, Jakub Hrozek wrote:

[SSSD] Re: [PATCH] LDAP: Do not print "null" in the DEBUG message

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 11:41), Jakub Hrozek wrote: >On Thu, Mar 10, 2016 at 10:15:01AM +0100, Lukas Slebodnik wrote: >> On (09/03/16 18:47), Jakub Hrozek wrote: >> >On Wed, Mar 09, 2016 at 10:06:38AM +0100, Pavel Březina wrote: >> >> I'm fine either way. >> >

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 11:54), Jakub Hrozek wrote: >Hi, > >attached are patches that in my opinion make libipa_hbac easier to use >by external projects like pam_hbac. > >[PATCH 1/4] libipa_hbac: Do not use C99 >- even though we use C99 in the deamon, pam_hbac needs to run on very > exotic platforms. I don't

[SSSD] Re: [PATCH] pam_sss: reorder pam_message array

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 12:54), Pavel Březina wrote: >On 03/08/2016 05:55 PM, Sumit Bose wrote: >>Hi, >> >>This patch fixes a 2FA issues observed with sudo. See commit message for >>details. >> >>bye, >>Sumit >> >> >>0001-pam_sss-reorder-pam_message-array.patch >> >> >> From 2c38adad7b527aceb4f9cb41c7d7b4c66d

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 12:58), Pavel Březina wrote: >On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: >>ehlo, >> >>I read log files from latest 1.13 today and it was a small challenge >>due to missing line feed after some ldb messages. >> >>LS > >Can we check if ne

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:10), Pavel Březina wrote: >On 03/10/2016 01:05 PM, Lukas Slebodnik wrote: >>On (10/03/16 12:58), Pavel Březina wrote: >>>On 03/09/2016 05:39 PM, Lukas Slebodnik wrote: >>>>ehlo, >>>> >>>>I read log files from latest 1.13 toda

[SSSD] Re: [PATCH] BUILD: Remove unused include directories

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:59), Pavel Březina wrote: >On 03/07/2016 10:37 AM, Lukas Slebodnik wrote: >>ehlo, >> >>We do not have the "include" directory in git >>and such directory is not generated by autotools in >>build directory either. >> >>

[SSSD] Re: [PATCH] BUILD: Simplify build of cwrap tests

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 13:39), Pavel Březina wrote: >On 03/07/2016 04:45 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Attached patch should speed up build a little bit. >>But the main purspose is to sipmplify src/tests/cwrap/Makefile.am >> >>LS > >Ack. > >htt

[SSSD] Re: UTIL: Fix warning misleading-indentation

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 14:13), Michal Židek wrote: >On 03/10/2016 01:03 PM, Pavel Březina wrote: >>On 03/07/2016 10:23 AM, Lukas Slebodnik wrote: >>>ehlo, >>> >>>There are new warnings with gcc-6.0 >>> >>>LS >> >>Ack. > >Just for t

[SSSD] Re: [PATCH] UTIL: Allow to append new line in sss_vdebug_fn

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 18:14), Jakub Hrozek wrote: >On Wed, Mar 09, 2016 at 05:39:51PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> I read log files from latest 1.13 today and it was a small challenge >> due to missing line feed after some ldb me

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-10 Thread Lukas Slebodnik
On (10/03/16 20:02), Jakub Hrozek wrote: >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: >> diff --git a/Makefile.am b/Makefile.am >> index d6eb0fc..f8111d0 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -946,6 +946,10 @@ libipa_hbac_la

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-11 Thread Lukas Slebodnik
On (10/03/16 20:37), Lukas Slebodnik wrote: >On (10/03/16 20:02), Jakub Hrozek wrote: >>On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: >>> diff --git a/Makefile.am b/Makefile.am >>> index d6eb0fc..f8111d0 100644 >>> --- a/Makefile.am >>

[SSSD] Re: [PATCH] Add a test for external group members resolution

2016-03-11 Thread Lukas Slebodnik
On (10/03/16 13:12), Pavel Březina wrote: >On 03/05/2016 03:03 PM, Jakub Hrozek wrote: >>Hi, >> >>I was in a hurry when I submitted the patch for external group members, >>so I didn't add a test. Bad developer, no cookie. >> >>The attached patch adds a test for that code. > >Ack. http://sssd-ci.duc

[SSSD] Re: [PATCH] CLIENT: Retry request after EPIPE

2016-03-11 Thread Lukas Slebodnik
On (11/03/16 11:41), Jakub Hrozek wrote: >On Fri, Feb 26, 2016 at 09:01:33PM +0100, Lukas Slebodnik wrote: >> On (26/02/16 16:22), Lukas Slebodnik wrote: >> >On (23/02/16 14:28), Lukas Slebodnik wrote: >> >>On (23/02/16 13:37), Jakub Hrozek wrote: >> >>

[SSSD] Re: [PATCH]: test ldap provider with TLS or SSL

2016-03-12 Thread Lukas Slebodnik
On (11/03/16 17:20), Dan Lavu wrote: >WOAH, that's a lot of comments! ;) Thanks for taking the time, I have some >questions inline and I'll start working on improving the code. > >On Fri, Mar 11, 2016 at 1:16 PM, Nikolai Kondrashov < >nikolai.kondras...@redhat.com> wrote: >> Hi Dan, >> >> Thanks a

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-12 Thread Lukas Slebodnik
On (11/03/16 11:14), Jakub Hrozek wrote: >On Thu, Mar 10, 2016 at 08:37:23PM +0100, Lukas Slebodnik wrote: >> On (10/03/16 20:02), Jakub Hrozek wrote: >> >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: >> >> diff --git a/Makefile.am b/Makefile.a

[SSSD] Re: [PATCH] libipa_hbac cleanup patches

2016-03-12 Thread Lukas Slebodnik
On (12/03/16 21:21), Lukas Slebodnik wrote: >On (11/03/16 11:14), Jakub Hrozek wrote: >>On Thu, Mar 10, 2016 at 08:37:23PM +0100, Lukas Slebodnik wrote: >>> On (10/03/16 20:02), Jakub Hrozek wrote: >>> >On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebod

[SSSD] Re: [PATCH] IPA SUDO: support old ipasudocmd rdn

2016-03-14 Thread Lukas Slebodnik
On (13/03/16 21:07), Jakub Hrozek wrote: >On Fri, Mar 11, 2016 at 12:21:49PM +0100, Pavel Březina wrote: >> Should have read the logs to the end, sorry about that. See the new patches. >> > >Thank you, these patches work for me with the latest CentOS-6 IPA packages >and the latest F-23 FreeIPA pac

[SSSD] [PATCH] UTIL: Do not call stderr with negative number

2016-03-14 Thread Lukas Slebodnik
ehlo, attached patch fix coverity error. LS >From 26fc8459b84d90fa3f1ac35eb018257285f6a1d7 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 14 Mar 2016 09:15:06 +0100 Subject: [PATCH] UTIL: Do not call stderr with negative number The function connect return -1 in case of error and

[SSSD] Re: [PATCH] UTIL: Do not call stderr with negative number

2016-03-14 Thread Lukas Slebodnik
On (14/03/16 10:02), Jakub Hrozek wrote: >On Mon, Mar 14, 2016 at 09:22:15AM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> attached patch fix coverity error. >> >> LS > >> From 26fc8459b84d90fa3f1ac35eb018257285f6a1d7 Mon Sep 17 00:00:00 2001 >> Fro

[SSSD] Re: [PATCH] UTIL: Do not call stderr with negative number

2016-03-14 Thread Lukas Slebodnik
On (14/03/16 10:18), Jakub Hrozek wrote: >On Mon, Mar 14, 2016 at 10:13:56AM +0100, Lukas Slebodnik wrote: >> On (14/03/16 10:02), Jakub Hrozek wrote: >> >On Mon, Mar 14, 2016 at 09:22:15AM +0100, Lukas Slebodnik wrote: >> >> ehlo, >> >> >> >&

[SSSD] Re: [PATCH] UTIL: Do not call stderr with negative number

2016-03-14 Thread Lukas Slebodnik
On (14/03/16 10:54), Jakub Hrozek wrote: >On Mon, Mar 14, 2016 at 10:32:32AM +0100, Lukas Slebodnik wrote: >> On (14/03/16 10:18), Jakub Hrozek wrote: >> >On Mon, Mar 14, 2016 at 10:13:56AM +0100, Lukas Slebodnik wrote: >> >> On (14/03/16 10:02), Jakub Hrozek wrote:

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

2016-03-15 Thread Lukas Slebodnik
On (15/03/16 11:26), Pavel Březina wrote: >On 03/07/2016 01:33 PM, Lukas Slebodnik wrote: >>On (07/03/16 12:12), Pavel Březina wrote: >>>On 03/07/2016 10:14 AM, Lukas Slebodnik wrote: >>>>ehlo, >>>> >>>>simple aptch is attached. >>>

  1   2   3   4   5   6   7   8   9   10   >