[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-02-01 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ bump """ See the full comment at https://github.com/SSSD/sssd/pull/85#issuecomment-276602905

[SSSD] [sssd PR#153][synchronized] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ New version pushed, but CI said "NO": http://sssd-ci.duckdns.org/logs/job/62/98/summary.html """ See the full comment a

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ New version pushed. CI passed: http://sssd-ci.duckdns.org/logs/job/63/02/summary.html """ See the full comment at https:/

[SSSD] [sssd PR#153][synchronized] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#153][comment] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache celestian commented: """ Thanks for comments. In my opinion it would be better to have the same value of dataExpireTimestamp only if we use sss_cache. The question is w

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ FYI http://sssd-ci.duckdns.org/logs/job/62/59/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#153][synchronized] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#153][edited] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: edited Changed field: title Original value: """ SYSDB: Changing dataExpireTimestamp in domain cache """ __

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ I pushed new version (#2). I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I added functions ``` sysdb_invalidate_u

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ I pushed new version (#2). I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I added functions ``` sysdb_invalidate_u

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ So, dnf repositories work again. I am able to test the functionality of my patch set. Unfortunately it doesnt work. I will fix it. "&quo

[SSSD] [sssd PR#153][+Changes requested] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#153][opened] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: opened PR body: """ When a group/users are invalidated from sss cache, the group/user information in Domain (cache_LDAP.ldb) and t

[SSSD] [sssd PR#153][synchronized] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-13 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#158][opened] IPA_SUDO: Unused value fix

2017-02-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/158 Author: celestian Title: #158: IPA_SUDO: Unused value fix Action: opened PR body: """ Unused value was immediately overwritten. Resolves: https://fedorahosted.org/sssd/ticket/3309 """ To pull the PR as Git branc

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ The are results from our CI http://sssd-ci.duckdns.org/logs/job/62/90/summary.html How we can see this patch fails on test_ts_cache.py integrati

[SSSD] [sssd PR#153][synchronized] sss_cache: User/groups invalidation in domain cache

2017-02-15 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-15 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ Fixed patch is pushed. I sent it to our CI and I will share the result. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ I pushed new version of the patch set. I addressed @sumit-bose notes, I hope in right manner. Unfortunately ```test_user_is_from_another_domain()`

[SSSD] [sssd PR#85][synchronized] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Author: celestian Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/85/head:pr85 git checkout pr85 From

[SSSD] [sssd PR#125][opened] RESPONDER: Adding of return value checking

2017-01-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/125 Author: celestian Title: #125: RESPONDER: Adding of return value checking Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/125/head

[SSSD] [sssd PR#125][closed] RESPONDER: Adding of return value checking

2017-01-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/125 Author: celestian Title: #125: RESPONDER: Adding of return value checking Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/125/head:pr125 git checkout pr125

[SSSD] [sssd PR#125][comment] RESPONDER: Adding of return value checking

2017-01-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/125 Title: #125: RESPONDER: Adding of return value checking celestian commented: """ Oh yes, I came too late :( Closing this pull request. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#85][synchronized] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Author: celestian Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/85/head:pr85 git checkout pr85 From

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ I pushed new version. Let me update the situation: There are three commits: ``` [1] SYSDB: Removing of sysdb_try_to_find_expecte

[SSSD] [sssd PR#85][-Changes requested] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#85][comment] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() celestian commented: """ New version is pushed. Thanks, @sumit-bose """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#85][synchronized] SYSDB: Removing of sysdb_try_to_find_expected_dn()

2017-01-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/85 Author: celestian Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/85/head:pr85 git checkout pr85 From

[SSSD] [sssd PR#170][opened] PROXY: Remove duplicit users from group

2017-02-27 Thread celestian
URL: https://github.com/SSSD/sssd/pull/170 Author: celestian Title: #170: PROXY: Remove duplicit users from group Action: opened PR body: """ It is possible to have duplicit members in local files (/etc/group). This patch removes duplicity in groups in proxy provider.

[SSSD] [sssd PR#170][comment] PROXY: Remove duplicit users from group

2017-02-27 Thread celestian
URL: https://github.com/SSSD/sssd/pull/170 Title: #170: PROXY: Remove duplicit users from group celestian commented: """ There is the first version of patch. I would like to ask @jhrozek or @lslebodn if our cwrap tests has capability to test this patch. I need ```/etc/group```

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (opened)

2016-09-02 Thread celestian
celestian's pull request #13: "MEMBEROF: Don't resolve members if they are removed" was opened PR body: """ ## TOPIC If we need remove ghost (SYSDB_GHOST, DB_GHOST) attribute from group we use empty structure. This doesn't mean that there is pointer to NULL but it means that there is zero

[SSSD] [sssd PR#13] MEMBEROF: Don't resolve members if they are removed (comment)

2016-09-02 Thread celestian
celestian commented on a pull request """ I wrote the conditions in fully way for clarity. Yes, it is possible to write it in condensed way. My question in note is about which type of our CI I can use. It is in memberof plugin. I don't see any test for memberof plugin at all. &q

[SSSD] [sssd PR#9] SYSDB: Removing of unused parametr (opened)

2016-08-31 Thread celestian
celestian's pull request #9: "SYSDB: Removing of unused parametr" was opened PR body: """ There were unused parameter struct ldb_message *cached_group in sysdb_store_group_attrs(). This parameter was introduced by 40de79d69860ec7f04bf7795bd88b641ec42fd23 SYSDB: Check if group attributes differ

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (opened)

2016-09-14 Thread celestian
celestian's pull request #26: "KRB5: Fixing FQ name of user in krb5_setup()" was opened PR body: """ This patch fixes creation of FQ username if krb5_map_user option ise used. Resolves: https://fedorahosted.org/sssd/ticket/3188 """ See the full pull-request at

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (comment)

2016-09-15 Thread celestian
celestian commented on a pull request """ http://sssd-ci.duckdns.org/logs/job/53/43/summary.html So, it is problem with cflags in test. I will send patch soon. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (synchronize)

2016-09-15 Thread celestian
celestian's pull request #26: "KRB5: Fixing FQ name of user in krb5_setup()" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/26 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (-Changes requested)

2016-09-15 Thread celestian
celestian's pull request #26: "KRB5: Fixing FQ name of user in krb5_setup()" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/26 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (comment)

2016-09-16 Thread celestian
celestian commented on a pull request """ Link to our CI: http://sssd-ci.duckdns.org/logs/job/53/46/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/26#issuecomment-247537214 ___ sssd

[SSSD] [sssd PR#25] TESTS: Add integration tests for the proxy provider of sssd-secrets (+Changes requested)

2016-09-16 Thread celestian
jhrozek's pull request #25: "TESTS: Add integration tests for the proxy provider of sssd-secrets" label *Changes requested* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/25 ___ sssd-devel mailing list

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-05 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains celestian commented: """ It's time for little explanation. SSSD (version 1.13) is able to find properly sudoRule. But sudoUser and login name can differ. This simple patch

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-06 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains celestian commented: """ Hi Fabiano, I wrote about it a bit with @jhrozek a I discussed it with @pbrezina today. Unfortunately on separate channels. Resume: 1. (sssd-1-

[SSSD] [sssd PR#39][+Changes requested] RESPONDER: Enable sudoRule in case insen. domains

2016-10-06 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][opened] RESPONDER: Enable sudoRule in case insen. domains

2016-10-05 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Author: celestian Title: #39: RESPONDER: Enable sudoRule in case insen. domains Action: opened PR body: """ This ptach is valid only for SSSD-1-13. It adds value 'ALL' to sudoRule attribute "sudoUser". So if we have case ins

[SSSD] [sssd PR#43][synchronized] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Author: celestian Title: #43: SUDO: Adding user name alias to sudoRule filter Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/43/head:pr43 git checkout pr43 From

[SSSD] [sssd PR#43][comment] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: SUDO: Adding user name alias to sudoRule filter celestian commented: """ Fixed patch pushed. I will add patch for testing new functionality of sudo. And I will add patch for caching both form of user name to sudoRule

[SSSD] [sssd PR#43][comment] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: SUDO: Adding user name alias to sudoRule filter celestian commented: """ PR #39 is for the same issue, but for version 1-13. And I need to change the patch. I would like to have two PR because there are two different patches

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains celestian commented: """ Hi, I have question on cache_req_recv(): https://github.com/SSSD/sssd/blob/master/src/responder/common/responder_cache_req.c#L1464 ``` errno_t

[SSSD] [sssd PR#40][+Accepted] TESTS: Remove a leftover debug message

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/40 Title: #40: TESTS: Remove a leftover debug message Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#40][comment] TESTS: Remove a leftover debug message

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/40 Title: #40: TESTS: Remove a leftover debug message celestian commented: """ I use one-line rule and I give ack without running tests. => ACK """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains celestian commented: """ Hi, I have question on cache_req_recv(): https://github.com/SSSD/sssd/blob/master/src/responder/common/responder_cache_req.c#L1464 ``` errno_t

[SSSD] [sssd PR#39][comment] RESPONDER: Enable sudoRule in case insen. domains

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Title: #39: RESPONDER: Enable sudoRule in case insen. domains celestian commented: """ Hi, I have question on cache_req_recv(): https://github.com/SSSD/sssd/blob/master/src/responder/common/responder_cache_req.c#L1464 ``` errno_t

[SSSD] [sssd PR#43][+Changes requested] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: SUDO: Adding user name alias to sudoRule filter Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#43][comment] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Title: #43: SUDO: Adding user name alias to sudoRule filter celestian commented: """ I see it, I forgot the tests. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#43][opened] SUDO: Adding user name alias to sudoRule filter

2016-10-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/43 Author: celestian Title: #43: SUDO: Adding user name alias to sudoRule filter Action: opened PR body: """ This patch adds another value to sudoUser attribute of sudoRule filter. The value is 'user alias' which means it is cased

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-21 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-21 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][-Changes requested] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-21 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-21 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ So, all notes addressed (fq_name too). I pushed new version. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ ACK """ See the full comment at https://github.com/SSSD/sssd/pull/25#issuecomment-247988840 __

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ Jakub, IMHO we have description and the link to ticket. If it is not so strict then I am OK with it. """

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Hi, I push new version. All comments are addressed. Petr """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ I change the order of patches, thanks Lukas. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ Well, LGTM. In my opinion we do not have to run CI again for removing of comment. One last point. Jakub, please, could you fix the

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (comment)

2016-09-15 Thread celestian
celestian commented on a pull request """ I pushed patch to our CI, we will see result soon. """ See the full comment at https://github.com/SSSD/sssd/pull/26#issuecomment-247304195 ___ sssd-devel mailing list sssd-deve

[SSSD] [sssd PR#26] KRB5: Fixing FQ name of user in krb5_setup() (synchronize)

2016-09-15 Thread celestian
celestian's pull request #26: "KRB5: Fixing FQ name of user in krb5_setup()" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/26 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ CI passed: http://sssd-ci.duckdns.org/logs/job/53/55/summary.html ACK """ See the full comment at https:

[SSSD] [sssd PR#25][+Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Lukas, sorry,I missed it. New version pushed. I have a question, is there any way how to reply to your comment? This is new one, it is not direct a

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ Lukas, sorry,I missed it. New version pushed. I have question, is there any way how to reply to your comment? This is new one, it is not direct answer. &q

[SSSD] [sssd PR#25][-Changes requested] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][synchronized] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13 From

[SSSD] [sssd PR#25][-Accepted] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#26][-Changes requested] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][-Changes requested] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed celestian commented: """ Hello, I pushed new version with tests. Thanks @sumit-bose with help with the second patch. By the way is there better way how to write co-authors?

[SSSD] [sssd PR#13][synchronized] MEMBEROF: Don't resolve members if they are removed

2016-09-19 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Author: celestian Title: #13: MEMBEROF: Don't resolve members if they are removed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/13/head:pr13 git checkout pr13 From

[SSSD] [sssd PR#26][closed] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-22 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26

[SSSD] [sssd PR#26][synchronized] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Author: celestian Title: #26: KRB5: Fixing FQ name of user in krb5_setup() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/26/head:pr26 git checkout pr26 From

[SSSD] [sssd PR#26][comment] KRB5: Fixing FQ name of user in krb5_setup()

2016-09-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/26 Title: #26: KRB5: Fixing FQ name of user in krb5_setup() celestian commented: """ New version is pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/26#issuecomment-248295259

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ So, code LGTM, thanks for Lukas's watchful eye. I pushed patch to CI. """ See the full comment at https:

[SSSD] [sssd PR#25][comment] TESTS: Add integration tests for the proxy provider of sssd-secrets

2016-09-16 Thread celestian
URL: https://github.com/SSSD/sssd/pull/25 Title: #25: TESTS: Add integration tests for the proxy provider of sssd-secrets celestian commented: """ LGTM, I will push it to our CI. And how Lukas mentioned in mail, it could be nice to fix commit message before pushing. "&quo

[SSSD] [sssd PR#13][comment] MEMBEROF: Don't resolve members if they are removed

2016-10-03 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed celestian commented: """ At first I would like to inform that ticket: https://fedorahosted.org/sssd/ticket/3186 wasn't bug. This patch is valid for ldap provider too.

[SSSD] [sssd PR#13][-Changes requested] MEMBEROF: Don't resolve members if they are removed

2016-10-04 Thread celestian
URL: https://github.com/SSSD/sssd/pull/13 Title: #13: MEMBEROF: Don't resolve members if they are removed Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#39][synchronized] RESPONDER: Enable sudoRule in case insen. domains (1.13)

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/39 Author: celestian Title: #39: RESPONDER: Enable sudoRule in case insen. domains (1.13) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/39/head:pr39 git checkout pr39 From

[SSSD] [sssd PR#76][comment] AD: Fix crash in AD subdomain reinit

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/76 Title: #76: AD: Fix crash in AD subdomain reinit celestian commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/76#issuecomment-259348408 _

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2016-11-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it celestian commented: """ The patch set LGTM. I am waiting for CI and I would like to test it manually. """ See the full comment at https://github.com/

[SSSD] [sssd PR#65][comment] Fixing of nitpicks

2016-11-09 Thread celestian
URL: https://github.com/SSSD/sssd/pull/65 Title: #65: Fixing of nitpicks celestian commented: """ @pbrezina please, could you join discussion? How we can see we call function ```rdp_process_pending_call()``` on two places. And we are not consistent on return value checking.

[SSSD] [sssd PR#73][synchronized] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/73/head:pr73 git checkout pr73 From

[SSSD] [sssd PR#73][opened] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: opened PR body: """ This is backport of https://fedorahosted.org/sssd/ticket/2828 to 1.13. """ To pull the PR as Git branch: git remote add

[SSSD] [sssd PR#73][comment] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-07 Thread celestian
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) celestian commented: """ Notes: 1. I have experienced issue with ```other then master``` case. I hope it was caused by my broken AD setup. 2. Actually there is a test for logic of confi

[SSSD] [sssd PR#73][-Changes requested] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#73][comment] AD_PROVIDER: Enabled subdomains (1.13)

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13) celestian commented: """ I pushed new version with ```(cherry picked from commit...``` (It is done manually) """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it celestian commented: """ I tested manually with IPA provider. It works and I was informed about attribute colision: ``` [sdap_extend_map] (0x0010): Attribute entryU

[SSSD] [sssd PR#70][+Accepted] check_duplicate: check name member before using it

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#69][comment] krb5: Use command line arguments instead env vars for krb5_child

2016-11-08 Thread celestian
URL: https://github.com/SSSD/sssd/pull/69 Title: #69: krb5: Use command line arguments instead env vars for krb5_child celestian commented: """ Code looks good to me. CI tests passed: http://sssd-ci.duckdns.org/logs/job/56/34/summary.html => ACK """ See the fu

  1   2   3   >