[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread mzidek-rh
mzidek-rh commented on a pull request """ The patch works. I pushed it to CI, waiting for results. As I tested the local provider now, I found that the sss_groupshow does not seem to work. Will check why. But it is not related to this patch. """ See the full comme

[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread mzidek-rh
mzidek-rh commented on a pull request """ I see the error with the sss_groupshow. Will send patch in another PR. """ See the full comment at https://github.com/SSSD/sssd/pull/14#issuecomment-244920668 ___ sssd

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (opened)

2016-09-06 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was opened PR body: """ sss_groupshow used shortname to search in sysdb database. We have to u e sysdb_fqname (aka internal_fqname) format for all sysdb oprations. Resolves: https://fedorahosted.org/sssd/ticket/3175 """ See the fu

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (synchronize)

2016-09-06 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/16 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/16/head:pr16 git checkout pr16 From 0bcb9c

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

2016-09-06 Thread mzidek-rh
mzidek-rh commented on a pull request """ This PR includes some fixes for local provider. Namely jhrozek's patch for sss_groupadd and fix for sss_groupshow. I will add more fixes (sss_usermod etc.) in another PR tomorrow. """ See the full comment at h

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (synchronize)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/16 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/16/head:pr16 git checkout pr16 From 0bcb9c

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (opened)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" was opened PR body: """ Hi, This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes fix for the ticket https://fedorahosted.org/sssd/ticket/3178. Michal """ See the full pull-request at https://github.com/S

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread mzidek-rh
mzidek-rh commented on a pull request """ Thanks for the tip Nick. """ See the full comment at https://github.com/SSSD/sssd/pull/18#issuecomment-245304406 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (synchronize)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/18 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/18/head:pr18 git checkout pr18 From 0bcb9

[SSSD] [sssd PR#20] sss_override fails to export (opened)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #20: "sss_override fails to export" was opened PR body: """ Here is a fix + CI test for https://fedorahosted.org/sssd/ticket/3179. Michal """ See the full pull-request at https://github.com/SSSD/sssd/pull/20 ... or pull the PR as Git branch: git remote add ghsssd https:/

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (-Changes requested)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *Changes requested* has been removed See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fe

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (+Rejected)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #16: "TOOLS: sss_groupshow did not work" label *Rejected* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/16 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (+Pushed)

2016-09-07 Thread mzidek-rh
mzidek-rh's pull request #18: "[PATCHES] sss_user/groupmod fixes" label *Pushed* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/18 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.o

[SSSD] [sssd PR#16] TOOLS: sss_groupshow did not work (comment)

2016-09-07 Thread mzidek-rh
mzidek-rh commented on a pull request """ The patches from PR are included in PR #18 . Labeling this one as rejected. """ See the full comment at https://github.com/SSSD/sssd/pull/16#issuecomment-245437017 ___ sssd

[SSSD] [sssd PR#20] sss_override fails to export (comment)

2016-09-09 Thread mzidek-rh
mzidek-rh commented on a pull request """ I agree that we need better tests for sss_override, but the purpose of this test was to catch the error in the ticket so that we do not regress. We can create a ticket to add more comprehensive tests for sss_overide export/import as a

[SSSD] [sssd PR#20] sss_override fails to export (comment)

2016-09-09 Thread mzidek-rh
mzidek-rh commented on a pull request """ Btw. I am currently working on tests for some features we do not have covered in upstream CI. I can add test for the sss_overide after I am finished with that. But I would really prefer not to block this fix (pbrezina confirmed it is a

[SSSD] [sssd PR#20] sss_override fails to export (synchronize)

2016-09-09 Thread mzidek-rh
mzidek-rh's pull request #20: "sss_override fails to export" was synchronize See the full pull-request at https://github.com/SSSD/sssd/pull/20 ... or pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/20/head:pr20 git checkout pr20 From d90b325eb5c2

[SSSD] [sssd PR#20] sss_override fails to export (comment)

2016-09-09 Thread mzidek-rh
mzidek-rh commented on a pull request """ See the updated tests. It uses export and import and checks if override works after import. """ See the full comment at https://github.com/SSSD/sssd/pull/20#issuecomment-245903519 _

[SSSD] [sssd PR#23] sss_groupshow does not work with mpg (opened)

2016-09-12 Thread mzidek-rh
mzidek-rh's pull request #23: "sss_groupshow does not work with mpg" was opened PR body: """ We recently fixed this with normal groups. The MPG code path was still using shortname in sysdb search operation. Upstream ticket: https://fedorahosted.org/sssd/ticket/3184 """ See the full pull-request

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (comment)

2016-09-13 Thread mzidek-rh
mzidek-rh commented on a pull request """ Makes sense, but I would prefer to add new "else if" branch with ADMINLIMIT_EXCEEDED specific debug message. It would also make sense to change the SDAP_SRCH_FLG_SIZELIMIT_SILENT into something more generic, like SDAP_SRCH_FLG_

[SSSD] [sssd PR#22] LDAP: Return partial results from adminlimit exceeded (+Changes requested)

2016-09-13 Thread mzidek-rh
jhrozek's pull request #22: "LDAP: Return partial results from adminlimit exceeded" label *Changes requested* has been added See the full pull-request at https://github.com/SSSD/sssd/pull/22 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#27][opened] Minor code changes

2016-09-16 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: opened PR body: """ Some small changes in the code. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/

[SSSD] [sssd PR#27][synchronized] Minor code changes

2016-09-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/27 Author: mzidek-rh Title: #27: Minor code changes Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/27/head:pr27 git checkout pr27 From ab432e4dd82a955c69b2b652082d6a9b62036f0e

[SSSD] [sssd PR#27][-Changes requested] Minor code changes

2016-09-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/27 Title: #27: Minor code changes Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#41][opened] MAN: Wrong defaults for AD provider

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Author: mzidek-rh Title: #41: MAN: Wrong defaults for AD provider Action: opened PR body: """ ldap_user_name and ldap_group_name have different defalts then what the man page states. Resolves: https://fedorahosted.org/sssd/ticket/30

[SSSD] [sssd PR#41][comment] MAN: Wrong defaults for AD provider

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Title: #41: MAN: Wrong defaults for AD provider mzidek-rh commented: """ It is man page change, but does not require native speaker for review. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#42][opened] MAN: Typo in id mapping explanation

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/42 Author: mzidek-rh Title: #42: MAN: Typo in id mapping explanation Action: opened PR body: """ It is probably result of modifying the code and not updating the man page properly. Resolves: https://fedorahosted.org/sssd/ticket/3205 &quo

[SSSD] [sssd PR#42][comment] MAN: Typo in id mapping explanation

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/42 Title: #42: MAN: Typo in id mapping explanation mzidek-rh commented: """ Another man page fix. Native speaker not required. """ See the full comment at https://github.com/SSSD/sssd/

[SSSD] [sssd PR#42][synchronized] MAN: Typo in id mapping explanation

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/42 Author: mzidek-rh Title: #42: MAN: Typo in id mapping explanation Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/42/head:pr42 git checkout pr42 From

[SSSD] [sssd PR#42][comment] MAN: Typo in id mapping explanation

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/42 Title: #42: MAN: Typo in id mapping explanation mzidek-rh commented: """ Updated according to Sumit's comment. """ See the full comment at https://github.com/SSSD/sssd/pull/42#issuecomment-251935126 _

[SSSD] [sssd PR#42][-Changes requested] MAN: Typo in id mapping explanation

2016-10-06 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/42 Title: #42: MAN: Typo in id mapping explanation Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#41][comment] MAN: Wrong defaults for AD provider

2016-10-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Title: #41: MAN: Wrong defaults for AD provider mzidek-rh commented: """ I did not want to explicitly state all the providers so I first special cased AD and then just said 'other providers'... however I do not think now it w

[SSSD] [sssd PR#41][comment] MAN: Wrong defaults for AD provider

2016-10-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Title: #41: MAN: Wrong defaults for AD provider mzidek-rh commented: """ Actually I do not think it was good to talk about providers, because this is more schema thing. I will put the schema names instead of the providers. ""&

[SSSD] [sssd PR#41][synchronized] MAN: Wrong defaults for AD provider

2016-10-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Author: mzidek-rh Title: #41: MAN: Wrong defaults for AD provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/41/head:pr41 git checkout pr41 From

[SSSD] [sssd PR#41][-Changes requested] MAN: Wrong defaults for AD provider

2016-10-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/41 Title: #41: MAN: Wrong defaults for AD provider Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ Hi, connecting to confdb makes some sssctl commands less useful (config-check and in the future, config-show). This adds flag to skip confdb init for s

[SSSD] [sssd PR#48][opened] sssctl: Flags for commadn initialization

2016-10-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: opened PR body: """ Allow passing flags for command specific initialization. Currently only one flag is available to skip the confdb initialization which

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ Updated patch according to Fabiano's comments. """ See the full comment at https://github.com/SSSD/

[SSSD] [sssd PR#48][synchronized] sssctl: Flags for commadn initialization

2016-10-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48 From

[SSSD] [sssd PR#48][synchronized] sssctl: Flags for commadn initialization

2016-10-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48 From

[SSSD] [sssd PR#48][-Changes requested] sssctl: Flags for commadn initialization

2016-10-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ updated """ See the full comment at https://github.com/SSSD/sssd/pull/48#issuecomment-253487693 _

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ Ok, new patch uploaded. """ See the full comment at https://github.com/SSSD/sssd/pull/48#issuecomment-253774056

[SSSD] [sssd PR#48][synchronized] sssctl: Flags for commadn initialization

2016-10-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48 From

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ I see the comment did not get forwarded to the devel list, so pasting again: Sorry, I am out of ideas here. What name do you propose? Or will it be enough

[SSSD] [sssd PR#48][synchronized] sssctl: Flags for commadn initialization

2016-10-18 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48 From

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-18 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ I used the jhrozek's proposed *_NOCONF name. I also added comment to make it clear that it will not initialize both confdb and domain context. "&q

[SSSD] [sssd PR#48][synchronized] sssctl: Flags for commadn initialization

2016-10-18 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Author: mzidek-rh Title: #48: sssctl: Flags for commadn initialization Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/48/head:pr48 git checkout pr48 From

[SSSD] [sssd PR#48][comment] sssctl: Flags for commadn initialization

2016-10-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization mzidek-rh commented: """ Is it really that confusing even with the comments added? Well, I immediately return from the function when the flag is set, because the function currently o

[SSSD] [sssd PR#59][opened] ipa_netgroups: Lowercase key to htable

2016-10-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: opened PR body: """ Fixes: https://fedorahosted.org/sssd/ticket/3116 We lowercase the search key when storing entries into the hash table, but do not do it

[SSSD] [sssd PR#59][reopened] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Lukas: The ticket 3116 was closed as duplicate by you. I was always saying that it is not duplicate. I even said that in order to solve them properly we need

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ IPA does not allow other then lower cased netgroup names. # ipa netgroup-add Netgroup name: WAAA - Added netgroup "waaa" ---

[SSSD] [sssd PR#59][reopened] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ And yes, there are differences between plain LDAP and IPA providers. The netgroup code is completely different. It may be good to unify the two, but it is not

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-10-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Part of the key is the attribute name. My guess is that the lowercaseing before storing to the hash table is to make sure that the attribute name case will not

[SSSD] [sssd PR#48][-Changes requested] sssctl: Flags for commadn initialization

2016-10-25 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/48 Title: #48: sssctl: Flags for commadn initialization Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Hi, I am reopening this ticket, because FreeIPA UQE have a test. Btw. I can change the patch to not lowercase the key in the first place (while creating the ent

[SSSD] [sssd PR#59][reopened] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Author: mzidek-rh Title: #59: ipa_netgroups: Lowercase key to htable Action: reopened To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/59/head:pr59 git checkout pr59

[SSSD] [sssd PR#59][comment] ipa_netgroups: Lowercase key to htable

2016-11-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/59 Title: #59: ipa_netgroups: Lowercase key to htable mzidek-rh commented: """ Well, changing the ticket is a detail, we can change the ticket wording if necessary. I would like to get some comments on the lowercasing and if we want

[SSSD] [sssd PR#78][opened] ipa: Nested netgroups do not work

2016-11-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/78 Author: mzidek-rh Title: #78: ipa: Nested netgroups do not work Action: opened PR body: """ We lowercase the keys to the hash table used to store netgroups but do not lowercase it when reading the table. This results in nested netg

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ I need to write an intg test. So the review can wait. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#102][opened] Sssctl no case sensitive searches

2016-12-01 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Author: mzidek-rh Title: #102: Sssctl no case sensitive searches Action: opened PR body: """ Trying to get rid of branches with smaller patches. Here is one of them. """ To pull the PR as Git branch: git remote add

[SSSD] [sssd PR#102][synchronized] Sssctl no case sensitive searches

2016-12-02 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Author: mzidek-rh Title: #102: Sssctl no case sensitive searches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/102/head:pr102 git checkout pr102 From

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-02 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ Regression test was added """ See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-264518150

[SSSD] [sssd PR#104][comment] Suppress a confusing error message from timestamp cache updates

2016-12-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates mzidek-rh commented: """ Tentative ACK. Testing now. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#105][comment] RESPONDER: Remove dead assignment to the variable ret

2016-12-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/105 Title: #105: RESPONDER: Remove dead assignment to the variable ret mzidek-rh commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/105#issuecomment-265487170

[SSSD] [sssd PR#105][+Accepted] RESPONDER: Remove dead assignment to the variable ret

2016-12-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/105 Title: #105: RESPONDER: Remove dead assignment to the variable ret Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#104][comment] Suppress a confusing error message from timestamp cache updates

2016-12-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates mzidek-rh commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/104#issuecomment-265496840 __

[SSSD] [sssd PR#104][+Accepted] Suppress a confusing error message from timestamp cache updates

2016-12-07 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/104 Title: #104: Suppress a confusing error message from timestamp cache updates Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#102][synchronized] Sssctl no case sensitive searches

2016-12-08 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Author: mzidek-rh Title: #102: Sssctl no case sensitive searches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/102/head:pr102 git checkout pr102 From

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-08 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ Just updated the patches. """ See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-265736056

[SSSD] [sssd PR#102][-Changes requested] Sssctl no case sensitive searches

2016-12-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ I see I forgot to remove the changes requested label. Doing so now. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#102][synchronized] Sssctl no case sensitive searches

2016-12-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Author: mzidek-rh Title: #102: Sssctl no case sensitive searches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/102/head:pr102 git checkout pr102 From

[SSSD] [sssd PR#102][-Changes requested] Sssctl no case sensitive searches

2016-12-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-14 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ I pushed it to CI, but the RHEL 6 build took too long time, so I canceled it. Here is the partial result (the rawhide fail is unrelated): http://sssd-ci.duckdns.org

[SSSD] [sssd PR#110][comment] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures mzidek-rh commented: """ Hi, I added some comments, please check them out. """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#110][+Changes requested] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-15 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status o

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status o

[SSSD] [sssd PR#110][comment] Add more DEBUG messages to help admins diagnose Kerberos login failures

2017-01-09 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures mzidek-rh commented: """ I agree with the smaller patch. I think jhrozek agreed that the changes in src/providers/krb5/krb5_child.c can be droppe

[SSSD] [sssd PR#120][opened] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Author: mzidek-rh Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion Action: opened PR body: """ We falsely stopped GPO processing when Group Policy Container in AD did not contain gPCFunctionalityVersion. Such GPOs should be

[SSSD] [sssd PR#120][comment] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion mzidek-rh commented: """ To test manually, you can create a testing GPO normally and then unset the parmeter (for example using the ADSI Edit). """

[SSSD] [sssd PR#120][synchronized] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Author: mzidek-rh Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/120/head:pr120 git checkout pr120 From

[SSSD] [sssd PR#120][comment] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-11 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion mzidek-rh commented: """ Hi Lukas, I responded to your comments, please tell me what you think about it. Michal """ See the full comment at https:/

[SSSD] [sssd PR#120][synchronized] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Author: mzidek-rh Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/120/head:pr120 git checkout pr120 From

[SSSD] [sssd PR#120][comment] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion mzidek-rh commented: """ I uploaded new version. I was thinking about the level of debug message and I made it less loud. I also returned the changed debug message to its ori

[SSSD] [sssd PR#120][-Changes requested] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#123][opened] MAN: sssctl debug level

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/123 Author: mzidek-rh Title: #123: MAN: sssctl debug level Action: opened PR body: """ Use tools specific reference to debog level explanation in sssctl man page. Resolves: https://fedorahosted.org/sssd/ticket/3085 """ To

[SSSD] [sssd PR#119][comment] Remove unused Attr type

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/119 Title: #119: Remove unused Attr type mzidek-rh commented: """ Patch: LDAP: Fix debug messages after errors in *_get_send Ack. Patch: LDAP: Removed unused attr_type from users_get_send I think it makes sense to remove the "TOD

[SSSD] [sssd PR#123][synchronized] MAN: sssctl debug level

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/123 Author: mzidek-rh Title: #123: MAN: sssctl debug level Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/123/head:pr123 git checkout pr123 From

[SSSD] [sssd PR#119][+Accepted] Remove unused Attr type

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/119 Title: #119: Remove unused Attr type Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#119][comment] Remove unused Attr type

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/119 Title: #119: Remove unused Attr type mzidek-rh commented: """ ACK to all patches. CI result: http://sssd-ci.duckdns.org/logs/job/60/03/summary.html """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#123][comment] MAN: sssctl debug level

2017-01-13 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/123 Title: #123: MAN: sssctl debug level mzidek-rh commented: """ Fixed typo in the commit message. """ See the full comment at https://github.com/SSSD/sssd/pull/123#issuecomment-272491946

[SSSD] [sssd PR#120][synchronized] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Author: mzidek-rh Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/120/head:pr120 git checkout pr120 From

[SSSD] [sssd PR#120][comment] GPO: Skip GPOs without gPCFunctionalityVersion

2017-01-19 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/120 Title: #120: GPO: Skip GPOs without gPCFunctionalityVersion mzidek-rh commented: """ I added one more patch that improves debug messages. It is not part of the fix, but touches the same lines, so I am using this PR for it. ""&

[SSSD] [sssd PR#151][comment] BUILD: Fix linking of test_sdap_initgr

2017-02-08 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/151 Title: #151: BUILD: Fix linking of test_sdap_initgr mzidek-rh commented: """ LGTM waiting for CI. """ See the full comment at https://github.com/SSSD/sssd/pull/151#issuecomment-278392638

[SSSD] [sssd PR#151][comment] BUILD: Fix linking of test_sdap_initgr

2017-02-08 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/151 Title: #151: BUILD: Fix linking of test_sdap_initgr mzidek-rh commented: """ Ack from me, but please also amend the commit message according to Fabiano's request before pushing. Link to CI: http://sssd-ci.duckdns.org/logs/jo

[SSSD] [sssd PR#151][+Accepted] BUILD: Fix linking of test_sdap_initgr

2017-02-08 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/151 Title: #151: BUILD: Fix linking of test_sdap_initgr Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

  1   2   3   4   5   6   7   8   >