[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5863 * `master` * 1110bd59e62dc9a9886612f59eb6358fa53fb0cc - Analyzer: Fail if chain ID support is missing * 9d62708176ce1c9d50f8f83f18497321aa86b6ae - Analyzer: Avoid circular import * ca1d7e29103c5720a639ae5b734846077e097d05 - sss-analyze: Fix self imports * 7825e0d3223a374d002d0feb23441f0a8f8687f7 - Analyzer: Search all responder log files * 0ba456f9edb978bb7b28452a8d3afa32fdba66cc - Analyzer: Add --child argument to 'request show' * 1959a2bb47c6f4e08f5bcddb4697e2ddde719c42 - Analyzer: Parse the responder request ID * 06d3e79c3baba5f9eae8f5c814a0b47ccc8856a7 - proxy_child: Add chain ID logging support * be482ac39075ce7d9112dfaeb962d2a01ba2a910 - p11_child: Add chain ID logging support * c92d39a30fa0162d4efdfbe5883c8ea9911a2249 - ipa_selinux: Add chain ID logging support * 60712f31fbc17fe2fd49364327c18e5da2697016 - gpo: Add chain ID logging support * cb70739f31f4051f52af03e1e2ba1e079689a231 - krb5_child: Add chain ID logging support * 526f731495c5a7fd13309a41bad61b4f95c5d2b4 - chain_id: Add support for custom debug format * 2b6edf7733fc69b7c7fb79ee935e77a9a1ec181d - RESPONDER: Support chain ID logging * 9296eaf9af04503807a0015e0405e2ff651ee532 - sbus: Remember outgoing request chain ID * 6f217eac888bb25c875f1bb060f6cef5a052e2f3 - RESPONDER: Remove extraneous client ID logging * e8e7e23afeb5f07c82dcb05341f26f92ee548ab7 - util: Split chain ID tevent functions """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-27498 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ The same test failed again. Looks a little bit similar to fails we saw in #5766 (that were fixed by 29f8a795f67db651e95842cddf153975f97d9b3f) """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-99947 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ > > https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log > > Not sure how this was caused by my PR I also don't understand this. But other PRs don't have this fail. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-997048503 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log Not sure how this was caused by my PR, I'm triggering a re-run of the CI before I leave for the weekend. I'll have to investigate further on Monday if it shows the same failures. I couldn't reproduce this failure locally but I am on Fedora 34, not 33 """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-997044673 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5863/20/fedora33/ci-make-intgcheck.log """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-997037186 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ * Added one final commit (I hope) https://github.com/SSSD/sssd/pull/5863/commits/8ab51e9dbd3ec7a469f0e38046f2354297e7b7ba """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996886077 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I agree with @alexey-tikhonov, it is better to just fail hard if chain ID support is missing. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996858330 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ From my point of view, it's ok to change "will be limited" to "unsupported" and just quit at this point. There is really very little we can do without req-ids. @sumit-bose, what would you say? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996735721 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ From my point of view, it's ok to change "will be limited" to "unsupported" and just quit at this point. There is really very little we can do without req-ids. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996735721 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ @justin-stephenson, I saw the message, thank you. Since there is no strict requirement on that version of libtevent I assumed the tool should work in either case. Otherwise, this case should be explicitly handled I think. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996730412 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > ``` > [root@master1 /]# sssctl analyze request list -v > NOTE: Tevent chain ID support missing, request analysis will be limited. > It is recommended to use the --logdir option against tevent chain ID > supported SSSD logs. > 2021-12-17 8:09:10: [uid 0] CID #: getent >- User by name > Traceback (most recent call last): > File "/usr/libexec/sssd/sss_analyze", line 5, in > sss_analyze.run() > File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 104, in run > analyzer.main() > File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 99, in main > args.func(args) > File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 231, in > list_requests > self.print_formatted(line, args.verbose) > File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 168, in > print_formatted > cr_field = fields[3][7:] > IndexError: list index out of range > Command '/usr/libexec/sssd/sss_analyze' failed with [1] > ``` @stanislavlevin Does your distribution provide a recent [libtevent](https://tevent.samba.org/) package ? The analyzer tool is effectively useless without tevent chain ID support. We do not handle this case well inside analyzer code, perhaps we just return gracefully and print a stronger error message in this situation. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996720068 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ > ``` > [root@master1 /]# sssctl analyze request list -v > NOTE: Tevent chain ID support missing, request analysis will be limited. > It is recommended to use the --logdir option against tevent chain ID > supported SSSD logs. > 2021-12-17 8:09:10: [uid 0] CID #: getent >- User by name > Traceback (most recent call last): > File "/usr/libexec/sssd/sss_analyze", line 5, in > sss_analyze.run() > File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 104, in run > analyzer.main() > File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 99, in main > args.func(args) > File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 231, in > list_requests > self.print_formatted(line, args.verbose) > File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 168, in > print_formatted > cr_field = fields[3][7:] > IndexError: list index out of range > Command '/usr/libexec/sssd/sss_analyze' failed with [1] > ``` ``` (Pdb) fields ['(2021-12-17 8:09:10): ', 'nss] ', 'cache_req_search_send] (0x0400): CR #135: Looking up _s...@ipa.test\n'] ``` """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996539870 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ Are there corresponding tests? Can't find them. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996523962 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ cherry-pick is OK. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996521088 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements stanislavlevin commented: """ ``` [root@master1 /]# sssctl analyze request list -v NOTE: Tevent chain ID support missing, request analysis will be limited. It is recommended to use the --logdir option against tevent chain ID supported SSSD logs. 2021-12-17 8:09:10: [uid 0] CID #: getent - User by name Traceback (most recent call last): File "/usr/libexec/sssd/sss_analyze", line 5, in sss_analyze.run() File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 104, in run analyzer.main() File "/usr/lib/python3/site-packages/sssd/sss_analyze.py", line 99, in main args.func(args) File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 231, in list_requests self.print_formatted(line, args.verbose) File "/usr/lib/python3/site-packages/sssd/modules/request.py", line 168, in print_formatted cr_field = fields[3][7:] IndexError: list index out of range Command '/usr/libexec/sssd/sss_analyze' failed with [1] ``` """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996518854 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ @stanislavlevin, are you fine with a cherry-pick and a fix on top? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996103825 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ Latest push adds the following into this PR, to incorporate changes from PR 5845 and avoid the need to rebase * Commit from @stanislavlevin in https://github.com/SSSD/sssd/pull/5845 * https://github.com/SSSD/sssd/pull/5863/commits/bf38817478bf234adab6043b9ce60e45a76908b6 on top to address circular import issue exposed by PR 5845 """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-996081969 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > @justin-stephenson, please rebase. Done, thank you. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-995837651 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ @justin-stephenson, please rebase. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-995785995 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, thanks for the patch, it is working well in my (quite basic) tests for PAM and NSS. I'm afraid I can't remember what we planned for the other responders, e.g. ssh. You added support in the responders already here but `sssctl analyze` currently has no options to select other responders. Nevertheless, this should not be added here but better with another patch on top of your patch with replaces python click. So, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-995106714 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ @sumit-bose, do you agree with the latest changes? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-994741262 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ These changes remove the analyzer `--cachereq'`option and add a new `--child` option, https://sssd.io/troubleshooting/analyzer.html will need to be updated when these changes are released. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-992919778 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
> > This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> > which makes the log analyzer output quite unfriendly/ugly.
>
> But this requires log with `SSSDBG_TRACE_LDB` enabled - something that should
> not really happen much in the wild, right? Probably we don't have to do
> anything with it at all?
You are right, I forgot i had debug_level = 10 set. Probably it can be ignored
then.
>
> ```
> > if (debug_chain_id > 0) {
> > -sss_debug_backtrace_printf(level, debug_chain_id_fmt,
> > debug_chain_id);
> > +if (strcmp(function, "ldb") != 0) {
> ```
>
> Doesn't look appealing... Imo, even check for `level` would be better, but
> see above.
Ok disregard.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-992915864
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
> This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> which makes the log analyzer output quite unfriendly/ugly.
But this requires log with `SSSDBG_TRACE_LDB` enabled - something that should
not really happen much in the wild, right?
Probably we don't have to do anything with it at all?
```
> if (debug_chain_id > 0) {
> -sss_debug_backtrace_printf(level, debug_chain_id_fmt,
> debug_chain_id);
> +if (strcmp(function, "ldb") != 0) {
```
Doesn't look appealing... Imo, even check for `level` would be better, but see
above.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-992890844
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
alexey-tikhonov commented:
"""
> This introduced an issue where `[ldb]` messages are tagged with CID/RID,
> which makes the log analyzer output quite unfriendly/ugly.
But this requires log with `SSSDBG_TRACE_LDB` enabled - something that should
not really happen much in the wild, right?
Probably we don't have to do anything with it at all?
> if (debug_chain_id > 0) {
> -sss_debug_backtrace_printf(level, debug_chain_id_fmt,
> debug_chain_id);
> +if (strcmp(function, "ldb") != 0) {
Doesn't look appealing... Imo, even check for `level` would be better, but see
above.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-992890844
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863
Title: #5863: Responder and Child process tevent chain id improvements
justin-stephenson commented:
"""
Latest push addresses final items requested by Pavel:
* splits a commit for [adding
chain_id](https://github.com/SSSD/sssd/pull/5863/commits/bc5f885dcab2d6e61863bcc5fdc4ee2c3867f063)
* removed cache req workaround and added commit
https://github.com/SSSD/sssd/pull/5863/commits/a671dc01e219c6004ca24faab50a0c0f14580db8
(proper fix)
This introduced an issue where `[ldb]` messages are tagged with CID/RID, which
makes the log analyzer output quite unfriendly/ugly.
~~~
(2021-12-13 15:35:32): [be[redhat.com]] [sdap_save_user] (0x0400): [RID#4]
Storing info for user jstep...@redhat.com
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] start ldb
transaction (nesting: 1)
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] Added timed
event "ldb_kv_callback": 0x1895110
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] Added timed
event "ldb_kv_timeout": 0x18a79c0
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] Running timer
event 0x1895110 "ldb_kv_callback"
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] Destroying
timer event 0x18a79c0 "ldb_kv_timeout"
(2021-12-13 15:35:32): [be[redhat.com]] [ldb] (0x1): [RID#4] Destroying
timer event 0x1895110 "ldb_kv_callback"
(2021-12-13 15:35:32): [be[redhat.com]] [sysdb_search_by_name] (0x0400):
[RID#4] No such entry
(2021-12-13 15:35:32): [be[redhat.com]] [sysdb_store_user] (0x1000): [RID#4]
User jstep...@redhat.com does not exist.
~~~
It could be addressed with the following diff, some other way in the ldb code,
or these logs can be simply filtered out in the analyzer code. What do you
suggest @alexey-tikhonov @sumit-bose ?
~~~
diff --git a/src/util/debug.c b/src/util/debug.c
index b54eca7ce..33d6ea049 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -354,7 +354,9 @@ void sss_vdebug_fn(const char *file,
debug_prg_name, function, level);
if (debug_chain_id > 0) {
-sss_debug_backtrace_printf(level, debug_chain_id_fmt, debug_chain_id);
+if (strcmp(function, "ldb") != 0) {
+sss_debug_backtrace_printf(level, debug_chain_id_fmt,
debug_chain_id);
+}
}
sss_debug_backtrace_vprintf(level, format, ap);
~~~
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5863#issuecomment-992881236
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements pbrezina commented: """ https://github.com/SSSD/sssd/pull/5863#discussion_r768040888 + split adding chain id format to its own commit and it is ack from me. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-992780662 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Deferred until we have a conclusion what upstream release this targets. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-979088453 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, thanks, remaining CI issues are not related, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-976215769 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > Thanks, sorry I should have caught this. Fixed now. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-975635466 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I'm sorry I didn't pull the latest version when running the tests. Since the chain_id option is now added unconditionally `test_set_extra_args` needs a change like: ``` diff --git a/src/tests/cmocka/test_krb5_common.c b/src/tests/cmocka/test_krb5_common.c index c43d836ad..4bf3237a7 100644 --- a/src/tests/cmocka/test_krb5_common.c +++ b/src/tests/cmocka/test_krb5_common.c @@ -103,7 +103,8 @@ void test_set_extra_args(void **state) assert_int_equal(ret, EOK); assert_string_equal(krb5_child_extra_args[0], uid_opt); assert_string_equal(krb5_child_extra_args[1], gid_opt); -assert_null(krb5_child_extra_args[2]); +assert_string_equal(krb5_child_extra_args[2], "--chain-id=0"); +assert_null(krb5_child_extra_args[3]); talloc_free(krb5_child_extra_args); krb5_ctx->canonicalize = true; @@ -113,7 +114,8 @@ void test_set_extra_args(void **state) assert_string_equal(krb5_child_extra_args[0], uid_opt); assert_string_equal(krb5_child_extra_args[1], gid_opt); assert_string_equal(krb5_child_extra_args[2], "--canonicalize"); -assert_null(krb5_child_extra_args[3]); +assert_string_equal(krb5_child_extra_args[3], "--chain-id=0"); +assert_null(krb5_child_extra_args[4]); talloc_free(krb5_child_extra_args); krb5_ctx->realm = discard_const(TEST_REALM); @@ -124,7 +126,8 @@ void test_set_extra_args(void **state) assert_string_equal(krb5_child_extra_args[1], gid_opt); assert_string_equal(krb5_child_extra_args[2], "--realm=" TEST_REALM); assert_string_equal(krb5_child_extra_args[3], "--canonicalize"); -assert_null(krb5_child_extra_args[4]); +assert_string_equal(krb5_child_extra_args[4], "--chain-id=0"); +assert_null(krb5_child_extra_args[5]); talloc_free(krb5_child_extra_args); /* --fast-principal will be only set if FAST is used */ @@ -136,7 +139,8 @@ void test_set_extra_args(void **state) assert_string_equal(krb5_child_extra_args[1], gid_opt); assert_string_equal(krb5_child_extra_args[2], "--realm=" TEST_REALM); assert_string_equal(krb5_child_extra_args[3], "--canonicalize"); -assert_null(krb5_child_extra_args[4]); +assert_string_equal(krb5_child_extra_args[4], "--chain-id=0"); +assert_null(krb5_child_extra_args[5]); talloc_free(krb5_child_extra_args); krb5_ctx->use_fast_str = discard_const(TEST_FAST_STR); @@ -150,7 +154,8 @@ void test_set_extra_args(void **state) assert_string_equal(krb5_child_extra_args[4], "--fast-principal=" TEST_FAST_PRINC); assert_string_equal(krb5_child_extra_args[5], "--canonicalize"); -assert_null(krb5_child_extra_args[6]); +assert_string_equal(krb5_child_extra_args[6], "--chain-id=0"); +assert_null(krb5_child_extra_args[7]); talloc_free(krb5_child_extra_args); krb5_ctx->lifetime_str = discard_const(TEST_LIFE_STR); @@ -168,7 +173,8 @@ void test_set_extra_args(void **state) assert_string_equal(krb5_child_extra_args[6], "--fast-principal=" TEST_FAST_PRINC); assert_string_equal(krb5_child_extra_args[7], "--canonicalize"); -assert_null(krb5_child_extra_args[8]); +assert_string_equal(krb5_child_extra_args[8], "--chain-id=0"); +assert_null(krb5_child_extra_args[9]); talloc_free(krb5_child_extra_args); talloc_free(krb5_ctx); ``` """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-974616834 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ Hi, I'm fine with the patches and test are working locally for me. I restarted the CI task to hopefully get some CI results as well. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-974286264 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Thank you for updates, @justin-stephenson. In general (besides one open minor conversation) looks good to me. @sumit-bose, could please also take a look (if your comments were addressed and if you agree with https://github.com/SSSD/sssd/pull/5863#discussion_r748463470)? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-972840915 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Isn't it required to execute `sss_chain_id_setup()` in all child processes? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-967256421 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Isn't it required to execute `sss_chain_id_setup()` in all child processes? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-967256421 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ Now that the chain ID is logged in responder log files, should the analyzer tool always grep responder log files for `CID#` in `request show` output? This is simple but it means removing the `--cachereq` option as those logs would always be included in the output then. I added a commit for this `Analyzer: Search all responder log files` in case this is agreed upon behavior (will drop it if not). It does produce more output but it would be useful in solving any responder-logged problems """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-965751719 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > Isn't it required to set `debug_from_responder` in `p11_child`? Yes, fixed. """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-965730359 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ > > Hi, > > I tend to the latter. The idea of the tool is to help to find issues. Adding > the child logs by default might make this harder especially if the issue is > not related to a child process. It might be even worth to be able to switch > on only a single child, e.g. `--child=krb5_child`. Okay agreed, I went ahead and added a `--child` boolean option defaulting to false to the `request show` subcommand > > Is there a reason you mostly send the id together with other data via stdin > and not with a command line option? Personally I would prefer a comand line > option because it makes the child process more easy to use manually. E.g. > currently you can run `p11_child` manually even in auth mode by calling > > ``` > echo -n PIN | /usr/libexec/sssd/p11_child --auth . > ``` > > Now additional 8 bytes are expected, which still would allow to call > `p11_child` manually but it would be less obvious. The PIN has to be send via > stdin, otherwise it would be visible on the command line and so visible for > everyone calling `ps`. Understood, I went ahead and switched to sending the chain ID as a command line argument for each child process. Could you please test the p11 child works as expected now? > > bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-965727885 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ Isn't it required to set `debug_from_responder` in `p11_child`? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-963465303 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements sumit-bose commented: """ > Now that the RID # is passed to the child log files, `sssctl analyze request > show #` will check these child logs and print those RID # matches also. > Should this be default behavior, or only when an argument like `--child` is > provided to the request show subcommand? Hi, I tend to the latter. The idea of the tool is to help to find issues. Adding the child logs by default might make this harder especially if the issue is not related to a child process. It might be even worth to be able to switch on only a single child, e.g. `--child=krb5_child`. Is there a reason you mostly send the id together with other data via stdin and not with a command line option? Personally I would prefer a comand line option because it makes the child process more easy to use manually. E.g. currently you can run `p11_child` manually even in auth mode by calling echo -n PIN | /usr/libexec/sssd/p11_child --auth . Now additional 8 bytes are expected, which still would allow to call `p11_child` manually but it would be less obvious. The PIN has to be send via stdin, otherwise it would be visible on the command line and so visible for everyone calling `ps`. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-963103190 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements justin-stephenson commented: """ Now that the RID # is passed to the child log files, `sssctl analyze request show #` will check these child logs and print those RID # matches also. Should this be default behavior, or only when an argument like `--child` is provided to the request show subcommand? """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-961183126 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5863][comment] Responder and Child process tevent chain id improvements
URL: https://github.com/SSSD/sssd/pull/5863 Title: #5863: Responder and Child process tevent chain id improvements alexey-tikhonov commented: """ RHBZs: - https://bugzilla.redhat.com/show_bug.cgi?id=2013259 - https://bugzilla.redhat.com/show_bug.cgi?id=2013260 - https://bugzilla.redhat.com/show_bug.cgi?id=2013262 - https://bugzilla.redhat.com/show_bug.cgi?id=2013263 """ See the full comment at https://github.com/SSSD/sssd/pull/5863#issuecomment-961125715 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
