[PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

2012-06-05 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- drivers/gpio/gpio-wm8994.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index f2b3d19..1c764e7 100644 --- a/drivers

Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

2012-06-07 Thread Mark Brown
On Thu, Jun 07, 2012 at 01:11:20PM +0200, Linus Walleij wrote: broo...@opensource.wolfsonmicro.com wrote: + ? ? ? if (value) + ? ? ? ? ? ? ? value = WM8994_GPN_LVL; ? ? ? ?return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?WM8994_GPN_DIR, 0); + ? ? ?

[PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

2012-06-08 Thread Mark Brown
Not paying attention to the value being set is a bad thing because it means that we'll not set the hardware up to reflect what was requested. Not setting the hardware up to reflect what was requested means that the caller won't get the results they wanted. ` Signed-off-by: Mark Brown broo

[PATCH 3/4] gpiolib: wm8994: Pay attention to the value set when enabling as output

2012-07-04 Thread Mark Brown
Not paying attention to the value being set is a bad thing because it means that we'll not set the hardware up to reflect what was requested. Not setting the hardware up to reflect what was requested means that the caller won't get the results they wanted. ` Signed-off-by: Mark Brown broo

Re: [ 35/73] ASoC: dapm: Fix locking during codec shutdown

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 01:11:01PM -0300, Herton Ronaldo Krzesinski wrote: Hi, this doesn't build on 3.2: linux-stable/sound/soc/soc-dapm.c: In function 'soc_dapm_shutdown_codec': linux-stable/sound/soc/soc-dapm.c:2982:18: error: 'struct snd_soc_card' has no member named 'dapm_mutex'

Re: [PATCH] regmap: Fix regcache-rbtree sync

2013-03-13 Thread Mark Brown
On Wed, Mar 13, 2013 at 04:38:33PM +0100, Lars-Peter Clausen wrote: The last register block, which falls into the specified range, is not handled correctly. The formula which calculates the number of register which should be Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 2/2] ARM: clk: imx35 sound admux_gate bugfix

2013-03-27 Thread Mark Brown
On Wed, Mar 27, 2013 at 12:57:00PM +0100, Philipp Zabel wrote: Am Mittwoch, den 27.03.2013, 12:22 +0100 schrieb Markus Pargmann: imx-ssi needs admux_gate clock to work on imx35. This patch registers this clock and enables it in the imx-ssi driver. I have no idea what the admux_gate really

Re: [PATCH 2/2] ARM: clk: imx35 sound admux_gate bugfix

2013-03-27 Thread Mark Brown
On Wed, Mar 27, 2013 at 04:04:20PM +0100, Markus Pargmann wrote: On Wed, Mar 27, 2013 at 12:37:00PM +, Mark Brown wrote: This is a patch to the ASoC driver? I just ignored it since it said it was an ARM patch... Anyway, what I'd expect should be happening here is that the clock API

[PATCH] mfd: wm8994: Add support for WM1811 rev E

2012-11-22 Thread Mark Brown
This is supported identically to the previous revisions. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- drivers/mfd/wm8994-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c index

Re: [PATCH 3.7] spi/bcm63xx: fix transfer bits_per_words check

2012-11-24 Thread Mark Brown
On Sat, Nov 24, 2012 at 02:44:50PM +0100, Jonas Gorski wrote: Transfers often do not have bits_per_words set, so use the spi device's bits_per_words in this case. This fixes the driver rejecting valid transfers e.g. generated by spi_write() or spi_read(). This is now done by the SPI core,

Re: [PATCH 3.7] spi/bcm63xx: fix transfer bits_per_words check

2012-11-24 Thread Mark Brown
On Sat, Nov 24, 2012 at 06:53:10PM +0100, Jonas Gorski wrote: On 24 November 2012 18:28, Mark Brown This is now done by the SPI core, there's no need for individual drivers to do this. So that will go to stable kernels, too? No, I hadn't sent it there. I'd really expect that anyone using

Re: [PATCH 3.7] spi/bcm63xx: fix transfer bits_per_words check

2012-11-26 Thread Mark Brown
On Mon, Nov 26, 2012 at 02:11:20PM +0100, Florian Fainelli wrote: On Saturday 24 November 2012 19:19:34 Jonas Gorski wrote: Well, I noticed this particular problem on a 3.6 kernel (3.6.7 to be exact), so by that definition at least one noticed, unless I don't count as anyone ;-). So, how

Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values

2012-12-15 Thread Mark Brown
On Fri, Dec 14, 2012 at 05:40:30PM +0200, Felipe Balbi wrote: No no, I mean that before you SoB you should have a: Cc: stable@vger.kernel.org # v3.x v3.y ... It's perfectly OK to omit this unless there's an awareness that the backport won't work on some kernels. signature.asc Description:

Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values

2012-12-15 Thread Mark Brown
On Thu, Dec 13, 2012 at 10:13:00AM +0100, Paolo Pisati wrote: Signed-off-by: Paolo Pisati paolo.pis...@canonical.com Tested-by: Robert Nelson robertcnel...@gmail.com Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values

2012-12-17 Thread Mark Brown
On Sat, Dec 15, 2012 at 04:57:38PM +0200, Felipe Balbi wrote: On Sat, Dec 15, 2012 at 11:15:20PM +0900, Mark Brown wrote: It's perfectly OK to omit this unless there's an awareness that the backport won't work on some kernels. that's not what Greg says, but fair enough. Won't discuss

Re: [PATCH] regulator: core: if voltage scaling fails, restore original voltage values

2012-12-17 Thread Mark Brown
On Mon, Dec 17, 2012 at 05:18:48PM +0200, Felipe Balbi wrote: On Mon, Dec 17, 2012 at 02:15:36PM +, Mark Brown wrote: Uh, no. Think about this for a minute - we want bug fixes backporting, we don't want to be putting process blockers in the way of that especially not in the cases

[PATCH] ARM: S3C64XX: Fix up IRQ mapping for balblair on Cragganmore

2013-01-13 Thread Mark Brown
From: Dimitris Papastamos d...@opensource.wolfsonmicro.com We are using S3C_EINT(4) instead of S3C_EINT(5). Signed-off-by: Dimitris Papastamos d...@opensource.wolfsonmicro.com Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- arch/arm/mach-s3c64xx/mach

Re: FAILED: patch [PATCH] regmap: debugfs: Avoid overflows for very small reads failed to apply to 3.7-stable tree

2013-01-13 Thread Mark Brown
On Sun, Jan 13, 2013 at 03:46:41PM +, Ben Hutchings wrote: For 3.2 I did: s/map-debugfs_tot_len/tot_len/ This should work for 3.4 and 3.7 as well. Yup, that's a good fix. signature.asc Description: Digital signature

Re: [PATCH] regulators: max8998: fix incorrect min_uV value for ldo10

2013-01-26 Thread Mark Brown
On Fri, Jan 25, 2013 at 09:25:40AM +0100, Marek Szyprowski wrote: Correct value for minimal voltage for ldo10 output is 95 uV. This patch fixes the typo introduced by patch adf6178ad5552a7f2f742a8c85343c50 (regulator: max8998: Use uV in voltage_map_desc), what solves broken probe of

Re: Linux 3.2.3

2012-02-03 Thread Mark Brown
On Fri, Feb 03, 2012 at 10:54:59AM -0800, Greg KH wrote: On Fri, Feb 03, 2012 at 10:53:19AM -0800, Greg KH wrote: Yes, the above commit fixes the build for me, thanks, I'll go release 3.2.4 with this build fix in it, thanks Tim for letting me know. Hm, no, I don't think I'll really trust

Re: Linux 3.2.3

2012-02-03 Thread Mark Brown
On Fri, Feb 03, 2012 at 12:11:29PM -0700, Tim Gardner wrote: On 02/03/2012 11:54 AM, Greg KH wrote: Mark, any objection to me just reverting the SOC patch that causes this build failure instead? I think you'll have to revert both WM5100 patches that came in with v3.2.3: Well, we should

[PATCH 3.3] mfd: Test for jack detection when deciding if wm8994 should suspend

2012-02-20 Thread Mark Brown
The jack detection on WM1811 is often required during system suspend, add it as another check when deciding if we should suspend. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- Samuel, could you please add this to your for-linus branch? It's been

Re: Patch mfd: Test for jack detection when deciding if wm8994 should suspend has been added to the 3.2-stable tree

2012-03-29 Thread Mark Brown
On Wed, Mar 28, 2012 at 03:55:42PM -0700, Greg KH wrote: It was dropped, as it broke the build. If this is to go into 3.2, can someone please provide a backport for it? Yeah, sorry - this is another one where I'd been sitting on it for long enough that I misremembered which kernel version the

Re: [PATCH] ASoC: tegra: correct playback_dma_data setup

2013-07-21 Thread Mark Brown
On Sun, Jul 21, 2013 at 10:34:09AM +0800, Richard Zhao wrote: The errors were caused by copy/paste mistake in below commit since v3.10: 3489d50 ASoC: tegra: Use common DAI DMA data struct Applied, thanks. signature.asc Description: Digital signature

Re: WTF: patch [PATCH] ASoC: wm8962: Remove remaining direct register cache accesses was seriously submitted to be applied to the 3.10-stable tree?

2013-07-29 Thread Mark Brown
On Mon, Jul 22, 2013 at 12:58:12PM -0700, gre...@linuxfoundation.org wrote: The patch below was submitted to be applied to the 3.10-stable tree. Stuff like this is very easy to miss when it comes in the middle of the general spam about stable kernels; the review mails do get rather vouluminous

Re: WTF: patch [PATCH] ASoC: wm8962: Remove remaining direct register cache accesses was seriously submitted to be applied to the 3.10-stable tree?

2013-07-29 Thread Mark Brown
On Mon, Jul 29, 2013 at 11:31:12AM -0700, Greg KH wrote: On Mon, Jul 29, 2013 at 07:21:10PM +0100, Mark Brown wrote: Stuff like this is very easy to miss when it comes in the middle of the general spam about stable kernels; the review mails do get rather vouluminous and unfortunately

Re: [PATCH] ASoC: tegra: fix Tegra30 I2S capture parameter setup

2013-08-15 Thread Mark Brown
On Wed, Aug 14, 2013 at 02:24:16PM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com The Tegra30 I2S driver was writing the AHUB interface parameters to the playback path register rather than the capture path register. This caused the capture parameters not to be

Re: [PATCH 9/9] ALSA: compress: use rate values for passing sampling rates

2013-08-27 Thread Mark Brown
On Tue, Aug 27, 2013 at 12:10:39PM +0530, Vinod Koul wrote: Clarify that its better to use the rate values like 8000, 12000, 11025, 44100, 48000 etc to send sampling rate values to driver. The changes kernel ABI but no drivers exist upstream so okay to change now Tinycompress to be fixed as

[PATCH] clk: wm831x: Initialise wm831x pointer on init

2013-08-29 Thread Mark Brown
From: Mark Brown broo...@linaro.org Otherwise any attempt to interact with the hardware will crash. This is what happens when drivers get written blind. Signed-off-by: Mark Brown broo...@linaro.org Cc: stable@vger.kernel.org --- drivers/clk/clk-wm831x.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH 1/5] ASoC: dapm: Add snd_soc_dapm_switch to the power up/down sequence table

2013-06-14 Thread Mark Brown
On Fri, Jun 14, 2013 at 01:16:50PM +0200, Lars-Peter Clausen wrote: The power up/down sequence order for DAPM switch widgets is not explicitly initialized, causing them to be run always as the first widget type for both power up and down. Move it to the same position in the sequence as other

Re: [PATCH] regmap: cache: bail in regmap_async_complete() for bus-less maps

2013-07-04 Thread Mark Brown
On Thu, Jul 04, 2013 at 01:11:03PM +0200, Daniel Mack wrote: Commit f8bd822cb (regmap: cache: Factor out block sync) made regcache_rbtree_sync() call regmap_async_complete(), which in turn does not check for map-bus before dereferencing it. Applied, thanks. signature.asc Description: Digital

Re: [Ksummit-2013-discuss] KS Topic request: Handling the Stable kernel, let's dump the cc: stable tag

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 03:45:17PM -0400, Steven Rostedt wrote: Have Greg, or whoever, change his script to not take commits marked for stable, but instead, forward the commit to the maintainer. Or as it already does today, to everyone on the Cc, and -by: tags. Change the script from being

Re: [Ksummit-2013-discuss] KS Topic request: Handling the Stable kernel, let's dump the cc: stable tag

2013-07-16 Thread Mark Brown
On Tue, Jul 16, 2013 at 03:00:29AM +0100, Ben Hutchings wrote: On Mon, 2013-07-15 at 23:27 +0400, James Bottomley wrote: The problem, as Jiří Kosina put is succinctly is that the distributions are finding stable less useful because it contains to much stuff they'd classify as not stable

Re: [Ksummit-2013-discuss] When to push bug fixes to mainline

2013-07-16 Thread Mark Brown
On Tue, Jul 16, 2013 at 06:40:39PM +0200, Takashi Iwai wrote: Maybe some QA period before the release might help, but who would care? (Especially under the situation where everybody has own x.y stable tree?) Hopefully people tracking the upstream stable trees would be throwing any

Re: [PATCH] ASoC: davinci: fix sample rotation

2013-05-21 Thread Mark Brown
On Thu, May 16, 2013 at 03:25:01PM +0200, Daniel Mack wrote: McASP serial audio engine needs different rotation values on TX and RX channels. Commit dde109fb462 (ASoC: McASP: Fix data rotation for playback. Enables 24bit audio playback) changed the calculation to fix the playback format, but

Re: [PATCH 3.9-stable] regulator: mc13892: Fix MC13892_SWITCHERS0_SWxHI bit in set_voltage_sel

2013-05-22 Thread Mark Brown
On Wed, May 22, 2013 at 01:55:32PM +0900, Jonghwan Choi wrote: This patch looks like it should be in the 3.9-stable tree, should we apply it? It doesn't seem particularly urgent (it wasn't new code) and we've not seen any feedback from anyone who actually uses the device. signature.asc

[PATCH] mfd: wm5102: Update register patch for latest evaluation

2012-10-08 Thread Mark Brown
Latest evaluation of the device has provided some revisions to the configuration. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- Would it be OK to merge this via ASoC? It'd help with bisection. drivers/mfd/wm5102-tables.c | 519

Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration

2012-08-07 Thread Mark Brown
On Tue, Aug 07, 2012 at 05:24:58PM +0300, Peter Ujfalusi wrote: The check for the mux_signal callback was wrong which prevents us to configure the 6pin port's FSR/CLKR signal mux. Is this different to the patch I already applied? -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/7] mfd: max8925: Move _IO resources out of ioport_ioresource

2012-08-07 Thread Mark Brown
we're not really using IO memory at all fix this by defining our own root resource outside the normal tree and make that the parent of all IO resources. This also ensures we won't conflict with read IO ports if we ever run on a platform which happens to use them. Signed-off-by: Mark Brown broo

[PATCH 2/7] mfd: 88pm860x: Move _IO resources out of ioport_ioresource

2012-08-07 Thread Mark Brown
we're not really using IO memory at all fix this by defining our own root resource outside the normal tree and make that the parent of all IO resources. This also ensures we won't conflict with read IO ports if we ever run on a platform which happens to use them. Signed-off-by: Mark Brown broo

Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration

2012-08-07 Thread Mark Brown
On Tue, Aug 07, 2012 at 09:23:07PM +0200, Ujfalusi, Peter wrote: On Tue, Aug 7, 2012 at 5:57 PM, Mark Brown Is this different to the patch I already applied? It is exactly the same patch. I'd like 3.4 and 3.5 kernels to have this fix as well. I already applied it and obviously fixed up

Re: [PATCH] ASoC: omap-mcbsp: Fix 6pin mux configuration

2012-08-08 Thread Mark Brown
On Wed, Aug 08, 2012 at 12:37:22PM +0300, Peter Ujfalusi wrote: I need to wait for the next -rc which have this patch. Take the patch from mainline and send it to stable@vger.kernel.org? You don't need to send it to them at all - the default process is that they'll notice any commits that

Re: [PATCH 1/7] mfd: max8925: Move _IO resources out of ioport_ioresource

2012-08-08 Thread Mark Brown
On Tue, Aug 07, 2012 at 07:46:52PM +, Arnd Bergmann wrote: Thanks a lot for following through with this series! I would have preferred to have the second step in stable as Russell suggested, but since you did all the work, I'm not going to complain about it ;-) Yeah, it'd be nicer to do

Re: [ 017/109] ASoC: dapm: Fix locking during codec shutdown

2012-08-09 Thread Mark Brown
On Wed, Aug 08, 2012 at 06:13:12PM -0300, Herton Ronaldo Krzesinski wrote: Always delete irrelevant text from your quotes. Doesn't build on 3.4: linux-stable/sound/soc/soc-dapm.c: In function 'soc_dapm_shutdown_codec': linux-stable/sound/soc/soc-dapm.c:3226:18: error: 'struct snd_soc_card'

[PATCH] ASoC: wm2000: Correct register size

2012-09-26 Thread Mark Brown
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Cc: stable@vger.kernel.org --- sound/soc/codecs/wm2000.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm2000.c b/sound/soc/codecs/wm2000.c index b723e91..683dc43 100644 --- a/sound/soc/codecs

Re: [rtc-linux] Re: [REGRESSION] rtc/interface.c: kills suspend-to-ram

2012-04-16 Thread Mark Brown
On Mon, Apr 16, 2012 at 09:55:49AM -0400, Mark Lord wrote: Can somebody show me how to identify the commit from the code? I know which lines got changed, but don't know how to find the corresponding commits in -git. git annotate is usually pretty helpful for this. -- To unsubscribe from this

Re: [PATCH 1/2] spi: orion: fix incorrect handling of cell-index DT property

2014-07-28 Thread Mark Brown
On Sun, Jul 27, 2014 at 11:53:19PM +0200, Thomas Petazzoni wrote: In commit f814f9ac5a81 (spi/orion: add device tree binding), Device Tree support was added to the spi-orion driver. However, this commit reads the cell-index property, without taking into account the fact that DT properties are

Re: [PATCH] spi: dw-pci: fix bug when regs left uninitialized

2014-08-27 Thread Mark Brown
On Wed, Aug 27, 2014 at 04:21:12PM +0300, Andy Shevchenko wrote: The commit 04f421e7 spi: dw: use managed resources changes drivers to use managed functions, but seems wasn't properly tested in PCI case. The regs field of struct dw_spi left uninitialized. Thus, kernel crashes when tries to

Re: [Fixes: PATCH v1] spi: dw: fix kernel crash due to NULL pointer dereference

2014-08-27 Thread Mark Brown
On Wed, Aug 27, 2014 at 07:26:08PM +0300, Andy Shevchenko wrote: The obvious fix after the commit d9c73bb8a3a5 spi: dw: add support for gpio controlled chip select. This patch fixes the issue by using locally defined temporary variable. Applied, thanks. signature.asc Description: Digital

Re: [Fixes: PATCH v1] spi: dw: fix kernel crash due to NULL pointer dereference

2014-08-27 Thread Mark Brown
On Wed, Aug 27, 2014 at 07:26:08PM +0300, Andy Shevchenko wrote: The obvious fix after the commit d9c73bb8a3a5 spi: dw: add support for gpio controlled chip select. This patch fixes the issue by using locally defined temporary variable. Signed-off-by: Andy Shevchenko

Re: [PATCH] spi: dw-mid: don't leak memory on exit

2014-08-28 Thread Mark Brown
On Thu, Aug 28, 2014 at 11:53:17AM +0300, Andy Shevchenko wrote: When built with DMA support the memory for an internal structure is allocated but not freed. Converting to devm_kzalloc solves the issue. Fixes: 7063c0d942a1 (spi/dw_spi: add DMA support) Signed-off-by: Andy Shevchenko

Re: [PATCH] regulator: core bugfix: Use normal enable for always_on regulators

2014-02-17 Thread Mark Brown
On Sun, Feb 16, 2014 at 08:00:56PM +0100, Markus Pargmann wrote: Please use more standard subject lines, don't do things like core bugfix, just write a normal changelog. +static int _regulator_do_enable_no_delay(struct regulator_dev *rdev) +{ + int ret; + + if (rdev-ena_pin) { +

Re: [PATCH] regulator: core bugfix: Use normal enable for always_on regulators

2014-02-18 Thread Mark Brown
On Tue, Feb 18, 2014 at 10:40:07PM +0100, Markus Pargmann wrote: On Tue, Feb 18, 2014 at 09:14:20AM +0900, Mark Brown wrote: I don't understand this. Why is this called _no_delay() and why don't we want to delay when applying constraints? We don't want to ever be in a position where we

Re: [PATCH 3.13 00/40] 3.13.4-stable review

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 05:16:22PM -0700, Shuah Khan wrote: On Intel systems, there are no dmesg regressions: emerg, crit, alert, err are clean. No regressions in warn. On AMD systems, the following new error messages - suspect is to drivers/regulator/core.c - patch 3.13.4 - amd:

Re: [PATCH 3.13 00/40] 3.13.4-stable review

2014-02-19 Thread Mark Brown
On Wed, Feb 19, 2014 at 06:20:13PM -0700, Shuah Khan wrote: Right. I think this message should be a warning instead of an error. Error is too alarming, unless there is a good reason for it to be an error. Patches welcome... signature.asc Description: Digital signature

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote: --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev *rdev) trace_regulator_disable_complete(rdev_get_name(rdev)); -

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 02:01:08PM +0100, Markus Pargmann wrote: I am using this function from _regulator_force_disable(), which calls _notifier_call_chain() with one additional flag REGULATOR_EVENT_FORCE_DISABLE. To prevent calling _notifier_call_chain() twice for the force_disable case, I

Re: [PATCH 3.13 00/40] 3.13.4-stable review

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 06:40:34AM -0700, Shuah Khan wrote: On 02/19/2014 07:34 PM, Mark Brown wrote: Patches welcome... ok I will send one soon then :) Thanks - if you forget I probably will get round to it but it's easier if you fix. signature.asc Description: Digital signature

[PATCH] ASoC: da732x: Mark DC offset control registers volatile

2014-02-23 Thread Mark Brown
From: Mark Brown broo...@linaro.org The driver reads from the DC offset control registers during callibration but since the registers are marked as volatile and there is a register cache the values will not be read from the hardware after the first reading rendering the callibration ineffective

Re: [PATCH] ASoC: da732x: Mark DC offset control registers volatile

2014-02-24 Thread Mark Brown
On Mon, Feb 24, 2014 at 11:31:25AM +, Opensource [Adam Thomson] wrote: On Mon, 24 Feb 2014 03:01:37 +, Mark Brown wrote: but since the registers are marked as volatile and there is a register Guessing that should read 'not marked as volatile'. Yes. Having looked over the driver

Re: [PATCH] ASoC: da732x: Mark DC offset control registers volatile

2014-02-24 Thread Mark Brown
On Mon, Feb 24, 2014 at 01:57:53PM +, Opensource [Adam Thomson] wrote: anyway. I'd be tempted to keep it simple and just make those registers volatile, then you know it will work as expected, at least for the time being until a That breaks suspend and resume without further work - for

Re: [PATCH 1/3] spi: bitbang: fix shift for getmosi

2014-03-12 Thread Mark Brown
On Wed, Mar 12, 2014 at 04:53:35PM +0100, Michael Grzeschik wrote: The driver needs to shift the word bit after reading the mosi bit. Otherwise the return word will have an Off-by-one bit value. This isn't exactly new code... do we understand why nobody has noticed this before? @@ -61,10

Re: [PATCH 1/3] spi: bitbang: fix shift for getmosi

2014-03-12 Thread Mark Brown
On Wed, Mar 12, 2014 at 10:23:34PM +0100, Gerhard Sittig wrote: On Wed, Mar 12, 2014 at 16:20 +0100, Michael Grzeschik wrote: Cc: stable@vger.kernel.org Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Is the Cc: to stable@ appropriate without Fixes: or a version that's

[PATCH] ASoC: samsung: Ensure DMA data is initialised for secondary DAI

2013-12-05 Thread Mark Brown
From: Mark Brown broo...@linaro.org While testing the upcoming dmaengine conversion for the driver Padma noticed that the DMA data for the secondard DAI is not being correctly initialised and provided a fix on top of the conversion. Also do this fix for mainline. Reported-by: Padmavathi Venna

Re: ipv6: fix headroom calculation in udp6_ufo_fragment

2013-12-13 Thread Mark Brown
On Fri, Dec 13, 2013 at 01:01:59PM +, Mark Hambleton wrote: Following a recent commit to LTS and upstream I see the following warning emitted on an ARM32 build: That's 024abeeced731 in LTS and 0e033e04c2678 upstream (ipv6: fix headroom calculation in udp6_ufo_fragment). signature.asc

Re: ipv6: fix headroom calculation in udp6_ufo_fragment

2013-12-13 Thread Mark Brown
On Fri, Dec 13, 2013 at 02:34:53PM +0100, Hannes Frederic Sowa wrote: Sorry, I don't know which version the LTS kernel is. Upstream does not use sk_buff_data_t for mac_header any more. This is with v3.10. signature.asc Description: Digital signature

Possible arm64 patches for stable

2013-12-20 Thread Mark Brown
Hi, While reading the kernel logs for arm64 (as one does) I noticed a few patches that seemed like candidates for either LTS or LTSI. I've also had a couple of others mentioned via other routes. What do you think of these? 4ecf7ccb1973 arm64: spinlock: retry trylock operation if strex fails

Re: Possible arm64 patches for stable

2014-01-07 Thread Mark Brown
On Mon, Jan 06, 2014 at 02:39:31PM +, Luis Henriques wrote: On Fri, Dec 20, 2013 at 05:28:27PM +, Mark Brown wrote: f0dd718090ae arm64: Remove unused cpu_name ascii in arch/arm64/mm/proc.S This seems to be the wrong SHA1. I've picked f3a1d7d assuming that's what you meant. Yup

Re: [PATCH] codecs: mc13783: add spi errate fix

2013-09-09 Thread Mark Brown
On Mon, Sep 09, 2013 at 04:12:36PM +0200, Steffen Trumtrar wrote: The MC13783 Chip Errata, Rev. 4 says, that depending on SPI clock and main audio clock speed, the Audio Codec or Stereo DAC do sometimes not start when programmed to do so. This is due to an internal clock timing issue related

Re: [PATCH] codecs: mc13783: add spi errate fix

2013-09-09 Thread Mark Brown
On Mon, Sep 09, 2013 at 03:57:30PM +0100, Mark Brown wrote: On Mon, Sep 09, 2013 at 04:12:36PM +0200, Steffen Trumtrar wrote: The MC13783 Chip Errata, Rev. 4 says, that depending on SPI clock and main audio clock speed, the Audio Codec or Stereo DAC do sometimes not start when programmed

Re: [PATCH v2] codecs: mc13783: add spi errata fix

2013-09-10 Thread Mark Brown
On Mon, Sep 09, 2013 at 06:09:12PM +0200, Steffen Trumtrar wrote: The MC13783 Chip Errata, Rev. 4 says, that depending on SPI clock and main audio clock speed, the Audio Codec or Stereo DAC do sometimes not start when programmed to do so. This is due to an internal clock timing issue related

Re: [PATCH 3.13 110/149] ASoC: pcm: free path list before exiting from error conditions

2014-03-22 Thread Mark Brown
On Sat, Mar 22, 2014 at 03:53:08PM +, Ben Hutchings wrote: On Thu, 2014-03-20 at 17:04 -0700, Greg Kroah-Hartman wrote: If you spot something on a stable patch that applies upstream (as opposed to being stable process or to do with the older kernel which are the most common things with these

Re: [PATCH 3.10 56/85] ASoC: pcm: free path list before exiting from error conditions

2014-03-22 Thread Mark Brown
On Thu, Mar 20, 2014 at 05:09:59PM -0700, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. Ben noticed an issue with this when checking for v3.13, I've dropped from upstream. signature.asc Description: Digital signature

Re: e4ad1accb28d0ed8cea6f12395d58686ad344ca7 is broken

2014-04-05 Thread Mark Brown
On Sat, Apr 05, 2014 at 10:06:04PM +0100, Russell King - ARM Linux wrote: The commit: ASoC: pcm: free path list before exiting from error conditions is broken and must not be applied to stable kernels, and needs reverting for 3.14. Yes, Ben Hutchings already reported this and a revert (with

Backport cpuidle: Check the result of cpuidle_get_driver() against NULL

2014-04-10 Thread Mark Brown
I'd like to propose 34e02c05bb1e (cpuidle: Check the result of cpuidle_get_driver() against NULL) for backporting to -stable. This is a small, non-invasive patch readily reviewed by inspection which fixes a crash if there's no cpuidle driver. We've run into the issue it fixes when testing on

Re: [PATCH] ASoC: dapm: Fix widget double free with auto-disable DAPM kcontrol

2014-04-18 Thread Mark Brown
On Tue, Apr 15, 2014 at 04:58:09PM +0300, Jarkko Nikula wrote: Commit 9e1fda4ae158 (ASoC: dapm: Implement mixer input auto-disable) is trying to free the widget it allocated by snd_soc_dapm_new_control() call in dapm_kcontrol_data_alloc() by adding kfree(data-widget) to

Re: [PATCH] ASoC: max98090: Fix missing free_irq

2014-06-19 Thread Mark Brown
On Thu, Jun 19, 2014 at 09:32:05AM +0300, Jarkko Nikula wrote: max98090.c doesn't free the threaded interrupt it requests. This causes an oops when doing cat /proc/interrupts after snd-soc-max98090.ko is unloaded. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 3.10 005/103] irqchip: Gic: Support forced affinity setting

2014-06-23 Thread Mark Brown
On Thu, Jun 05, 2014 at 11:05:24AM -0700, Greg Kroah-Hartman wrote: On Thu, Jun 05, 2014 at 05:05:00PM +0100, Mark Rutland wrote: This patch alone has the possiblity of breaking CPU hotplug on arm and arm64 (specifically it breaks hot unplugging CPU0 where interrupts may be left targetting

Re: [PATCH 1/2] regulators: TPS65218: Add the missing of_node assignment in probe

2014-06-24 Thread Mark Brown
On Wed, Jun 18, 2014 at 10:17:47AM -0500, Felipe Balbi wrote: From: Keerthy j-keer...@ti.com Add the missing of_node assignment in probe. Applied both, thanks. Please use subject lines reflecting the style for the subsystem. signature.asc Description: Digital signature

Re: [PATCH v2] regulator: s2mpa01: Use correct register for buck1 ramp delay

2014-05-26 Thread Mark Brown
On Mon, May 26, 2014 at 10:26:46AM +0200, Krzysztof Kozlowski wrote: Fix the register for ramp delay of buck1 regulator. Buck1 and buck6 share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2. Applied, thanks. signature.asc Description: Digital signature

Possible stable fix for decompressor speed

2014-01-28 Thread Mark Brown
The changes in patch 1431574a1c4c (lib/decompressors: fix no limit output buffer length) avoid doing decompression a byte at a time when decompressing into high physical addresses using a small, well isolated change. The patch can give a very noticable improvement in kernel boot times on affected

Re: [PATCH] ASoC: fsl: fix pm support of machine drivers

2014-02-10 Thread Mark Brown
On Sat, Feb 08, 2014 at 01:20:35PM +0800, Shawn Guo wrote: The commit 1abe729 (ASoC: fsl: Add missing pm to current machine drivers) enables pm support for a few IMX machine drivers. But it does Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/4] Input: wm97xx: Drop out of range inputs

2013-03-08 Thread Mark Brown
) + || abs_y[1] (data.y 0xfff)) { + dev_dbg(wm-dev, Measurement out of range, dropping it\n); + rc = RC_AGAIN; + goto out; The change is good but not a fan of the coding style here. Otherwise Acked-by: Mark Brown broo

Re: [PATCH 2/4] Input: wm9712: Fix returncode for wrong sample

2013-03-08 Thread Mark Brown
On Fri, Mar 08, 2013 at 05:15:07PM +0100, Markus Pargmann wrote: Instead of interpreting a wrong measurement as pen up, we should try to read again. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: [PATCH 3/4] Input: wm9712: Fix wrong pen up readings

2013-03-08 Thread Mark Brown
the sort of issue that might mean this is needed and if it improves performance in your testing: Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com signature.asc Description: Digital signature

Re: Potential cpufreq backports for v3.10 LTS

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 12:48:44PM +0100, Mark Brown wrote: Hi, The power management team at Linaro has had a look at the cpufreq updates since the v3.10 LTS and identified a few patches that look like they should be in there. The most recent of these is from v3.12 so they won't apply

Re: Potential cpufreq backports for v3.10 LTS

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 09:46:43AM -0700, Greg Kroah-Hartman wrote: On Tue, Oct 07, 2014 at 12:48:44PM +0100, Mark Brown wrote: The power management team at Linaro has had a look at the cpufreq updates since the v3.10 LTS and identified a few patches that look like they should

Re: Patch cpufreq: serialize calls to __cpufreq_governor() has been added to the 3.10-stable tree

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 01:02:29PM -0700, gre...@linuxfoundation.org wrote: This is a note to let you know that I've just added the patch titled cpufreq: serialize calls to __cpufreq_governor() Sorry, I got confused in my earlier mail: it's this one that got reverted in mainline, the

Re: Potential cpufreq backports for v3.10 LTS

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 01:04:58PM -0700, Greg Kroah-Hartman wrote: On Tue, Oct 07, 2014 at 06:08:00PM +0100, Mark Brown wrote: - 59a6342203a7a cpufreq: Fix governor start/stop race condition This looks like a straight race condition fix. That is not a commit id in Linus's tree

Re: Potential cpufreq backports for v3.10 LTS

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 02:58:07PM -0700, Greg Kroah-Hartman wrote: On Tue, Oct 07, 2014 at 09:45:05PM +0100, Mark Brown wrote: Actually I thinkoed here, as I said in reply to the stable mail the problematic patch was 19c763031acb8 cpufreq: serialize calls to __cpufreq_governor() which

Re: Potential cpufreq backports for v3.10 LTS

2014-10-07 Thread Mark Brown
On Wed, Oct 08, 2014 at 12:36:59AM +0300, Stratos Karafotis wrote: For your information, commits: - 61c63e5ed3b9 cpufreq: Remove unused APERF/MPERF support - cffe4e0e7413 cpufreq: Remove unused function __cpufreq_driver_getavg() remove unused code (no other functional changes) as a result

Re: Patch cpufreq: serialize calls to __cpufreq_governor() has been added to the 3.10-stable tree

2014-10-07 Thread Mark Brown
On Tue, Oct 07, 2014 at 02:59:11PM -0700, Greg KH wrote: Kernel development is done in public, I hate private emails... Yeah, me too. I'm trying to encourage people not to do this unless they've got a really good reason (marketing departments tend to get really upset when you announce products

Re: [PATCH] ASoC: adau1761: Fix input PGA volume

2014-10-22 Thread Mark Brown
On Wed, Oct 22, 2014 at 10:51:18AM +0200, Lars-Peter Clausen wrote: For the input PGA to work correctly the ALC clock needs to be active. Otherwise volume changes are not applied. Applied, thanks. signature.asc Description: Digital signature

Potential USB PHY error handling fix for stable

2014-10-29 Thread Mark Brown
Hi, One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While it's error handling that's being fixed this does seem like a reasonable candidate, it's a very simple fix and the behaviour without

Re: Potential USB PHY error handling fix for stable

2014-10-29 Thread Mark Brown
On Wed, Oct 29, 2014 at 03:30:18PM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 29, 2014 at 10:10:12PM +, Mark Brown wrote: One of the Linaro stable kernel users has suggested 2c4e3dbf63b39d (usb: phy: return -ENODEV on failure of try_module_get) as a fix for the stable kernel. While

Re: [PATCH] regulator: max77693: Fix use of uninitialized regulator config

2014-11-03 Thread Mark Brown
On Mon, Nov 03, 2014 at 03:07:05PM +0100, Krzysztof Kozlowski wrote: Driver allocated on stack struct regulator_config but didn't initialize it fully. Few fields (driver_data, ena_gpio) were left untouched. This lead to using random ena_gpio values as GPIOs for max77693 regulators. Applied,

Re: [PATCHv2] ASoC: cs42l51: re-hook of_match_table pointer

2014-11-12 Thread Mark Brown
On Wed, Nov 12, 2014 at 03:40:44PM +0100, Thomas Petazzoni wrote: In commit a1253ef6d3fa (ASoC: cs42l51: split i2c from codec driver), the I2C part of the CS42L51 was moved to a separate file, but the Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/6] ASoC: sigmadsp: Refuse to load firmware files with a non-supported version

2014-11-20 Thread Mark Brown
On Wed, Nov 19, 2014 at 06:29:02PM +0100, Lars-Peter Clausen wrote: Make sure to check the version field of the firmware header to make sure to not accidentally try to parse a firmware file with a different layout. Trying to do so can result in loading invalid firmware code to the device.

Re: [PATCH 1/3] ARM: pxa: add regulator_has_full_constraints to corgi board file

2014-12-04 Thread Mark Brown
On Thu, Dec 04, 2014 at 09:41:45PM +0100, Robert Jarzmik wrote: Dmitry Eremin-Solenikov dbarysh...@gmail.com writes: + regulator_has_full_constraints(); Added Mark for review, as I was thinking regulator_has_full_constraints() was to be used to disable unused regulators, a bit like in

Re: [PATCH] regulator: s2mps11: Fix dwmmc failure on Gear 2

2014-12-11 Thread Mark Brown
On Thu, Dec 11, 2014 at 01:39:11PM +0100, Krzysztof Kozlowski wrote: Invalid buck4 configuration in S2MPS14 regulators caused boot failure on Gear 2 (dwmmc_exynos): What is invalid about the configuration and how is this change intended to fix it? [3.569137] EXT4-fs (mmcblk0p15): mounted

  1   2   3   >