Re: [PATCH v10 1/3] Initial support for LuaJIT scripting

2017-08-07 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:50:54PM +0300, Victor Krapivensky wrote: > * .gitignore: Add luajit_lib.h. > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_shared.h, ffi.h. > (luajit_lib.h): Auto-generate from luajit_lib.lua. > * configure.ac: Add new --with-luajit confi

Re: [PATCH v10 2/3] Introduce upoken function and expose it to LuaJIT scripts

2017-08-07 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:50:56PM +0300, Victor Krapivensky wrote: > This patch implies that we have process_vm_writev if and only if we have > process_vm_readv, and that they are either both supported or both > unsupported. > > * defs.h: Add declaration for upoken. > * luajit.h (func_upoke): New

Re: [PATCH v6 4/9] Improve fd filtering

2017-08-07 Thread Nikolay Marchuk
On 07.08.2017 11:52, Eugene Syromiatnikov wrote: > What makes incredibly difficult to review this patch is the abundance of > all these syscall sets. I think, making return code of > match_fd_common/pathtrace_match_state tri-state (positive match, > negative match, no match) instead of boolean cou

Re: [PATCH 1/3] Move err/mem subroutines to separate files

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:34AM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov "virtuozzo" > > In order to allow usage of utility functions by other binaries > included in the strace package (like the upcoming asinfo utility), > these functions should be moved to separate files.

Re: [PATCH 2/3] Move shorthand notations to separate file

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:35AM +0300, Edgar Kaziakhmedov wrote: > In order to allow usage shorthand notations of defines in sysent.h file "usage of shorthand notations of definitions from sysent.h used in syscallent.h files" > by other binaries in the strace package these defines should be mov

Re: [PATCH 2/2] asinfo: Introduce static query tool asinfo

2017-08-07 Thread Eugene Syromiatnikov
On Tue, Aug 01, 2017 at 01:13:56AM +0300, Edgar Kaziakhmedov wrote: > On Mon, 31 Jul 2017 06:19:23 +0200 > Eugene Syromiatnikov wrote: > > > +enum impl_type > > > +al_sck_syscall(struct arch_service *m, unsigned index) > > > +{ > > > + struct arch_descriptor *elem = al_get(m, index); > > > + int i

Re: [PATCH 1/3] Move err/mem subroutines to separate files

2017-08-07 Thread Dmitry V. Levin
On Sat, Aug 05, 2017 at 04:57:34AM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov virtuzzo.com? Really? ;) > In order to allow usage of utility functions by other binaries > included in the strace package (like the upcoming asinfo utility), > these functions should be moved to separ

[PATCH] netlink.c: fix indentation

2017-08-07 Thread JingPiao Chen
* netlink.c (print_cookie): Fix indentation. --- netlink.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/netlink.c b/netlink.c index 947e52df..f3a7cf9a 100644 --- a/netlink.c +++ b/netlink.c @@ -287,10 +287,8 @@ print_nlmsghdr(struct tcb *tcp, } static bool -print_c

Re: [PATCH 2/3] Move shorthand notations to separate file

2017-08-07 Thread Dmitry V. Levin
On Sat, Aug 05, 2017 at 04:57:35AM +0300, Edgar Kaziakhmedov wrote: > In order to allow usage shorthand notations of defines in sysent.h file > by other binaries in the strace package these defines should be moved to > separate file. > > * Makefile.am (strace_SOURCES): Add shorthand_def.h. > * sho

Re: [PATCH 3/3] asinfo: Introduce static query tool asinfo

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:36AM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov "virtuozzo" > > The main purpose of this program is to present all information concluded > at sysent.h files as a query tool. > The asinfo tool has the following architecture: > command dispatcher->arc

Re: [PATCH 2/3] Move shorthand notations to separate file

2017-08-07 Thread Edgar Kaziakhmedov
On Mon, 7 Aug 2017 16:47:46 +0300 "Dmitry V. Levin" wrote: > On Sat, Aug 05, 2017 at 04:57:35AM +0300, Edgar Kaziakhmedov wrote: > > In order to allow usage shorthand notations of defines in sysent.h > > file by other binaries in the strace package these defines should > > be moved to separate fi

Re: [PATCH 1/3] Move err/mem subroutines to separate files

2017-08-07 Thread Edgar Kaziakhmedov
On Mon, 7 Aug 2017 14:48:03 +0300 "Dmitry V. Levin" wrote: > On Sat, Aug 05, 2017 at 04:57:34AM +0300, Edgar Kaziakhmedov wrote: > > From: Edgar Kaziakhmedov > > virtuzzo.com? Really? ;) Oh, these typos... > > > In order to allow usage of utility functions by other binaries > > included in t

Edgar Kaziakhmedov's GSoC status report - #10 of 13

2017-08-07 Thread Edgar Kaziakhmedov
Project: Advanced syscall information tool So, this week I've managed to provide first work version of the asinfo tool(as I thought at least). After that I wrote script to generate list of architectures, bit it needs refining. However, after last review, I've decided to change a little bit my dire