Re: commit dfcd741a5ad170f7fc4ccc0391d3dc92e2d5e3ab is broken

2011-06-21 Thread Dmitry V. Levin
On Tue, Jun 21, 2011 at 03:43:58PM +0200, Denys Vlasenko wrote: > commit dfcd741a5ad170f7fc4ccc0391d3dc92e2d5e3ab > Author: Andi Kleen > Date: Mon Jun 13 22:05:44 2011 + > > Enhance io_submit() decoding > > strace didn't decode important fields in the iocb passed to io_submit. >

Re: [PATCH] simplify expand_tcbtab/alloc_tcb

2011-06-21 Thread Dmitry V. Levin
On Tue, Jun 21, 2011 at 08:21:26PM +0200, Denys Vlasenko wrote: > Hi, > > Sometime ago expand_tcbtab/alloc_tcb were modified > so that they never return failure (they will abort instead). > > This opens up a possibility for further simplifications. > > This patch is a simple one which gets rid o

Re: [PATCH] delete fork_tcb()

2011-06-21 Thread Dmitry V. Levin
On Tue, Jun 21, 2011 at 08:26:07PM +0200, Denys Vlasenko wrote: > Hi, > > Sometime ago expand_tcbtab/alloc_tcb were modified > so that they never return failure (they will abort instead). > > This opens up a possibility for further simplifications. > > This patch gets rid of fork_tcb() function.

Re: [PATCH] remove dead "ifndef CLONE_PTRACE" branch, make setbpt easier to read

2011-06-23 Thread Dmitry V. Levin
On Wed, Jun 22, 2011 at 01:48:19PM +0200, Denys Vlasenko wrote: [...] > --- strace.6/util.c 2011-06-22 00:19:30.268714125 +0200 > +++ strace.7/util.c 2011-06-22 13:32:30.653923439 +0200 > @@ -1494,9 +1494,9 @@ setbpt(struct tcb *tcp) > return 0; > # endif > > - case SYS_cl

Re: [PATCH] Remove TCB_FOLLOWFORK

2011-06-23 Thread Dmitry V. Levin
On Wed, Jun 22, 2011 at 01:42:20PM +0200, Denys Vlasenko wrote: > Hi, > > TCB_FOLLOWFORK flag seems to be unnecessary, because we either follow > all [v]forks/clones or don't follow any, therefore global variable > followfork is an already existing indicator of what we want to do. > > This patch

Re: [PATCH] remove dead "ifndef CLONE_PTRACE" branch, make setbpt easier to read

2011-06-23 Thread Dmitry V. Levin
On Thu, Jun 23, 2011 at 04:07:17PM +0200, Denys Vlasenko wrote: > On Thu, 2011-06-23 at 17:26 +0400, Dmitry V. Levin wrote: > > On Wed, Jun 22, 2011 at 01:48:19PM +0200, Denys Vlasenko wrote: > > [...] > > > --- strace.6/util.c 2011-06-22 00:19:30.268714125 +0200 &

Re: [PATCH] better debug logging

2011-06-24 Thread Dmitry V. Levin
On Fri, Jun 24, 2011 at 04:41:17PM +0200, Denys Vlasenko wrote: > Current debug logging looks like this: > > # ./strace -d -o/dev/null /bin/true [...] > Every stop takes two lines. > > This patch changes it so that every waitpid result is shown on one line. > It also adds debug output on alloc/dr

Re: [PATCH] Check for additional PTRACE options, events, etc.

2011-07-19 Thread Dmitry V. Levin
On Wed, Jul 20, 2011 at 07:10:30AM +1000, Steve Bennett wrote: > Thanks, but it also needs some extra checks and some changes to defs.h Thanks, I've added checks for additional PTRACE_* constants. > See attached. PTRACE_EVENT_EXIT is not 4 but 6. I've added fallback definitions based on linux/p

Re: [PATCH] Check for additional PTRACE options, events, etc.

2011-07-19 Thread Dmitry V. Levin
On Wed, Jul 20, 2011 at 08:28:59AM +1000, Steve Bennett wrote: > On 20/07/2011, at 8:25 AM, Dmitry V. Levin wrote: > > On Wed, Jul 20, 2011 at 07:10:30AM +1000, Steve Bennett wrote: > >> Thanks, but it also needs some extra checks and some changes to defs.h > > > >

Re: Ping: tcp->parent removal patches

2011-07-24 Thread Dmitry V. Levin
On Wed, Jul 20, 2011 at 07:18:27PM +0200, Denys Vlasenko wrote: > Dmitry, can you review the following patches > I sent about a month ago? Sorry for making you wait, I apparently failed to find time for looking at these non-trivial patches, but I hope to review on this week. > [PATCH] RFC: do not

Re: [PATCH] Slight optimization and cleanup in trace()

2011-08-01 Thread Dmitry V. Levin
On Sat, Jun 25, 2011 at 11:34:01AM +0200, Denys Vlasenko wrote: > Slight optimization and cleanup in trace(): > > - do not recalculate "cflag ? &ru : NULL" again and again > - do not clear errno unnecessarily > - consistently check wait errors as pid < 0, not pid == -1 > - indent ifdefs for better

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-08-01 Thread Dmitry V. Levin
On Sat, Jun 25, 2011 at 11:34:23AM +0200, Denys Vlasenko wrote: > This is a big change. I am not entirely sure it is correct, > so this patch is meant more like a RFC rather than a proposal > to apply it right away. I've read your series of patches several times and tested it with several kernel v

Re: [PATCH 2/2] remove tcp->parent and TCB_CLONE_THREAD

2011-08-01 Thread Dmitry V. Levin
On Sat, Jun 25, 2011 at 11:34:41AM +0200, Denys Vlasenko wrote: > +#ifdef LINUX > +/* Temporarily hijack this bit to mark tcb's we already attached */ > +# define TCB_ATTACH_DONE TCB_INSYSCALL We are not short of unused flags yet to apply such tricks, and your patch series makes even more room for

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-08-17 Thread Dmitry V. Levin
On Mon, Aug 15, 2011 at 12:01:56PM +0200, Denys Vlasenko wrote: > On Tue, 2011-08-02 at 01:45 +0400, Dmitry V. Levin wrote: > > On Sat, Jun 25, 2011 at 11:34:23AM +0200, Denys Vlasenko wrote: [...] > > > I need to look in the past to figure out why we even do it. > > >

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-08-17 Thread Dmitry V. Levin
On Wed, Aug 17, 2011 at 03:37:40PM +0200, Denys Vlasenko wrote: > On Wed, 2011-08-17 at 14:45 +0400, Dmitry V. Levin wrote: > > On Mon, Aug 15, 2011 at 12:01:56PM +0200, Denys Vlasenko wrote: > > > On Tue, 2011-08-02 at 01:45 +0400, Dmitry V. Levin wrote: > > > > On S

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-08-17 Thread Dmitry V. Levin
On Wed, Aug 17, 2011 at 07:33:57PM +0200, Denys Vlasenko wrote: [...] > We might have moderately bad news. I tested current git > on 2.4.32 kernel (ISO image from > http://mirrors.kernel.org/openwall/Owl/2.0-release/iso/Owl-2.0-release-i386.iso.gz > ) > > and test/childthread.c testcase apparently

Re: [PATCH] set saner MAX_ARGS

2011-08-18 Thread Dmitry V. Levin
On Thu, Aug 18, 2011 at 12:47:38PM +0200, Denys Vlasenko wrote: > On Thu, 2011-08-18 at 12:23 +0200, Denys Vlasenko wrote: > > I noticed that tcp->u_args[MAX_ARGS] array is way larger than > > I'd expect: for all arches except HPPA it has 32 (!) elements. > > > > I looked at the code and so far I

Re: Possible bug in sys_mmap64

2011-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2011 at 04:23:51PM +0200, Denys Vlasenko wrote: > I noticed particularly ugly ifdef forest in sys_mmap64 and decided > to simplify it (see the commit below). > > While looking at simplified version, I noticed that we seem to use > tcp->u_arg[i] while we have to use u_arg[i]. > > I

Re: [PATCH] set saner MAX_ARGS

2011-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2011 at 05:38:19PM +0200, Denys Vlasenko wrote: > On Fri, 2011-08-19 at 00:02 +0400, Dmitry V. Levin wrote: > > On Thu, Aug 18, 2011 at 12:47:38PM +0200, Denys Vlasenko wrote: [...] > > > > Alternative solution is to make sys_sigreturn print mask > > >

Re: Possible bug in sys_mmap64

2011-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2011 at 08:07:38PM +0200, Andreas Schwab wrote: > Denys Vlasenko writes: > > > However, I failed to make test program which invokes mmap64 > > (need to try on x86-64), thus I hesitated to fix the bug. > > No linux architecture uses sys_mmap64, since none of them define off_t > to

Re: [PATCH] set saner MAX_ARGS

2011-08-19 Thread Dmitry V. Levin
On Fri, Aug 19, 2011 at 05:38:19PM +0200, Denys Vlasenko wrote: > On Fri, 2011-08-19 at 00:02 +0400, Dmitry V. Levin wrote: [...] > > > --- strace.5/defs.h 2011-08-18 11:57:30.512416447 +0200 > > > +++ strace.6/defs.h 2011-08-18 11:46:56.349540479 +0200

Re: [PATCH] stop using -1 in syscallent tables

2011-08-23 Thread Dmitry V. Levin
On Tue, Aug 23, 2011 at 12:34:14PM +0200, Denys Vlasenko wrote: > Usage -1 as argument count in syscallent tables > necessitates the check for it, a-la: > > if (tcp->scno >= 0 && tcp->scno < nsyscalls && > sysent[tcp->scno].nargs != -1) > tcp->u_nargs = sysent[tcp->scno].n

Re: [PATCH 1/5] Duplicate get_scno into identical get_scno_on_sysenter, get_scno_on_sysexit

2011-08-23 Thread Dmitry V. Levin
On Mon, Aug 22, 2011 at 12:24:04PM +0200, Denys Vlasenko wrote: > On Mon, 2011-08-22 at 12:21 +0200, Denys Vlasenko wrote: > > 1. Duplicate get_scno into identical get_scno_on_sysenter, > > get_scno_on_sysexit functions. Call them in syscall enter and syscall > > exit, correspondingly. > > diff -d

Re: [PATCH 4/5] On x86, EAX read on syscall entry is not necessary

2011-08-23 Thread Dmitry V. Levin
On Mon, Aug 22, 2011 at 12:28:59PM +0200, Denys Vlasenko wrote: > On Mon, 2011-08-22 at 12:21 +0200, Denys Vlasenko wrote: > > 4. Another speedup: on x86, EAX read on syscall entry is also not > > necessary if we know that post-execve SIGTRAP is disabled by > > PTRACE_O_TRACEEXEC ptrace option. Thi

Re: [PATCH 5/5] Unify post-execve SIGTRAP check across all arches

2011-08-23 Thread Dmitry V. Levin
On Mon, Aug 22, 2011 at 12:30:26PM +0200, Denys Vlasenko wrote: > On Mon, 2011-08-22 at 12:21 +0200, Denys Vlasenko wrote: > > 5. Move post-execve SIGTRAP from get_scno_on_sysenter (multitude of > > places on many architectures) to a single location in > > trace_syscall_entering. This loosens the l

Re: [PATCH 4/5] On x86, EAX read on syscall entry is not necessary

2011-08-24 Thread Dmitry V. Levin
On Wed, Aug 24, 2011 at 11:13:29AM +0200, Denys Vlasenko wrote: > get_scno_on_sysexit() is a total misnomer, and should be renamed, > something like get_retval_on_sysexit(). OK, lets name it this way from the beginning, to avoid further confusion. -- ldv pgpcuSqh6jRcT.pgp Description: PGP sig

Re: [SCM] strace branch, master, updated. v4.6-109-ga614692

2011-08-25 Thread Dmitry V. Levin
On Wed, Aug 24, 2011 at 04:13:48PM +, Denys Vlasenko wrote: > commit a614692fb082294ae3d3c7f6c1ed26b355d6c4bf > Author: Denys Vlasenko > Date: Wed Aug 24 18:07:22 2011 +0200 > > Reorder functions in syscall.c. No code changes. > > Old order (basically "in no particular order"):

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-25 Thread Dmitry V. Levin
On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: > --- strace.5/syscall.c2011-08-25 10:39:36.0 +0200 > +++ strace.6/syscall.c2011-08-25 11:51:32.148543603 +0200 > @@ -716,7 +716,28 @@ struct tcb *tcp_last = NULL; > > #ifdef LINUX > # if defined (I386) > -s

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-25 Thread Dmitry V. Levin
On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: > While discussing ptrace speedup, in one email Linus said > that it's stupid that strace doesn't even use already existing > speedups, such as PTRACE_GETREGS. Yes, use of PTRACE_GETREGS is a long awaited change. I expect a significan

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-26 Thread Dmitry V. Levin
On Fri, Aug 26, 2011 at 11:50:15AM +0200, Denys Vlasenko wrote: > On Thu, 2011-08-25 at 21:10 +0400, Dmitry V. Levin wrote: > > On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: > > > While discussing ptrace speedup, in one email Linus said > > > that it&#

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-26 Thread Dmitry V. Levin
On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: > #ifdef LINUX > # if defined (I386) > -static long eax; > +struct i386_user_regs_struct { > + long ebx; > + long ecx; > + long edx; > + long esi; > + long edi; > + long ebp; > + long eax; > + long xds

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-26 Thread Dmitry V. Levin
On Fri, Aug 26, 2011 at 07:32:17PM +0200, Denys Vlasenko wrote: > On Fri, 2011-08-26 at 20:36 +0400, Dmitry V. Levin wrote: > > On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: > > > #ifdef LINUX > > > # if defined (I386) > > > -static long eax;

Re: [PATCH] Use PTRACE_GETREGS on i386

2011-08-26 Thread Dmitry V. Levin
On Fri, Aug 26, 2011 at 03:56:15PM -0400, Mike Frysinger wrote: > On Friday, August 26, 2011 13:32:17 Denys Vlasenko wrote: > > On Fri, 2011-08-26 at 20:36 +0400, Dmitry V. Levin wrote: > > > On Thu, Aug 25, 2011 at 12:10:06PM +0200, Denys Vlasenko wrote: >

Re: [PATCH] Use PTRACE_GETREGS on i386 and x86-64

2011-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2011 at 05:48:01PM +0200, Denys Vlasenko wrote: > On Fri, 2011-08-26 at 20:31 +0200, Denys Vlasenko wrote: > > > This version which uses asm/ptrace.h and its struct pt_regs. > > > > > > Also, I decided to bite the bullet and convert x86-64 too. > > > Especially that on it we also ge

Re: [PATCH] PATH_MAX may not be defined

2011-08-29 Thread Dmitry V. Levin
On Mon, Aug 29, 2011 at 08:43:33PM +1000, Steve Bennett wrote: > So define something reasonable in this case > > Signed-off-by: Steve Bennett > --- > pathtrace.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/pathtrace.c b/pathtrace.c > index b2efd33..553fef7 1

Re: [PATCH] PATH_MAX may not be defined

2011-08-30 Thread Dmitry V. Levin
On Tue, Aug 30, 2011 at 02:55:01PM +1000, Steve Bennett wrote: [...] > Including sys/param.h will bring in linux/limits.h and hence PATH_MAX > on this platform. Thanks, I've pushed a fix. -- ldv pgpfT3RGpnmaM.pgp Description: PGP signature -

Re: [SCM] strace branch, master, updated. v4.6-115-g102ec49

2011-08-30 Thread Dmitry V. Levin
On Wed, Aug 24, 2011 at 11:41:10PM +, Denys Vlasenko wrote: > commit 102ec4935440ff52a7fa3566154a84cc2473f16a > Author: Denys Vlasenko > Date: Thu Aug 25 01:27:59 2011 +0200 > > Optimize tabto() > > tabto is used in many lines of strace output. > On glibc, tprintf("%*s", co

Re: [SCM] strace branch, master, updated. v4.6-115-g102ec49

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 02:04:52PM +0200, Denys Vlasenko wrote: > On Tue, 2011-08-30 at 20:20 +0400, Dmitry V. Levin wrote: > > On Wed, Aug 24, 2011 at 11:41:10PM +, Denys Vlasenko wrote: > > > commit 102ec4935440ff52a7fa3566154a84cc2473f16a > > > Author: Denys Vlas

Re: [SCM] strace branch, master, updated. v4.6-115-g102ec49

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 03:19:16PM +0200, Denys Vlasenko wrote: > On Wed, 2011-08-31 at 16:25 +0400, Dmitry V. Levin wrote: > > On Wed, Aug 31, 2011 at 02:04:52PM +0200, Denys Vlasenko wrote: > > > On Tue, 2011-08-30 at 20:20 +0400, Dmitry V. Levin wrote: [...] > >

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 03:50:16PM +0200, Denys Vlasenko wrote: > Speaking of non-linux-2.6 systems. > > I am suspicious about non-Linux systems. I'd expect that > changes to the source are mostly tested on Linux, > and therefore we should see a fair number of errors > on non-Linux builds, especia

Re: [SCM] strace branch, master, updated. v4.6-126-g5284557

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 10:11:49AM +, Denys Vlasenko wrote: > commit 5284557bfad96f12dd5798539008e1644f1dc094 > Author: Denys Vlasenko > Date: Wed Aug 31 12:07:38 2011 +0200 > > Optimization: eliminate some usages of strcat() > > * defs.h: Declare stpcpy(). > * util.c: Defi

Re: [SCM] strace branch, master, updated. v4.6-127-g8778bff

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 10:25:34AM +, Denys Vlasenko wrote: > commit 8778bffdd25dca050b3aa2a7a7e05bc8a63a6665 > Author: Denys Vlasenko > Date: Wed Aug 31 12:22:56 2011 +0200 > > Optimize string_quote() for speed > > * util.c (string_quote): Speed up check for terminating NUL. >

Re: [SCM] strace branch, master, updated. v4.6-128-g2fb4db3

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 10:32:55AM +, Denys Vlasenko wrote: > commit 2fb4db3e7aa1d6ac6b4b43f47597197492a846dd > Author: Denys Vlasenko > Date: Wed Aug 31 12:26:03 2011 +0200 > > Optimization: eliminate all remaining usages of strcat() > > After this change, we don't use strcat(

Re: [SCM] strace branch, master, updated. v4.6-129-g1d46ba5

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 12:01:06PM +, Denys Vlasenko wrote: > commit 1d46ba57a8ab16b353b531f2bbefe2ad7f354ca9 > Author: Denys Vlasenko > Date: Wed Aug 31 14:00:02 2011 +0200 > > Make out-of-memory handling more uniform > > This fixes one real bug in dumpstr(). > > * de

Re: [SCM] strace branch, master, updated. v4.6-130-gdfa0acc

2011-08-31 Thread Dmitry V. Levin
On Wed, Aug 31, 2011 at 02:00:38PM +, Denys Vlasenko wrote: > commit dfa0acc8c1fc8d287c77f96ace8ac874f09c829a > Author: Denys Vlasenko > Date: Wed Aug 31 15:58:06 2011 +0200 > > Add README-linux-ptrace file > > I tried to push this doc to Michael Kerrisk , > but got no repl

Re: [PATCH] RFC: do not detach when we think tracee is going to die

2011-09-04 Thread Dmitry V. Levin
On Fri, Sep 02, 2011 at 11:33:05AM +1000, Steve Bennett wrote: > On 01/09/2011, at 3:14 AM, Dmitry V. Levin wrote: > > On Wed, Aug 31, 2011 at 03:50:16PM +0200, Denys Vlasenko wrote: > >> Speaking of non-linux-2.6 systems. > >> > >> I am suspicious abou

Re: strace: pid 0 exited with 0

2011-09-06 Thread Dmitry V. Levin
Hi, On Tue, Sep 06, 2011 at 10:49:23AM +0100, Stringfellow, Justin wrote: > Hi there. > > I'm trying to use strace on rhel to get some info on what a process is > spending it's time doing. The first problem I'm getting is that strace -c > alone is just hanging without executing anything. When I

Re: Patch for linux/mips/syscallent.h

2011-10-11 Thread Dmitry V. Levin
Hi, On Sun, Oct 09, 2011 at 11:41:43PM +0200, Ralf Friedl wrote: > I have a patch for linux/mips/syscallent.h, sys_stat64 ist already > defined and works well. Thanks. This bug was fixed by commit v4.5.20-58-g4dd5432; the first released strace version with this fix is 4.6. -- ldv pgpLeqyME

Re: epoll_wait displaying fixes

2011-10-11 Thread Dmitry V. Levin
Hi, On Mon, Oct 10, 2011 at 11:00:49AM +0600, Марк Коренберг wrote: > -- 1 -- > Please add displaying EPOLLRDHUP to epoll_wait instead of 0x200 > > current vesion (4.5.20-2ubuntu2) Why don't they update to 4.6? It was released more than 6 months ago. > epoll_wait(15, {{

Re: fix splice syscall displaying

2011-10-11 Thread Dmitry V. Levin
On Mon, Oct 10, 2011 at 11:01:42AM +0600, Марк Коренберг wrote: > splice(0x4, 0, 0x9, 0, 0x1, 0x3) = 2 > splice(0x7, 0, 0x6, 0, 0x2, 0x3) = 2 > > Why the "splice" show file descriptors in hex mode, while other > syscalls display in decimal mode? When strace has no specialised decoder for a sy

Re: epoll_wait displaying fixes

2011-10-12 Thread Dmitry V. Levin
On Wed, Oct 12, 2011 at 10:31:27AM +0600, Марк Коренберг wrote: > 12 октября 2011 г. 2:23 пользователь Dmitry V. Levin написал: > > On Mon, Oct 10, 2011 at 11:00:49AM +0600, Марк Коренберг wrote: > >> -- 1 -- > >> Please add displaying EPOLLRDH

Re: strace bug + prctl (PR_SET_PDEATHSIG, SIGKILL) + threads

2011-10-12 Thread Dmitry V. Levin
On Wed, Oct 12, 2011 at 10:10:46AM +0600, Марк Коренберг wrote: > Suppose this scenario: > > $ pstree -upal > > strace,26778 -ff -o j ./main > └─main,26779 > ├─main,26780 > ├─main,26781 > ├─main,26782 > │ └─{main},26794 > ├─main,26783 > ├─main,26784

Re: [PATCH] sys_epoll_create1: decode flag arguments correctly

2011-10-14 Thread Dmitry V. Levin
On Thu, Oct 13, 2011 at 10:33:45PM -0400, Mike Frysinger wrote: > * desc.c (epollflags): Define. > (sys_epoll_create1): Use epollflags to printflags. Change "O" to "EPOLL". Applied and pushed, thanks. -- ldv pgpGJCcg3BBkk.pgp Description: PGP signature

Re: How to exclude ipc calls

2011-11-24 Thread Dmitry V. Levin
Hi, On Thu, Nov 24, 2011 at 11:51:19PM +0100, Alexander Kriegisch wrote: > I would like to user an exception like "-e trace=!ipc", but that option does > not work. It seems to be a bug, but if it is not, please tell me what I am > doing wrong. Exceptions for other calls work, but not for ipc - m

Re: How to exclude ipc calls

2011-11-25 Thread Dmitry V. Levin
arm. What's the strace version and architecture you are talking about? > -- > Alexander Kriegisch (kriegaex) > http://freetz.org A: Because it messes up the order in which people normally read text. Q: Why top-posting is considered the most annoying thing in messages? > Dmitry V. Le

Re: How to exclude ipc calls

2011-11-25 Thread Dmitry V. Levin
On Fri, Nov 25, 2011 at 05:49:01PM +0100, Alexander Kriegisch wrote: [...] > > You can use > > strace -e trace='!ipc' > > to hide all IPC related syscalls (shm*, sem* and msg*). > > Thank you very much, but have you read my original question? I want to > specifically hide calls like these: > > >

Re: How to exclude ipc calls

2011-11-26 Thread Dmitry V. Levin
On Sat, Nov 26, 2011 at 01:51:28PM +0100, Alexander Kriegisch wrote: > On Fri, Nov 25, 2011 at 10:56:51PM +0400, Dmitry V. Levin wrote: [...] > > There is something wrong with strace on your platform, otherwise you > > would never see this ipc() syscall. I'm not an expert wit

Re: [PATCH] Fix sys_ipc/sys_semtimedop decoding on s390

2011-12-01 Thread Dmitry V. Levin
On Wed, Nov 30, 2011 at 01:16:29PM +0100, Heiko Carstens wrote: > The s390 kernel sys_ipc system call only takes five arguments instead of > six arguments which the common code sys_ipc implementation takes. > One of the arguments of the sys_semtimedop subcall is therefore passed in > a different re

Re: [PATCH 4.6] Teach strace about TCP_CONGESTION and TCP_MD5SIG

2011-12-01 Thread Dmitry V. Levin
On Wed, Nov 30, 2011 at 02:49:17PM -0800, Rick Jones wrote: > > Teach strace about the TCP_CONGESTION and TCP_MD5SIG options. Thanks, I added more TCP_* constants from linux/tcp.h, someday netinet/tcp.h will hopefully catch up. -- ldv pgp1u17M7sDYh.pgp Description: PGP signature

Re: [PATCH] Dump details for Bluetooth socket operations

2011-12-01 Thread Dmitry V. Levin
On Sun, Nov 20, 2011 at 07:18:51PM +0100, Lubomir Rintel wrote: > * net.c: Dump details for AF_BLUETOOTH sockets Thanks. > Signed-off-by: Lubomir Rintel > --- > configure.ac |1 + > net.c| 79 > +++--- > 2 files changed, 76 inse

Re: [PATCH] include stdbool.h for "bool" types

2011-12-10 Thread Dmitry V. Levin
On Sat, Dec 10, 2011 at 03:54:00PM -0500, Mike Frysinger wrote: > Current build fails due to missing stdbool.h include: I surely see no build failures on my side, but it depends on system headers. > strace.c:102:1: error: unknown type name 'bool' > strace.c: In function 'die_out_of_memory': > str

Re: [PATCH] include stdbool.h for "bool" types

2011-12-18 Thread Dmitry V. Levin
On Sat, Dec 10, 2011 at 03:54:00PM -0500, Mike Frysinger wrote: > Current build fails due to missing stdbool.h include: > strace.c:102:1: error: unknown type name 'bool' > strace.c: In function 'die_out_of_memory': > strace.c:269:2: error: unknown type name 'bool' > > Signed-off-by: Mike Frysinger

Re: [PATCH] x86_64 strace personality switching

2011-12-26 Thread Dmitry V. Levin
Hi, On Fri, Apr 29, 2011 at 12:13:14AM -0400, Michael A Fetterman wrote: > strace on x86_64 sometimes gets confused by interrupted system calls. > This happens routinely when tracing a large tree of processes. > > You get things like this: > > 1405 vfork( > > 1405 <... vfork resumed> )

Re: wait: No child processes

2011-12-27 Thread Dmitry V. Levin
Hi, On Thu, Nov 17, 2011 at 10:25:26AM +0100, Łukasz Michalik wrote: > Hello, > > I'm currently debugging an issue in sydbox wrt recent linux kernels. > I initially thought strace wasn't affected by it, but then debian bug > #622863 [1] made me investigate further, althought it's impossible to >

Re: [PATCH] display mask on enter to sigreturn, not exit

2012-01-10 Thread Dmitry V. Levin
Hi, On Mon, Jan 09, 2012 at 01:49:10PM +0100, Denys Vlasenko wrote: > sys_sigreturn() performs ugly manipulations in order to show > the signal mask which is restored by this syscall: on syscall entry, > fetches it from the stack, saves it in tcp->u_arg[] > (where it used to overflow this array -

Re: strace-4.6 failed to build with clang-3.0

2012-01-14 Thread Dmitry V. Levin
Hi, On Sun, Jan 15, 2012 at 03:12:50AM +0300, Alexander Kolesen wrote: > Hello. > > I've tried to build strace-4.6 with clang-3.0 and got the following > error: > > /usr/bin/clang -DHAVE_CONFIG_H -I. -I./linux/x86_64 -I./linux -I./linux > -Wall -Wwrite-strings -O2 -pipe -MT strace.o -MD -MP

Re: [PATCH] display mask on enter to sigreturn, not exit

2012-01-17 Thread Dmitry V. Levin
/* See below for TCB_ values */ I actually missed this obvious mistake during the first review. I'm about to push the following fix: From 024cad9a25bd11abc05525ab58b33cb570e29464 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Tue, 17 Jan 2012 18:37:13 + Subject: [

Re: [PATCH] display mask on enter to sigreturn, not exit

2012-01-17 Thread Dmitry V. Levin
On Tue, Jan 17, 2012 at 08:01:00PM +0100, Denys Vlasenko wrote: > On 01/17/2012 07:53 PM, Dmitry V. Levin wrote: [...] > >[X86_64] (x86_64_regs): Remove. > >* syscall.c [X86_64] (x86_64_regs): Make static. > > I think we will eventually need register structs to be access

Re: [PATCH] display mask on enter to sigreturn, not exit

2012-01-17 Thread Dmitry V. Levin
On Tue, Jan 17, 2012 at 08:59:46PM +0100, Denys Vlasenko wrote: > On 01/17/2012 08:43 PM, Dmitry V. Levin wrote: > > On Tue, Jan 17, 2012 at 08:01:00PM +0100, Denys Vlasenko wrote: > >> On 01/17/2012 07:53 PM, Dmitry V. Levin wrote: > > [...] > >>> [X86_64] (x86

Re: [PATCH] display mask on enter to sigreturn, not exit

2012-01-18 Thread Dmitry V. Levin
On Wed, Jan 18, 2012 at 11:09:58AM +0100, Denys Vlasenko wrote: > On 01/17/2012 10:46 PM, Dmitry V. Levin wrote: > > On Tue, Jan 17, 2012 at 08:59:46PM +0100, Denys Vlasenko wrote: > >> On 01/17/2012 08:43 PM, Dmitry V. Levin wrote: > >>> On Tue, Jan 17, 2012 at 08

Re: [PATCH] get rid of TCB_SIGTRAPPED

2012-01-18 Thread Dmitry V. Levin
On Wed, Jan 18, 2012 at 03:56:38PM +0100, Denys Vlasenko wrote: [...] > So, why we even have TCB_SIGTRAPPED? No one knows. It predates > version control: this code was present in the initial commit, > in 1999. > > Moreover, TCB_SIGTRAPPED is not used in sys_rt_sigaction, > only in obsolete sys_sig

Re: [PATCH] Add support for statfs64.f_flags

2012-01-18 Thread Dmitry V. Levin
On Tue, Jan 17, 2012 at 11:56:53PM +0100, Andreas Schwab wrote: > * file.c (printstatfs64): Print f_flags if available. > --- > file.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/file.c b/file.c > index 4e62c2c..473e6fd 100644 > --- a/file.c > +++ b/file.c > @@

Re: [PATCH] Add support for compat_statfs64

2012-01-18 Thread Dmitry V. Levin
On Tue, Jan 17, 2012 at 11:58:02PM +0100, Andreas Schwab wrote: > * file.c (struct compat_statfs64, printcompat_statfs64): Define. > (sys_statfs64, sys_fstatfs64): Use it. Looks OK for me. -- ldv pgpl6Q2hqKpxn.pgp Description: PGP signature

Re: strace 4.6 broken on mips64 n32

2012-01-22 Thread Dmitry V. Levin
Hi, On Sun, Jan 22, 2012 at 07:44:17PM +0100, Lluís Batlle i Rossell wrote: > Hello, > > strace 4.5.20 works perfectly on mips64 n32, but 4.6 shows wrong syscalls all > around. > > You'll see an example at the end of this letter. > > There is also a build warning, as defs.h does not contain any

Re: I will partially revert commit 44d0532

2012-01-24 Thread Dmitry V. Levin
On Tue, Jan 24, 2012 at 10:10:05AM +0100, Denys Vlasenko wrote: > The commit was: > > "strace.c (verror_msg): Rewrite without use of heap memory allocation" > > it replaced "malloc + one fprintf + free" with "three fprintf's". > > I guess it's my fault that I did not add a comment which explains

Re: I will partially revert commit 44d0532

2012-01-24 Thread Dmitry V. Levin
On Tue, Jan 24, 2012 at 11:42:49AM +0100, Denys Vlasenko wrote: > On 01/24/2012 11:24 AM, Dmitry V. Levin wrote: > >On Tue, Jan 24, 2012 at 10:10:05AM +0100, Denys Vlasenko wrote: > >> msg = NULL; > >> vasprintf(&msg, fmt, p); > >> if

Re: [SCM] strace branch, master, updated. v4.6-207-g3449ae8

2012-01-27 Thread Dmitry V. Levin
On Fri, Jan 27, 2012 at 04:27:32PM +, Denys Vlasenko wrote: [...] > commit 3449ae83c26d159dddc8573dc22b867feb0f49c6 > Author: Denys Vlasenko > Date: Fri Jan 27 17:24:26 2012 +0100 > > Fix readlink result display - was printing bogus "..." semi-randomly > > * file.c (decode_read

Re: [SCM] strace branch, master, updated. v4.6-207-g3449ae8

2012-01-30 Thread Dmitry V. Levin
On Sun, Jan 29, 2012 at 09:26:26PM +0100, Denys Vlasenko wrote: > On 01/28/2012 01:38 AM, Dmitry V. Levin wrote: > > On Fri, Jan 27, 2012 at 04:27:32PM +, Denys Vlasenko wrote: > > [...] > >> commit 3449ae83c26d159dddc8573dc22b867feb0f49c6 > >> Author: Denys Vl

Re: [PATCH 1/7] Print NULL for zero address in sys_mmap64

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:07:42AM -0800, H.J. Lu wrote: > Hi, > > This patch prints NULL for zero address in sys_mmap64 so that > it is consistent with sys_mmap. Applied, thanks. -- ldv pgpNxBBRMEbpm.pgp Description: PGP signature ---

Re: [PATCH 2/7] Define old stat functions only if needed

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:10:30AM -0800, H.J. Lu wrote: > Hi, > > When HAVE_LONG_LONG_OFF_T is defined, those old stat functions aren't used > and strace won't link since they use realprintstat which isn't defined > when HAVE_LONG_LONG_OFF_T is defined. Thanks, applied. -- ldv pgpEGagM

Re: [PATCH 3/7] Check HAVE_LONG_LONG_OFF_T when printing offset

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:12:10AM -0800, H.J. Lu wrote: > Hi, > > When HAVE_LONG_LONG_OFF_T is defined, we need to use %llu to print > offset. Applied, thanks. -- ldv pgpSzfVkGfJIx.pgp Description: PGP signature --

Re: [PATCH 5/7] Cast to long for %l in printf

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:16:03AM -0800, H.J. Lu wrote: > Hi, > > This patch casts a value to long for %l in printf to avoid compiler > warning on systems where it may be long long. Thanks, applied. -- ldv pgpuFDpJfFRoI.pgp Description: PGP signature --

Re: [PATCH 6/7] Define RLIM64_INFINITY only if not defined

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:17:01AM -0800, H.J. Lu wrote: > Hi, > > This patch defines RLIM64_INFINITY only if it isn't defined. Applied, thanks. -- ldv pgp6qrvWzpARd.pgp Description: PGP signature -- Try before

Re: [PATCH 4/7] Check sys_pread64 and sys_pwrite64 only if needed

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:14:07AM -0800, H.J. Lu wrote: > Hi, > > When HAVE_LONG_LONG_OFF_T is defined, sys_pread64 and sys_pwrite64 won't > be defined. We shouldn't reference them. Thanks. These sys_pread64/sys_pwrite64 are even less needed than on !HAVE_LONG_LONG_OFF_T, so I applied ano

Re: [PATCH 7/7] Skip the entry if the sys_func field is NULL

2012-02-06 Thread Dmitry V. Levin
Hi, On Fri, Feb 03, 2012 at 10:19:55AM -0800, H.J. Lu wrote: > Hi, > > This patch avoids segfault when there are holes in system call table. > It can happen with syscall (number, ...) and number is in those holes. We don't have sysent tables with holes yet, do we? Another question is, assuming

Re: [PATCH 7/7] Skip the entry if the sys_func field is NULL

2012-02-06 Thread Dmitry V. Levin
On Mon, Feb 06, 2012 at 07:43:58AM -0800, H.J. Lu wrote: > On Mon, Feb 6, 2012 at 7:24 AM, Dmitry V. Levin wrote: > > On Fri, Feb 03, 2012 at 10:19:55AM -0800, H.J. Lu wrote: > >> > >> This patch avoids segfault when there are holes in system call table. > >>

Re: [PATCH/RFC] don't store struct sysent::native_scno member if we aren't using it.

2012-02-07 Thread Dmitry V. Levin
Hi, On Tue, Feb 07, 2012 at 12:23:24PM +0100, Denys Vlasenko wrote: > Hi Dmitry. > > I noticed that this structure member is used only if > we have more than one personality. This native_scno thing is not so much used in the code than before. For example, there are 21 initialized native_scno ent

Re: How about removing non-Linux code?

2012-02-07 Thread Dmitry V. Levin
Hi, On Tue, Feb 07, 2012 at 02:06:24PM +0100, Denys Vlasenko wrote: > Hi Dmitry, > > Non-linux code (FreeBSD/SunOS/SVR4) appears to be dead. > > I looked through changelog and all changes to this code > since at least 2005 only keep it in line with evolution > of Linux code (such as changing the

Re: Release plans?

2012-02-07 Thread Dmitry V. Levin
On Tue, Feb 07, 2012 at 03:33:44PM +, Grant Edwards wrote: > Are there any plans to release a new version any time soon? Unless we want to enable PTRACE_SEIZE support by default (which is a nice feature, but in that case we would have to wait for a stable kernel API, so I'm not sure about it),

Re: Logic to develop strace

2012-02-09 Thread Dmitry V. Levin
On Thu, Feb 09, 2012 at 11:01:29AM -0500, Mike Frysinger wrote: > On Thursday 09 February 2012 08:47:51 shubham wrote: > > This is my first post and I am new to strace also. I liked the facilities > > this command provides and I want to learn the logics behind the development > > of this command. >

Re: Release plans?

2012-02-09 Thread Dmitry V. Levin
On Tue, Feb 07, 2012 at 06:18:22PM +, Grant Edwards wrote: > On 2012-02-07, Dmitry V. Levin wrote: > > On Tue, Feb 07, 2012 at 03:33:44PM +, Grant Edwards wrote: > > > >> Are there any plans to release a new version any time soon? > > > > Unless we wa

Re: [PATCH] util: check for process_vm_readv in C library

2012-02-16 Thread Dmitry V. Levin
On Tue, Feb 14, 2012 at 02:59:58PM +0100, Denys Vlasenko wrote: > On 02/14/2012 05:56 AM, Mike Frysinger wrote: > > glibc-2.15 provides process_vm_readv, so trying to provide this ourselves > > with that version fails: > > util.c:797:16: error: static declaration of 'process_vm_readv' > >

Re: [PATCH] util: check for process_vm_readv in C library

2012-02-19 Thread Dmitry V. Levin
On Thu, Feb 16, 2012 at 01:28:01PM -0500, Mike Frysinger wrote: > On Thursday 16 February 2012 11:55:06 Dmitry V. Levin wrote: > > A ChangeLog-style entry is missing in the commit message, > > but the commit is already pushed... > > blah, sorry. i started to look at `gi

Re: [PATCH/RFC] don't store struct sysent::native_scno member if we aren't using it.

2012-02-20 Thread Dmitry V. Levin
On Tue, Feb 07, 2012 at 02:14:11PM +0100, Denys Vlasenko wrote: > On 02/07/2012 01:17 PM, Dmitry V. Levin wrote: > >> I noticed that this structure member is used only if > >> we have more than one personality. > > > > This native_scno thing is not so much used

Re: strace: Shows wrong system call

2012-02-21 Thread Dmitry V. Levin
On Wed, Jan 09, 2008 at 12:12:20AM +0200, Petri Latvala wrote: > Package: strace > Version: 4.5.14-2 > Severity: normal This comes from quite an old Debian bug report http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=459820 which seems to be actual. > -- BEGIN TESTCASE PROGRAM -- > > #include >

Re: How about removing non-Linux code?

2012-02-21 Thread Dmitry V. Levin
On Tue, Feb 07, 2012 at 04:18:32PM +0100, Denys Vlasenko wrote: > On 02/07/2012 04:05 PM, Dmitry V. Levin wrote: > >> What do you think about removing all non-Linux code after the next release? > > > > I'm inclined to think it would be better to remove that dead co

Re: How about removing non-Linux code?

2012-02-24 Thread Dmitry V. Levin
On Wed, Feb 22, 2012 at 05:40:46AM +0400, Dmitry V. Levin wrote: > So, since there were no objections, let's go ahead and kick the dead code out. Here it is, tested on x86 and x86-64, please have a look (6 top commits): http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=sh

Re: How about removing non-Linux code?

2012-02-25 Thread Dmitry V. Levin
On Sat, Feb 25, 2012 at 03:49:03PM +0100, Denys Vlasenko wrote: > On 02/25/2012 02:51 PM, Denys Vlasenko wrote: > > On 02/25/2012 01:41 AM, Dmitry V. Levin wrote: > >> On Wed, Feb 22, 2012 at 05:40:46AM +0400, Dmitry V. Levin wrote: > >>> So, since there were no objec

Re: Feature requests: list of PIDS, and all threads

2012-03-09 Thread Dmitry V. Levin
On Thu, Mar 08, 2012 at 12:32:12PM +0100, Denys Vlasenko wrote: > On 03/07/2012 08:59 PM, George Spelvin wrote: > > With multi-process and multi-threaded programs becoming more common, > > there are a couple of things I wish strace gave me: > > > > 1) Some way to supply a *list* of pids to be trace

Re: Release plans?

2012-03-10 Thread Dmitry V. Levin
On Thu, Feb 09, 2012 at 07:38:27PM +0100, Denys Vlasenko wrote: > On 02/09/2012 05:29 PM, Dmitry V. Levin wrote: [...] > > The current release was made in March of 2011, we have 228 commits on top > > of 4.6 so far, including some important internal and user-visible changes, >

<    2   3   4   5   6   7   8   9   10   11   >