DO NOT REPLY [Bug 17855] - ELMessagesPresentTag gives NullPointerException when name not specified

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-struts/src/share/org/apache/struts/action ActionServlet.java

dgraham 2003/03/10 21:24:55 Modified:src/share/org/apache/struts/action ActionServlet.java Log: Fixed javadoc error and added braces to one line blocks. Revision ChangesPath 1.144 +12 -11 jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java In

DO NOT REPLY [Bug 17854] - Integer validation does not give an alert.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: Tiles excessive memory usage

Thanks Christophe. I will take my time seeing what youve done and to see how it best fits to 1.1. I would like to hear from Cedric too as soo as possible to be sure there's ot something we've missed. If I have succes with 1.1 I'll be sure to offer it to this mail list But I truly hope to hear

DO NOT REPLY [Bug 17855] New: - ELMessagesPresentTag gives NullPointerException when name not specified

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17854] New: - Integer validation does not give an alert.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

dgraham 2003/03/10 19:09:00 Modified:src/share/org/apache/struts/util RequestUtils.java Log: Removed redundant code for getModuleConfig methods, moved the methods next to each other for readability. Revision ChangesPath 1.93 +16 -20 jakarta-struts/src/share/org

DO NOT REPLY [Bug 17823] - Problem with resouce bundles when working with multiple modules

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17833] - Validator Javascript does not validate negative numbers correctly

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

dgraham 2003/03/10 18:04:20 Modified:src/share/org/apache/struts/util RequestUtils.java Log: Added missing braces to blocks to ease confusion. No functionality change. Revision ChangesPath 1.92 +56 -36 jakarta-struts/src/share/org/apache/struts/util/RequestUtils

cvs commit: jakarta-struts/conf/share validator-rules.xml

dgraham 2003/03/10 17:40:41 Modified:conf/share validator-rules.xml Log: Fixed validateShort and isAllDigits for negative numbers. PR #17833. Revision ChangesPath 1.27 +9 -2 jakarta-struts/conf/share/validator-rules.xml Index: validator-rules.xml

While checking in a few changes to tests...

Checking in web/test/test/org/apache/struts/taglib/html/TestImageTag3.jsp; /home/cvs/jakarta-struts/web/test/test/org/apache/struts/taglib/html/Tes tImageTag3.jsp,v <-- TestImageTag3.jsp new revision: 1.3; previous revision: 1.2 done qmail-inject: fatal: qq write error or disk full (#4.3.0) <--

RE: Tiles excessive memory usage

Patches are attached to the corresponding bugzilla ticket. David From: Christophe Warland <[EMAIL PROTECTED]> Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> To: 'Struts Developers List' <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: RE: Tiles excessive memory usag

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Tiles excessive memory usage

Patch is attached. Once again, please note that this is based on Tiles as of 2001-09-10. I would send my sources to the list, but I have only just joined struts-dev today and I don't know the etiquette in use here with regards to attachments. FWIW, my modified sources fit in a 17k zip file (non-uue

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/bean MessageTag.java

jmitchell2003/03/10 16:00:28 Modified:src/share/org/apache/struts/taglib/bean MessageTag.java Log: As discussed (briefly) on the dev list: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17838 This fix helps to debug specific user errors by showing quotes around the key th

Re: Tiles excessive memory usage

Chris, I'm just now getting to profiling our struts/tiles app and have always had some concern about the efficiency of the tiles. Not that I'm a suspecting type of person but I just didn't have any information and that caused me to wonder. Regardles when or if this fix gets placed in a release

DO NOT REPLY [Bug 17847] - MessageFormat usage in MessageResources.java

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: Tiles excessive memory usage

Struts 1.0.2 development has stopped with all further development in 1.1 and higher. 1.1 is in code freeze with no new enhancements being added. While this is an important issue, it is not a bug. Does anyone know (specifically Cedric) if there's a good reason for the deep copying? David F

DO NOT REPLY [Bug 17847] - MessageFormat usage in MessageResources.java

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17847] New: - MessageFormat usage in MessageResources.java

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Tiles excessive memory usage

At my company, we have been recently forced to patch Tiles to solve some major memory problems where Tiles was eating a lot of memory for no apparent reasons. We wish to share our findings with you. And we will be happy to send our code change to Cedric if he wishes so.   Here are some quic

Re: [Patch] MessageFormat usage in MessageResources.java

Please attach your patch to the bugzilla ticket for this issue. David From: Nick Coleman <[EMAIL PROTECTED]> Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> To: "'[EMAIL PROTECTED]'" <[EMAIL PROTECTED]> Subject: [Patch] MessageFormat usage in MessageResources.java Date: Mon, 10 Mar 2003

[Patch] MessageFormat usage in MessageResources.java

In profiling struts-el, I noticed a big lag in the standard taglib Resources class in that it calls MessageFormat.format rather than caching preparsed formats. The initialization of a MessageFormat is easily 75% of the time spend while the call to format() is only 25%. I entered a bug about thi

Re: Did you find the solution to this problem ....

Sorry but there not exist a solution to this problem. When i have submitted the bug to the committers, they have marked it as a "LATER" bug. My solution to this problem was create a MessageResorce loader that can receive multiple file as parameter (comma separated) in tha same manner that the conf

RE: DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

Keep in mind though that this only affects the MessageTag since that's where the (somewhat confusing) message is generated. -- James Mitchell Software Developer/Struts Evangelist http://jakarta.apache.org/struts "People demand freedom of speech to make up for the freedom of thought which they av

RE: DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

+1 If all agree I'll commit tonight. -- James Mitchell Software Developer/Struts Evangelist http://jakarta.apache.org/struts "People demand freedom of speech to make up for the freedom of thought which they avoid." - Soren Aabye Kierkegaard (1813-1855) > -Original Message- > From

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] - should trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17838] New: - Bean:message should Trim keys before dereferencing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17837] - javascript validating errors with integers

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17837] New: - javascript validating errors with integers

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17836] - could possibly fail with taglib pooling

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17836] New: - bean:write could possibly fail with taglib pooling

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: jakarta-struts/web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp TestButtonTag1.jsp TestButtonTag2.jsp TestCancelTag1.jsp TestCancelTag2.jsp TestCheckboxTag1.jsp TestCheckboxTag2.jsp TestCheckboxTag3.jsp TestCheckboxTag4.jsp TestErrorsTag1.jsp TestErrorsTag2.jsp TestFileTag1.jsp TestFileTag2.jsp TestHiddenTag1.jsp TestHiddenTag2.jsp TestHtmlTag.jsp TestImageTag1.jsp TestImageTag2.jsp TestImageTag3.jsp TestImageTag4.jsp

craigmcc2003/03/10 09:29:53 Modified:web/test/test/org/apache/struts/taglib/html TestBaseTag.jsp TestButtonTag1.jsp TestButtonTag2.jsp TestCancelTag1.jsp TestCancelTag2.jsp TestCheckboxTag1.jsp TestCheckboxTag2.jsp

RE: RequestUtils.computeURL()

> -Original Message- > From: Craig R. McClanahan [mailto:[EMAIL PROTECTED] > Sent: Monday, March 10, 2003 12:24 PM > To: Struts Developers List > Subject: RE: RequestUtils.computeURL() > > > > > On Mon, 10 Mar 2003, James Mitchell wrote: > > > Date: Mon, 10 Mar 2003 11:44:01 -0500 >

RE: RequestUtils.computeURL()

On Mon, 10 Mar 2003, James Mitchell wrote: > Date: Mon, 10 Mar 2003 11:44:01 -0500 > From: James Mitchell <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: 'Struts Developers List' <[EMAIL PROTECTED]> > Subject: RE: RequestUtils.computeURL() > > Sounds great. I'll

RE: RequestUtils.computeURL()

Sounds great. I'll take care of that tonight. Can anyone run test.tomcat.all? I guess I purchased some bad memory for my laptop or the OS/JVM is a piece of sh#t, because when I try to run them all, I get somewhere in the .40 tests and my laptop just shuts downno blue screenno OutOfMemory

DO NOT REPLY [Bug 17835] - The javascript code to validate integers does not display an alert box if the number being validated has invalid digits. (i.e. floating point numbers)

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: RequestUtils.computeURL()

On Mon, 10 Mar 2003, David Graham wrote: > Date: Mon, 10 Mar 2003 08:27:32 -0700 > From: David Graham <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Subject: Re: RequestUtils.computeURL() > > >Is there any reason that any tag should NOT call

Re: RequestUtils.computeURL()

On Mon, 10 Mar 2003, James Mitchell wrote: > Date: Mon, 10 Mar 2003 10:01:16 -0500 > From: James Mitchell <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: Struts Developers List <[EMAIL PROTECTED]> > Subject: RequestUtils.computeURL() > > > Is there any reason tha

DO NOT REPLY [Bug 17835] New: - The javascript code to validate integers does not display an alert box if the number being validated has invalid digits. (i.e. floating point numbers)

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: RequestUtils.computeURL()

Yes, well, my concern is that we have duplicate code doing the same thing. I assume computURL was added after the code for ImgTag was written, and then perhaps overlooked. I changed the '&' to "&" in the ImgTag and my tests are now passing. That sounds fine until you actually look at the test.

DO NOT REPLY [Bug 17833] New: - The javascript code to validate integers does not validate negative numbers correctly.

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: RequestUtils.computeURL()

Ok, so make the image tag call RequestUtils.computeURL() to escape the & and encode session data if needed. David Except that the doc for says: Renders an HTML element with the image at the specified URL. Like the link tag, URL rewriting will be applied automatically to the value specified

DO NOT REPLY [Bug 17328] - Unsafe initialization in PropertyMessageResources

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: RequestUtils.computeURL()

Except that the doc for says: Renders an HTML element with the image at the specified URL. Like the link tag, URL rewriting will be applied automatically to the value specified in src or page, to maintain session state in the absence of cookies. This will allow dynamic generation of an image whe

Re: compiling and building struts

asatrasala wrote: Hello, Is there any one place I can download all the dependent jars necessary for compiling struts Yes download a nightly build and use the included commons-* jars. -Rob - To unsubscribe, e-mail: [EMAIL PROTE

RE: RequestUtils.computeURL()

That was my initial thought, but wanted to bounce it off a few other people first. -- James Mitchell Software Developer/Struts Evangelist http://jakarta.apache.org/struts "People demand freedom of speech to make up for the freedom of thought which they avoid." - Soren Aabye Kierkegaard (1813

Re: RequestUtils.computeURL()

Is there any reason that any tag should NOT call computeURL when evaluating a URL that needs a parameter of Map entries added? computeURL also encodes the url with session information which isn't desirable for images. Maybe ImgTag should just replace & with & itself without calling computeURL.

RE: RequestUtils.computeURL()

Only that unnecessary calls to the URLEncoder.encode within the computeURL method adds excess overhead that is not always needed. If encoding a url could be optionally turned on / off, performance would be better. The URLEncoder instantiates a ByteArrayOutputStream and a BufferedWriter which can

RequestUtils.computeURL()

Is there any reason that any tag should NOT call computeURL when evaluating a URL that needs a parameter of Map entries added? It seems that ImgTag does it all by itself, and since it hard-codes '&' instead of the standard '&', my new tests (which I haven't even committed yet) are failing. Shoul

DO NOT REPLY [Bug 11932] - MessageResources is not module aware

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17328] - Unsafe initialization in PropertyMessageResources

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 17823] New: - Problem with resouce bundles when working with multiple modules

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu