Re: Proposed enhancement to

2001-06-24 Thread Martin Cooper
I would be leery of changing to support a body. In a fully localizable page, this is one of the most frequently used tags (if not _the_ most frequently used). Changing a tag from extending TagSupport to extending BodyTagSupport increases the amount of code that is generated from the JSP page, esp

Re: Logic tags and string properties

2001-06-24 Thread Martin Cooper
Picking up on an old thread here (because I'd like to go ahead and fix the problem :-) ). If we add an 'empty' attribute to and , what should the allowed values be? One option which occurs to me is that "empty='true'" would mean that the condition is true if the property is an empty string, whi

cvs commit: jakarta-struts/web/upload/WEB-INF struts-config.xml web.xml

2001-06-24 Thread craigmcc
craigmcc01/06/24 17:02:35 Modified:src/share/org/apache/struts/action ActionServlet.java web/blank/WEB-INF struts-config.xml web.xml web/documentation/WEB-INF web.xml web/example/WEB-INF struts-config.xml web.xml web/exercise-t

cvs commit: jakarta-struts/src/share/org/apache/struts/action ActionServlet.java

2001-06-24 Thread craigmcc
craigmcc01/06/24 16:49:55 Modified:src/share/org/apache/struts/action ActionServlet.java Log: Remove deprecated support for the old (Struts 0.5) configuration file format. Revision ChangesPath 1.71 +6 -83 jakarta-struts/src/share/org/apache/struts/action/Acti

Where's Craig?

2001-06-24 Thread Craig R. McClanahan
As I have told a couple of people, I'm going to be on vacation for a couple of weeks starting tomorrow (Monday June 25) evening. It is very unlikely that I will have email contact during most of that time. I will be available again on July 11. Therefore, I'm great with adding some additional co

Re: Controller loads forms before validating logon/session

2001-06-24 Thread Craig R. McClanahan
On Sun, 24 Jun 2001, Martin Cooper wrote: > This seems to me to be a "necessary but not sufficient" check. That is, to > ascertain that a valid user is logged on, it may be necessary to check for > the existence of a particular session attribute, but it is unlikely that > such a test, by itself,

Re: [VOTE] Two New Committers

2001-06-24 Thread Craig R. McClanahan
+1 ... absolutely! Craig On Sun, 24 Jun 2001, Ted Husted wrote: > I would like to propose the following individuals for Committer status > on the Struts project: > > Oleg V Alexeev > > David Winterfeldt > > The have both contributed significant new extensions to the Struts > com

Re[4]: Controller loads forms before validating logon/session

2001-06-24 Thread Oleg V Alexeev
Hello Martin, I am agree with you. But it is strange solution, for my mind, to implement session attribute check and avoid user or role checking. This thread is started with letter about logon checking with session attribute. But this is a custom way to implement secure constraints - standart sol

Re: [VOTE] Two New Committers

2001-06-24 Thread Martin Cooper
+1 each. - Original Message - From: "Ted Husted" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, June 24, 2001 3:54 AM Subject: [VOTE] Two New Committers > I would like to propose the following individuals for Committer status > on the Struts project: > > Oleg V Alexee

Re: Re[2]: Controller loads forms before validatinglogon/session

2001-06-24 Thread Martin Cooper
Actually, my proposal would be sufficient to cover both examples you suggested, since they could be implemented using the sessionCheck() method. However, I think the key is determining the right set of sufficiently common and useful checks that could be built in, so that only struts-config.xml nee

Re: [VOTE] Two New Committers

2001-06-24 Thread Oleg V Alexeev
Hello Ted, +1, certainly... 8) Sunday, June 24, 2001, 2:54:32 PM, you wrote: TH> I would like to propose the following individuals for Committer status TH> on the Struts project: TH> Oleg V Alexeev TH> David Winterfeldt TH> The have both contributed significant new extensions to

[VOTE] Two New Committers

2001-06-24 Thread Ted Husted
I would like to propose the following individuals for Committer status on the Struts project: Oleg V Alexeev David Winterfeldt The have both contributed significant new extensions to the Struts community, and as Committers they can help integrate these extensions with the nightly di

Re[2]: Controller loads forms before validating logon/session

2001-06-24 Thread Oleg V Alexeev
Hello Martin, Sunday, June 24, 2001, 11:42:13 AM, you wrote: MC> This seems to me to be a "necessary but not sufficient" check. That is, to MC> ascertain that a valid user is logged on, it may be necessary to check for MC> the existence of a particular session attribute, but it is unlikely that

Re: Extending the scope of the struts validation

2001-06-24 Thread Oleg V Alexeev
Hello Frangois, +1 to merge validation and transformation processing. I like idea that core java transformation classes (SimpleDateFormat for example) can help to validate inputs in conversion processing moment. It all already handle locale to transform - i18n supported by the way. It think that

Re: Controller loads forms before validating logon/session

2001-06-24 Thread Martin Cooper
This seems to me to be a "necessary but not sufficient" check. That is, to ascertain that a valid user is logged on, it may be necessary to check for the existence of a particular session attribute, but it is unlikely that such a test, by itself, will be sufficient to make the determination. Here