[PATCH] planner: disable mouse interaction when zoomed in

2015-03-10 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" When zoomed in, things like moving planner points is not possible, but if the user attempts that, replan() -> plotDive() is called and the zoomLevel should be reset to the default value (we don't really want that), but instead it's lost for some reason (as the user repor

Re: [PATCH] Import Datatrak/WLog files

2015-03-10 Thread Salvador Cuñat
2015-03-10 22:25 GMT+01:00 Dirk Hohndel : > I cleaned it up a tiny bit but left it mostly unchanged... and > pushed it so I wouldn't forget again :-) > Hmmm. There was a little more work to do involving some recent changes like divemode. But I can't take a look until tomorrow evening. > So

[PATCH] datatrak: some codings style fixes and fopen() usage

2015-03-10 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" - subsurface_fopen() is needed - translated one puts("") message - sizeof(unsigned char | char) is always 1 - pointer symbol (*) location - padding fixes - braces fixes Signed-off-by: Lubomir I. Ivanov --- salva, please check if i broke something. some generic cleanup

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Dirk Hohndel
On Wed, Mar 11, 2015 at 12:13:17AM +0200, Yosef Hamza wrote: > On Tue, Mar 10, 2015 at 11:39 PM, Dirk Hohndel wrote: > > > On Tue, Mar 10, 2015 at 11:08:14PM +0200, Yosef Hamza wrote: > > > > a) the events are ordered by time, so the moment you have one where > >time.seconds > 0 you can stop

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Yosef Hamza
On Tue, Mar 10, 2015 at 11:39 PM, Dirk Hohndel wrote: > On Tue, Mar 10, 2015 at 11:08:14PM +0200, Yosef Hamza wrote: > > a) the events are ordered by time, so the moment you have one where >time.seconds > 0 you can stop > Yea I thought about that, But Gehad told me before that there was an i

Re: [PATCH] Import Datatrak/WLog files

2015-03-10 Thread Dirk Hohndel
Salva, On Tue, Mar 10, 2015 at 08:26:32PM +0100, Salvador Cuñat wrote: > > > > And now, five months later, it seems I still never applied it. > > > > Any idea why? > > > > /D > > > I don't know. I thought you didn't like that hackish code pages related > thing (I recon I dislike very much). I'm

Re: [PATCH] Import Datatrak/WLog files

2015-03-10 Thread Davide DB
On Tue, Mar 10, 2015 at 8:36 PM, Salvador Cuñat wrote: > As commented some time (months :-) ) ago, I have a quite functional parser > for SmartTrak files. > Do you still have access to your friend's divelog? It would be great to > test it, as all my dives in smarttrak are imported and I only hav

Re: [PATCH] Import Datatrak/WLog files

2015-03-10 Thread Pedro Neves
On 03/10/2015 07:36 PM, Salvador Cuñat wrote: As commented some time (months :-) ) ago, I have a quite functional parser for SmartTrak files. Do you still have access to your friend's divelog? It would be great to test it, as all my dives in smarttrak are imported and I only have the exampl

Re: Request For Comments - Undo/Redo framework

2015-03-10 Thread Grace Karanja
On Mon, Mar 9, 2015 at 2:51 PM, Grace Karanja wrote: > > > See the attached patch, which implements undo/redo of when merging dives. > The next attached patch implements undo/redo when downloading from dive computers. > > >> >> /D >> > > From 3217288dfdd60b84fd6cc182b85b7e5cd213b80e Mon Sep 17

Uwatec Smartrak dive log decoding

2015-03-10 Thread Willem Ferguson
On 10/03/2015 21:36, Salvador Cuñat wrote: I have a quite functional parser for SmartTrak files. Do you still have access to your friend's divelog? It would be great to test it, as all my dives in smarttrak are imported and I only have the example file shipped with Uwatek's app. I don't know

Re: Allow removal of manually added unused cylinders, Fixes #832

2015-03-10 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 07:31:06PM +0100, Joakim Bygdell wrote: > If we manually add a cylinder we should be allowed to remove it, unless we > have assigned a gas switch to it. I wrote this code when I removed the "used" member of the cylinder structure. Looking back I don't understand why I did

Allow removal of manually added unused cylinders, Fixes #832

2015-03-10 Thread Joakim Bygdell
If we manually add a cylinder we should be allowed to remove it, unless we have assigned a gas switch to it. 0001-Allow-removal-of-manually-added-unused-cylinders.patch Description: Binary data /Jocke ___ subsurface mailing list subsurface@subsurfac

Re: Customizable Print Formats GSoC 2015

2015-03-10 Thread Lubomir I. Ivanov
On 10 March 2015 at 17:49, Gehad Elrobey wrote: > On Sun, Mar 8, 2015 at 9:40 PM, Lubomir I. Ivanov wrote: >> compared to what we do ATM - rendering the profile QWidget directly to >> QPrinter which produces vector (Win32 / OSX only), the introduction of >> SVG which is grabbed from a QWidget the

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Yosef Hamza
On Tue, Mar 10, 2015 at 5:02 PM, Dirk Hohndel wrote: > On Tue, Mar 10, 2015 at 02:54:48PM +0200, Yosef Hamza wrote: > > Hey subsurface, > > > > My name is Yousef Hamza, and I'm 3rd year CESS student, I already have > > contributions to subsurface the desktop app and the iOS app. > > You have sent

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 02:54:48PM +0200, Yosef Hamza wrote: > Hey subsurface, > > My name is Yousef Hamza, and I'm 3rd year CESS student, I already have > contributions to subsurface the desktop app and the iOS app. You have sent some ideas for the iOS app and you still need to actually implemen

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 01:59:53AM +0200, Yosef Hamza wrote: > On Tue, Mar 10, 2015 at 1:18 AM, Dirk Hohndel wrote: > > > > > > > > @@ -1392,6 +1395,23 @@ void ProfileWidget2::changeGas() > > qDebug() << "failed to parse tank number"; > > tank = get_gasidx(&displaye

Re: [PATCH] Import Datatrak/WLog files

2015-03-10 Thread Dirk Hohndel
On Wed, Nov 05, 2014 at 07:50:15PM +0100, Salvador Cuñat wrote: > Hi Dirk. > > May be you missed the previous patch. And now, five months later, it seems I still never applied it. Any idea why? /D ___ subsurface mailing list subsurface@subsurface-di

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Davide DB
On Tue, Mar 10, 2015 at 12:52 PM, Joakim Bygdell wrote: > > You can change back to the first gas later in the dive if you have done a > switch to another gas. > If you have say 4 different gas mixes during a dive you can have a gas change > series that does not follow the order of the gases in

Re: some patches regarding the location edit.

2015-03-10 Thread Tomaz Canabrava
On Mon, Mar 9, 2015 at 5:09 PM, Dirk Hohndel wrote: > On Mon, Mar 09, 2015 at 04:01:12PM -0300, Tomaz Canabrava wrote: > > From 7e89b79afbefd508015841a667cc68a73865754b Mon Sep 17 00:00:00 2001 > > From: Tomaz Canabrava > > Date: Mon, 9 Mar 2015 15:12:48 -0300 > > Subject: [PATCH 3/6] Remove red

Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Yosef Hamza
Hey subsurface, My name is Yousef Hamza, and I'm 3rd year CESS student, I already have contributions to subsurface the desktop app and the iOS app. I'm interested in adding integration to subsurface with established online dive logs, In the description "diveboard.com" was mentioned I googled a li

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Joakim Bygdell
On 10 March 2015 at 10:19, Davide DB wrote: > On Tue, Mar 10, 2015 at 6:52 AM, Joakim Bygdell > wrote: > > > > The default cylinder setup is more suited to people that do not dive the > way you do, since the way you describe it you rarely start a dive on > backgas. > > It's just a way to make it

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Joakim Bygdell
On 10 March 2015 at 12:08, Davide DB wrote: > If I recall it correctly, I remember that some developer told me that > having at least a cylinder is compulsory. > Why? > When I import dives from my Viper in gauge mode, the cylinder table is > originally empty. > When I import from my Xdeep I have

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Davide DB
If I recall it correctly, I remember that some developer told me that having at least a cylinder is compulsory. Why? When I import dives from my Viper in gauge mode, the cylinder table is originally empty. When I import from my Xdeep I have a unkonwn cylinder (it's logged into the imported uddf fil

[PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Willem Ferguson
Dirk and Tomaz, How easy would it be to implement reordering the cylinders in the equipment tab after they have been copy-and- pasted from another dive, that is, without having to delete and re-type all the information for a cylinder? The present setup is not very user-friendly for divers using

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Robert Helling
Hi all, > On 10.03.2015, at 06:52, Joakim Bygdell wrote: > > The default cylinder setup is more suited to people that do not dive the way > you do, since the way you describe it you rarely start a dive on backgas. > It’s just a way to make it convenient for people that doesn’t have as complex

Re: [PATCH 2/2] Ticket #831 Fix

2015-03-10 Thread Davide DB
On Tue, Mar 10, 2015 at 6:52 AM, Joakim Bygdell wrote: > > The default cylinder setup is more suited to people that do not dive the way > you do, since the way you describe it you rarely start a dive on backgas. > It's just a way to make it convenient for people that doesn't have as complex > se