Re: Cloud storage and web view
Did a quick test. The dive numbers don’t match with the dates. The last dive by date should also have the highest number, logically that is. Yes, I noticed that as well when playing around with it. I was going to ask Gehad about this and then forgot. Thanks for bringing it up! Seems like the export doesn’t care about the numbers in my log book and always starts from 1. Since mine starts with 1 I didn't see that. But there's an option for the exporter to use Subsurface numbers and I forgot to set that. My guess is that would fix this issue. I'll play with this (and try to track down a weird crash in the headless exporter that I observed while trying to force an export for everyone who has an account) /D Another thing, if I use the Trip view the dive numbering is correct. /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 18 June 2015 at 15:48, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 18, 2015 at 01:35:16PM +0200, Gehad Elrobey wrote: On Thu, Jun 18, 2015 at 9:52 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 June 2015 at 19:51, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. thanks, your branch seems to be missing the patch to fix this: error: 'm__nstance' was not declared in this scope Q_ASSERT_X(m__nstance == NULL, WindowTitleUpdate, WindowTitleUpdate recreat ed!); [Patch] Re-fix silly typo (was Current git no compilee) lubomir -- rebased with current master and pushed. Good - Lubomir are you going to sign off on them again? hello, haven't reviewed yet. will do soon. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On 18 June, 2015 - Dirk Hohndel wrote: On Wed, Jun 17, 2015 at 07:28:20PM -0700, Dirk Hohndel wrote: So while there are still some rough edges, I think this is taking shape quite nicely. I've seen five of you have tested the cloud storage so far - thanks for doing that. If you run into any problem, please post about them - I fixed a few more bugs, saving to the cloud storage should work more reliably now. And for a number of interesting reasons I got to test the account creation a couple more times so that should work quite well by now as well. I see a few more people testing. A couple of comments: - for those who used this before last night (Robert, Thomas, David, Jocke, Willem) - you will need to save a change to the cloud storage before a new export to HTML is triggered... I guess I could have run this manually for each repository... actually, why don't I do that - Gaetan - I see a few hundred requests from you with failed authorization. Was this a bug somewhere or a hacking attempt? :-) - In general, if you test and things don't work as you expect, please discuss this here so I can either explain or fix the bugs... https://cloud.subsurface-divelog.org/user/email-address/dives.html Oh yeah, and several of you clicked on this link. Cute :-) But it does require you to remplace email-address with your actual email address - and you have to have that email address registered and cloud data populated before it will work. You can always use ssrft...@hohndel.org / geheim - but I'd really like it if a few more people tried the account setup procedure and put data on the server. While I check the logs to see if I can spot issues, I DO NOT look at the dives you upload. Hope this helps Just tested this quickly with daliy windows build 4.4.2-772. Opened subsurface. Settings, punched in ssrft...@hohndel.org / geheim as cloud storage parameters. Sync to cloud and save password locally. Cloud storage as default file. When i open subsurface i get unable to open git cache repository .. Could not find repository... When i hit open cloud storage i got a crash. Windows wasn't helpfull in giving me any notes about what or where things went south. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
I have similar issues with my account. Fresh build this lunchtime on my laptop. On trying to open cloud storage I get Git cache branch da...@acmelabs.co.uk no longer exists. Unable to look up revision 'da...@acmelabs.co.uk' On trying to save to cloud storage: Cannot connect to cloud server, working with local copy. No user name configuration in git repo. Creating commit failed -- David Tillotson___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On Wed, Jun 17, 2015 at 07:28:20PM -0700, Dirk Hohndel wrote: So while there are still some rough edges, I think this is taking shape quite nicely. I've seen five of you have tested the cloud storage so far - thanks for doing that. If you run into any problem, please post about them - I fixed a few more bugs, saving to the cloud storage should work more reliably now. And for a number of interesting reasons I got to test the account creation a couple more times so that should work quite well by now as well. I see a few more people testing. A couple of comments: - for those who used this before last night (Robert, Thomas, David, Jocke, Willem) - you will need to save a change to the cloud storage before a new export to HTML is triggered... I guess I could have run this manually for each repository... actually, why don't I do that - Gaetan - I see a few hundred requests from you with failed authorization. Was this a bug somewhere or a hacking attempt? :-) - In general, if you test and things don't work as you expect, please discuss this here so I can either explain or fix the bugs... https://cloud.subsurface-divelog.org/user/email-address/dives.html Oh yeah, and several of you clicked on this link. Cute :-) But it does require you to remplace email-address with your actual email address - and you have to have that email address registered and cloud data populated before it will work. You can always use ssrft...@hohndel.org / geheim - but I'd really like it if a few more people tried the account setup procedure and put data on the server. While I check the logs to see if I can spot issues, I DO NOT look at the dives you upload. Hope this helps /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On 18 Jun 2015, at 14:56, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jun 17, 2015 at 07:28:20PM -0700, Dirk Hohndel wrote: So while there are still some rough edges, I think this is taking shape quite nicely. I've seen five of you have tested the cloud storage so far - thanks for doing that. If you run into any problem, please post about them - I fixed a few more bugs, saving to the cloud storage should work more reliably now. And for a number of interesting reasons I got to test the account creation a couple more times so that should work quite well by now as well. I see a few more people testing. A couple of comments: - for those who used this before last night (Robert, Thomas, David, Jocke, Willem) - you will need to save a change to the cloud storage before a new export to HTML is triggered... I guess I could have run this manually for each repository... actually, why don't I do that - Gaetan - I see a few hundred requests from you with failed authorization. Was this a bug somewhere or a hacking attempt? :-) - In general, if you test and things don't work as you expect, please discuss this here so I can either explain or fix the bugs… Did a quick test. The dive numbers don’t match with the dates. The last dive by date should also have the highest number, logically that is. Seems like the export doesn’t care about the numbers in my log book and always starts from 1. /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On Thu, Jun 18, 2015 at 02:49:18PM +0100, David Tillotson wrote: I have similar issues with my account. Fresh build this lunchtime on my laptop. On trying to open cloud storage I get Git cache branch da...@acmelabs.co.uk no longer exists. Unable to look up revision 'da...@acmelabs.co.uk' So it looks like something is in inconsistent state. What's supposed to happen is this: once you verify the PIN your account is created and the git repository is initialized. When you save to cloud the first time, it should create the branch, both in the local cache repository and remotely. I have recreated an emptry repository for you on the server, could you delete the local cache as well (under ~/.local/share/Subsurface/Subsurface - the directory name is a hash of the remote path... I'm too lazy to calculate that right now... likely there's only one) and try again, please? On trying to save to cloud storage: Cannot connect to cloud server, working with local copy. No user name configuration in git repo. Creating commit failed That's what making me think that your local repo is corrupted as well. Earlier versions of Subsurface (as in - from a couple of days ago) sometimes did odd things there if they encountered an error. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Android Port)
On Sun, Jun 14, 2015 at 11:55 PM, Tomaz Canabrava tcanabr...@kde.org
wrote:
Grace, always do a rebase from master so your work is not hard to merge
later.
I'm doing the review right now.
Here are patches containing the work done so far.
To compile the mobile executable, call cmake with -DSUBSURFACE_MOBILE=True.
This
will result in a subsurface-mobile executable.
--
--
Grace K
From faf064b4b7e8b7b931e84ff2f3995a5169e1ac61 Mon Sep 17 00:00:00 2001
From: Grace Karanja gracie.karanj...@gmail.com
Date: Thu, 18 Jun 2015 09:13:30 +0300
Subject: [PATCH 21/22] Display more details
Show more dive info in the extended view of the dive.
Signed-off-by: Grace Karanja gracie.karanj...@gmail.com
---
qt-mobile/main.qml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qt-mobile/main.qml b/qt-mobile/main.qml
index e257477..8af0a9e 100644
--- a/qt-mobile/main.qml
+++ b/qt-mobile/main.qml
@@ -107,7 +107,13 @@ ApplicationWindow {
contentHeight: detailsView.height
clip: true
Row {
- Text { text: 'bNotes:/bbr/' + notes; wrapMode: Text.WordWrap; width: details.width }
+ Text { text:
+'bLocation: /b' + location +
+'brbAir temp: /b' + airtemp + ' b Water temp: /b' + watertemp +
+'brbSuit: /b' + suit +
+'brbBuddy: /b' + buddy +
+'brbDive Master: /b' + divemaster +
+'br/bNotes:/bbr/' + notes; wrapMode: Text.WordWrap; width: details.width }
}
}
}
--
2.4.4
From 49d59bdf3d4f61fc45f9dcb994d18715705c08f6 Mon Sep 17 00:00:00 2001
From: Grace Karanja gracie.karanj...@gmail.com
Date: Thu, 18 Jun 2015 09:12:52 +0300
Subject: [PATCH 20/22] Add more dive details to the DiveListModel
Add some more details to the model.
Signed-off-by: Grace Karanja gracie.karanj...@gmail.com
---
qt-models/divelistmodel.cpp | 80 +
qt-models/divelistmodel.h | 27 ---
2 files changed, 88 insertions(+), 19 deletions(-)
diff --git a/qt-models/divelistmodel.cpp b/qt-models/divelistmodel.cpp
index ad36096..add5af5 100644
--- a/qt-models/divelistmodel.cpp
+++ b/qt-models/divelistmodel.cpp
@@ -17,13 +17,7 @@ Dive::Dive(dive *d)
setDepth(get_depth_string(d-maxdepth));
setDuration(get_dive_duration_string(d-duration.seconds, h:,min));
- if (!d-watertemp.mkelvin)
- m_depth = ;
-
- if (get_units()-temperature == units::CELSIUS)
- m_depth = QString::number(mkelvin_to_C(d-watertemp.mkelvin), 'f', 1);
- else
- m_depth = QString::number(mkelvin_to_F(d-watertemp.mkelvin), 'f', 1);
+ setupDiveTempDetails();
weight_t tw = { total_weight(d) };
setWeight(weight_string(tw.grams));
@@ -33,6 +27,8 @@ Dive::Dive(dive *d)
setSac(QString::number(d-sac));
setLocation(get_dive_location(d));
setNotes(d-notes);
+ setBuddy(d-buddy);
+ setDivemaster(d-divemaster);
}
QString Dive::date() const
@@ -98,14 +94,14 @@ void Dive::setWeight(const QString weight)
{
m_weight = weight;
}
-QString Dive::temp() const
+QString Dive::airtemp() const
{
- return m_temp;
+ return m_airtemp;
}
-void Dive::setTemp(const QString temp)
+void Dive::setAirTemp(const QString airtemp)
{
- m_temp = temp;
+ m_airtemp = airtemp;
}
QString Dive::duration() const
{
@@ -170,6 +166,53 @@ void Dive::setTrip(const QString trip)
{
m_trip = trip;
}
+QString Dive::buddy() const
+{
+return m_buddy;
+}
+
+void Dive::setBuddy(const QString buddy)
+{
+m_buddy = buddy;
+}
+QString Dive::divemaster() const
+{
+return m_divemaster;
+}
+
+void Dive::setDivemaster(const QString divemaster)
+{
+m_divemaster = divemaster;
+}
+QString Dive::watertemp() const
+{
+ return m_watertemp;
+}
+
+void Dive::setWatertemp(const QString watertemp)
+{
+ m_watertemp = watertemp;
+}
+
+void Dive::setupDiveTempDetails()
+{
+ const char *unit;
+ double d_airTemp, d_waterTemp;
+
+ d_airTemp = get_temp_units(m_thisDive-airtemp.mkelvin, unit);
+ d_waterTemp = get_temp_units(m_thisDive-watertemp.mkelvin, unit);
+
+ setAirTemp(QString::number(d_airTemp) + unit);
+ setWatertemp(QString::number(d_waterTemp) + unit);
+
+ if (!m_thisDive-airtemp.mkelvin)
+ setAirTemp();
+
+ if (!m_thisDive-watertemp.mkelvin)
+ setWatertemp();
+}
+
+
@@ -212,8 +255,10 @@ QVariant DiveListModel::data(const QModelIndex index, int role) const
return dive.depth();
else if (role == DiveDurationRole)
return dive.duration();
- else if (role == DiveTemperatureRole)
- return dive.temp();
+ else if (role == DiveAirTemperatureRole)
+ return dive.airtemp();
+ else if (role == DiveWaterTemperatureRole)
+ return dive.watertemp();
else if (role == DiveWeightRole)
return dive.weight();
else if (role == DiveSuitRole)
@@ -228,6 +273,10 @@ QVariant DiveListModel::data(const QModelIndex index, int role) const
return dive.location();
else if (role == DiveNotesRole)
return dive.notes();
+ else if (role == DiveBuddyRole)
+ return dive.buddy();
+ else if (role == DiveMasterRole)
+ return
Re: Cloud storage and web view
Below, my first try with the cloud storage. On 18-06-15 04:28, Dirk Hohndel wrote: I've seen five of you have tested the cloud storage so far - thanks for doing that. If you run into any problem, please post about them - I fixed a few more bugs, saving to the cloud storage should work more reliably now. And for a number of interesting reasons I got to test the account creation a couple more times so that should work quite well by now as well. On my desktop machine. I use (for a long time already) the local git store as my primary data store for ssrf. Today, I filled the preferences for the cloud store and received the PIN correctly, and activated the cloud store (apparently) successfully. Did save to cloud and after that open cloud. The cloud seems to be populated with my divelog. That is, restarting ssrf, open cloud manually (did not default to cloud open), and the correct divelog shows. However. The https://cloud.subsurface-divelog.org/user/myemailadress/dives.html https://cloud.subsurface-divelog.org/user/%3Cemail-address%3E/dives.html reports (after logging in with correct credentials) a 404. Further, started on a second notebook from scratch. So no local log data, not even a ssrf installation. Installed the latest master (build myself), and ran ssrf. Started setting cloud preferences. Authenticated correctly. No PIN (as expected, because logging in with already activated credentials). Open cloud, and the log shows, so pulled data from the cloud. I see numerous issues on the notebook after opening the cloud (and at this point unclear to me whether is is related to the cloud store (or the location management for example)): - 1 specific divesite is missing. Apparently, there is some data corruption, that does not show on the desktop, but does show on the notebook. - The location list is not filled. - a save to cloud results in error No user name in git repo, creating commit failed. In addition. commit 7cf3ebc2f7b6 seems to introduce a SIGSEGV: strcmp(existing_filename, remote) aborts for remote=0 Both desktop and notebook are running Arch Linux. best, --jan ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Android Port)
Dirk, I'll do a proof read of them before you can apply wait for my ack. On Thu, Jun 18, 2015 at 12:26 PM, Grace Karanja gracie.karanj...@gmail.com wrote: On Sun, Jun 14, 2015 at 11:55 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Grace, always do a rebase from master so your work is not hard to merge later. I'm doing the review right now. Here are patches containing the work done so far. To compile the mobile executable, call cmake with -DSUBSURFACE_MOBILE=True. This will result in a subsurface-mobile executable. -- -- Grace K ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On Thu, Jun 18, 2015 at 03:57:37PM +0200, Jan Mulder wrote: Below, my first try with the cloud storage. Thanks for testing this! Things work for me and once I'm at that state I rely on you guys to show me all the ways that the code still breaks... On my desktop machine. I use (for a long time already) the local git store as my primary data store for ssrf. Today, I filled the preferences for the cloud store and received the PIN correctly, and activated the cloud store (apparently) successfully. Yes, your account shows as verified in the database Did save to cloud and after that open cloud. The cloud seems to be populated with my divelog. That is, restarting ssrf, open cloud manually (did not default to cloud open), and the correct divelog shows. Excellent. However. The https://cloud.subsurface-divelog.org/user/myemailadress/dives.html https://cloud.subsurface-divelog.org/user/%3Cemail-address%3E/dives.html reports (after logging in with correct credentials) a 404. Just to make sure, you did go to https://cloud.subsurface-divelog.org/user/jlmul...@xs4all.nl/dives.html and not to a URL with myemailaddress in the middle :-) I noticed earlier that the auto-creation of your HTML export triggered a bug and that the exporter would crash. I believe that's fixed now... but I haven't tried accessing the HTML export (again, in general I am planning to try not to use at your data - I actually set it up so that ONLY your credentials allow access that folder from your net - there is no admin account that could be (ab-)used to look at other people's data...) Further, started on a second notebook from scratch. So no local log data, not even a ssrf installation. Installed the latest master (build myself), and ran ssrf. Started setting cloud preferences. Authenticated correctly. No PIN (as expected, because logging in with already activated credentials). Yep - so that works as intended. Open cloud, and the log shows, so pulled data from the cloud. I see numerous issues on the notebook after opening the cloud (and at this point unclear to me whether is is related to the cloud store (or the location management for example)): - 1 specific divesite is missing. Apparently, there is some data corruption, that does not show on the desktop, but does show on the notebook. That's weird. Git is highly unlikely not to notice actual corruption. - The location list is not filled. Which location list? - a save to cloud results in error No user name in git repo, creating commit failed. Umm. Same bug as in David's report. I need to look at this to see how this is happening - I have never seen this. In addition. commit 7cf3ebc2f7b6 seems to introduce a SIGSEGV: strcmp(existing_filename, remote) aborts for remote=0 Both desktop and notebook are running Arch Linux. Duh. That's what I get for not using same_string()... I'll fix that right away, thanks for that report. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
Just retried. Still getting the same errors. The same happens with the setup using one of my mail aliases that I set up this afternoon, so shouldn't be historical corruption. There are 2 new local repos, both currently are only 68K. On 18 June 2015 15:57:35 BST, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 18, 2015 at 02:49:18PM +0100, David Tillotson wrote: I have similar issues with my account. Fresh build this lunchtime on my laptop. On trying to open cloud storage I get Git cache branch da...@acmelabs.co.uk no longer exists. Unable to look up revision 'da...@acmelabs.co.uk' So it looks like something is in inconsistent state. What's supposed to happen is this: once you verify the PIN your account is created and the git repository is initialized. When you save to cloud the first time, it should create the branch, both in the local cache repository and remotely. I have recreated an emptry repository for you on the server, could you delete the local cache as well (under ~/.local/share/Subsurface/Subsurface - the directory name is a hash of the remote path... I'm too lazy to calculate that right now... likely there's only one) and try again, please? On trying to save to cloud storage: Cannot connect to cloud server, working with local copy. No user name configuration in git repo. Creating commit failed That's what making me think that your local repo is corrupted as well. Earlier versions of Subsurface (as in - from a couple of days ago) sometimes did odd things there if they encountered an error. /D -- David Tillotson___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On 18-06-15 17:08, Dirk Hohndel wrote: Just to make sure, you did go to https://cloud.subsurface-divelog.org/user/jlmul...@xs4all.nl/dives.html and not to a URL with myemailaddress in the middle :-) Yes. I noticed earlier that the auto-creation of your HTML export triggered a bug and that the exporter would crash. I believe that's fixed now... but I haven't tried accessing the HTML export (again, in general I am planning to try not to use at your data - I actually set it up so that ONLY your credentials allow access that folder from your net - there is no admin account that could be (ab-)used to look at other people's data...) And indeed, it is fixed now. Nice :-) Open cloud, and the log shows, so pulled data from the cloud. I see numerous issues on the notebook after opening the cloud (and at this point unclear to me whether is is related to the cloud store (or the location management for example)): - 1 specific divesite is missing. Apparently, there is some data corruption, that does not show on the desktop, but does show on the notebook. That's weird. Git is highly unlikely not to notice actual corruption. Agreed that this is very weird. I will investigate further. - The location list is not filled. Which location list? The pop-up list on the notes tab containing all dive sites to chose from. I will also investigate further here. best, --jan ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 1 (VPM-B)
Hi, right now I'm getting first deco plans from the vpmb algorithm so It's time to add some ui option to switch between algorithms. For now, a simple check box in the planning section should be enough (just like for the recreational dives). Maybe later there will be some more parameters to specify. Do you want to do this as proposed or maybe you're busy and I should do it? Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On Thu, Jun 18, 2015 at 03:57:37PM +0200, Jan Mulder wrote: - a save to cloud results in error No user name in git repo, creating commit failed. This was a good one. I just pushed a fix. With newer libgit2 (which is required for cloud storage to work) we have an API to get the user / email to use as author for a commit. Except if git never got configured on your system, then those aren't set. And for strange reason the code doesn't fall back to just set a Subsurface default author but instead returned an error. Oops. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 1 (VPM-B)
Jan, Am 18.06.2015 um 21:11 schrieb Jan Darowski jan.darow...@gmail.com: I know, I just don't know the motives behind the proposal so I prefer to ask. I think this just was an offer to help with UI stuff if you cannot get it to work yourself. Best Robert ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [Patch] Fix planner notes gas change output logic
Thanks for the feedback, On 18 June 2015 at 16:16, Robert C. Helling rob...@euve10195.vserver.de wrote: Hi, Am 18.06.2015 um 02:09 schrieb Rick Walsh rickmwa...@gmail.com: However, I think a more intuitive output would be: depth dur. runtime gas 20m 1min 1min air 20m 5min 5min 20m 10min 15min EAN80 20m 5min 20min air 9m 1min 21min -for the segment of 1min duration leading up to the 21min runtime (we ascend to 9m), we are still breathing air 9m 0min 21min EAN80 -there is zero time at 9m, but this is where to change to EAN80 6m 17min 39min -keep breathing EAN80 0m 2min 41min Do you think this is a clear and reasonable approach? This is definitely a correct approach. It is not what I had in mind, though, but it is very close. These notes are supposedly copied to wet notes and taken underwater. So, to avoid task overloading, the display should really be minimal and contain no clutter. A 0min stop looks a bit weird to me. So my plan was to merge that segment with the preceding transition an thus place the ean80 there. After all, the printed gas indicates the diver should do a gas switch. Look at it from this point of view: the table row. 9m x min y min EANzz Should really be read as the instruction to the diver: Go to 9m. There switch to the gas. Then stay there until runtime y. Then go to the next line. At least that supports my intended way of doing things. BTW this whole discussion is a bit academic: gas switches without stop that we are worrying about do not appear in real dives. As no stops come with short shallow dives for which you would not take additional gases. Or we could resolve it by stating a gas change is automatically followed by a stop of at least one minute. After all the gas change takes some time. Not to mention esoteric topics like the oxygen window. I agree we're getting a bit academic. My problem with the gas change on an ascent only segment with a duration is that being consistent with the other stops, it implies we should be breathing that gas for that duration (i.e. on the ascent). For the option ignoring transitions, what do you think of having a zero duration segment, but not including the preceding ascent segment. That way we put the gas change at the correct depth, but indicate by a zero duration that there isn't a stop required. E.g. 20m 5min 20min air 9m 0min 21min EAN80 -there is zero time at 9m, but this is where to change to EAN80 6m 17min 39min -keep breathing EAN80 0m 2min 41min There are real cases where the gas change is done when a stop (for a duration) is not required. I'm halfway through an Advanced Nitrox and Deco Procedures course, which is largely why I'm suddenly paying more attention to dive planning. On two dives last week, I had a ceiling of 12 m at the end of my bottom time. Deco gas was 50% - so there was a gas change at 21 m, but a stop wasn't required. I did stop to switch gas, but it is technically possible to start the procedure during ascent, and do the actual switch without stopping for longer than a few seconds. Best Robert Ps: this is probably the longest email I ever typed on the phone. Ouch. Thanks for the effort. Rick ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [Patch] Fix planner notes gas change output logic
Hi, Am 18.06.2015 um 02:09 schrieb Rick Walsh rickmwa...@gmail.com: However, I think a more intuitive output would be: depth dur.runtime gas 20m 1min1minair 20m 5min5min 20m 10min 15min EAN80 20m 5min20min air 9m1min21min -for the segment of 1min duration leading up to the 21min runtime (we ascend to 9m), we are still breathing air 9m0min21min EAN80 -there is zero time at 9m, but this is where to change to EAN80 6m17min 39min -keep breathing EAN80 0m2min41min Do you think this is a clear and reasonable approach? This is definitely a correct approach. It is not what I had in mind, though, but it is very close. These notes are supposedly copied to wet notes and taken underwater. So, to avoid task overloading, the display should really be minimal and contain no clutter. A 0min stop looks a bit weird to me. So my plan was to merge that segment with the preceding transition an thus place the ean80 there. After all, the printed gas indicates the diver should do a gas switch. Look at it from this point of view: the table row. 9m x min y min EANzz Should really be read as the instruction to the diver: Go to 9m. There switch to the gas. Then stay there until runtime y. Then go to the next line. At least that supports my intended way of doing things. BTW this whole discussion is a bit academic: gas switches without stop that we are worrying about do not appear in real dives. As no stops come with short shallow dives for which you would not take additional gases. Or we could resolve it by stating a gas change is automatically followed by a stop of at least one minute. After all the gas change takes some time. Not to mention esoteric topics like the oxygen window. Best Robert Ps: this is probably the longest email I ever typed on the phone. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Cloud storage and web view
On Thu, Jun 18, 2015 at 4:28 AM, Dirk Hohndel d...@hohndel.org wrote: So while there are still some rough edges, I think this is taking shape quite nicely. Anyway, give it a try, let me know what you think. And if someone with better design skills than me wants to work on the theming / CSS - that might be good. :-) Wow There are so many new features that the next official release deserve a main version increment :) -- Davide https://vimeo.com/bocio/videos ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [Patch] Re-fix silly typo (was Current git no compilee)
Dirk, Am 18.06.2015 um 06:51 schrieb Dirk Hohndel d...@hohndel.org: I hear that working in flower arrangements is rather similar to the lifestyle of a dive master. Life can be difficult that way. Agreed I'm sure you'll do great! http://youtu.be/TNV1U34p6jk Best Robert___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 17 June 2015 at 19:51, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. thanks, your branch seems to be missing the patch to fix this: error: 'm__nstance' was not declared in this scope Q_ASSERT_X(m__nstance == NULL, WindowTitleUpdate, WindowTitleUpdate recreat ed!); [Patch] Re-fix silly typo (was Current git no compilee) lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [Patch] Fix planner notes gas change output logic
Jocke, On 18 Jun 2015, at 07:24, Joakim Bygdell j.bygd...@gmail.com wrote: The deep segments should look like this: depth duration runtime gas 30m 2min 2min EAN32 30m 27min 29min 30m 1min 30min air 30m 29min 59min 30m 1min 60min EAN32 30m 29min 89min I had to insert one minute segments where the gas switch happens for it to be displayed correctly. I think this is far too confusing, as there are many more lines than are required. Taking into account what I wrote in my previous mail, I think the rule should simply be (when not displaying transitions): All manual segements are displayed. For the deco, There is at most one line per depth. A depth is printed if there is a gas switch or a stop. Gas switches are always supposed to be done when the corresponding depth is reached. Does that make sense? Best Robert signature.asc Description: Message signed with OpenPGP using GPGMail ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
