Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Robert Helling
On 27.10.2014, at 04:27, Dirk Hohndel d...@hohndel.org wrote: Good morning, Robert appears to have stepped up to help our Willem to get this right, but the more people work on this and help figure out what's the right way to do things, the better. indeed, more people needed here. I cannot

Re: [PATCH 0/9] fix some warnings

2014-10-27 Thread Lubomir I. Ivanov
On 27 October 2014 05:18, Dirk Hohndel d...@hohndel.org wrote: On Sat, Oct 25, 2014 at 01:03:28PM +0300, Lubomir I. Ivanov wrote: please ignore anything in particular if you see fit. i'm not really advocating any of these. [PATCH 1/9] MainWindow: prevent a possible crash on re-plan [PATCH

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Dirk Hohndel
Good morning... On Mon, Oct 27, 2014 at 08:42:12AM +0100, Robert Helling wrote: Robert appears to have stepped up to help our Willem to get this right, but the more people work on this and help figure out what's the right way to do things, the better. indeed, more people needed here. I

Re: Two more rebreather patches

2014-10-27 Thread Rodrigo Severo
On Mon, Oct 27, 2014 at 12:37 PM, William Perry wmpe...@kadath.us wrote: I just finished by CCR training down in Bonaire last week so I don’t have a lot of experience, but I did find that minor depth changes did not impact the loop volume enough for me to feel the need to add diluent. My

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread William Perry
I can probably get my instructor to run a download against a bunch of shearwaters or Nitek Qs with the 4th cell monitoring if we need test data for subsurface or libdivecomputer. Maybe I can convince my wife that I need to buy the rebreather a bit earlier than planned so I can help… :) -bill

Re: Two more rebreather patches

2014-10-27 Thread William Perry
On Oct 27, 2014, at 10:42 AM, Rodrigo Severo rodr...@fabricadeideias.com wrote: On Mon, Oct 27, 2014 at 12:37 PM, William Perry wmpe...@kadath.us wrote: I just finished by CCR training down in Bonaire last week so I don’t have a lot of experience, but I did find that minor depth

Re: Two more rebreather patches

2014-10-27 Thread Paul Sargent
On Oct 27, 2014, at 03:42 PM, Rodrigo Severo rodr...@fabricadeideias.com wrote: Bill, I agree: 1/2 foot is noise, 10 m is significant. What value do you think we should use as limit? I just proposed 1 m on my previous email to Robert but I'm not sure if this value is big enough. What do

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Paul Sargent
On Oct 27, 2014, at 04:26 PM, William Perry wmpe...@kadath.us wrote: I can probably get my instructor to run a download against a bunch of shearwaters or Nitek Qs with the 4th cell monitoring if we need test data for subsurface or libdivecomputer. I've got tons of Shearwater data. Can

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 03:23:11PM +, Paul Sargent wrote: So who are the rebreather divers besides Willem who are helping to get this right and are especially testing this as thoroughly as possible. I'd hate to release 4.3 and announve rebreather support and then have to say never

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 11:26:52AM -0400, William Perry wrote: I can probably get my instructor to run a download against a bunch of shearwaters or Nitek Qs with the 4th cell monitoring if we need test data for subsurface or libdivecomputer. I'll leave this to the experts to ask for the data

Re: Two more rebreather patches

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 11:29:47AM -0400, William Perry wrote: I just finished by CCR training down in Bonaire last week so I don’t have a lot of experience, but I did find that minor depth changes did not impact the loop volume enough for me to feel the need to add diluent. My

[PATCH 1/2] Do not zero setpoint value when duplicate

2014-10-27 Thread Miika Turkia
We cannot zero setpoint value upon import if the current and previous values are zero. This is because on setpoint context a value of 0 means open circuit. Signed-off-by: Miika Turkia miika.tur...@gmail.com --- dive.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git

Re: [PATCH] Poseidon MK6 import

2014-10-27 Thread Paul Sargent
Ok, I'll try to put some time aside over the next couple of days to have a play. On Oct 27, 2014, at 05:05 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, Oct 27, 2014 at 03:23:11PM +, Paul Sargent wrote: So who are the rebreather divers besides Willem who are helping to get this

towards 4.3

2014-10-27 Thread Dirk Hohndel
A few notes... - I would like to have a first beta released no later than Nov 10. - I have fixed the script that created the daily builds. It was still uploading them to the old site. :facepalm: - I will make a go/no-go decision on some of the features in a week or so; what that means is that

Re: Two more rebreather patches

2014-10-27 Thread Rodrigo Severo
On Mon, Oct 27, 2014 at 2:10 PM, Dirk Hohndel d...@hohndel.org wrote: With the benefit of absolutely know subject matter expertize, I think what would make sense is to smooth out the depth graph. Something like a gliding average across one minute - that should remove jitter and the quick pop

Re: towards 4.3

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 01:34:37PM -0400, John Van Ostrand wrote: What other things are partly done and likely / unlikely to be finished in the next two weeks? Any chance the Cochran import can make it in? That's more a libdivecomputer question. Or are there Subsurface patches as well

[PATCH 2/6] Set a max value for the custom text in OSTC3

2014-10-27 Thread Anton Lundin
The device supports a up to 60 chars custom text. This limits the LineEdit to that amount, so users see when they reach the max limit. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.ui | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 6/6] Cleanup syntax and styling in Configure DC

2014-10-27 Thread Anton Lundin
This cleans up some styling and syntax in the Configure Dive Computer code path. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/configuredivecomputerthreads.cpp

[PATCH 2/8] Change the OSTC3 copied ui to be sane for OSTC

2014-10-27 Thread Anton Lundin
The OSTC supports a bit different functionalities than the OSTC3 does. The unsupported bits are setBrightness setCalibrationGas setCompassGain setDiveMode - Bult into setDecoType (OC/CCR) setDiveModeColor - Lots of different colors setFlipScreen setLanguage - Controlled via flashing different

[PATCH 5/8] Decode configuration data from OSTC

2014-10-27 Thread Anton Lundin
This adds code to decode the configuration blocks from the OSTC. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 250 +++ 1 file changed, 250 insertions(+) diff --git a/configuredivecomputerthreads.cpp

[PATCH 7/8] Debug code for OSTC CF

2014-10-27 Thread Anton Lundin
This code is to debug the rest of the existing CF's, so we can look at the rest of the values. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/configuredivecomputerthreads.cpp

[PATCH 6/8] Decode CF configuration data from OSTC

2014-10-27 Thread Anton Lundin
This adds code to decode the custom functions data. We only decode the relevant CF's. The relevant ones are chosen by which ones have corresponding settings in the OSTC3. Signed-off-by: Anton Lundin gla...@acc.umu.se --- configuredivecomputerthreads.cpp | 57

[PATCH 3/8] Change the salinity setting for OSTC

2014-10-27 Thread Anton Lundin
On the OSTC's the salinity is in kg/l and is stored as kg/l * 100 Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 4 ++-- qt-ui/configuredivecomputerdialog.ui | 11 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 0/9] fix some warnings

2014-10-27 Thread Lubomir I. Ivanov
On 27 October 2014 22:44, Robert Helling hell...@atdotde.de wrote: On 27 Oct 2014, at 21:03, Lubomir I. Ivanov neolit...@gmail.com wrote: this is Robert's code (CC) so perhaps he or others have some ideas. on a brief look, DiveLogExportDialog::export_depths() would not always produce a

[PATCH 2/2] Create a delegate for depth and gas components

2014-10-27 Thread Anton Lundin
This creates a delegate to simplify the handling of gas components and the change depth. Signed-off-by: Anton Lundin gla...@acc.umu.se --- qt-ui/configuredivecomputerdialog.cpp | 44 +++ qt-ui/configuredivecomputerdialog.h | 20 2 files changed,

Re: [PATCH 3/6] Change the OSTC3 macros to have a ; in the end

2014-10-27 Thread Linus Torvalds
On Mon, Oct 27, 2014 at 12:37 PM, Anton Lundin gla...@acc.umu.se wrote: -#define READ_SETTING(_OSTC3_SETTING, _DEVICE_DETAIL) \ +#define READ_SETTING(_OSTC3_SETTING, _DEVICE_DETAIL); \ That extra ';' as the first token in the macro definition seems entirely broken. rc

Re: [PATCH 3/6] Change the OSTC3 macros to have a ; in the end

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 02:13:54PM -0700, Linus Torvalds wrote: On Mon, Oct 27, 2014 at 12:37 PM, Anton Lundin gla...@acc.umu.se wrote: -#define READ_SETTING(_OSTC3_SETTING, _DEVICE_DETAIL) \ +#define READ_SETTING(_OSTC3_SETTING, _DEVICE_DETAIL); \ That extra ';' as the first token in

Re: OSTC Configuration

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 10:04:57PM +0100, Anton Lundin wrote: On 27 October, 2014 - Anton Lundin wrote: Here is the results of my last little project. This stack of patches adds support for reading and writing the config blocks of the OSTC devices. All this bit magic was a bit tricky to

Re: Create delegates for Config gas tables

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 10:12:44PM +0100, Anton Lundin wrote: These patches was as far as i manage to get in my delegate handling. These ones looks ok, but the ComboBox one would be better if it saved the string value instead of the numeric value after you clicked on it, and you managed to

Re: Two more rebreather patches

2014-10-27 Thread Dirk Hohndel
On Mon, Oct 27, 2014 at 08:14:44PM +0100, Anton Lundin wrote: On 27 October, 2014 - Gaetan Bisson wrote: [2014-10-24 16:48:34 +0200] Robert Helling: what happened to Gaetan’s attempts at coming up with a UI implementation? I wanted to do something basic and Anton convinced me that

Re: Patches to add basic support for the Suunto EON Steel

2014-10-27 Thread Linus Torvalds
On Mon, Oct 27, 2014 at 3:57 PM, Jef Driesen j...@libdivecomputer.org wrote: On 23-10-14 00:34, Linus Torvalds wrote: Both the windows and non-libusb builds are broken. I have no sane way to test the windows build issues. But I fixed the non-libusb build by moving the ifdef around a bit, and I

[PATCH] Commented out section waiting on commit from libdivecomputer. It relied on DC_EVENT_BATTERY.

2014-10-27 Thread John Van Ostrand
Signed-off-by: John Van Ostrand j...@vanostrand.com --- cochran.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cochran.c b/cochran.c index 9e31f55..7651441 100644 --- a/cochran.c +++ b/cochran.c @@ -351,11 +351,13 @@ int cochran_dive_event(struct divecomputer *dc, const unsigned char

Re: [PATCH] Commented out section waiting on commit from libdivecomputer. It relied on DC_EVENT_BATTERY.

2014-10-27 Thread Linus Torvalds
On Mon, Oct 27, 2014 at 5:51 PM, John Van Ostrand j...@vanostrand.com wrote: +/* waiting for libdivecomputer patch case 0xC2: // Low battery warning add_event(dc, seconds, SAMPLE_EVENT_BATTERY,

[PATCH] Removed dependence on not yet released libdivecomputer code.

2014-10-27 Thread John Van Ostrand
Signed-off-by: John Van Ostrand j...@vanosrand.com --- cochran.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cochran.c b/cochran.c index 9e31f55..b3ba7b4 100644 --- a/cochran.c +++ b/cochran.c @@ -351,11 +351,13 @@ int cochran_dive_event(struct divecomputer *dc, const unsigned char *s,

Re: [PATCH] Removed dependence on not yet released libdivecomputer code.

2014-10-27 Thread Dirk Hohndel
BTW, did you check git master…? :-) /D On Oct 27, 2014, at 7:02 PM, John Van Ostrand j...@vanostrand.com wrote: Signed-off-by: John Van Ostrand j...@vanosrand.com --- cochran.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cochran.c b/cochran.c index 9e31f55..b3ba7b4 100644 ---