Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 22:03:52 Dirk Hohndel wrote: > I tried testing on Ubuntu, also in a VM on the same Mac. But I can't seem > to figure out which package to install to get the QtBluetooth stuff. Any > suggestion on the right package names? This needs to be added to the > INSTALL file, too... I

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 10:03:52PM -0700, Dirk Hohndel wrote: > On Mon, Jul 06, 2015 at 11:00:08PM +0300, Claudiu Olteanu wrote: > > Hi, > > > > I wanted to let you know that after I did the firmware upgrade everything > > works fine. I tested both devices on all three environments > > (OpenSuse,

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 11:00:08PM +0300, Claudiu Olteanu wrote: > Hi, > > I wanted to let you know that after I did the firmware upgrade everything > works fine. I tested both devices on all three environments > (OpenSuse, Fedora, ArchLinux) and I didn't encounter any problem. > > Now we just ha

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 02:02:54PM -0700, Thiago Macieira wrote: > On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > > > That's slightly weird :-) > > > > I know that this is weird but there is no HostPoweredOn enu

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Oh yeah :). I don't know what was in my mind when I did that :)). On Tue, Jul 7, 2015 at 12:02 AM, Thiago Macieira wrote: > On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > > > That's slightly weird :-) > > > > I

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 23:19:58 Claudiu Olteanu wrote: > > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > That's slightly weird :-) > > I know that this is weird but there is no HostPoweredOn enum :-). It can be > either off, connectable, discoverable or discoverable limi

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Claudiu Olteanu
Sorry, my mistake! Somehow I deleted the qtserialbluetooth.cpp source from SUBSURFACE_CORE_LIB_SRCS list :-). I managed to compile the project with Qt5.5.0. I saw that Bluetooth connectivity doesn't work for the moment with this version. I will investigate it tomorrow.

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Hi Thiago, > + bool on = !(mode == QBluetoothLocalDevice::HostPoweredOff); > > That's slightly weird :-) I know that this is weird but there is no HostPoweredOn enum :-). It can be either off, connectable, discoverable or discoverable limited inquiry. Therefore I choose to use !(mode == QB

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 11:00:08PM +0300, Claudiu Olteanu wrote: > Hi, > > I wanted to let you know that after I did the firmware upgrade everything > works fine. I tested both devices on all three environments > (OpenSuse, Fedora, ArchLinux) and I didn't encounter any problem. > > Now we just ha

[PATCH] OSTCTools - Add unsigned char variable

2015-07-06 Thread Salvador Cuñat
In commit 22bfc49 an explicit cast to (char *) was introduced to silence some compiler warnings, but an (unsigned char *) is needed if related values are expected to be greater than 127 or we will get the usual weirdnesses. Just introduce such variable and use it where needed. Signed-off-by: Salv

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 23:00:08 Claudiu Olteanu wrote: > Thiago, do you have a dive computer with Bluetooth support? Do you > believe that you can help me with some tests? No, I don't have one. I could probably borrow one from Dirk, but please don't expect a lot of availability to do debugging..

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Claudiu Olteanu
Hi, I wanted to let you know that after I did the firmware upgrade everything works fine. I tested both devices on all three environments (OpenSuse, Fedora, ArchLinux) and I didn't encounter any problem. Now we just have to figure out why Dirk's devices don't work. Dirk, do you have other environ

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 17:42:00 Claudiu Olteanu wrote: [mostly cut] Hello Claudiiu The patches look good. They do what we had discussed previously. My comments are only nitpicks and suggestions for coding style in the future. There's no need to change anything now. > + bool on = !(mode =

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 21:41:37 Claudiu Olteanu wrote: > libsubsurface_corelib.a(libdivecomputer.c.o): In function > `do_libdivecomputer_import': > /home/claudiu/gsoc/subsurface/libdivecomputer.c:930: undefined reference to > `dc_serial_qt_open' > > The method is declared as external "C" and is im

remove unused icons

2015-07-06 Thread Tomaz Canabrava
So, I just send a bunch of icons for luisa so she can take a look at them and save us I found out those old icons laying around. From 611a7d28f9b7647437e585036e2dba5949a11c93 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 6 Jul 2015 16:28:08 -0300 Subject: [PATCH] Removed unused icons

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Claudiu Olteanu
Sorry for the late response but I decided to try again to compile the Subsurface project with Qt 5.5.0. After I read carefully the log messages I find out what caused the problem. Apparently the headers from two libraries were missing (mesa-libGL-devel and libdrm-devel). Now I receive an undefin

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Dirk Hohndel
On Tue, Jul 07, 2015 at 03:53:35AM +1000, Rick Walsh wrote: > Our local sea conditions change rapidly. Frequently, the scheduled dive > site is altered an hour before the boat leaves. Or a boat is cancelled > because not enough people booked onto it. Either way, much of the time we > end up divi

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Rick Walsh
On 7 Jul 2015 1:55 am, "Dirk Hohndel" wrote: > > On Mon, Jul 06, 2015 at 05:27:45PM +0200, Anton Lundin wrote: > > > > Also a simple ui for the planner would be on my wishlist =) > > > > > > Not so sure about this one. There are so many options plus the smaller > > > screen size. And you can't pri

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Thiago Macieira
On Monday 06 July 2015 08:20:19 Dirk Hohndel wrote: > Pull requests have advantages for GSoC purposes as they make it much > easier for me to ask the mentor to go through them, sign off on the > patches and then I can pull them. But as Lubomir said, that's optional. And I've just reviewed, but the

GSoC Status - Week 6 (VPM-B)

2015-07-06 Thread Jan Darowski
Hi! This week I spent mostly on testing and refactoring my commits. I also started the promised article and checked how the Boyle's law compensation should work. I still haven't discovered where some of the result differences come from, I want to finish it this week but it's hard to predict how mu

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
> > Actually, here's one. The fake open function for the OSTC 2N. That could > have been its own commit, added before the next commit that adds all the > qtserialbluetooth stuff. That's a simple example, but maybe it illustrates > what I mean. > It is funny that in the beginning I did an isolated

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 05:27:45PM +0200, Anton Lundin wrote: > > > Also a simple ui for the planner would be on my wishlist =) > > > > Not so sure about this one. There are so many options plus the smaller > > screen size. And you can't print. Would people REALLY use that instead of > > doing thi

Re: [PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Dirk Hohndel
Hi CLaudiu On Mon, Jul 06, 2015 at 05:42:00PM +0300, Claudiu Olteanu wrote: > Hi there, > > I attached you some patches which add the QtBluetooth serial implementation. > The Bluetooth download mode is accessible from the DownloadFromDiveComputer > widget. > > In order to connect to a Bluetooth

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 05:33:00PM +0300, Claudiu Olteanu wrote: > Hi, > > These patches create a generic way to represent any type of serial > communication. They are used to create a custom serial implementation > for HW_OSTC3 and SHEARWATER families. This looks good to me. I'll add these to o

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Anton Lundin
On 06 July, 2015 - Dirk Hohndel wrote: > On Mon, Jul 06, 2015 at 09:47:42AM +0200, Anton Lundin wrote: > > > Also a simple ui for the planner would be on my wishlist =) > > Not so sure about this one. There are so many options plus the smaller > screen size. And you can't print. Would people REAL

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:17:02PM +0300, Claudiu Olteanu wrote: > Hi Lubomir, > > Thanks for the info! > > Yeah, probably I shouldn't named the thread "PULL REQUEST". > > Since these are the differences between my repository > and the Subsurface' one, I thought that the process is similar > wit

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:07:02PM +0300, Lubomir I. Ivanov wrote: > On 6 July 2015 at 17:33, Claudiu Olteanu > wrote: > > Hi, > > > > These patches create a generic way to represent any type of serial > > communication. They are used to create a custom serial implementation > > for HW_OSTC3 and

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Claudiu Olteanu
Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread "PULL REQUEST". Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull request. Also I knew that Dirk prefers patches instead of pull requests.

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Lubomir I. Ivanov
On 6 July 2015 at 17:33, Claudiu Olteanu wrote: > Hi, > > These patches create a generic way to represent any type of serial > communication. They are used to create a custom serial implementation > for HW_OSTC3 and SHEARWATER families. > hey, Claudiu. just to point out that if you attach the p

[PULL REQUEST] Subsurface branch - QtBluetooth serial implementation

2015-07-06 Thread Claudiu Olteanu
Hi there, I attached you some patches which add the QtBluetooth serial implementation. The Bluetooth download mode is accessible from the DownloadFromDiveComputer widget. In order to connect to a Bluetooth device I decided to remove the SDP discovery because it doesn't work for all devices. For t

[PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Claudiu Olteanu
Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial implementation for HW_OSTC3 and SHEARWATER families. Claudiu From 05d830371f2bce35820bebb7419ed27946b3a658 Mon Sep 17 00:00:00 2001 From: Claudiu Olteanu Date: Sat, 27 J

Re: dive plan test

2015-07-06 Thread Robert C. Helling
> On 06 Jul 2015, at 15:51, Dirk Hohndel wrote: > > On Mon, Jul 06, 2015 at 06:36:58AM -0700, Dirk Hohndel wrote: >> >> I seem to get 107 with the latest build. 9/9/9/3 m/min for ascent. >> GF 100/100 >> last stop at 6 >> drop down to depth and 30 minutes at 79m >> 0 min minimum switch duration

Re: dive plan test

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:36:58AM -0700, Dirk Hohndel wrote: > > I seem to get 107 with the latest build. 9/9/9/3 m/min for ascent. > GF 100/100 > last stop at 6 > drop down to depth and 30 minutes at 79m > 0 min minimum switch duration > > depth duration runtime gas > 79m 3min 3min (15/45) > 79

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 09:56:20AM -0300, Rodrigo Severo wrote: > On Mon, Jul 6, 2015 at 4:24 AM, Henrik Brautaset Aronsen > wrote: > > > > On Sun, Jul 5, 2015 at 11:03 PM, Rick Walsh wrote: > >> > >> Serious question: does anyone switch to 50% at 22m? > > > > > > For tank MOD markings around me

Re: dive plan test

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 01:00:54PM +0200, Robert C. Helling wrote: > Dirk, > > > On 05 Jul 2015, at 20:47, Dirk Hohndel wrote: > > > > Thank you. Much appreciated. I'm reasonably certain that I'm just missing > > some setting that gets set up in the full app but does not get set up in > > TestPl

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 11:55:38AM +0300, Grace Karanja wrote: > On Mon, Jul 6, 2015 at 1:51 AM, Dirk Hohndel wrote: > > Things looks nice, great progress. Styling is a bit off on my display (text > > seems to be too close to the bottom of the surrounding box) but it's quite > > usable already. It

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 09:47:42AM +0200, Anton Lundin wrote: > ... > > > and > > > - Spend time on improving Android compilation. As the app has only been > > > tested > > > on desktop, we will need to run it on Android for better testing. > > > > Definitely. Please keep asking Anton(glance) to

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-06 Thread Matthias Heinrichs
When I manage to connect to the OSTC 2 device and to initiate the data transfer I get the same result. It gets stuck somewhere in the middle. The libdivecomputer back-end initiate a read request for a 1024 buffer and can read only 923 bytes from device's buffer. I will let you know if the new fir

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-06 Thread Rodrigo Severo
On Mon, Jul 6, 2015 at 4:24 AM, Henrik Brautaset Aronsen wrote: > > On Sun, Jul 5, 2015 at 11:03 PM, Rick Walsh wrote: >> >> Serious question: does anyone switch to 50% at 22m? > > > For tank MOD markings around me usually round to the nearest 3 (meters). So > 21 meters (not 22) for 50% and 6 m

Re: dive plan test

2015-07-06 Thread Robert C. Helling
Dirk, > On 05 Jul 2015, at 20:47, Dirk Hohndel wrote: > > Thank you. Much appreciated. I'm reasonably certain that I'm just missing > some setting that gets set up in the full app but does not get set up in > TestPlanner. I found three things: 1) I think most important: you have a typo in the

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Grace Karanja
On Mon, Jul 6, 2015 at 1:51 AM, Dirk Hohndel wrote: > Hi Grace > > On Sun, Jul 05, 2015 at 11:00:31PM +0300, Grace Karanja wrote: > > > > This week, I managed the following:- > > > > - Adding a preferences dialog for the user to store cloud credentials. > > - Loading dives/Saving them to the clou

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Anton Lundin
On 05 July, 2015 - Dirk Hohndel wrote: > Hi Grace > > On Sun, Jul 05, 2015 at 11:00:31PM +0300, Grace Karanja wrote: ... > > and > > - Spend time on improving Android compilation. As the app has only been > > tested > > on desktop, we will need to run it on Android for better testing. > > Defin

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-06 Thread Henrik Brautaset Aronsen
On Sun, Jul 5, 2015 at 11:03 PM, Rick Walsh wrote: > Serious question: does anyone switch to 50% at 22m? > For tank MOD markings around me usually round to the nearest 3 (meters). So 21 meters (not 22) for 50% and 6 meters (not 5) for o2. Etc. Also to the nearest 10ft. Henrik

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-06 Thread Anton Lundin
On 06 July, 2015 - Robert C. Helling wrote: > > > On 05 Jul 2015, at 21:31, Dirk Hohndel wrote: > > > > On Sun, Jul 05, 2015 at 12:11:15PM -0700, Linus Torvalds wrote: > >> On Sun, Jul 5, 2015 at 11:56 AM, Dirk Hohndel wrote: > >>> static inline depth_t gas_mod(struct gasmix *mix, pressure_t p