Re: new APK with smaller action button

2017-08-03 Thread Joakim Bygdell
On 4 August 2017 at 06:09, Dirk Hohndel wrote: > > > On Aug 3, 2017, at 8:01 PM, Chirana Gheorghita Eugeniu Theodor < > off...@adaptcom.ro> wrote: > > > > Looks ok but small issues on the size of the screens. > > In show gps fixes text is positioned out of the screen and in

Re: Subsurface-mobile crash on deleting dive from dive list

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 3:49 PM, Rick Walsh wrote: > > Hi, > > This is not a new bug, and has been reported before, but I think it's one > that should be eliminated before the next release. When deleting a dive from > the dive list (select the dive from the list but hold

Re: new APK with smaller action button

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 8:01 PM, Chirana Gheorghita Eugeniu Theodor > wrote: > > Looks ok but small issues on the size of the screens. > In show gps fixes text is positioned out of the screen and in each screen > there is a remainant of the old one onbthe left side. The

Re: new APK with smaller action button

2017-08-03 Thread Chirana Gheorghita Eugeniu Theodor
Looks ok but small issues on the size of the screens. In show gps fixes text is positioned out of the screen and in each screen there is a remainant of the old one onbthe left side. On Aug 4, 2017 01:01, "Davide DB" wrote: > Action Burton much better. > > I dont have the old

Re: QtLocation map updates

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 6:54 AM, Dirk Hohndel wrote: > > >> On Aug 3, 2017, at 4:36 AM, Jan Mulder wrote: > Suspicious line in the console: > > qrc:/MapWidget.qml:41: Error: Cannot assign [undefined] to > QDeclarativeGeoMapType* >

Subsurface-mobile crash on deleting dive from dive list

2017-08-03 Thread Rick Walsh
Hi, This is not a new bug, and has been reported before, but I think it's one that should be eliminated before the next release. When deleting a dive from the dive list (select the dive from the list but hold down until the trash icon appears, then select the trash icon), the app will crash...

Re: new APK with smaller action button

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 3:34 PM, Rick Walsh wrote: > > > > On 4 August 2017 at 08:01, Davide DB > wrote: > Action Burton much better. > > I agree > > I dont have the old apk right now but Text fields should occupy the

Re: new APK with smaller action button

2017-08-03 Thread Rick Walsh
On 4 August 2017 at 08:01, Davide DB wrote: > Action Burton much better. > > I agree > I dont have the old apk right now but Text fields should occupy the entire > horizontal space. I cannot even see my email. > > That bug has been around for a little while now but should

new APK with smaller action button

2017-08-03 Thread Dirk Hohndel
Thanks to Thomas noticing this and Marco's quick fix we have a new APK with much more appropriately sized action button. http://subsurface-divelog.org/downloads/test/Subsurface-mobile-4.6.4.699-arm.apk I'd be interested to see what others think - I like it! With my vacation trip starting

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Robert Helling
Hi Linus, > On 3. Aug 2017, at 21:03, Linus Torvalds > wrote: > > It *should* be straightforward to fix, but it just looks nasty to > really do. We don't even have a helper function to turn gas volume > into a pressure value. > > The planner tries to do it in

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Linus Torvalds
On Thu, Aug 3, 2017 at 11:20 AM, Linus Torvalds wrote: > > Let me check. I *think* it's going to be trivial to fix. Patch sent. The SAC rate might end up being more complex, but we've never done that correctly before, so it's not like it's all that noticeable.

[PATCH] Fix Poseidon MkVI txt file import sensor pressures

2017-08-03 Thread Linus Torvalds
From: Linus Torvalds Date: Thu, 3 Aug 2017 11:34:20 -0700 Subject: [PATCH] Fix Poseidon MkVI txt file import sensor pressures When I unified the sample pressures in commit 11a0c0cc7018 ("Unify sample pressure and o2pressure as pressure[2] array") I did all the

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Linus Torvalds
On Thu, Aug 3, 2017 at 11:15 AM, Linus Torvalds wrote: > > Ahh. It's a big in parse_txt_file(). Will fix this one too. Thanks for > noticing. The bug was that while we set the pressures correctly, we didn't set any sensor value at all. The incorrect change was

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Linus Torvalds
On Thu, Aug 3, 2017 at 12:33 AM, Anton Lundin wrote: > > I looked at the MkVI test data we have laying in the dives directory, > and the pressure graphs there doesn't look right. > > If I import dives/Poseidon_MkVILog.txt into a clean logbook on current > master, I just get one

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Linus Torvalds
On Wed, Aug 2, 2017 at 11:44 PM, Anton Lundin wrote: > > On the subject of SAC rate, when we interpolate the SAC between a start > and end pressure, we currently do that on _pressure_, as pressure_time. > > Since you made our gas volume calculations more correct, Ie factor for

Re: QtLocation map updates

2017-08-03 Thread Lubomir I. Ivanov
On 3 August 2017 at 14:15, Lubomir I. Ivanov wrote: > On 3 August 2017 at 09:06, Dirk Hohndel wrote: >> >>> On Aug 2, 2017, at 6:11 PM, Dirk Hohndel wrote: >>> >>> On Aug 2, 2017, at 1:38 PM, Lubomir I. Ivanov

Re: latest windows build

2017-08-03 Thread Rainer Mohr
OK, Export has been updated to calculate the sample rate based on the duration and the number of samples (only if its 0 in the database). Found one dive that gives me a sample rate of 7 seconds (dive 100) which is probably bogus, but that is thanks to the duration I get from the importing

Re: latest windows build

2017-08-03 Thread Rainer Mohr
Hi Miika, That is strange, yes. I do have a few dives from John that have a sample rate of 0 in the database. There is one DLD on the server containing his last dive only and that has a correct sample rate of 10 seconds. But this file was uploaded after the dive had already been imported, so

Re: latest windows build

2017-08-03 Thread Miika Turkia
On Wed, Aug 2, 2017 at 3:47 PM, John Smith wrote: > >> >>> 5. However import from Divelogs, although it seems to work, the drawing of >>> the profile has a few issues >> >> Ugh,. "A few issues". It looks like all your samples are lost, or more >> likely they are there but

Re: QtLocation map updates

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 4:36 AM, Jan Mulder wrote: Suspicious line in the console: qrc:/MapWidget.qml:41: Error: Cannot assign [undefined] to QDeclarativeGeoMapType* >>> >>> the map plugin is not being found. We need a better error message for that

Re: Size of Kirigami controls in Subsurface-mobile

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 4:21 AM, Marco Martin wrote: > > now kirigami master should have better sizes for the handles and action > buttons Thank you. I'll try to get a new APK up for testing. /D ___ subsurface mailing list

Re: Travis CI problem

2017-08-03 Thread Dirk Hohndel
> On Aug 3, 2017, at 5:48 AM, Robert Helling wrote: > > it seems, the recent switching to googlemaps broke the build on Travis CI > (which means PRs do not get through). PRs go through, they just are marked as having failed a test. The reason for the Travis failure is a bit

Re: QtLocation map updates

2017-08-03 Thread Jan Mulder
On 03-08-17 13:14, Jan Mulder wrote: On 03-08-17 12:50, Lubomir I. Ivanov wrote: On 3 August 2017 at 11:03, Jan Mulder wrote: On 03-08-17 08:06, Dirk Hohndel wrote: Actually, I pulled your proposed changes and added some of mine on top. This seems to be working ok based

Re: QtLocation map updates

2017-08-03 Thread Lubomir I. Ivanov
On 3 August 2017 at 09:06, Dirk Hohndel wrote: > >> On Aug 2, 2017, at 6:11 PM, Dirk Hohndel wrote: >> >> >>> On Aug 2, 2017, at 1:38 PM, Lubomir I. Ivanov wrote: >>> >>> i started with the esri -> googlemaps plugin transition, but i

Re: QtLocation map updates

2017-08-03 Thread Jan Mulder
On 03-08-17 12:50, Lubomir I. Ivanov wrote: On 3 August 2017 at 11:03, Jan Mulder wrote: On 03-08-17 08:06, Dirk Hohndel wrote: Actually, I pulled your proposed changes and added some of mine on top. This seems to be working ok based on my minimal testing - more work is

Re: QtLocation map updates

2017-08-03 Thread Lubomir I. Ivanov
On 3 August 2017 at 11:03, Jan Mulder wrote: > On 03-08-17 08:06, Dirk Hohndel wrote: > >> >> Actually, I pulled your proposed changes and added some of mine on top. >> This seems to be working ok based on my minimal testing - more work >> is definitely needed to test this on

Re: Size of Kirigami controls in Subsurface-mobile

2017-08-03 Thread Marco Martin
seems is due to a recent change in kirigami as the gallery app built from master has the same bigger handles size, i'm bisecting now to see when and what the change has been On Wed, Aug 2, 2017 at 10:57 PM, Dirk Hohndel wrote: > > On Aug 2, 2017, at 1:50 PM, Marco Martin

Re: QtLocation map updates

2017-08-03 Thread Jan Mulder
On 03-08-17 08:06, Dirk Hohndel wrote: Actually, I pulled your proposed changes and added some of mine on top. This seems to be working ok based on my minimal testing - more work is definitely needed to test this on all our platforms... Hmm. My self build tree (from current master) has a

Re: Real support for multiple concurrent sensors..

2017-08-03 Thread Anton Lundin
On 27 July, 2017 - Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 12:43 PM, Linus Torvalds > wrote: > > > > Also, there are a few things that never worked and that I'd like to > > make work, like just making the "Info window" show all the pressures > > that we're

Re: QtLocation map updates

2017-08-03 Thread Dirk Hohndel
> On Aug 2, 2017, at 6:11 PM, Dirk Hohndel wrote: > > >> On Aug 2, 2017, at 1:38 PM, Lubomir I. Ivanov wrote: >> >> On 2 August 2017 at 22:19, Linus Torvalds >> wrote: >>> On Wed, Aug 2, 2017 at 12:11 PM, Lubomir I.