Re: [PATCH] Improved adding images

2015-03-15 Thread Jan Darowski
, 2015 at 11:01:06AM +0100, Jan Darowski wrote: 1) To be honest I'm not sure where it comes from, seems like QtDesigner chenged it... OK, that makes sense. 2) I think this qstrdup can and should be removed... I used qstrdup instead of strdup (they work the same) because somewhere else

Re: [PATCH] Improved adding images

2015-03-16 Thread Jan Darowski
wrote: On Sun, Mar 15, 2015 at 10:33:53PM +0100, Jan Darowski wrote: I've cleaned whitespaces, removed completely qstrdump (left one copy_string where it was needed), merged 2 later patches into one (3. was just changing message from 2.), changed author of the commits to match Signed-off

Re: Proposal

2015-03-25 Thread Jan Darowski
discovered during the implementation. And I need to dive into the Subsurface code before starting coding to know how to organize it and make compatible with other parts, like the case from point 2 2015-03-25 10:07 GMT+01:00 Robert Helling hell...@atdotde.de: Jan, On 24.03.2015, at 21:34, Jan Darowski

Proposal

2015-03-24 Thread Jan Darowski
Hi! Here is my proposal for the GSoC. I believe it's the last thing from the projects checklist so if you have any suggestions on how I could improve it, please let me know. Jan Darowski subsurface.pdf Description: Adobe PDF document ___ subsurface

Re: [PATCH] Improved adding images

2015-03-18 Thread Jan Darowski
asked me at the beginning. Are you fine with the table solution? (sorry that I didn't respond for a while, busy time lately). 2015-03-16 8:55 GMT+01:00 Miika Turkia miika.tur...@gmail.com: On Mon, Mar 16, 2015 at 9:39 AM, Jan Darowski jan.darow...@gmail.com wrote: Ok, I can introduce changes

VPM-B Project

2015-04-28 Thread Jan Darowski
Hi! Thanks for accepting me as a GSoC participant! I hope to meet your expectations and add some useful features to the project. It's going to be a busy and exciting summer. Regards, Jan Darowski ___ subsurface mailing list subsurface@subsurface

VPM-B Project - Report

2015-05-20 Thread Jan Darowski
in the compartment and ambient pressure). And that's all! As soon as my implementation will correctly read input files and simulate gas pressures, I will link a repo so anyone could take a look at it. I hope it will be done this weekend. Jan Darowski

GSoC Status - Week 2 (VPM-B)

2015-06-08 Thread Jan Darowski
will add the basic deco. Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

GSoC Status - Week 4 (VPM-B)

2015-06-22 Thread Jan Darowski
but I think the result is fine. Now I will focus on testing these deco plans, integrating with Subsurface (ui part) and cleaning up the code. By the end of the week, code should be ready for pull request. -- Jan Darowski ___ subsurface mailing list

Re: GSoC Status - Week 1 (VPM-B)

2015-06-18 Thread Jan Darowski
. Do you want to do this as proposed or maybe you're busy and I should do it? Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Reproducable hang when using edit dive in planner on non-planned dive

2015-06-15 Thread Jan Darowski
ok. 2015-06-15 6:24 GMT+02:00 Dirk Hohndel d...@hohndel.org: On Mon, Jun 15, 2015 at 12:25:43AM +0200, Jan Darowski wrote: First problem from the daily build of subsurface hangs (reproducable for me) thread solved: in planner.c unsigned int stoplevels were compared with int depth. Thanks

[PATCH] Reproducable hang when using edit dive in planner on non-planned dive

2015-06-14 Thread Jan Darowski
First problem from the daily build of subsurface hangs (reproducable for me) thread solved: in planner.c unsigned int stoplevels were compared with int depth. Jan Darowski From ed0d74a067e2dd33e83bc4f5c48bc453d4b1eb1a Mon Sep 17 00:00:00 2001 From: Jan Darowski jan.darow...@gmail.com Date: Mon

GSoC Status - Week 1 (VPM-B)

2015-05-31 Thread Jan Darowski
problems with reaching the first big milestone: having a basic implementation of the algorithm on 14.06. Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

VPM-B and the current deco algorithm

2015-05-27 Thread Jan Darowski
logic of the current deco algorithm. Can I add plan_buehlmann and plan_vpmb() which will be called from the current plan() function? Thanks, Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi

Re: VPM-B and the current deco algorithm

2015-05-27 Thread Jan Darowski
something that can be checked / changed easily later. 2015-05-27 21:38 GMT+02:00 Robert C. Helling hell...@atdotde.de: On 27 May 2015, at 19:22, Jan Darowski jan.darow...@gmail.com wrote: Hi Jan, The most important thing is if we want both algorithms to be calculated for the current dive

Re: [PULL REQUEST] VPM-B

2015-07-01 Thread Jan Darowski
to completely ignore this part of the dive (the saturation increases so the first deco stop is deeper what increases deco time but that's not connected to the gradient). I will test this, maybe I'm missing something. -- Jan Darowski ___ subsurface mailing list

Re: [PATCH] Analytic solution rather than binary root search

2015-07-03 Thread Jan Darowski
Of course, I'm working on it right now, should be ready tonight.. 2015-07-03 6:09 GMT-07:00 Dirk Hohndel d...@hohndel.org: On Thu, Jul 02, 2015 at 08:49:29PM +0200, Jan Darowski wrote: Solution tested, results the same as with existing implementation. Great. I assume that I will get a pull

GSoC Status - Week 5 (VPM-B)

2015-06-29 Thread Jan Darowski
. On Friday I've rebased my changes and prepared for merging with master. This week I will write the promised paper about the algorithm and maybe add Boyle's Law compensation. What also needs to be done is optimization of some calculations. -- Jan Darowski

GSoC Status - Week 6 (VPM-B)

2015-07-06 Thread Jan Darowski
much time it will take. I will also implement Boyle's law compensation and finish the algorithm's description. Then the great testing will come but it will probably the next week. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface

Re: [PULL REQUEST] VPM-B

2015-07-02 Thread Jan Darowski
on the results or any cases that I should test please, tell me. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PULL REQUEST] VPM-B

2015-08-17 Thread Jan Darowski
reproduce this. I've checked, there are only two places setting this variable, the only place it's used is passing it to the boyles_law(). Printing it there gives the same value several times... -- Jan Darowski ___ subsurface mailing list subsurface

Re: [PULL REQUEST] VPM-B

2015-08-17 Thread Jan Darowski
on searching for bugs in this code. I suppose there can be some other small issues but this one explains a lot. Today there will be a patch for this. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org

Re: planner / VPM-B patches

2015-08-18 Thread Jan Darowski
when the first gas change during the deco is before the first deco stop. -- Jan Darowski From 81a792e1209e0943b6ff848c1b54467b5066845c Mon Sep 17 00:00:00 2001 From: Jan Darowski jan.darow...@gmail.com Date: Tue, 18 Aug 2015 13:20:56 +0200 Subject: [PATCH] VPM-B: Fix calculating Boyles compensation

Re: [PULL REQUEST] VPM-B

2015-08-16 Thread Jan Darowski
against other implementations... And they differ. Yay! -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Re: [PULL REQUEST] VPM-B

2015-08-17 Thread Jan Darowski
the conservatism levels already, so users can manipulate how aggressive their schedule is. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[PULL REQUEST] VPM-B

2015-06-29 Thread Jan Darowski
-06-26 20:47:13 +0200) Jan Darowski (11): Added basic VPM-B deco algorithm settings. Added crushing pressure state and is_vpmb parameter. Added basic crushing pressure calculation, without calculating current

[PULL REQUEST] VPM-B

2015-08-15 Thread Jan Darowski
for the VPM with the Boyles compensation. Also missing units comments were added. (2015-08-15 15:55:46 +0200) Jan Darowski (7): VPM-B: Fix trial_ascent() for vpm-b. Previously, current depth was checked, instead of the depth after

Re: GSoC Status - Week 7 (VPM-B)

2015-07-14 Thread Jan Darowski
because later gradients are calculated against this depth. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

GSoC Status - Week 7 (VPM-B)

2015-07-13 Thread Jan Darowski
of difference without Boyles compensation and 235 vs 289min with it on. That's way too much. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: GSoC Status - Week 7 (VPM-B)

2015-07-15 Thread Jan Darowski
boyle On 15 July 2015 at 06:31, Jan Darowski jan.darow...@gmail.com wrote: Yes, I've seen this link first time you sent it. Parameters are not the problem here. We have a different tissue saturation calculation method, so results differ a little bit at the beginning of the ascent. So the first

Re: VPM-B Patches for discussion

2015-08-26 Thread Jan Darowski
I agree that these commits would make the code cleaner and easier to understand. So if their influence on the plan is insignificant, they should be applied. -- Jan Darowski ___ subsurface mailing list subsurface@subsurface-divelog.org http