Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread Bernie Innocenti
On Wed, 2010-04-21 at 10:32 +1000, James Cameron wrote: However, I've just applied the patch on os119 on XO-1.5, restarted Sugar and tested Restart and Shutdown options, and they function correctly. Restart causes a UL screen and reboot. Shutdown causes a UL screen and power off. As we're

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-25 Thread Bernie Innocenti
On Wed, 2010-04-21 at 01:19 -0400, Michael Stone wrote: P.S. - I might feel differently if I knew how to make D-Bus and ConsoleKit work sanely with chroots, which I care about deeply for purposes of testing. What's the problem? I do: mount --bind /var/run/dbus $ROOT/var/run/dbus I know

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-25 Thread Paul Fox
bernie wrote: On Wed, 2010-04-21 at 01:19 -0400, Michael Stone wrote: P.S. - I might feel differently if I knew how to make D-Bus and ConsoleKit work sanely with chroots, which I care about deeply for purposes of testing. What's the problem? I do: mount --bind

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread Paul Fox
bernie wrote: On Wed, 2010-04-21 at 10:32 +1000, James Cameron wrote: However, I've just applied the patch on os119 on XO-1.5, restarted Sugar and tested Restart and Shutdown options, and they function correctly. Restart causes a UL screen and reboot. Shutdown causes a UL screen and

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-25 Thread Bernie Innocenti
On Sun, 2010-04-25 at 12:48 -0400, Paul Fox wrote: unified, perhaps, except that access from shell (last i looked) was fairly inadequate. So I'm not the only one to be disgusted by this trend? Modern Linux is becoming worryingly similar to MacOS and Windows. CLI support is being added as an

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread James Cameron
On Sun, Apr 25, 2010 at 11:46:41AM -0400, Bernie Innocenti wrote: As we're there, how do we get rid of the useless UL screen with its ugly inverted color scheme? For OLPC builds we'd need a product safety review to remove it. ;-) For deployment builds, you could hide /usr/sbin/ul-warning ...

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 01:18:53PM +1000, James Cameron wrote: dbus.exceptions.DBusException: org.freedesktop.ConsoleKit.Manager.NotPrivileged: Not privileged for action: org.freedesktop.consolekit.system.restart-multiple-users auth_admin_keep_always After the patch is applied, Sugar's

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 01:19:54AM -0400, Michael Stone wrote: For what it's worth, I would prefer to see a patch which simply called sudo /sbin/shutdown -h now and sudo /sbin/shutdown -r now. I don't see the value that D-Bus and ConsoleKit are providing here. That patch was rejected

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. While the actual patch was only tested on XO-1, I tried out the ConsoleKit API on XO-1.5 first. Both times Debian

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Peter Robinson
On Wed, Apr 21, 2010 at 1:32 AM, James Cameron qu...@laptop.org wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha,     Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5?  I'm curious how much of a backwards- compatibility break this

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Jonas Smedegaard
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: On Wed, Apr 21, 2010 at 1:32 AM, James Cameron qu...@laptop.org wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Now, if one also stops HAL, the shutdown or restart options don't work, and shell.log says: I

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-21 Thread Michael Stone
On Wed, Apr 21, 2010 at 01:19:54AM -0400, Michael Stone wrote: For what it's worth, I would prefer to see a patch which simply called sudo /sbin/shutdown -h now and sudo /sbin/shutdown -r now. I don't see the value that D-Bus and ConsoleKit are providing here. That patch was rejected some

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: I thought the point of these patches was to move from HAL to ConsoleKit so surely it should work whether HAL is there or not especially with everyone moving away from HAL to ConsoleKit/upower/udisk/udev etc/ The failure was

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: Since I've run into the same issue before (i.e. with HAL), I suppose the default is the same but the OLPC builds explicitly configure HAL to allow shutdowns even for multiple sessions? I've looked and not found where this might

[Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Michael Stone
Sascha wrote: HAL is dead, ConsoleKit now handles shutdown / reboot. I still prefer the /sbin/shutdown approach taken in sl#615 to the D-Bus based mechanisms that Tomeu prefers but I am concerned that this may be an area of irreconcilable difference between Tomeu and myself. Therefore, in the

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Daniel Drake
On 21 April 2010 19:07, James Cameron qu...@laptop.org wrote: On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: Since I've run into the same issue before (i.e. with HAL), I suppose the default is the same but the OLPC builds explicitly configure HAL to allow shutdowns even for

[Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Sascha Silbe
HAL is dead, ConsoleKit now handles shutdown / reboot. Shutdown tested on Debian squeeze with consolekit 0.4.1-4. Reboot mode cannot be triggered by UI in Sugar 0.88, so not tested. Signed-off-by: Sascha Silbe sascha-...@silbe.org --- src/jarabe/model/session.py | 10 +- 1 files

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Chris Ball
Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. - Chris. -- Chris Ball c...@laptop.org One Laptop Per Child ___ Sugar-devel mailing

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. No, I only did a code review and cross-check against ConsoleKit API

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Paul Fox
james wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. No, I only did a code review and

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Tue, Apr 20, 2010 at 08:37:54PM -0400, Paul Fox wrote: so, can someone tell me (gently) why either of these techniques is better than simply invoking /bin/reboot or /bin/shutdown? (other than the fact that those will work even if hal isn't running?) Lets Sugar hop the privilege barrier in

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Paul Fox
james wrote: On Tue, Apr 20, 2010 at 08:37:54PM -0400, Paul Fox wrote: so, can someone tell me (gently) why either of these techniques is better than simply invoking /bin/reboot or /bin/shutdown? (other than the fact that those will work even if hal isn't running?) Lets Sugar

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Wed, Apr 21, 2010 at 10:32:28AM +1000, James Cameron wrote: dbus.exceptions.DBusException: org.freedesktop.ConsoleKit.Manager.NotPrivileged: Not privileged for action: org.freedesktop.consolekit.system.restart-multiple-users auth_admin_keep_always After the patch is applied, Sugar's

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-20 Thread Michael Stone
Paul wrote: james wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. No, I only did a code

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-20 Thread Paul Fox
michael wrote: Paul wrote: james wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is.

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-20 Thread Michael Stone
Paul wrote: michael wrote: Paul wrote: james wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility