Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 01:18:53PM +1000, James Cameron wrote: dbus.exceptions.DBusException: org.freedesktop.ConsoleKit.Manager.NotPrivileged: Not privileged for action: org.freedesktop.consolekit.system.restart-multiple-users auth_admin_keep_always After the patch is applied, Sugar's

[Sugar-devel] [PATCH] improve encrypted wireless access point usability #1805 #1674

2010-04-21 Thread James Cameron
A 0.84 patch for review. When a passphrase dialog is cancelled, no further attempt to connect is made, and the icon is not marked as favourite. Fixes #1805. When an access point changes from encrypted to open, the new icon can be selected. Fixes #1674. Signed-off-by: James Cameron

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 01:19:54AM -0400, Michael Stone wrote: For what it's worth, I would prefer to see a patch which simply called sudo /sbin/shutdown -h now and sudo /sbin/shutdown -r now. I don't see the value that D-Bus and ConsoleKit are providing here. That patch was rejected

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. While the actual patch was only tested on XO-1, I tried out the ConsoleKit API on XO-1.5 first. Both times Debian

Re: [Sugar-devel] [PATCH] improve encrypted wireless access point usability #1805 #1674

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 06:23:04PM +1000, James Cameron wrote: When a passphrase dialog is cancelled, no further attempt to connect is made, and the icon is not marked as favourite. Fixes #1805. When an access point changes from encrypted to open, the new icon can be selected. Fixes

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Peter Robinson
On Wed, Apr 21, 2010 at 1:32 AM, James Cameron qu...@laptop.org wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha,     Reviewed-by: James Cameron qu...@laptop.org Did you test on XO-1 or XO-1.5?  I'm curious how much of a backwards- compatibility break this

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Jonas Smedegaard
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: On Wed, Apr 21, 2010 at 1:32 AM, James Cameron qu...@laptop.org wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Now, if one also stops HAL, the shutdown or restart options don't work, and shell.log says: I

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for

2010-04-21 Thread Michael Stone
On Wed, Apr 21, 2010 at 01:19:54AM -0400, Michael Stone wrote: For what it's worth, I would prefer to see a patch which simply called sudo /sbin/shutdown -h now and sudo /sbin/shutdown -r now. I don't see the value that D-Bus and ConsoleKit are providing here. That patch was rejected some

[Sugar-devel] [ASLO] Release Poll-23

2010-04-21 Thread Sugar Labs Activities
Activity Homepage: http://activities.sugarlabs.org/addon/4074 Sugar Platform: 0.82 - 0.86 Download Now: http://activities.sugarlabs.org/downloads/file/26883/poll-23.xo Release notes: Add new funcionality to enables or disables the display of vote results immediately while voting. It stops

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Jorge Saldivar
Hi Daniel, In attach I'm sending a patch which change the Keep string to Keep a copy. Hope it will help. Daniel Drake wrote: Argh! Another country, another core team confused by the Keep button. The Argentinian in-house generated teaching materials say: (translated from Spanish) To save

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread James Cameron
Reviewed-by: James Cameron qu...@laptop.org -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Chris Ball
Hi Jorge, - self.props.tooltip = _('Keep') + self.props.tooltip = _('Keep a copy') I think this will break translations. Not sure what our procedure for renaming a string is; you might want to make your patch also change all instances of 'msgid Keep' in po/* to be 'msgid Keep a copy',

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Daniel Drake
On 21 April 2010 18:48, Chris Ball c...@laptop.org wrote: Hi Jorge,   - self.props.tooltip = _('Keep')   + self.props.tooltip = _('Keep a copy') I think this will break translations. I think that's what we want; this new string will come up as untranslated in pootle, alerting translators

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: I thought the point of these patches was to move from HAL to ConsoleKit so surely it should work whether HAL is there or not especially with everyone moving away from HAL to ConsoleKit/upower/udisk/udev etc/ The failure was

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Chris Ball
Hi, I think that's what we want; this new string will come up as untranslated in pootle, alerting translators to submit translations for the clearer string. Ah, that's fine. (I assumed we'd want to use the old translations in the meantime.) - Chris. -- Chris Ball c...@laptop.org

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: Since I've run into the same issue before (i.e. with HAL), I suppose the default is the same but the OLPC builds explicitly configure HAL to allow shutdowns even for multiple sessions? I've looked and not found where this might

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Bert Freudenberg
On 21.04.2010, at 23:57, Chris Ball wrote: Hi, I think that's what we want; this new string will come up as untranslated in pootle, alerting translators to submit translations for the clearer string. Ah, that's fine. (I assumed we'd want to use the old translations in the meantime.)

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Eben Eliason
On Wed, Apr 21, 2010 at 6:22 PM, Bert Freudenberg b...@freudenbergs.de wrote: On 21.04.2010, at 23:57, Chris Ball wrote: Hi, I think that's what we want; this new string will come up as untranslated in pootle, alerting translators to submit translations for the clearer string. Ah, that's

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Chris Ball
Hi Eben, I'd lean toward the first option. It's intended purpose was always to be a convenience on top of auto-save, that simply forced a new version. Once Sugar has full version support, and a Journal updated to take advantage of it, restoring the Keep functionality as it

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Eben Eliason
On Wed, Apr 21, 2010 at 7:18 PM, Chris Ball c...@laptop.org wrote: Hi Eben,   I'd lean toward the first option. It's intended purpose was   always to be a convenience on top of auto-save, that simply   forced a new version. Once Sugar has full version support, and a   Journal updated to

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 07:27:44PM -0400, Eben Eliason wrote: No, sorry. The current prompt-on-quit is fine, as it only occurs when you stop a brand new activity instance. It basically asks do you want me to keep track of this thing in your Journal, ... How do I answer no? As far as I can

[Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-21 Thread Chris Ball
Hi, No, sorry. The current prompt-on-quit is fine, as it only occurs when you stop a brand new activity instance. It basically asks do you want me to keep track of this thing in your Journal, and from then on it will auto-save as usual. Since the Keep button is causing

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread Bert Freudenberg
On 22.04.2010, at 01:39, James Cameron wrote: On Wed, Apr 21, 2010 at 07:27:44PM -0400, Eben Eliason wrote: No, sorry. The current prompt-on-quit is fine, as it only occurs when you stop a brand new activity instance. It basically asks do you want me to keep track of this thing in your

Re: [Sugar-devel] Keep confusion, yet again

2010-04-21 Thread James Cameron
On Thu, Apr 22, 2010 at 01:48:09AM +0200, Bert Freudenberg wrote: On 22.04.2010, at 01:39, James Cameron wrote: On Wed, Apr 21, 2010 at 07:27:44PM -0400, Eben Eliason wrote: No, sorry. The current prompt-on-quit is fine, as it only occurs when you stop a brand new activity instance. It

Re: [Sugar-devel] [PATCH] Remove the keep button from the default activity toolbar

2010-04-21 Thread Frederick Grose
On Wed, Apr 21, 2010 at 7:35 PM, Chris Ball c...@laptop.org wrote: Hi, No, sorry. The current prompt-on-quit is fine, as it only occurs when you stop a brand new activity instance. It basically asks do you want me to keep track of this thing in your Journal, and from then on it

[Sugar-devel] [PATCH 1/4] passphrase dialog, remove destroy, fix duplicate error, catch escape key

2010-04-21 Thread James Cameron
Removed the destroy callback, since it is always called. The error callback was called after an OK response, resulting in DBusException CanceledError, which was ignored by NetworkManager. When Cancel was pressed, there were two DBusExceptions. This was benign. Added handling of

[Sugar-devel] [PATCH 2/4] add model.network.find_connection_by_path

2010-04-21 Thread James Cameron
Finds a connection given the path by which it is known to NetworkManager, required since at least one caller doesn't have the connection name available to them. --- src/jarabe/model/network.py |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

[Sugar-devel] [PATCH 4/4] disconnect on passphrase cancel #1805

2010-04-21 Thread James Cameron
When a passphrase dialog is cancelled, no further attempt to connect is made, and the icon is not marked as favourite. Fixes #1805. Details: 1. a backlink to the NMSettings object is placed in each NMSettingsConnection object, 2. NMSettings.clear_connections method is adjusted to better fit

[Sugar-devel] [PATCH 3/4] fix AP association failure after removing encryption #1674

2010-04-21 Thread James Cameron
Mesh box already segregates access points with the same SSID, but clicking on them treats them all the same. This leads to failure to associate with an AP after encryption has been removed, and the favourite badge icon appears on the wrong icon. This patch changes the naming of the network

[Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Michael Stone
Sascha wrote: HAL is dead, ConsoleKit now handles shutdown / reboot. I still prefer the /sbin/shutdown approach taken in sl#615 to the D-Bus based mechanisms that Tomeu prefers but I am concerned that this may be an area of irreconcilable difference between Tomeu and myself. Therefore, in the

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Daniel Drake
On 21 April 2010 19:07, James Cameron qu...@laptop.org wrote: On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: Since I've run into the same issue before (i.e. with HAL), I suppose the default is the same but the OLPC builds explicitly configure HAL to allow shutdowns even for