Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
No worries. I'm not a mentor this year, so your proposal is not something I'll advise on. My feedback was about Simulate, and the normal workflow of the organisation. On Sun, Apr 02, 2023 at 01:06:38PM +0530, Spandan Barve wrote: > Thanks for the reply quozl, I understand now and this will also help me when > porting simulate to python3 which is also a part of my proposal, I'll also > specify sugargame in my proposal, thanks. > > On Sat, Apr 1, 2023 at 4:54 PM James Cameron <[1]qu...@laptop.org> wrote: > > On Sat, Apr 01, 2023 at 04:21:59PM +0530, Spandan Barve wrote: > > Thanks for the feedback Ibiam. > > [...] > > > Simulate activity sometimes crashes Sugar, what do you mean by > crashing > > Sugar? > > I was not able to reproduce it but I do have the error saved. by > > crash, I mean that the activity stops responding completely, > > including the stop button and pressing CTRL+Q, I had to go back to > > the journal and then remove the activity, after that I got an error > > in the terminal. > > here is the error : [2]https://pastebin.com/1RcTvYHc > > It's a bug. > > The error showed Python 2.7. Simulate is yet to be ported to Python > 3. The traceback can be ignored until that port is done. > > Simulate also needs a port to later Sugargame. During the port of > Sugargame a complete review of the event loop should be done, as > Sugargame changed substantially. > > Simulate contains many inner event loops, with calls to wait, update, > and tick, yet without checking for the stop button or Control/Q. > That's probably the bug you saw. > > Simulate also uses an unconventional exit method. > > The Sugargame sample code shows how to do it instead. > > Simulate window can also vanish but the system process persist, which > was first reported in 2018. > > [3]https://github.com/devAbnull/simulate_sugargame/issues/1 > > I could not tell if you used git HEAD or the latest release of > Simulate, which predates git HEAD by some years. > > [4]http://activities.sugarlabs.org/en-US/sugar/addon/4778 > > References: > > [1] mailto:qu...@laptop.org > [2] https://pastebin.com/1RcTvYHc > [3] https://github.com/devAbnull/simulate_sugargame/issues/1 > [4] http://activities.sugarlabs.org/en-US/sugar/addon/4778 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
Thanks for the reply quozl, I understand now and this will also help me when porting simulate to python3 which is also a part of my proposal, I'll also specify sugargame in my proposal, thanks. On Sat, Apr 1, 2023 at 4:54 PM James Cameron wrote: > On Sat, Apr 01, 2023 at 04:21:59PM +0530, Spandan Barve wrote: > > Thanks for the feedback Ibiam. > > [...] > > > Simulate activity sometimes crashes Sugar, what do you mean by crashing > > Sugar? > > I was not able to reproduce it but I do have the error saved. by > > crash, I mean that the activity stops responding completely, > > including the stop button and pressing CTRL+Q, I had to go back to > > the journal and then remove the activity, after that I got an error > > in the terminal. > > here is the error : https://pastebin.com/1RcTvYHc > > It's a bug. > > The error showed Python 2.7. Simulate is yet to be ported to Python > 3. The traceback can be ignored until that port is done. > > Simulate also needs a port to later Sugargame. During the port of > Sugargame a complete review of the event loop should be done, as > Sugargame changed substantially. > > Simulate contains many inner event loops, with calls to wait, update, > and tick, yet without checking for the stop button or Control/Q. > That's probably the bug you saw. > > Simulate also uses an unconventional exit method. > > The Sugargame sample code shows how to do it instead. > > Simulate window can also vanish but the system process persist, which > was first reported in 2018. > > https://github.com/devAbnull/simulate_sugargame/issues/1 > > I could not tell if you used git HEAD or the latest release of > Simulate, which predates git HEAD by some years. > > http://activities.sugarlabs.org/en-US/sugar/addon/4778 > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
On Sat, Apr 01, 2023 at 04:21:59PM +0530, Spandan Barve wrote: > Thanks for the feedback Ibiam. > [...] > > Simulate activity sometimes crashes Sugar, what do you mean by crashing > Sugar? > I was not able to reproduce it but I do have the error saved. by > crash, I mean that the activity stops responding completely, > including the stop button and pressing CTRL+Q, I had to go back to > the journal and then remove the activity, after that I got an error > in the terminal. > here is the error : https://pastebin.com/1RcTvYHc It's a bug. The error showed Python 2.7. Simulate is yet to be ported to Python 3. The traceback can be ignored until that port is done. Simulate also needs a port to later Sugargame. During the port of Sugargame a complete review of the event loop should be done, as Sugargame changed substantially. Simulate contains many inner event loops, with calls to wait, update, and tick, yet without checking for the stop button or Control/Q. That's probably the bug you saw. Simulate also uses an unconventional exit method. The Sugargame sample code shows how to do it instead. Simulate window can also vanish but the system process persist, which was first reported in 2018. https://github.com/devAbnull/simulate_sugargame/issues/1 I could not tell if you used git HEAD or the latest release of Simulate, which predates git HEAD by some years. http://activities.sugarlabs.org/en-US/sugar/addon/4778 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
Thanks for the feedback Ibiam. > Would the ghost lines for dots and boxes appear on mouse hover? Yes, the lines would be drawn on hover, again to indicate where the new line will be placed on click. > Simulate activity sometimes crashes Sugar, what do you mean by crashing Sugar? I was not able to reproduce it but I do have the error saved. by crash, I mean that the activity stops responding completely, including the stop button and pressing CTRL+Q, I had to go back to the journal and then remove the activity, after that I got an error in the terminal. here is the error : https://pastebin.com/1RcTvYHc > too many unknowns, you mention implementing an AI but no details as to how you intend to go about it, what data would you use? As for the AI, I specified using the minimax algorithm to implement the AI, which is a tree based algorithm specializing in two player games, including othello which is what reversi is based off. As to how I would be making the AI play the game, I would call the minimax function to get the ideal move and then place the piece on the board by calling the self.board_model.put_piece function of ReversiController class and instead of toggling player like in normal mode, the toggle_current_player function would call the minimax function. > What new dependencies would you be adding to the activity? No new dependencies will be required. > for reversi activity, is collaboration working fine? No, collaboration is not implemented for this activity > Reset and next buttons in jumble activity not being visible, no images to explain again. How can you click on them if they're not visible? I will attach images to my proposal to explain further. I can click them as the buttons are still there and function properly, just that they are not visible. Again, I will attach images to elaborate > Nutrition activity: "having premade questions" any sample of such questions would be helpful. I'd add a proper sample in the proposal, but it would be like for eg: A fast food item Vs a Salad, or pizza vs a vegetable. - In response to IQ activity, thanks for the suggestion, I will add it to the proposal that I'll be making these settings optional. > how do you intend to "make sure". after calling the _generate_color method of the BallsGenerator class, I'd calculate hsp hsp = sqrt( 0.299 * (r * r) + 0.587 * (g * g) + 0.114 * (b * b) ); This is how hsp is calculated and if hsp is greater than 128, it means the color is bright enough for the text to be visible. If it is not, I'd call the function again until the condition is satisfied. This approach is better than generating the rgb values in the _generate_color function ranging from 128 to 255 because calculating hsp provides room for more colors than this approach. Finally, Thanks for the review and I'll be adding all these to the proposal as well, and I'll attach images wherever needed, as you suggested when talking about flip activity. I will soon be uploading the updated proposal On Fri, Mar 31, 2023 at 8:30 PM Chihurumnaya Ibiam wrote: > I forgot to add this for reversi activity, is collaboration working fine? > > -- > > Ibiam Chihurumnaya > ib...@sugarlabs.org > > > > On Fri, Mar 31, 2023 at 3:17 PM Chihurumnaya Ibiam > wrote: > >> Hi Spandan, >> >> Thanks for sharing, a few comments. >> >> Would the ghost lines for dots and boxes appear on mouse hover? >> >> Simulate activity sometimes crashes Sugar, what do you mean by crashing >> Sugar? >> What does the logs say? >> >> When talking about images, the best way to explain is to add images to >> prove your point, the board size overflow you mentioned >> in flip activity can better be understood with an image. >> This also applies to every activity where you mention something that's >> wrong with the canvas. >> >> Reset and next buttons in jumble activity not being visible, no images to >> explain again. >> How can you click on them if they're not visible? >> >> Reversi activity: too many unknowns, you mention implementing an AI but >> no details as to how you intend to go about it, what data would you use? >> What new dependencies would you be adding to the activity? >> >> Nutrition activity: "having premade questions" any sample of such >> questions would be helpful. >> Where do you intend to get the healthy index from? >> >> IQ activity: The timer idea seems nice but it should be optional as some >> kids might feel pressured when timed and the goal ultimately is >> to have fun while playing. >> Hard coding solutions doesn't sound intuitive, what happens if the board >> size changes in the future so that means the solutions would have to be >> hard coded again. >> >> Hit the balls activity: "I intend on creating a utility function which >> generates a random color only after making sure the color is bright enough >> that the text on it would be visible." >> Only after making sure sounds vague, how do you intend to "make sure". >> Button hover sound doesn't seem
Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
I forgot to add this for reversi activity, is collaboration working fine? -- Ibiam Chihurumnaya ib...@sugarlabs.org On Fri, Mar 31, 2023 at 3:17 PM Chihurumnaya Ibiam wrote: > Hi Spandan, > > Thanks for sharing, a few comments. > > Would the ghost lines for dots and boxes appear on mouse hover? > > Simulate activity sometimes crashes Sugar, what do you mean by crashing > Sugar? > What does the logs say? > > When talking about images, the best way to explain is to add images to > prove your point, the board size overflow you mentioned > in flip activity can better be understood with an image. > This also applies to every activity where you mention something that's > wrong with the canvas. > > Reset and next buttons in jumble activity not being visible, no images to > explain again. > How can you click on them if they're not visible? > > Reversi activity: too many unknowns, you mention implementing an AI but no > details as to how you intend to go about it, what data would you use? > What new dependencies would you be adding to the activity? > > Nutrition activity: "having premade questions" any sample of such > questions would be helpful. > Where do you intend to get the healthy index from? > > IQ activity: The timer idea seems nice but it should be optional as some > kids might feel pressured when timed and the goal ultimately is > to have fun while playing. > Hard coding solutions doesn't sound intuitive, what happens if the board > size changes in the future so that means the solutions would have to be > hard coded again. > > Hit the balls activity: "I intend on creating a utility function which > generates a random color only after making sure the color is bright enough > that the text on it would be visible." > Only after making sure sounds vague, how do you intend to "make sure". > Button hover sound doesn't seem right as hovering is not really an action > the activity cares about. > > Hope this helps! > > > -- > > Ibiam Chihurumnaya > ib...@sugarlabs.org > > > > On Fri, Mar 31, 2023 at 8:23 AM Spandan Barve > wrote: > >> Hi everyone, I am Spandan Barve, also known as marsian83 on github. >> Here is my draft GSOC 2023 proposal for the project : Improve and >> Maintain 12 sugar activities >> Looking forward to a feedback from the mentors and any suggestions are >> welcome >> Thanks >> >> >> ___ >> Sugar-devel mailing list >> Sugar-devel@lists.sugarlabs.org >> http://lists.sugarlabs.org/listinfo/sugar-devel >> > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Draft Proposal - improve & maintain 12 sugar activities
Hi Spandan, Thanks for sharing, a few comments. Would the ghost lines for dots and boxes appear on mouse hover? Simulate activity sometimes crashes Sugar, what do you mean by crashing Sugar? What does the logs say? When talking about images, the best way to explain is to add images to prove your point, the board size overflow you mentioned in flip activity can better be understood with an image. This also applies to every activity where you mention something that's wrong with the canvas. Reset and next buttons in jumble activity not being visible, no images to explain again. How can you click on them if they're not visible? Reversi activity: too many unknowns, you mention implementing an AI but no details as to how you intend to go about it, what data would you use? What new dependencies would you be adding to the activity? Nutrition activity: "having premade questions" any sample of such questions would be helpful. Where do you intend to get the healthy index from? IQ activity: The timer idea seems nice but it should be optional as some kids might feel pressured when timed and the goal ultimately is to have fun while playing. Hard coding solutions doesn't sound intuitive, what happens if the board size changes in the future so that means the solutions would have to be hard coded again. Hit the balls activity: "I intend on creating a utility function which generates a random color only after making sure the color is bright enough that the text on it would be visible." Only after making sure sounds vague, how do you intend to "make sure". Button hover sound doesn't seem right as hovering is not really an action the activity cares about. Hope this helps! -- Ibiam Chihurumnaya ib...@sugarlabs.org On Fri, Mar 31, 2023 at 8:23 AM Spandan Barve wrote: > Hi everyone, I am Spandan Barve, also known as marsian83 on github. > Here is my draft GSOC 2023 proposal for the project : Improve and Maintain > 12 sugar activities > Looking forward to a feedback from the mentors and any suggestions are > welcome > Thanks > > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
