Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Steven Hartland
On 04/08/2015 21:24, Slawa Olhovchenkov wrote: On Tue, Aug 04, 2015 at 09:06:55PM +0100, Steven Hartland wrote: On 04/08/2015 17:14, Slawa Olhovchenkov wrote: On Tue, Aug 04, 2015 at 09:30:30AM +0100, Steven Hartland wrote: On 03/08/2015 21:48, Warner Losh wrote: On Aug 3, 2015, at 1:44

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Slawa Olhovchenkov
On Wed, Aug 05, 2015 at 12:10:23PM +0100, Steven Hartland wrote: Just in case you didn't notice kib committed a fix for i386 thread0 in r286288 so this may not be needed at all any more which is good news :) If I understund kib fix (and you about ZFS stack requirements) you need check

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-04 Thread Steven Hartland
On 03/08/2015 21:48, Warner Losh wrote: On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: On 8/3/15 8:03 PM, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-04 Thread Fabian Keil
Fabian Keil freebsd-lis...@fabiankeil.de wrote: Fabian Keil freebsd-lis...@fabiankeil.de wrote: Konstantin Belousov kostik...@gmail.com wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size,

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-04 Thread Slawa Olhovchenkov
On Tue, Aug 04, 2015 at 09:30:30AM +0100, Steven Hartland wrote: On 03/08/2015 21:48, Warner Losh wrote: On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: On 8/3/15 8:03 PM, Konstantin Belousov

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-04 Thread Steven Hartland
On 04/08/2015 17:14, Slawa Olhovchenkov wrote: On Tue, Aug 04, 2015 at 09:30:30AM +0100, Steven Hartland wrote: On 03/08/2015 21:48, Warner Losh wrote: On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote:

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-04 Thread Slawa Olhovchenkov
On Tue, Aug 04, 2015 at 09:06:55PM +0100, Steven Hartland wrote: On 04/08/2015 17:14, Slawa Olhovchenkov wrote: On Tue, Aug 04, 2015 at 09:30:30AM +0100, Steven Hartland wrote: On 03/08/2015 21:48, Warner Losh wrote: On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov s...@zxy.spb.ru

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Fabian Keil
Fabian Keil freebsd-lis...@fabiankeil.de wrote: Konstantin Belousov kostik...@gmail.com wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide a

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Steven Hartland
On 03/08/2015 10:47, Slawa Olhovchenkov wrote: On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author: smh Date: Mon Aug 3 09:34:09 2015 New Revision: 286223 URL: https://svnweb.freebsd.org/changeset/base/286223 Log: Fix KSTACK_PAGES check in ZFS module The check

svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Steven Hartland
Author: smh Date: Mon Aug 3 09:34:09 2015 New Revision: 286223 URL: https://svnweb.freebsd.org/changeset/base/286223 Log: Fix KSTACK_PAGES check in ZFS module The check introduced by r285946 failed to add the dependency on opt_kstack_pages.h which meant the default value for the

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Slawa Olhovchenkov
On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author: smh Date: Mon Aug 3 09:34:09 2015 New Revision: 286223 URL: https://svnweb.freebsd.org/changeset/base/286223 Log: Fix KSTACK_PAGES check in ZFS module The check introduced by r285946 failed to add the

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Peter Wemm
On Monday, August 03, 2015 11:31:58 AM Steven Hartland wrote: On 03/08/2015 10:47, Slawa Olhovchenkov wrote: On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author: smh Date: Mon Aug 3 09:34:09 2015 New Revision: 286223 URL:

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Slawa Olhovchenkov
On Mon, Aug 03, 2015 at 11:31:58AM +0100, Steven Hartland wrote: On 03/08/2015 10:47, Slawa Olhovchenkov wrote: On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author: smh Date: Mon Aug 3 09:34:09 2015 New Revision: 286223 URL:

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Slawa Olhovchenkov
On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: I looked at the possibility of making default kernel stack size configurable by a loader tunable, and the issue is that thread0 gets its stack set up too early (locore for i386, hammer_time() for amd64). I.e., it is

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Konstantin Belousov
On Mon, Aug 03, 2015 at 03:52:21AM -0700, Peter Wemm wrote: On Monday, August 03, 2015 11:31:58 AM Steven Hartland wrote: On 03/08/2015 10:47, Slawa Olhovchenkov wrote: On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author: smh Date: Mon Aug 3 09:34:09 2015 New

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Slawa Olhovchenkov
On Mon, Aug 03, 2015 at 02:19:42PM +0300, Konstantin Belousov wrote: The whole thing has missing the point. Changing the default for the entire kernel just because the zfs compat wrappers can't be bothered requesting a suitable value is.. unfortunate.. particularly when it is in

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Steven Hartland
On 03/08/2015 12:19, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 03:52:21AM -0700, Peter Wemm wrote: On Monday, August 03, 2015 11:31:58 AM Steven Hartland wrote: On 03/08/2015 10:47, Slawa Olhovchenkov wrote: On Mon, Aug 03, 2015 at 09:34:10AM +, Steven Hartland wrote: Author:

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Konstantin Belousov
On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide a reasonable warning to the user that smaller values could cause a panic. Hmm, is it limited to the thread0 only

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Fabian Keil
Konstantin Belousov kostik...@gmail.com wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide a reasonable warning to the user that smaller values could

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Steven Hartland
On 03/08/2015 13:03, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide a reasonable warning to the user that smaller values could cause a

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Slawa Olhovchenkov
On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: On 8/3/15 8:03 PM, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Warner Losh
On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: On 8/3/15 8:03 PM, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into

Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Julian Elischer
On 8/3/15 8:03 PM, Konstantin Belousov wrote: On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: For this change I don't want to get into fixing the thread0 stack size, which can be done later, just to provide a reasonable warning to the user that smaller values could cause a