Re: svn commit: r212550 - head/sys/mips/rmi

2010-09-13 Thread John Baldwin
that live on the bus. If a bus can self-enumerate devices (e.g. PCI) it should use device_add_child() directly. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r212572 - in head/sys: dev/cxgb kern sys vm

2010-09-13 Thread John Baldwin
icitly so that they can then call SYSCTL_OUT() without dropping a lock. The pcblist sysctls do this for example I think. In general code in the kernel assumes that copyout(9) to/from a wired buffer is safe while holding mutexes or rwlocks. -- John Baldwin __

Re: svn commit: r212647 - head/sys/sys

2010-09-15 Thread John Baldwin
data. > - * > - * We don't use SET_DECLARE because it defines the set as 'a' when we > - * want 'aw'. gcc considers uninitialized data in a separate section > - * writable, and there is no generic zero initializer that works for > - * structs and scalars. > */

Re: svn commit: r212653 - head/sys/netinet

2010-09-15 Thread John Baldwin
r TCP over IPv4 across the Internet's smallest > * known link MTU (256 bytes for AX.25 packet radio). However, a connection > is > * very unlikely to come across such low MTU interfaces (anno domini 2003). > */ > #define TCP_MINMSS 216 I actually prefer the above

Re: svn commit: r212661 - head/sys/dev/aac

2010-09-15 Thread John Baldwin
ue to devfs unmount would cause VOP_CLOSE() to be called > only once despite the number of opens being > 1. cdevpriv is probably a much better route for handling this than D_TRACKCLOSE. The destructor routine passed to devfs_set_cdevpriv() would just do the work of decrementing the referen

Re: svn commit: r212647 - head/sys/sys

2010-09-15 Thread John Baldwin
The comment seemed to imply that it would have used SET_DECLARE() if there had not been technical difficulties. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r212749 - head/usr.sbin/pciconf

2010-09-16 Thread John Baldwin
Author: jhb Date: Thu Sep 16 16:03:12 2010 New Revision: 212749 URL: http://svn.freebsd.org/changeset/base/212749 Log: Only attempt to list extended capabilities for devices that have a PCI-express capabilities. Non-PCI-express PCI devices may simply ignore the upper bits in a config regist

svn commit: r212902 - head/sys/dev/e1000

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 16:04:44 2010 New Revision: 212902 URL: http://svn.freebsd.org/changeset/base/212902 Log: Tweak the stats exported by the e1000 drivers: - Add a single sysctl procedure to all three drivers to read an arbitrary register (the register is passed as arg2). Use it

svn commit: r212911 - stable/8/sys/netinet

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 18:40:54 2010 New Revision: 212911 URL: http://svn.freebsd.org/changeset/base/212911 Log: MFC 211888: Simplify the tcp pcblist estimate logic slightly. Modified: stable/8/sys/netinet/tcp_subr.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys

svn commit: r212912 - stable/7/sys/netinet

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 18:41:15 2010 New Revision: 212912 URL: http://svn.freebsd.org/changeset/base/212912 Log: MFC 211888: Simplify the tcp pcblist estimate logic slightly. Modified: stable/7/sys/netinet/tcp_subr.c Directory Properties: stable/7/sys/ (props changed) stable/7/sys

svn commit: r212914 - stable/8/sys/boot/forth

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 18:58:24 2010 New Revision: 212914 URL: http://svn.freebsd.org/changeset/base/212914 Log: MFC 212338: If autoboot_delay is set to -1, boot immediately without checking for a keypress to match the behavior of the loader. Modified: stable/8/sys/boot/forth/beasti

svn commit: r212915 - stable/7/sys/boot/forth

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 18:58:44 2010 New Revision: 212915 URL: http://svn.freebsd.org/changeset/base/212915 Log: MFC 212338: If autoboot_delay is set to -1, boot immediately without checking for a keypress to match the behavior of the loader. Modified: stable/7/sys/boot/forth/beasti

svn commit: r212918 - stable/8/usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:17:21 2010 New Revision: 212918 URL: http://svn.freebsd.org/changeset/base/212918 Log: MFC 212329: Simplify chkattached(). The PCIOCATTACHED ioctl only needs the pi_sel field populated, it ignores the rest of the 'pci_io' structure. Modified: stable/8/usr.

svn commit: r212919 - stable/7/usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:17:31 2010 New Revision: 212919 URL: http://svn.freebsd.org/changeset/base/212919 Log: MFC 212329: Simplify chkattached(). The PCIOCATTACHED ioctl only needs the pi_sel field populated, it ignores the rest of the 'pci_io' structure. Modified: stable/7/usr.

svn commit: r212921 - stable/8/usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:25:15 2010 New Revision: 212921 URL: http://svn.freebsd.org/changeset/base/212921 Log: MFC 212369: - Use 'sta' to hold the PCIR_STATUS register value instead of 'cmd' when walking the capability list. - Use constants for PCI header types instead of magic n

svn commit: r212922 - stable/7/usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:25:27 2010 New Revision: 212922 URL: http://svn.freebsd.org/changeset/base/212922 Log: MFC 212369: - Use 'sta' to hold the PCIR_STATUS register value instead of 'cmd' when walking the capability list. - Use constants for PCI header types instead of magic n

svn commit: r212923 - in stable/8: sys/dev/pci usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:29:48 2010 New Revision: 212923 URL: http://svn.freebsd.org/changeset/base/212923 Log: MFC 209907,212326,212368,212749: - Provide more defines for PCI-Express device ctrl. - Add register definitions related to extended capability IDs in PCI-express. I use

svn commit: r212924 - in stable/7: sys/dev/pci usr.sbin/pciconf

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:30:20 2010 New Revision: 212924 URL: http://svn.freebsd.org/changeset/base/212924 Log: MFC 209907,212326,212368,212749: - Provide more defines for PCI-Express device ctrl. - Add register definitions related to extended capability IDs in PCI-express. I use

svn commit: r212929 - in stable/8/sys: fs/nfsclient nfsclient

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:58:50 2010 New Revision: 212929 URL: http://svn.freebsd.org/changeset/base/212929 Log: MFC 212293: Store the full timestamp when caching timestamps of files and directories for purposes of validating name cache entries. This closes races where two updates t

svn commit: r212930 - in stable/7/sys: nfs4client nfsclient

2010-09-20 Thread John Baldwin
Author: jhb Date: Mon Sep 20 19:59:08 2010 New Revision: 212930 URL: http://svn.freebsd.org/changeset/base/212930 Log: MFC 212293: Store the full timestamp when caching timestamps of files and directories for purposes of validating name cache entries. This closes races where two updates t

Re: svn commit: r212964 - head/sys/kern

2010-09-21 Thread John Baldwin
lock alone to +* avoid changing the state. +*/ + if (panicstr != NULL && curthread->td_flags & TDF_INPANIC) + return; + + /* * We have to lock the chain before the turnstile so this turnstile * can be removed from the hash lis

Re: svn commit: r212964 - head/sys/kern

2010-09-21 Thread John Baldwin
7;ll double panic more often than not. Yes, I don't dispute this. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r212974 - head/sys/kern

2010-09-21 Thread John Baldwin
Author: jhb Date: Tue Sep 21 19:12:22 2010 New Revision: 212974 URL: http://svn.freebsd.org/changeset/base/212974 Log: Comment nit, set TDF_NEEDRESCHED after the comment describing why it is done rather than before. MFC after:1 week Modified: head/sys/kern/sched_ule.c Modified: he

svn commit: r212999 - head/sys/sys

2010-09-22 Thread John Baldwin
Author: jhb Date: Wed Sep 22 15:10:03 2010 New Revision: 212999 URL: http://svn.freebsd.org/changeset/base/212999 Log: Copy td_rqindex during fork instead of zero'ing it to match the comments. I do not believe there is any functional change. Modified: head/sys/sys/proc.h Modified: head/sys

Re: svn commit: r212964 - head/sys/kern

2010-09-22 Thread John Baldwin
v will give you the same info you generally can get from a textdump in the form of a simple /var/crash/core.txt.N file. The other benefit of full crashdumps + crashinfo as compared to textdumps is that a developer can request further information in a PR followup (fire up kgdb and enter command 'X

svn commit: r213028 - head/sys/net

2010-09-22 Thread John Baldwin
Author: jhb Date: Wed Sep 22 21:02:43 2010 New Revision: 213028 URL: http://svn.freebsd.org/changeset/base/213028 Log: - Expand scope of tun/tap softc locks to cover more softc fields and driver-maintained ifnet fields (such as if_drv_flags). - Use soft locks as the mutex that protects eac

Re: svn commit: r212964 - head/sys/kern

2010-09-22 Thread John Baldwin
On Wednesday, September 22, 2010 5:15:25 pm Ken Smith wrote: > On 9/22/10 5:02 PM, Andriy Gapon wrote: > > on 22/09/2010 22:58 John Baldwin said the following: > > > >> Agreed. FWIW, I actually think that this is the only change needed as > >> crashinfo is enabled

Re: svn commit: r212964 - head/sys/kern

2010-09-23 Thread John Baldwin
ong time on modern systems). I think textdumps are just as likely to fail as regular dumps though since they both use the same code for writing out the dump, they just write different bits to the dump area. -- John Baldwin ___ svn-src-all@freebsd.org

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread John Baldwin
pbegin) + UIO_CHUNK_SZ; > + pbegin += UIO_CHUNK_SZ; > } else { > found_end = 1; > } > @@ -1025,9 +1030,12 @@ do { > \ >

Re: svn commit: r212964 - head/sys/kern

2010-09-24 Thread John Baldwin
info versus users > who would be negatively impacted simply by the fact their > systems are generating stuff they're completely ignorant > of and will never touch. Well, if we turn it on we should document it clearly. Folks are already interested in asking for help once a machine pani

Re: svn commit: r212723 - head/sys/compat/linprocfs

2010-09-24 Thread John Baldwin
On Friday, September 24, 2010 9:32:15 am Kostik Belousov wrote: > On Fri, Sep 24, 2010 at 08:34:16AM -0400, John Baldwin wrote: > > On Friday, September 24, 2010 7:53:11 am Kostik Belousov wrote: > > > On Fri, Sep 24, 2010 at 02:17:29PM +0400, pluknet wrote: > > > > O

Re: svn commit: r212964 - head/sys/kern

2010-09-27 Thread John Baldwin
> >acceptable. > > savecore already has support for a 'minfree' file to prevent > crashdumps filling the crashdir. Maybe the default install should > include a minfree set to (say) 512MB. The one problem this approach is it implements a FIFO in

svn commit: r213205 - stable/8/sys/dev/e1000

2010-09-27 Thread John Baldwin
Author: jhb Date: Mon Sep 27 16:29:25 2010 New Revision: 213205 URL: http://svn.freebsd.org/changeset/base/213205 Log: MFC 212902: Tweak the stats exported by the e1000 drivers: - Add a single sysctl procedure to all three drivers to read an arbitrary register (the register is passed as

svn commit: r213206 - stable/7/sys/dev/e1000

2010-09-27 Thread John Baldwin
Author: jhb Date: Mon Sep 27 16:29:46 2010 New Revision: 213206 URL: http://svn.freebsd.org/changeset/base/213206 Log: MFC 212902: Tweak the stats exported by the e1000 drivers: - Add a single sysctl procedure to all three drivers to read an arbitrary register (the register is passed as

svn commit: r213226 - head/sys/i386/i386

2010-09-27 Thread John Baldwin
Author: jhb Date: Mon Sep 27 19:36:15 2010 New Revision: 213226 URL: http://svn.freebsd.org/changeset/base/213226 Log: Rewrite the i386 memory probe: - Check for SMAP data from the loader first. If it exists, don't bother doing any VM86 calls at all. This will be more friendly for non-BI

Re: svn commit: r213226 - head/sys/i386/i386

2010-09-27 Thread John Baldwin
On Monday, September 27, 2010 3:36:16 pm John Baldwin wrote: > Author: jhb > Date: Mon Sep 27 19:36:15 2010 > New Revision: 213226 > URL: http://svn.freebsd.org/changeset/base/213226 > > Log: > Rewrite the i386 memory probe: > - Check for SMAP data from the loader fir

Re: svn commit: r213241 - in head: include lib/libthr/thread

2010-09-28 Thread John Baldwin
be statically initialized correctly. Does this fix PR threads/150889 then? -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r212964 - head/sys/kern

2010-09-28 Thread John Baldwin
On Tuesday, September 28, 2010 5:49:12 am Alexander Leidinger wrote: > Quoting John Baldwin (from Mon, 27 Sep 2010 09:28:47 > -0400): > > >> savecore already has support for a 'minfree' file to prevent > >> crashdumps filling the crashdir. Maybe the

Re: svn commit: r212964 - head/sys/kern

2010-09-28 Thread John Baldwin
On Tuesday, September 28, 2010 2:33:50 pm Pawel Jakub Dawidek wrote: > On Fri, Sep 24, 2010 at 09:23:04AM -0400, John Baldwin wrote: > > > Because disks are big and (again, just trying to explain my > > > understanding of what I inherited) we want all the support > >

Re: svn commit: r212964 - head/sys/kern

2010-09-28 Thread John Baldwin
On Tuesday, September 28, 2010 3:36:11 pm Pawel Jakub Dawidek wrote: > On Tue, Sep 28, 2010 at 03:04:11PM -0400, John Baldwin wrote: > > I'm suggesting they provide us the core.txt.X file, not the full minidump. > > A developer could then ask them to run specific comman

svn commit: r213268 - head/sys/dev/ral

2010-09-29 Thread John Baldwin
Author: jhb Date: Wed Sep 29 11:52:44 2010 New Revision: 213268 URL: http://svn.freebsd.org/changeset/base/213268 Log: If rt2560_bbp_init() fails, don't drop the lock as the callers of rt2560_init_locked() expect the lock to be held on return. Reported by: Anton Shterenlikht mexas of br

svn commit: r213271 - head/sys/sys

2010-09-29 Thread John Baldwin
Author: jhb Date: Wed Sep 29 13:24:56 2010 New Revision: 213271 URL: http://svn.freebsd.org/changeset/base/213271 Log: Account for unlocking a spin mutex in the lock profiling code in the !SMP case. Submitted by: truckman MFC after:3 days Modified: head/sys/sys/mutex.h Modified:

svn commit: r213300 - head/usr.bin/csup

2010-09-30 Thread John Baldwin
Author: jhb Date: Thu Sep 30 14:28:48 2010 New Revision: 213300 URL: http://svn.freebsd.org/changeset/base/213300 Log: If an RCS file is truncated, rcsfile_getdelta() will return NULL. Instead of faulting, check for NULL. However, returning an error would cause csup to just abort the entir

Re: svn commit: r213386 - head/usr.sbin/sysinstall

2010-10-08 Thread John Baldwin
TH_LIB32' flag similar to the existing 'WITH_SYSCONS', etc. flags in sysinstall.h so that there is only one place to update in the future to add support for lib32 on other platforms? -- John Baldwin ___ svn-src-all@freebsd.org mailing list htt

Re: svn commit: r213437 - in head/sys: conf modules/usb modules/usb/xhci

2010-10-08 Thread John Baldwin
added to the corresponding kernel config files as well > > as NOTES? > > Keep up the good work! > > Regards! > > //Niclas > > Yes, but I'm not sure who will do that. You should certainly go ahead and add it to NOTES. If it replaces the other *hci drivers then you

Re: svn commit: r213662 - in head: sbin/geom/class/concat sbin/geom/class/eli sbin/geom/class/journal sbin/geom/class/mirror sbin/geom/class/part sbin/geom/class/raid3 sbin/geom/class/shsec sbin/geom/

2010-10-11 Thread John Baldwin
e: > > movl$7, %esi > movl$.LC0, %edi > movl$0, %eax > callprintf > > And (though tastes differ) I think the sizeof() variant is less > readable. The strlen(_PATH_something) idiom is common in other parts > of the kernel out

svn commit: r213720 - stable/8/lib/libc/stdio

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 13:13:20 2010 New Revision: 213720 URL: http://svn.freebsd.org/changeset/base/213720 Log: MFC 205021: - Use an initializer macro to initialize fields in 'fake' FILE objects used by *sprintf(), etc. - Explicitly initialize _fl_mutex to PTHREAD_MUTEX_INITIALIZE

svn commit: r213721 - stable/8/sys/kern

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 15:26:13 2010 New Revision: 213721 URL: http://svn.freebsd.org/changeset/base/213721 Log: MFC 212974: Comment nit, set TDF_NEEDRESCHED after the comment describing why it is done rather than before. Modified: stable/8/sys/kern/sched_ule.c Directory Properties:

svn commit: r213722 - stable/7/sys/kern

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 15:26:37 2010 New Revision: 213722 URL: http://svn.freebsd.org/changeset/base/213722 Log: MFC 212974: Comment nit, set TDF_NEEDRESCHED after the comment describing why it is done rather than before. Modified: stable/7/sys/kern/sched_ule.c Directory Properties:

svn commit: r213723 - stable/8/sys/sys

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 15:48:14 2010 New Revision: 213723 URL: http://svn.freebsd.org/changeset/base/213723 Log: MFC 213271: Account for unlocking a spin mutex in the lock profiling code in the !SMP case. Modified: stable/8/sys/sys/mutex.h Directory Properties: stable/8/sys/ (pr

svn commit: r213724 - stable/7/sys/sys

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 15:48:27 2010 New Revision: 213724 URL: http://svn.freebsd.org/changeset/base/213724 Log: MFC 213271: Account for unlocking a spin mutex in the lock profiling code in the !SMP case. Modified: stable/7/sys/sys/mutex.h Directory Properties: stable/7/sys/ (pr

svn commit: r213726 - stable/8/sys/net

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 16:08:20 2010 New Revision: 213726 URL: http://svn.freebsd.org/changeset/base/213726 Log: MFC 213028,213328: - Expand scope of tun/tap softc locks to cover more softc fields and driver-maintained ifnet fields (such as if_drv_flags). - Use soft locks as the mu

svn commit: r213727 - stable/7/sys/net

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 16:09:08 2010 New Revision: 213727 URL: http://svn.freebsd.org/changeset/base/213727 Log: MFC 213028,213328: - Expand scope of tun/tap softc locks to cover more softc fields and driver-maintained ifnet fields (such as if_drv_flags). - Use soft locks as the mu

svn commit: r213728 - stable/8/sys/dev/ral

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 16:23:50 2010 New Revision: 213728 URL: http://svn.freebsd.org/changeset/base/213728 Log: MFC 213268: If rt2560_bbp_init() fails, don't drop the lock as the callers of rt2560_init_locked() expect the lock to be held on return. Modified: stable/8/sys/dev/ral/rt

svn commit: r213731 - stable/7/contrib/csup

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 17:09:33 2010 New Revision: 213731 URL: http://svn.freebsd.org/changeset/base/213731 Log: MFC 194070: Remove semicolon that should not have been there. Modified: stable/7/contrib/csup/rcsfile.c Directory Properties: stable/7/contrib/csup/ (props changed) Modi

svn commit: r213732 - stable/8/contrib/csup

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 17:12:13 2010 New Revision: 213732 URL: http://svn.freebsd.org/changeset/base/213732 Log: MFC 213300: If an RCS file is truncated, rcsfile_getdelta() will return NULL. Instead of faulting, check for NULL. However, returning an error would cause csup to just a

svn commit: r213733 - stable/7/contrib/csup

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 17:12:22 2010 New Revision: 213733 URL: http://svn.freebsd.org/changeset/base/213733 Log: MFC 213300: If an RCS file is truncated, rcsfile_getdelta() will return NULL. Instead of faulting, check for NULL. However, returning an error would cause csup to just a

svn commit: r213745 - stable/8/sys/i386/i386

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 19:28:20 2010 New Revision: 213745 URL: http://svn.freebsd.org/changeset/base/213745 Log: MFC 213226: Rewrite the i386 memory probe: - Check for SMAP data from the loader first. If it exists, don't bother doing any VM86 calls at all. This will be more frien

svn commit: r213746 - stable/7/sys/i386/i386

2010-10-12 Thread John Baldwin
Author: jhb Date: Tue Oct 12 19:28:33 2010 New Revision: 213746 URL: http://svn.freebsd.org/changeset/base/213746 Log: MFC 213226: Rewrite the i386 memory probe: - Check for SMAP data from the loader first. If it exists, don't bother doing any VM86 calls at all. This will be more frien

Re: svn commit: r213772 - head/sys/dev/acpica/Osd

2010-10-13 Thread John Baldwin
; without any warnings. Actually, I think this should have been removed when AcpiOsDerivePciId() was removed during the update to ACPICA 20100915. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all

svn commit: r213774 - head/bin/sh

2010-10-13 Thread John Baldwin
Author: jhb Date: Wed Oct 13 13:17:38 2010 New Revision: 213774 URL: http://svn.freebsd.org/changeset/base/213774 Log: Suggest that DEBUG_FLAGS be used to enable extra debugging rather than frobbing CFLAGS directly. DEBUG_FLAGS is something that can be specified on the make command line wit

svn commit: r213775 - head/bin/sh

2010-10-13 Thread John Baldwin
Author: jhb Date: Wed Oct 13 13:22:11 2010 New Revision: 213775 URL: http://svn.freebsd.org/changeset/base/213775 Log: Make DEBUG traces 64-bit clean: - Use %t to print ptrdiff_t values. - Cast a ptrdiff_t value explicitly to int for a field width specifier. While here, sort includes.

Re: svn commit: r213648 - head/sys/kern

2010-10-13 Thread John Baldwin
d it really be useful for them to do so. What barriers allow you to do is order the operations on a lock cookie (such as mtx_lock in mutexes) with respect to operations on other memory locations (e.g. the data a lock protects). By using a specific set of barriers and protocols for accessing the

Re: svn commit: r213744 - head/bin/sh

2010-10-13 Thread John Baldwin
UNCTIONS) goes too far > for me. To be honest, I think changing STATIC is excessive churn. The "right" fix is to use 'make DEBUG_FLAGS="-g -DDEBUG=2 -fno-inline"'. I often use 'make DEBUG_FLAGS="-g -fno-inline"' to workaround excessive inlining when debugging. I think all of the STATIC changes should just be backed out. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r213648 - head/sys/kern

2010-10-13 Thread John Baldwin
hich case its value is not stale. Yes. mtx_owned() (and mtx_assert()) depend on a similar "feature" in that stale values don't hurt. > On Wed, Oct 13, 2010 at 09:05:04AM -0400, John Baldwin wrote: > > On Tuesday, October 12, 2010 5:08:04 pm Gennady Proskurin wrote: >

Re: svn commit: r213793 - in head/sys/dev: ce cp

2010-10-13 Thread John Baldwin
his is wrong I think... the PP_FR was used for compiling in/out > > support for something.. see the comment: > > > > /* If we don't have Cronyx's sppp version, we don't have fr support > > via sppp */ #ifndef PP_FR > > #define PP_FR 0 > > #endif

Re: svn commit: r213813 - in head: share/man/man9 sys/kern sys/sys

2010-10-14 Thread John Baldwin
that does not rely on the lifetime of pointers being the same. This also > restores the task KBI. > > Suggested by: jhb > MFC after: 1 month Thanks! -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.

Re: svn commit: r213765 - head/sys/dev/aic7xxx/aicasm

2010-10-14 Thread John Baldwin
ot; (which failed as I described). > > I can confirm this: my build machine, which is > > FreeBSD beaver.rinet.ru 8.1-STABLE FreeBSD 8.1-STABLE #1 r213380M: Sun Oct 3 > 13:25:15 MSD 2010 > > is now failing 'buildworld buildkernel __MAKE_CONF=/dev/null' for HEAD > sources > both for TARGET=amd64 and i386 The tinderboxes are also failing (at least sun4v). -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r213845 - head/sys/dev/aic7xxx/aicasm

2010-10-14 Thread John Baldwin
the host lex instead of the lex built during buildworld. I will MFC the > lex changes soon and in a few weeks this I'll commit again r213765. Can't you make 'lex' a build-tool to workaround this? -- John Baldwin ___ svn-src-all@fr

Re: svn commit: r213845 - head/sys/dev/aic7xxx/aicasm

2010-10-15 Thread John Baldwin
On Thursday, October 14, 2010 5:09:58 pm Dimitry Andric wrote: > On 2010-10-14 21:39, John Baldwin wrote: > > On Thursday, October 14, 2010 3:19:19 pm Rui Paulo wrote: > ... > >>Revert r213765. This is required because our build infrastructure uses > >>the hos

Re: svn commit: r213845 - head/sys/dev/aic7xxx/aicasm

2010-10-15 Thread John Baldwin
On Friday, October 15, 2010 2:50:46 pm Rui Paulo wrote: > On 15 Oct 2010, at 13:45, John Baldwin wrote: > > > On Thursday, October 14, 2010 5:09:58 pm Dimitry Andric wrote: > >> On 2010-10-14 21:39, John Baldwin wrote: > >>> On Thursday, October 14

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-18 Thread John Baldwin
ution. Thus, places that actually actually call hardclock() should probably still be wrapped in a critical section. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-18 Thread John Baldwin
On Monday, October 18, 2010 3:06:15 pm Marius Strobl wrote: > On Mon, Oct 18, 2010 at 10:03:12AM -0400, John Baldwin wrote: > > On Sunday, October 17, 2010 12:46:54 pm Marius Strobl wrote: > > > Author: marius > > > Date: Sun Oct 17 16:46:54 2010 > > >

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-18 Thread John Baldwin
On Monday, October 18, 2010 4:52:24 pm Marius Strobl wrote: > On Mon, Oct 18, 2010 at 11:28:13PM +0300, Alexander Motin wrote: > > Marius Strobl wrote: > > > On Mon, Oct 18, 2010 at 10:03:12AM -0400, John Baldwin wrote: > > >> On Sunday, October 17, 2010 1

Re: svn commit: r213845 - head/sys/dev/aic7xxx/aicasm

2010-10-18 Thread John Baldwin
On Friday, October 15, 2010 4:28:40 pm John Baldwin wrote: > On Friday, October 15, 2010 2:50:46 pm Rui Paulo wrote: > > On 15 Oct 2010, at 13:45, John Baldwin wrote: > > > > > On Thursday, October 14, 2010 5:09:58 pm Dimitry Andric wrote: > > >> On

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-19 Thread John Baldwin
On Monday, October 18, 2010 5:41:57 pm Alexander Motin wrote: > Marius Strobl wrote: > > On Mon, Oct 18, 2010 at 05:05:24PM -0400, John Baldwin wrote: > >> On Monday, October 18, 2010 4:52:24 pm Marius Strobl wrote: > >>> AFAICT this is not true; intr_event_ha

Re: svn commit: r213985 - head/sys/sparc64/sparc64

2010-10-19 Thread John Baldwin
On Tuesday, October 19, 2010 9:37:15 am Alexander Motin wrote: > John Baldwin wrote: > > On Monday, October 18, 2010 5:41:57 pm Alexander Motin wrote: > >> Marius Strobl wrote: > >>> On Mon, Oct 18, 2010 at 05:05:24PM -0400, John Baldwin wrote: > >>>>

Re: svn commit: r214125 - head/sys/kern

2010-10-21 Thread John Baldwin
evh. The default case should look more like the removed code (except returning EOPNOTSUPP instead of 0 if there is no chainevh). -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubsc

svn commit: r214144 - head/sys/vm

2010-10-21 Thread John Baldwin
Author: jhb Date: Thu Oct 21 17:29:32 2010 New Revision: 214144 URL: http://svn.freebsd.org/changeset/base/214144 Log: - Make 'vm_refcnt' volatile so that compilers won't be tempted to treat its value as a loop invariant. Currently this is a no-op because 'atomic_cmpset_int()' clobbers

svn commit: r214146 - head/sys/dev/pci

2010-10-21 Thread John Baldwin
Author: jhb Date: Thu Oct 21 17:46:23 2010 New Revision: 214146 URL: http://svn.freebsd.org/changeset/base/214146 Log: Clarify a misleading comment. The test in pci_reserve_map() was meant to ignore BARs that are invalid due to having a size of zero, not to ignore BARs with an existing base

Re: svn commit: r214144 - head/sys/vm

2010-10-21 Thread John Baldwin
On Thursday, October 21, 2010 2:19:21 pm Ed Schouten wrote: > Hi John, > > * John Baldwin , 20101021 19:29: > > + if (atomic_fetchadd_int(&vm->vm_refcnt, -1) == 1) > > vmspace_dofree(vm); > > Not that it's that useful, but maybe it would b

svn commit: r214158 - in head/sys: kern sys

2010-10-21 Thread John Baldwin
Author: jhb Date: Thu Oct 21 19:17:40 2010 New Revision: 214158 URL: http://svn.freebsd.org/changeset/base/214158 Log: - When disabling ktracing on a process, free any pending requests that may be left. This fixes a memory leak that can occur when tracing is disabled on a process via di

Re: svn commit: r214125 - head/sys/kern

2010-10-21 Thread John Baldwin
On Thursday, October 21, 2010 3:08:12 pm Xin LI wrote: > On 10/21/10 04:46, John Baldwin wrote: > > On Thursday, October 21, 2010 4:57:25 am Xin LI wrote: > >> Author: delphij > >> Date: Thu Oct 21 08:57:25 2010 > >> New Revision: 214125 > >> URL:

svn commit: r214203 - head/sys/dev/pci

2010-10-22 Thread John Baldwin
Author: jhb Date: Fri Oct 22 11:42:02 2010 New Revision: 214203 URL: http://svn.freebsd.org/changeset/base/214203 Log: - Add a new PCI quirk to whitelist an old chipset that doesn't support PCI-express or PCI-X capabilities if we are running in a virtual machine. - Whitelist the Intel 8244

svn commit: r214346 - in head/sys: amd64/include i386/i386 i386/include

2010-10-25 Thread John Baldwin
Author: jhb Date: Mon Oct 25 15:28:03 2010 New Revision: 214346 URL: http://svn.freebsd.org/changeset/base/214346 Log: Use intr_disable() and intr_restore() instead of frobbing the flags register directly to disable interrupts. Reviewed by: bde (earlier version) MFC after:2 weeks

svn commit: r214347 - in head/sys: amd64/amd64 i386/i386 i386/isa x86/x86

2010-10-25 Thread John Baldwin
Author: jhb Date: Mon Oct 25 15:31:13 2010 New Revision: 214347 URL: http://svn.freebsd.org/changeset/base/214347 Log: Use 'saveintr' instead of 'savecrit' or 'eflags' to hold the state returned by intr_disable(). Requested by: bde Modified: head/sys/amd64/amd64/fpu.c head/sys/i386/i

svn commit: r214396 - head/usr.sbin/mfiutil

2010-10-26 Thread John Baldwin
Author: jhb Date: Tue Oct 26 19:11:09 2010 New Revision: 214396 URL: http://svn.freebsd.org/changeset/base/214396 Log: - Save errno values before calling warn(3) so that errors are correctly reported. - Use powerof2() from rather than a copy and paste version. Submitted by: gcooper

svn commit: r214448 - in head/sys: amd64/amd64 i386/i386

2010-10-28 Thread John Baldwin
Author: jhb Date: Thu Oct 28 13:44:19 2010 New Revision: 214448 URL: http://svn.freebsd.org/changeset/base/214448 Log: Use 'PCPU_GET(apic_id)' to determine the BSP's APIC ID on a UP machine when routing interrupts instead of cpu_apic_ids[0] since cpu_apic_ids[] is only populated for multiple

svn commit: r214449 - head/sys/kern

2010-10-28 Thread John Baldwin
Author: jhb Date: Thu Oct 28 14:17:06 2010 New Revision: 214449 URL: http://svn.freebsd.org/changeset/base/214449 Log: Set bootverbose directly in mi_startup() rather than via a SYSINIT. This ensures 'bootverbose' is in a valid state for all SYSINITs. Reported by: avg MFC after:1

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-28 Thread John Baldwin
gt; + if (res == NULL) > + panic("ram_attach: resource %d failed to attach", rid); > + rid++; > + } > + return (0); > +} > +#else > static int > ram_attach(device_t dev) > { > @@ -688,6 +743,7 @@ ram_attach

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-28 Thread John Baldwin
On Thursday, October 28, 2010 1:21:34 pm Attilio Rao wrote: > 2010/10/28 John Baldwin : > > On Thursday, October 28, 2010 12:31:39 pm Attilio Rao wrote: > >> Author: attilio > >> Date: Thu Oct 28 16:31:39 2010 > >> New Revision: 214457 > >> URL:

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-28 Thread John Baldwin
On Thursday, October 28, 2010 2:11:40 pm John Baldwin wrote: > On Thursday, October 28, 2010 1:21:34 pm Attilio Rao wrote: > > + vm_paddr_t *p; > > caddr_t kmdp; > > uint32_t smapsize; > > - int error, rid; > > + int error, i, rid;

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-28 Thread John Baldwin
On Thursday, October 28, 2010 4:28:12 pm Attilio Rao wrote: > 2010/10/28 John Baldwin : > > On Thursday, October 28, 2010 1:21:34 pm Attilio Rao wrote: > >> 2010/10/28 John Baldwin : > >> > On Thursday, October 28, 2010 12:31:39 pm Attilio Rao wrote: > >> &

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-29 Thread John Baldwin
On Thursday, October 28, 2010 8:25:38 pm Attilio Rao wrote: > 2010/10/28 John Baldwin : > > On Thursday, October 28, 2010 4:28:12 pm Attilio Rao wrote: > >> 2010/10/28 John Baldwin : > >> > On Thursday, October 28, 2010 1:21:34 pm Attilio Rao wrote: > >> &g

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-29 Thread John Baldwin
On Friday, October 29, 2010 10:17:23 am Attilio Rao wrote: > 2010/10/29 John Baldwin : > > On Thursday, October 28, 2010 8:25:38 pm Attilio Rao wrote: > >> 2010/10/28 John Baldwin : > >> > On Thursday, October 28, 2010 4:28:12 pm Attilio Rao wrote: > >> &g

Re: svn commit: r214457 - in head/sys: amd64/amd64 conf i386/i386 x86/x86

2010-10-29 Thread John Baldwin
On Friday, October 29, 2010 10:33:05 am Attilio Rao wrote: > 2010/10/29 John Baldwin : > > On Friday, October 29, 2010 10:17:23 am Attilio Rao wrote: > >> 2010/10/29 John Baldwin : > >> > On Thursday, October 28, 2010 8:25:38 pm Attilio Rao wrote: > >> &g

svn commit: r214523 - head/usr.sbin/config

2010-10-29 Thread John Baldwin
Author: jhb Date: Fri Oct 29 19:17:07 2010 New Revision: 214523 URL: http://svn.freebsd.org/changeset/base/214523 Log: Remove support for creating the 'machine' symlink as well as creating the extra MACHINE_ARCH symlink for certain platforms (such as pc98). The support for creating these sy

svn commit: r214625 - head/usr.bin/kdump

2010-11-01 Thread John Baldwin
Author: jhb Date: Mon Nov 1 15:18:57 2010 New Revision: 214625 URL: http://svn.freebsd.org/changeset/base/214625 Log: Correct the abbreviations for general I/O and signal traces. PR: docs/151854 Submitted by: Stephen Veiss stephen of brokenbottle net MFC after:3 days Mo

svn commit: r214629 - in head: include sys/conf sys/x86/include

2010-11-01 Thread John Baldwin
Author: jhb Date: Mon Nov 1 17:34:04 2010 New Revision: 214629 URL: http://svn.freebsd.org/changeset/base/214629 Log: Add an x86/include directory to the kernel to hold headers that are common to amd64, i386, and pc98. The headers are installed to /usr/include/x86 during an installworld, a

svn commit: r214630 - in head/sys: amd64/acpica amd64/amd64 amd64/include i386/acpica i386/i386 i386/include pc98/include pc98/pc98 x86/include x86/x86

2010-11-01 Thread John Baldwin
Author: jhb Date: Mon Nov 1 17:40:35 2010 New Revision: 214630 URL: http://svn.freebsd.org/changeset/base/214630 Log: Move the header to . Added: head/sys/x86/include/mca.h - copied, changed from r214624, head/sys/amd64/include/mca.h Deleted: head/sys/amd64/include/mca.h head/sys/i

  1   2   3   4   5   6   7   8   9   10   >