Thank you for the suggested code.
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.04
- the provided method is used to draw triangles in BasicArrowButton class
- shift to one pixel right is added for the triangles drawing
- AA rendering hint is
On 20.09.16 15:04, Alexandr Scherbatiy wrote:
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
Not
Hello Alok,
Is it possible to update the line where File.exists() is used just
converting the file to a Path and using java.nio.exists() check?
Thanks,
Alexandr.
On 9/16/2016 1:20 PM, Alexey Ivanov wrote:
Hi Alok,
This change should be discussed on swing-dev mailing list because
On 9/20/2016 3:04 PM, Alexandr Scherbatiy wrote:
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
I would rewrite the method that draws triangle to simplify it:
private void paintScaledTriangle(Graphics g, double x, double y,
double size,
int direction, boolean isEnabled) {
size = Math.max(size , 2);
Path2D.Double path = new
On 9/20/2016 3:22 PM, Alexandr Scherbatiy wrote:
On 9/20/2016 2:02 PM, Semyon Sadetsky wrote:
Thanks, that helped.
Did you think about changing the DefaultCaret class to use the new 2D
API in case it is allowed for the component ?
DefaultCaret class extends Rectangle so it always uses int
On 9/20/2016 2:02 PM, Semyon Sadetsky wrote:
Thanks, that helped.
Did you think about changing the DefaultCaret class to use the new 2D
API in case it is allowed for the component ?
DefaultCaret class extends Rectangle so it always uses int coordinates.
I filled an enhancement to support
On 9/20/2016 1:56 PM, Semyon Sadetsky wrote:
Hi Alexander,
why in the TextUI class the new viewToModel2D and modelToView2D
methods implementations fall-back to the deprecated ones?
TextUI is a public abstract class. There is no way to add a new
abstract method to it and keep a backward
On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote:
[2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png
[3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png
Radio buttons are still not ideal. Have you
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165594/webrev.02
The code formatting issues are updated.
On 9/14/2016 8:02 PM, Semyon Sadetsky wrote:
Hi Alexander,
When I press the arrow button (for example in the "111" combo) several
times I can see
On 9/16/2016 11:22 AM, Andrej Golovnin wrote:
Hi Alexandr,
thanks! It looks much better now.
http://cr.openjdk.java.net/~alexsch/8165594/webrev.01
src/java.desktop/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
490 if(isScaledGraphics){
Spaces are
+1
--Semyon
On 20.09.2016 03:31, Sergey Bylokhov wrote:
Looks fine.
On 15.09.16 12:31, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8165234/webrev.02
The closeOnMouseClick property is renamed to doNotCloseOnMouseClick
Yet another question: Why the floating point API doesn't work for JTextPane?
Also it doesn't work for JTextArea, JTextField and JTextPane if i18n is on.
--Semyon
On 12.09.2016 15:19, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
all changes:
Thanks, that helped.
Did you think about changing the DefaultCaret class to use the new 2D
API in case it is allowed for the component ?
--Semyon
On 19.09.2016 22:43, Alexandr Scherbatiy wrote:
This is the known issue: JDK-8163175 PlainView.modelToView() method
should return Rectangle2D
Hi Alexander,
why in the TextUI class the new viewToModel2D and modelToView2D methods
implementations fall-back to the deprecated ones?
--Semyon
On 12.09.2016 15:19, Alexandr Scherbatiy wrote:
Hello,
Could you review the updated fix:
all changes:
On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote:
On 9/14/2016 11:51 AM, Semyon Sadetsky wrote:
On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote:
On 9/13/2016 8:49 PM, Semyon Sadetsky wrote:
On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote:
On 9/13/2016 8:34 PM, Semyon Sadetsky wrote:
On
16 matches
Mail list logo
