Re: Nimbus class extending.

On 5/5/2017 2:08 PM, Ashutosh Pandey wrote: Hello, I was wondering if someone can offer an advice on how can I modify Nimbus L& F classes. We have used Nimbus L in a sizable desktop product. But lately our customers have been reporting class cast exceptions which upon some digging appears

Re: [9] RFR Backport of 8160893: [macosx] JMenuItems in JPopupMenu are not accessible

On 4/27/2017 3:34 PM, Mikhail Cherkasov wrote: Hi all, Could you please review a backport of 8160893 to jdk8? The backport looks good to me. Should the email subject be [8] RFR Backport...? Thanks, Alexandr. The fix is the same, the only difference in CAccessibility.java

Re: [9] Review request for 8179027: JComboBox too small under Windows LAF

The fix looks good to me. Thanks, Alexandr. On 4/25/2017 6:55 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8179027 webrev: http://cr.openjdk.java.net/~ssadetsky/8179027/webrev.00/ This a regression introduced by JDK-6490753.

Re: [9] Review request for 8140237: [TEST_BUG]Test javax/swing/plaf/nimbus/8041642/bug8041642.java fails for OEL 7

The fix looks good to me. Thanks, Alexandr. On 4/21/2017 8:29 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8140237 webrev: http://cr.openjdk.java.net/~ssadetsky/8140237/webrev.00/ Delay was fixed to improve test stability on

Re: [9] Review Request: 8076249: NPE in AccessBridge while editing JList model

The fix looks good to me. Thanks, Alexandr. On 4/13/2017 6:57 PM, Mikhail Cherkasov wrote: On 4/13/2017 6:31 PM, Phil Race wrote: 31 import javax.swing.*; Fixed:

Re: JDK-8178091 : Bug I will workin on

Hi Patrick, Please, sign the OCA [1], use the JDK 10 client repository [2] and prepare the webrev [3] of the fix with the test. [1] http://www.oracle.com/technetwork/community/oca-486395.html [2] http://hg.openjdk.java.net/jdk10/client [3] http://openjdk.java.net/guide/webrevHelp.html

Re: [9] Review Request: 8177450: javax.swing.text.html.parser.Parser parseScript ignores a character after commend end

The fix looks good to me. Thanks, Alexndr. On 4/9/2017 10:33 PM, Mikhail Cherkasov wrote: Ok, thank you! On 4/9/2017 9:41 PM, Philip Race wrote: No more comments. That's fine. -phil. On 4/9/17, 11:24 AM, Mikhail Cherkasov wrote: Hi Phil, Do you have any other comments about the fix?

Re: [9] Review Request: 8177450: javax.swing.text.html.parser.Parser parseScript ignores a character after commend end

The fix looks good to me. Thanks, Alexandr. On 3/31/2017 2:28 PM, Mikhail Cherkasov wrote: Hello, Could you please review the fix for jdk9? The problem is that Parser reads extra symbol after comment or script tag and missed the symbol. I added 'continue' after those tags, so it goes to

Re: RFR: 8043773: Deprecate JComponent.AccessibleJComponent.AccessibleFocusHandler

The fix looks good to me. Thanks, Alexandr. On 3/28/2017 1:41 AM, Phil Race wrote: webrev: http://cr.openjdk.java.net/~prr/8043773/ bug : https://bugs.openjdk.java.net/browse/JDK-8043773 This just deprecates the un-used, un-needed inner classs. A CCC was approved ages ago however the fix

Re: [9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

fix. Thanks, Alexandr. -phil. On 03/16/2017 09:03 AM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176883 webrev: http://cr.openjdk.java.net/~alexsch/8176883/webrev.00 Metal RadioButton and RadioButtonMenuItem ico

Re: [9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

r. -phil. On 03/16/2017 09:03 AM, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176883 webrev: http://cr.openjdk.java.net/~alexsch/8176883/webrev.00 Metal RadioButton and RadioButtonMenuItem icons are not drawn smoothly on HiDP

[9] Review request for 8176883 Enable antialiasing for Metal L icons on HiDPI display

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8176883 webrev: http://cr.openjdk.java.net/~alexsch/8176883/webrev.00 Metal RadioButton and RadioButtonMenuItem icons are not drawn smoothly on HiDPI displays especially with floating point scales like 1.25

Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

I prepared the image [1] which contains the middle.gif icon from the MenuSelectionManagerDemo drawn with scales from the top to the bottom 1, 1.25, 1.5, 2 and the interpolation rendering hint from the left to the right: not set, NEAREST_NEIGHBOR, BILINEAR, BICUBIC. If it may sense to add

Re: [9] Review Request: 8176448 [macos] Popups in JCombobox and Choice have incorrect location in multiscreen systems

The fix looks good to me. Thanks, Alexandr. On 3/14/2017 6:12 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In the fixes for JDK-7072653 [1] and JDK-8129838 [2] and JDK-8144161[3] [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/7606d0af7b80 Notes about JDK-7072653 -

Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

On 3/14/2017 7:31 PM, Sergey Bylokhov wrote: The initial image at [1] also show some issues in the submenu pointer and the menu corners, did we solve them already? The submenu icon is updated in the current fix and the issue with a menu corner is covered by the fix JDK-8162350

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

On 3/14/2017 3:37 PM, Philip Race wrote: I am not sure why the test went to the trouble of looking for Arial. If there was a good reason (Alexander ??) an alternative is to initialise The test tries to calculate number of intersection with letter O and its underline. It is sensitive to the

[9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8174845 webrev: http://cr.openjdk.java.net/~alexsch/8174845/webrev.00 Metal JCheckBox and JMenuItem icons are updated to be drawn by ovals, arcs and polygons. The [1] folder contains screenshots how icons

Re: Java_Swings/AWT Native Interface give error in 32-bit window OS

Forwarded to the awt-dev alias. Thanks, Alexandr. On 3/7/2017 8:50 AM, mahendrag gajera wrote: Hello All, I follow step as mention in below link and create .dll and java application. https://en.wikibooks.org/wiki/Java_Swings/AWT. Every things work fine in window 7/8 64-bit OS. In

Re: [9] Review Request: 8176177 The new SwingContainer annotation can be removed from javax.accessibility.AccessibleContext

The fix looks good to me. Thanks, Alexandr. On 3/6/2017 5:00 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. When the new annotation SwingContainer was added to the Swing library, we applied it to all classes where the old compile time bean-info has an isContainer=false

Re: [9] Review Request: 8158209 Editing in TableView breaks the layout, when the document is I18n

- all the text come back on the same line. There no such artifacts when i18n is false. Thanks for your help. Guy. ----- Le 2016-05-27 16:53, Alexandr Scherbatiy a écrit : The fix should be prepared for the

Re: Review request for JDK-6490753 JComboBox doesn't look as native combobox in different states of component

e was 3) 609 setBorder(new EmptyBorder(0, 2, 0, i.right)); (previous value was 3 as well) br Martin 2017-02-03 13:31 GMT+01:00 Alexandr Scherbatiy <alexandr.scherba...@oracle.com <mailto:alexandr.scherba...@oracle.com>>: On 2/1/2017 3:41 PM, Martin M wrote: bug: https:/

Re: [9] Review Request: 8176046 Replace package.html files with package-info.java in the java.desktop module

The fix looks good to me. Thanks, Alexandr. On 3/1/2017 9:37 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. This is the last request which covers all packages in java.desktop(except javax.swing and java.awt which were covered earlier) - All "package.html" files were

Re: [9] Review request for 8171808: Performance problems in dialogs with large tables when JAB activated

The fix looks good to me. Thanks, Alexandr. On 3/1/2017 9:20 PM, Sergey Bylokhov wrote: Looks fine. 28 февр. 2017 г., в 17:40, Mikhail Cherkasov написал(а): Hi Sergey, Alexander, I have to revert the fix back to first version:

Re: [9] Review request for 8171808: Performance problems in dialogs with large tables when JAB activated

The fix looks good to me. The second version also contains the extra semicolon on the line 4542. Thanks, Alexandr. On 2/27/2017 5:07 PM, Mikhail Cherkasov wrote: Hi again, with this implementation I see a runtime exception, I see it in AccessBridge. getAccessibleNameFromContext.

Re: [9] Review Request: 8175266 Use package-info.java instead of package.html within swing packages

The fix looks good to me. Thanks, Alexandr. On 2/20/2017 5:05 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. - All "package.html" files were replaced by "package-info.java" in javax.swing package and its subpackages. - All were replaced by {@tag }. - Some unnecessary

Re: Testing Latest OpenJDK Swing Build

On 2/20/2017 9:49 PM, Landon Blake wrote: I'd like to help with the development of Swing in OpenJDK. Is there a recent build of the Swing code that I can test? Or do I need to build the source code myself? The JDK 9 Early Access Releases is available to download from [1]. To build JDK 9

Re: Review request for JDK-6490753 JComboBox doesn't look as native combobox in different states of component

On 2/1/2017 3:41 PM, Martin M wrote: bug: https://bugs.openjdk.java.net/browse/JDK-6490753 webrev: http://cr.openjdk.java.net/~alexsch/mraz.martin/6490753/webrev.00

Re: RFR: 8173409: make setMixingCutoutShape public and remove jdk.desktop

The fix looks good to me. Thanks, Alexandr. On 1/31/2017 11:28 AM, Sergey Bylokhov wrote: Looks fine. Bug: https://bugs.openjdk.java.net/browse/JDK-8173409 Webrev: http://cr.openjdk.java.net/~prr/8173409/ In OpenJDK the jdk.desktop module (not java.desktop) has only one method. It is the

Re: [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

The fix looks good to me. Thanks, Alexandr. On 1/12/2017 10:04 AM, Prasanta Sadhukhan wrote: Hi All, Please review the name change for this regression test which was causing jtreg to fail as it was not finding the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8172558 Filename was

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

On 1/11/2017 2:01 PM, Avik Niyogi wrote: Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ With Regards, Avik Niyogi On

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

the object fields updating. There is still no guarantee that all works as expected if a Swing component is constructed in non-EDT. Thanks, Alexandr. -phil. On 12/15/2016 09:06 AM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch

Re: [9] Review request for 8133919 [macosx] JTable grid lines are incorrectly positioned on HiDPI display

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8133919/webrev.01 The test is converted to the automated. Thanks, Alexandr. On 12/15/2016 1:24 PM, Sergey Bylokhov wrote: Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8133919

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

PM, Sergey Bylokhov wrote: Hi, Alexander. Should not the storage be based on soft references? In the current solution we will store the references to the checked classes forever in the static map. 13 дек. 2016 г., в 18:41, Alexandr Scherbatiy <alexandr.scherba...@oracle.com> нап

[9] Review request for 8133919 [macosx] JTable grid lines are incorrectly positioned on HiDPI display

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8133919 webrev: http://cr.openjdk.java.net/~alexsch/8133919/webrev.00 Draw lines calls are replaced by SwingUtilities2.drawHLine()/drawVLine in BasicTableUI. The added test is manual because the Robot takes

[9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8169922 webrev: http://cr.openjdk.java.net/~alexsch/8169922/webrev.00 The fix JDK-8156217 checks presence of the overridden methods with floating point arguments. The proposed fix caches results of found

Re: RFR: 8171074 : Test api/javax_swing/UIManager/index.html\#Methods is failing

The fix looks good to me. Thanks, Alexandr. On 12/13/2016 12:42 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8171074 Webrev: http://cr.openjdk.java.net/~prr/8171074/ Other than the @SuppressWarnings, UIManager.setLookAndFeel(String className) is now reverted to how it

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: On 11/30/2016 2:53 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review a fix for a continuation/regression of JDK-8081491

Re: [9] Review request for 8074883: Tab key should move to focused button in a button group

The fix looks good to me. Thanks, Alexandr. On 11/29/2016 7:42 PM, Semyon Sadetsky wrote: Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.03/ changes: - according to Sergey's suggestion in the specs term "focusable" is replaced with "can be the focus

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

ce between paintDoubleBufferedImpl vs paintDoubleBufferedFPScales? At least in terms of heavyweight operations it looks similar, and probably we can have only one of them? It has an additional benefits that the new code will be tested on the usual system as well. On 21.11.16 16:59, Alexandr Scherb

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

16:59, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8162350/webrev.04 - isFloatingPointScale(AffineTransform) is moved from the SunGraphics2D to the SwingUtilities2 class. Thanks, Alexandr. On 11/18/2016 11:23 PM, Jim Graham

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

. --Semyon On 7/21/2016 4:40 PM, Semyon Sadetsky wrote: On 7/21/2016 2:51 PM, Alexandr Scherbatiy wrote: On 7/20/2016 4:46 PM, Semyon Sadetsky wrote: On 7/20/2016 2:29 PM, Alexandr Scherbatiy wrote: On 7/20/2016 10:18 AM, Semyon Sadetsky wrote: On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the java.desktop module.

Re: RFR: 8169887: javax/swing/JEditorPane/8080972/TestJEditor.java, javax/swing/text/View/8080972/TestObjectView.java are failing

The fix looks good to me. Thanks, Alexandr. On 11/18/2016 9:21 PM, Sergey Bylokhov wrote: Looks fine. On 18.11.16 21:08, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8169887 webrev : http://cr.openjdk.java.net/~prr/8169887/ 8155874 changed many calls from the deprecated

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

- Region.clipRound() is used for pixels coordinates rounding. Thanks, Alexandr. On 11/16/2016 1:52 AM, Jim Graham wrote: Let me clarify something... On 11/15/16 2:49 AM, Alexandr Scherbatiy wrote: Let's consider the following use case: scale = 1.5 A component calls fillRect(1, 1, 1, 1

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

() is used for pixels coordinates rounding. Thanks, Alexandr. On 11/16/2016 1:52 AM, Jim Graham wrote: Let me clarify something... On 11/15/16 2:49 AM, Alexandr Scherbatiy wrote: Let's consider the following use case: scale = 1.5 A component calls fillRect(1, 1, 1, 1). This is (1.5

Re: [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

: The assumption that just because values *can* be non-integral that they *will* be non-integral is not valid. Even if you know that the probability is small, it is not zero. This seems like it could lead to spurious failures of this test. -phil. On 11/15/2016 09:18 AM, Alexandr Scherbatiy wrote

Re: [9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

ressWarnings("deprecation")"is removed The test is not suitable for Mac OS X because chars advances on Mac OS X have integer values. Thanks, Alexandr. On 15.11.16 16:49, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.ja

[9] Review request for 8169719 WrappedPlainView.modelToView() should return Rectangle2D

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8169719 webrev: http://cr.openjdk.java.net/~alexsch/8169719/webrev.00 WrappedPlainView.modelToView() method is updated to use Utilities.getTabbedTextWidth() which returns floating point text width. Thanks,

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

On 11/15/2016 2:44 AM, Jim Graham wrote: I want to clarify the following issue... On 10/24/2016 9:11 AM, Alexandr Scherbatiy wrote: Using floating point scale leads that drawing the same thing from different coordinates gives different results. For example filling a rectangle with size (1, 1

Re: RFR: 8169518: Suppress Deprecation warnings for deprecated Swing APIs

The fix looks good to me. Thanks, Alexandr. On 11/10/2016 8:50 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8169518 Webrev: http://cr.openjdk.java.net/~prr/8169518 The last set of deprecation warnings to be suppressed or fixed in desktop - so with this fix we can

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

e translate is in device pixels, it shouldn't matter where in the buffer you render it, so it should be enough to just ensure integer translations - did you try using an integer origin for the rendering instead? ...jim On 10/24/2016 9:11 AM, Alexandr Scherbatiy wrote: He

Re: [9] Review request for 8075084: https://bugs.openjdk.java.net/browse/JDK-8075084

On 10/25/2016 4:24 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8075084 webrev: http://cr.openjdk.java.net/~ssadetsky/8075084/webrev.00/ When a modal dialog is shown in scroll bar button click listener it blocks all events

Re: RFR: 8155874: Fix java.desktop deprecation warnings about Class.newInstance

The fix looks good to me. Thanks, Alexandr. On 11/7/2016 10:12 PM, Sergey Bylokhov wrote: Looks fine. On 07.11.16 21:49, Phil Race wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8155874 Webrev: http://cr.openjdk.java.net/~prr/8155874/ This hits all across the desktop module, hence the

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

: It seems that most of our deprecated api have an annotation and a javadoc tag. I guess we should add javadoc tag here as well. On 28.10.16 14:04, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 10/28/2016 7:19 AM, Prasanta Sadhukhan wrote: Please find the webrev

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

The fix looks good to me. Thanks, Alexandr. On 10/31/2016 9:31 PM, Jim Graham wrote: Looks good. +1 ...jim On 10/30/16 11:53 PM, Avik Niyogi wrote: Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews.

Re: [9] Review request for 8153522: Update JLightweightFrame to allow non-integer (and X/Y) scales

The fix looks good to me. Thanks, Alexandr. On 10/28/2016 9:59 AM, Semyon Sadetsky wrote: On 10/25/2016 8:17 PM, Alexandr Scherbatiy wrote: On 9/29/2016 10:55 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153522 webrev: http

[9] Review request for 8168992 Add floating point implementation for new BasicGraphicsUtils text related methods use floating point API

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8168992 webrev: http://cr.openjdk.java.net/~alexsch/8168992/webrev.00 The fix JDK-8132119 added stubs for the following methods: BasicGraphicsUtils.drawString(JComponent c, Graphics2D g, String string,

[9] Review request for 8168899 java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8168899 webrev: http://cr.openjdk.java.net/~alexsch/8168899/webrev.00 It has been already discussed in the thread http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006803.html However, the

Re: [9] RFR JDK-8048702: Deprecate obsolete classes in javax/swing/plaf/metal/MetalFileChooserUI.java

On 10/26/2016 10:28 AM, Prasanta Sadhukhan wrote: Hi All, Please review a fix for the issue where this obsolete class needs to be deprecated: Bug: https://bugs.openjdk.java.net/browse/JDK-8048702 diff -r aae3690e53e3

Re: [9] Review request for 8153522: Update JLightweightFrame to allow non-integer (and X/Y) scales

On 9/29/2016 10:55 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8153522 webrev: http://cr.openjdk.java.net/~ssadetsky/8153522/webrev.00/ LightweightFrame Swing embedding API is updated for capability with floating point scale

Re: [9] Review request for 8075904: The regression-swing case failed as Ctrl-F4 can't work with the special options"-client -Dswing.defaultlaf=javax.swing.plaf.nimbus.NimbusLookAndFeel"

The fix looks good to me. Thanks, Alexandr. On 10/25/2016 2:29 AM, Sergey Bylokhov wrote: Looks fine. On 21.10.16 19:22, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8075904 webrev:

Re: [9] Review request for 8074883: Tab key should move to focused button in a button group

On 10/19/2016 8:14 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8074883 webrev: http://cr.openjdk.java.net/~ssadetsky/8074883/webrev.00/ To avoid unexpected selection change the selected button of a button group should always

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

The fix looks good to me. Thanks, Alexandr. On 10/24/2016 1:18 PM, Erik Joelsson wrote: The last change looks good and simple to me. /Erik On 2016-10-21 06:55, Pete Brunet wrote: Please see the latest update http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/ The fix now is to

Re: [9] Review request for 8027639: JComboBox's popup leaves tracks after closing

On 10/10/2016 12:55 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8027639 webrev: http://cr.openjdk.java.net/~ssadetsky/8027639/webrev.00/ When the Swing repaint manager paints Swing to a separate off-screen buffer the root

Re: RFR: PIT Bug 8167988 : java.nio.file.InvalidPathException if click button in JFileChooser demo of SwingSet2

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8167988/webrev.00 - Path creation is moved under instanceof ShellFolder check - Paths.get(file.getPath()) is changed to file.toPath() Thanks, Alexandr. On 10/25/2016 9:36 AM, Semyon Sadetsky wrote: It seems the

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

than just drawing the same component from the new location. The fix suggests to disable the JScrollPane area copying for floating point scales. Thanks, Alexandr. On 10/7/2016 4:30 PM, Alexandr Scherbatiy wrote: On 10/6/2016 11:42 PM, Sergey Bylokhov wrote: Hi, Alexandr. Can you please provide

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

() method is made private Thanks, Alexandr. On 10/18/2016 8:23 PM, Phil Race wrote: On 10/18/2016 03:54 AM, Alexandr Scherbatiy wrote: On 10/18/2016 12:42 AM, Philip Race wrote: Hi, First note that any of the alternatives here require an approved CCC before pushing. As I wrote in the bug

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

ndr. -phil. On 10/17/16, 4:22 AM, Alexandr Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8167176/webrev.01 MetalBorders.bumps and MetalScrollBarUI.bumps fields are nor marked for removal any more. Thanks, Alexandr. On 10/14/

Re: [9] Review request for 8167176 Exported elements referring to inaccessible types in java.desktop

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8167176/webrev.01 MetalBorders.bumps and MetalScrollBarUI.bumps fields are nor marked for removal any more. Thanks, Alexandr. On 10/14/2016 3:23 PM, Sergey Bylokhov wrote: Is it necessary to remove

Re: [9] Review request for 8163167: [PIT] javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java always fail

The fix looks good to me. Thanks, Alexandr. On 10/14/2016 8:52 PM, Sergey Bylokhov wrote: On 03.10.16 12:35, Semyon Sadetsky wrote: But if layout was done, why we get any notifications? Should the check be (cnt != 0)? Okay. I have changed it to zero:

Re: [9] Review request for 8164321: Crash of SwingNode with GTK LaF

The fix looks good to me. Thanks, Alexandr. On 10/11/2016 8:56 PM, Alexander Zvegintsev wrote: +1 On 10/6/16 11:18 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8164321 webrev:

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

[5] ENLARGED_SCALED_BACKBUFFER compare: http://cr.openjdk.java.net/~alexsch/8162350/results/rect-%5b7%2c5%2c11%2c9%5d/screenshot-05-%5b7%2c5%2c11%2c9%5d-enlarged-scaled-backbuffers-compare.png Thanks, Alexandr. On 06.10.16 20:07, Alexandr Scherbatiy wrote: Hello, Could yo

[9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8162350 webrev: http://cr.openjdk.java.net/~alexsch/8162350/webrev.00 The fix uses the solution suggest by Jim in the email: http://mail.openjdk.java.net/pipermail/2d-dev/2016-October/007737.html To draw to

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/20/2016 10:40 AM, Semyon Sadetsky wrote: On 9/20/2016 12:00 AM, Alexandr Scherbatiy wrote: On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

suggesting to make the paintTriangle() method accept floating point coordinates to get more precise location and size for the scaled version. Optionally, 2D AA hints can be added to get better appearance for scales 1.25, 1.5, 1.75. --Semyon On 9/20/2016 2:58 PM, Alexandr Scherbatiy wrote

Re: OpenJDK JDK-7067885 code changes for community review

Hello Alok, Is it possible to update the line where File.exists() is used just converting the file to a Path and using java.nio.exists() check? Thanks, Alexandr. On 9/16/2016 1:20 PM, Alexey Ivanov wrote: Hi Alok, This change should be discussed on swing-dev mailing list because

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

new floating point version of the caret. JDK-8163174 Add DefaultCaret2D which supports floating point API https://bugs.openjdk.java.net/browse/JDK-8163174 Thanks, Alexandr. --Semyon On 19.09.2016 22:43, Alexandr Scherbatiy wrote: This is the known issue: JDK-8163175

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

getTabSize(); -} - It seems this was added only in 9. Since I think I remember that asking a question about it. I note it has no @since. Moot if you are really removing it but what has it to do with the rest of this change ? -phil. On 9/9/16, 11:51 AM, Alexandr Scherbatiy wrote: Hello, Could

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

On 9/20/2016 2:56 PM, Alexandr Scherbatiy wrote: [2] http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png [3] http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png Radio buttons are still not ideal. Have you

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

I can see artifacts. They are well seen in scale x4. I have filled an issue on it: JDK-8166368 JComboBox drawing has artifacts with Windows Classic L on HiDPI display https://bugs.openjdk.java.net/browse/JDK-8166368 Thanks, Alexandr. --Semyon On 9/14/2016 5:39 PM, Alexandr Scherb

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

On 9/16/2016 11:22 AM, Andrej Golovnin wrote: Hi Alexandr, thanks! It looks much better now. http://cr.openjdk.java.net/~alexsch/8165594/webrev.01 src/java.desktop/share/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java 490 if(isScaledGraphics){ Spaces are

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/14/2016 11:51 AM, Semyon Sadetsky wrote: On 9/13/2016 9:03 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

The fix looks good to me. Thanks, Alexandr. On 9/16/2016 5:34 PM, Semyon Sadetsky wrote: On 15.09.2016 16:11, Alexander Scherbatiy wrote: On 15/09/16 15:03, Semyon Sadetsky wrote: On 15.09.2016 12:49, Alexandr Scherbatiy wrote: On 9/15/2016 11:47 AM, Semyon Sadetsky wrote

Re: [9] Review request for 8163124 Add floating point API support to javax.swing.text.Caret

jFrame.getContentPane().add(jTextArea2d); jFrame.getContentPane().add(jTextArea); jFrame.pack(); jFrame.setVisible(true); } } For some reason I cannot see the difference with the new and old API result. --Semyon On 04.08.2016 15:44, Alexandr Scherbatiy wrote:

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

: Sergey Bylokhov Sent: 14 September 2016 23:39 To: Alexandr Scherbatiy; Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon Is "MultiResolutionTrayIconTest.html" should

Re: [9] Review request for 8165234 Provide a way to not close toggle menu items on mouse click on component level

ws nothing about it will be in use, then the code in SwingUtilities2 returns false. Is it expected? On 05.09.16 13:51, Alexandr Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165234/webrev.01 On 9/2/2016 9:59 PM, Phil Race wrote: Seems f

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

On 9/14/2016 6:41 PM, Alexandr Scherbatiy wrote: On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/ The new RadioButton group focus traversal

Re: javax.swing.text.html.parser.NPrintWriter

On 9/14/2016 7:35 PM, Sergey Bylokhov wrote: I think that NPrintWriter is not public and is not used in jdk. May be it it has sense just to remove it? Thanks, Alexandr. On 14.09.16 19:29, Alexandr Scherbatiy wrote: Hello Manuel, Thank you for the feedback. I have filled an issue

Re: javax.swing.text.html.parser.NPrintWriter

Hello Manuel, Thank you for the feedback. I have filled an issue on it [1]: JDK-8166050 partialArray is not created in javax.swing.text.html.parser.NPrintWriter.println(...) method Do you have any particular test which runs into this issue? [1]

Re: [9] Review request for 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.

On 9/14/2016 1:48 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8154043 webrev: http://cr.openjdk.java.net/~ssadetsky/8154043/webrev/ The new RadioButton group focus traversal algorithm introduced by JDK-8033699 doesn't take into

Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

176/webrev.03/> Regards, Rajeev Chamyal *From:*Alexandr Scherbatiy *Sent:* 12 September 2016 20:07 *To:* Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov *Subject:* Re: [9] Review request for JDK-8150176 [hidpi] wrong resolution variant of multi-res. image is used for TrayIcon

Re: [9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8165594/webrev.01 - HiDPI icons are only drawn for scaled graphics. The screenshots [1], [2], and [3] show difference between icons drawing before and after the fix for scales 1x, 2x, and 4x. [1]

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/13/2016 8:49 PM, Semyon Sadetsky wrote: On 9/13/2016 8:46 PM, Alexandr Scherbatiy wrote: On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/13/2016 8:34 PM, Semyon Sadetsky wrote: On 9/13/2016 8:25 PM, Alexandr Scherbatiy wrote: On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/13/2016 7:38 PM, Semyon Sadetsky wrote: On 9/13/2016 7:21 PM, Alexandr Scherbatiy wrote: On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/12/2016 10:42 PM, Semyon Sadetsky wrote: On 9/12/2016 9:48 PM, Alexandr Scherbatiy wrote: On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can

Re: RFR: JDK-8165799 Fix license and copyright headers under test/java/swing

The fix looks good to me. Thanks, Alexandr. On 9/13/2016 12:50 AM, Ken Chen wrote: ** *Hello,* * Please review the patch below which fixes copyright in test files for awt *Bug: https://bugs.openjdk.java.net/browse/JDK-8165799* *Webrev:

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

On 9/12/2016 7:52 PM, Semyon Sadetsky wrote: On 9/12/2016 6:50 PM, Alexandr Scherbatiy wrote: On 9/12/2016 6:42 PM, Semyon Sadetsky wrote: GTKPainter does not implement a lot of methods which can be accessed by public API. Could you, please, explain, why this specific method is more

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

methods with different number of arguments which do not fall to overridden implementation should be overridden to provide proper implementation. Thanks, Alexandr. --Semyon On 9/12/2016 6:20 PM, Alexandr Scherbatiy wrote: The paintTabbedPaneTabBorder() without orientation should be implemented

Re: [9] Review request for 8157065: There is no the focus border on the selected tab.

The paintTabbedPaneTabBorder() without orientation should be implemented as well because it can be accessed by public API. Thanks, Alexandr. On 6/3/2016 10:54 PM, Semyon Sadetsky wrote: On 6/3/2016 10:34 PM, Sergey Bylokhov wrote: On 03.06.16 22:21, Semyon Sadetsky wrote: What reason? Why

  1   2   3   >