It's unclear from the spec that the original implementation of the method
JComponent.updateUI() does nothing which needs to be explicitly stated in the
javadoc.
-
Commit messages:
- 8263472: Specification of JComponent::updateUI doesn't mention that the
original implementaiton
> ListModel class javadoc refers to ListDataModel interface but there is no
> ListDataModel interface. Rectified the anomaly.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Copyright change
-
Changes:
ListModel class javadoc refers to ListDataModel interface but there is no
ListDataModel interface. Rectified the anomaly.
-
Commit messages:
- 8263410: ListModel javadoc refers to non-existent interface
Changes: https://git.openjdk.java.net/jdk/pull/2931/files
Webrev:
On Wed, 10 Mar 2021 18:09:37 GMT, Andrey Turbanov
wrote:
>
>
> There is one more occurrence of `ListDataModel` in JDK code -
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/ListModel.java#L34
> Perhaps it's worth to fix it too.
ok. will take a look.
On Tue, 9 Mar 2021 08:09:04 GMT, Prasanta Sadhukhan
wrote:
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current v
On Wed, 10 Mar 2021 12:19:45 GMT, Alexey Ivanov wrote:
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply listing the items.
>
>> I think these are nouns and as per I know, we shouldn't place comma before
>> "and" when we are simply
und, background, caret
> color, selection color, selected text color, disabled text color, and border
> color are set if their current value is either null or a UIResource.
> Fixed the javadoc to specify the same.
Prasanta Sadhukhan has updated the pull request incrementally with one
On Wed, 10 Mar 2021 11:49:40 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> copyright change
>
> src/java.desktop/share/classes/javax/swing/plaf/basi
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan
wrote:
> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but
> actually it extends ListModel and there is no such interface as
> ListDataModel. Rectified the anomaly.
This pull request has
On Tue, 9 Mar 2021 21:17:13 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line
>> 306:
>>
>>> 304: * Initializes component properties, such as font, foreground,
>>> 305: * background, caret color, selection color, selected text
und, background, caret
> color, selection color, selected text color, disabled text color, and border
> color are set if their current value is either null or a UIResource.
> Fixed the javadoc to specify the same.
Prasanta Sadhukhan has updated the pull request incrementally with one
und, background, caret
> color, selection color, selected text color, disabled text color, and border
> color are set if their current value is either null or a UIResource.
> Fixed the javadoc to specify the same.
Prasanta Sadhukhan has updated the pull request incrementally with one
> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but
> actually it extends ListModel and there is no such interface as
> ListDataModel. Rectified the anomaly.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional co
BasicTextUI: installDefaults javadoc specifies only font, foreground and
background properties are set if their current value is either null or a
UIResource
and other properties are set if the current value is null
but in reality all properties such as font, foreground, background, caret
javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but
actually it extends ListModel and there is no such interface as ListDataModel.
Rectified the anomaly.
-
Commit messages:
- 8263170: ComboBoxModel documentation refers to a nonexistant type
Changes:
On Wed, 3 Mar 2021 05:14:11 GMT, Alexander Zuev wrote:
>> 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with
>> "Exception: Failed to hide opaque button"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 1 Mar 2021 11:15:09 GMT, Alexander Zvegintsev
wrote:
>> This issue occurs only under `MetalLookAndFeel` on Linux.
>>
>> It was introduced by
>> [JDK-8040630](https://bugs.openjdk.java.net/browse/JDK-8040630) fix.
>>
>>> component.setBounds(ownerX, ownerY, 1, 1);
>>
>> This line
On Sun, 28 Feb 2021 07:39:20 GMT, Alexander Zvegintsev
wrote:
>> This issue occurs only under `MetalLookAndFeel` on Linux.
>>
>> It was introduced by
>> [JDK-8040630](https://bugs.openjdk.java.net/browse/JDK-8040630) fix.
>>
>>> component.setBounds(ownerX, ownerY, 1, 1);
>>
>> This line
On Sun, 28 Feb 2021 07:39:20 GMT, Alexander Zvegintsev
wrote:
>> This issue occurs only under `MetalLookAndFeel` on Linux.
>>
>> It was introduced by
>> [JDK-8040630](https://bugs.openjdk.java.net/browse/JDK-8040630) fix.
>>
>>> component.setBounds(ownerX, ownerY, 1, 1);
>>
>> This line
On Mon, 22 Feb 2021 09:45:31 GMT, Prasanta Sadhukhan
wrote:
> It is seen
> JTextArea.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT)
> orientation is not honoured if it is called after setText() and remain at LTR
> orientation. It changes the orientation only if so
is called.
> Checked for all L in all supported platforms.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Add comment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2673/files
- new: https://git.ope
is called.
> Checked for all L in all supported platforms.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Remove robot reliance
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2673/files
- new: https://g
On Mon, 22 Feb 2021 12:42:20 GMT, Alexander Zvegintsev
wrote:
>> It is seen
>> JTextArea.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT)
>> orientation is not honoured if it is called after setText() and remain at
>> LTR orientation. It changes the orientation only if some more
It is seen
JTextArea.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT)
orientation is not honoured if it is called after setText() and remain at LTR
orientation. It changes the orientation only if some more text is typed
additionally to existing text.
This behaviour is different from
On Wed, 17 Feb 2021 03:56:56 GMT, Amresh Sahu
wrote:
>> Test name(s): javax/swing/JFileChooser/6698013/bug6698013.java
>>
>> Problem: A manual regression test case instructions does not match with the
>> UI shown to the user. Instruction says to click Open button while the File
>> chooser
On Fri, 12 Feb 2021 16:29:07 GMT, Stanimir Stamenkov
wrote:
>> Proposed fix for [JDK-8260687][].
>>
>> It is noted the issue appeared after the [JDK-8257664][] (PR #1759) fix
>> landed but the underlying problem is present even before that as
>> demonstrated by using the following HTML
On Fri, 12 Feb 2021 12:54:49 GMT, Alexey Ivanov wrote:
>> I guess instead of depending on passed parameter, it will be better to
>> capture the image only on failure.
>
>> I guess instead of depending on passed parameter, it will be better to
>> capture the image only on failure.
>
> That's
On Fri, 12 Feb 2021 12:37:25 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/text/html/StyleSheet/TestWrongCSSFontSize.java line 149:
>>
>>> 147:
>>> 148: public static void main(String[] args) throws Throwable {
>>> 149: TestWrongCSSFontSize test = new TestWrongCSSFontSize(
>>
On Thu, 11 Feb 2021 22:52:56 GMT, Stanimir Stamenkov
wrote:
>> Proposed fix for [JDK-8260687][].
>>
>> It is noted the issue appeared after the [JDK-8257664][] (PR #1759) fix
>> landed but the underlying problem is present even before that as
>> demonstrated by using the following HTML
On Wed, 10 Feb 2021 17:55:56 GMT, Stanimir Stamenkov
wrote:
> Proposed fix for [JDK-8260687][].
>
> It is noted the issue appeared after the [JDK-8257664][] (PR #1759) fix
> landed but the underlying problem is present even before that as demonstrated
> by using the following HTML document
On Wed, 10 Feb 2021 21:49:40 GMT, Sergey Bylokhov wrote:
>> Both coordinates robot/frame use the user's space and internally should be
>> transformed to the device space. But that transformation should be the same,
>> there are should not be differences in the final result for both.
>
> BTW
On Wed, 10 Feb 2021 11:18:38 GMT, Sergey Bylokhov wrote:
>> Test hardcodes bufferedimage and frame bounds so it does not capture correct
>> size if scaling factor is used.
>> The solution is to always use the same uiscale=1, an updated test still can
>> reproduce the JDK-8015085 issue without
Test hardcodes bufferedimage and frame bounds so it does not capture correct
size if scaling factor is used.
The solution is to always use the same uiscale=1, an updated test still can
reproduce the JDK-8015085 issue without fix. Additionally, moved the frame to
centre of screen for better
On Sat, 6 Feb 2021 12:11:52 GMT, Alexey Ivanov wrote:
> This test verifies the CSS unit mappings when `JEditorPane.W3C_LENGTH_UNITS`
> is in effect.
>
> The test needs to be modified to take into account the changes under
> [JDK-8231286](https://bugs.openjdk.java.net/browse/JDK-8257664):
On Fri, 5 Feb 2021 01:27:26 GMT, Phil Race wrote:
> we need to specify ()I for the signature of the method that returns int.
> Additionally number (the instance!) needs to be passed to the method up call.
Marked as reviewed by psadhukhan (Reviewer).
-
PR:
On Thu, 4 Feb 2021 11:10:19 GMT, Alexey Ivanov wrote:
>
>
> I have written automatic test for
> [JDK-8260687](https://bugs.openjdk.java.net/browse/JDK-8260687): Inherited
> font size is smaller than expected when using StyleSheet to add styles. You
> can find it in my JDK-8260687 branch:
>
On Wed, 3 Feb 2021 18:53:08 GMT, Matthias Perktold
wrote:
>> This PR supersedes #2223.
>> The original PR was created from master, whereas this PR is created from a
>> fresh branch.
>>
>> Below is a copy of the original description, but as @mrserb correctly
>> [pointed
>>
On Wed, 3 Feb 2021 09:17:44 GMT, Matthias Perktold
wrote:
>
>
> > Merging, rather than rebasing, is usually preferred as it doesn't involve
> > force pushing and makes incremental reviews easier. The answer is the same,
> > though: no, it won't cause problems. The bot comment was that you
On Wed, 3 Feb 2021 08:36:30 GMT, Matthias Perktold
wrote:
>
>
> > I think we should hard-code 96. Does JDK treat 93/94/95 differently? Does
> > it change font size in any other place but CSS with W3C_LENGTH_UNITS?
>
> But isn't that precesily the only situation in which the old length
On Wed, 3 Feb 2021 06:59:17 GMT, Sergey Bylokhov wrote:
>> There were many instances faced during test sprint where a test was failing
>> in one platform and we added the stability code of waitForIdle,delay etc to
>> make it work. It was not cited as product bug...I believe it's the same
>>
On Mon, 25 Jan 2021 13:24:19 GMT, Prasanta Sadhukhan
wrote:
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
This pull reques
On Tue, 2 Feb 2021 20:32:46 GMT, Alexey Ivanov wrote:
>
>
> > It seems Toolkit.getDefaultToolkit().getScreenResolution() can return
> > 93/94/95 instead of 96 in mac/linux in internal mach5 testing systems
> > causing failure in this test Test.java. Probably we need to make the
> > testcase
On Tue, 2 Feb 2021 06:20:44 GMT, Prasanta Sadhukhan
wrote:
>> Changes requested by aivanov (Reviewer).
>
>>
>>
>> > It seems for screen with low resolution, this change might cause some
>> > failure as can be seen in the testcase attached in JBS Tes
On Mon, 1 Feb 2021 23:03:30 GMT, Alexey Ivanov wrote:
>> Matthias Perktold has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Link to CSS 2.2 spec from length mapping comments
>
> Changes requested by aivanov (Reviewer).
>
>
> > It
On Mon, 1 Feb 2021 22:02:16 GMT, Sergey Bylokhov wrote:
>> I ran the test locally for several iterations but it does not fail locally
>> so I believe it's a test issue. Re reverting the test changes made in 1st
>> webrev...
>
> I do not see a reason to change the test until the root cause of
On Mon, 1 Feb 2021 07:19:10 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
On Sat, 30 Jan 2021 12:00:43 GMT, Alexey Ivanov wrote:
>> Unfortunately, volatile modifier has no effect if infinite loop is
>> reinstated..
>
>> > Does this volatile modifier resolve the now-removed infinite loop in
>> > `while (!tk.IsDisposed())` in `WToolkit_shutdown`?
>>
>> The loop
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
addition
On Fri, 29 Jan 2021 23:46:14 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h line 478:
>>
>>> 476: BOOL m_breakOnError;
>>> 477:
>>> 478: volatile BOOL m_breakMessageLoop;
>>
>> Does this volatile modifier resolve the now-removed infinite
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
addition
On Wed, 27 Jan 2021 12:06:43 GMT, Alexey Ivanov wrote:
>> This PR supersedes #2223.
>> The original PR was created from master, whereas this PR is created from a
>> fresh branch.
>>
>> Below is a copy of the original description, but as @mrserb correctly
>> [pointed
>>
On Thu, 28 Jan 2021 19:50:56 GMT, Sergey Bylokhov wrote:
>>>
>>> My point is that this is not a test bug, so the test should not be changed.
>>
>> The test never dispose of the frame. Why is it expected to shut down the
>> toolkit? Shall the frame be disposed of when the main thread in the
On Thu, 28 Jan 2021 05:53:05 GMT, Sergey Bylokhov wrote:
>> My point is that this is not a test bug, so the test should not be changed.
>
> Please take a look at the "AwtToolkit::Dispose()" method, on how much stuff
> should be done to properly shutdown the toolkit. This Dispose() method is
>
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
addition
On Wed, 27 Jan 2021 11:40:10 GMT, Matthias Perktold
wrote:
> This PR supersedes #2223.
> The original PR was created from master, whereas this PR is created from a
> fresh branch.
>
> Below is a copy of the original description, but as @mrserb correctly
> [pointed
>
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
addition
On Wed, 27 Jan 2021 12:35:38 GMT, Prasanta Sadhukhan
wrote:
>> This test was failing in our nightly mach5 testing. Appropriate stability
>> code in form of waitForIdle and delay is added.
>> mach5 job running for several iterations on all platforms is ok. Link in JBS.
>
On Tue, 26 Jan 2021 17:34:04 GMT, Matthias Perktold
wrote:
>>> > ⚠️ @mperktold a branch with the same name as the source branch for this
>>> > pull request (`master`) is present in the [target
>>> > repository](https://github.com/openjdk/jdk). If you eventually integrate
>>> > this pull
On Fri, 4 Dec 2020 17:30:11 GMT, Prasanta Sadhukhan
wrote:
> Issue is when using a JEditorPane to render HTML views with W3C_UNIT_LENGTHS
> enabled, font-sizes set using CSS are much larger than the same font size
> outside the HTML.
> It's because CSS LengthUnit uses scree
This test was failing in our nightly mach5 testing. Appropriate stability code
in form of waitForIdle and delay is added.
mach5 job running for several iterations on all platforms is ok. Link in JBS.
-
Commit messages:
- 8197825: [Test] Intermiitent timeout with javax/swing
On Tue, 19 Jan 2021 14:31:03 GMT, Tejpal Rebari wrote:
>
>
> The methods intervalAdded(ListDataEvent e) ,intervalRemoved(ListDataEvent e)
> and lt(File a, File b) of javax/swing/plaf/basic/BasicDirectoryModel.java
> states that "Obsolete - not used" ( in the doc).
>
> The
On Mon, 25 Jan 2021 07:08:33 GMT, Sergey Bylokhov wrote:
> Obsolete/unused classes are removed.
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java
line 529:
> 527: * @deprecated As of Java 2 platform v1.4.
> 528: */
> 529: @Deprecated
Should
On Fri, 22 Jan 2021 07:23:00 GMT, Prasanta Sadhukhan
wrote:
> This test was problemlisted for linux as it fails only on ubuntu18.04 in
> mach5 nightly testing. It was infact passing on ubuntu19.10, 20.04 and 20.10
> so it was test specific issue. Made appropriate stability fix
This test was problemlisted for linux as it fails only on ubuntu18.04 in mach5
nightly testing. It was infact passing on ubuntu19.10, 20.04 and 20.10 so it
was test specific issue. Made appropriate stability fix by adding waitForIdle()
at appropriate location.
Mach5 job running specifically on
On Wed, 20 Jan 2021 11:49:25 GMT, Prasanta Sadhukhan
wrote:
> Few problemlisted test
> javax/swing/plaf/basic/Test6984643.java
> javax/swing/JMenuItem/6249972/bug6249972.java
> javax/swing/JTree/6263446/bug6263446.java
> were unstable in mach5 nightly testing. These can be depr
On Thu, 21 Jan 2021 07:39:31 GMT, Sergey Bylokhov wrote:
>
>
> Does the JDK-8198340 bug is a test issue?
Could be...It shows
Caused by: java.lang.IllegalStateException: Shutdown in progress
which I think could be caused by invokeLater so that test tried to do the
execution when the main is
On Wed, 20 Jan 2021 13:24:36 GMT, Stanimir Stamenkov
wrote:
>
>
> Thank you @prsadhuk for reviewing this. Should/could I go with `/integrate`
> now?
yes sure
-
PR: https://git.openjdk.java.net/jdk/pull/1759
Few problemlisted test
javax/swing/plaf/basic/Test6984643.java
javax/swing/JMenuItem/6249972/bug6249972.java
javax/swing/JTree/6263446/bug6263446.java
were unstable in mach5 nightly testing. These can be deproblemlisted now with
appropriate stability fixes.
Mach5 jobs running for several
On Mon, 18 Jan 2021 13:21:18 GMT, Stanimir Stamenkov
wrote:
>
>
> The display dpi shouldn't matter. I've tried it in a couple of different
> monitor configurations: 1.25, 1.5, and 2.0 scaling. I've also tried it with
> non-dpi-aware Java 8. I've used `body { font-size: 14 }` which should
On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov
wrote:
>> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes.
>>
>> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best
>> chance to get it addressed is to submit a pull request against this
>>
On Sat, 16 Jan 2021 06:45:35 GMT, Stanimir Stamenkov
wrote:
>> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes.
>>
>> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best
>> chance to get it addressed is to submit a pull request against this
>>
On Wed, 13 Jan 2021 10:41:29 GMT, Prasanta Sadhukhan
wrote:
> This test was unstable in linux in nightly testing. Modified to move the
> frame to center of screen so that the left-taskbar of linux doesn't interfere
> with the mouse movement along with delay after frame is visibl
On Sun, 17 Jan 2021 09:26:52 GMT, Alexander Zuev wrote:
> 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with
> "Exception: Failed to hide opaque button"
test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 96:
> 94: robot.waitForIdle(1000);
> 95:
>
eral iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with three
additional commits since the last revision:
- Review fix
- Revert "Address review comments"
This reverts commit cb12e5bf447b0922fe601c11bbceb2200904b1c3.
On Fri, 15 Jan 2021 15:31:54 GMT, Stanimir Stamenkov
wrote:
>> I believe the test is _headful_ because it uses
>> `SwingUtilities.invokeAndWait` even though it does not show any UI.
>
> I've used `SwingUtilities.invokeAndWait` just to be on the safe side that
> "everything Swing should be
On Wed, 13 Jan 2021 15:45:22 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> Copyright year in the test and in the Pr
On Fri, 15 Jan 2021 12:47:28 GMT, Stanimir Stamenkov
wrote:
>> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes.
>>
>> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best
>> chance to get it addressed is to submit a pull request against this
>>
On Sun, 13 Dec 2020 14:51:47 GMT, Stanimir Stamenkov
wrote:
> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes.
>
> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best
> chance to get it addressed is to submit a pull request against this
>
eral iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2061/files
- new: https://git.openj
On Wed, 13 Jan 2021 22:26:47 GMT, Alexander Zuev wrote:
> Backport from mainline.
Marked as reviewed by psadhukhan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk16/pull/119
This test was unstable in linux in nightly testing. Modified to move the frame
to center of screen so that the left-taskbar of linux doesn't interfere with
the mouse movement along with delay after frame is visible to make it more
stable.
Mach5 job running for several iterations on all
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote:
>> Please review the application of @java.io.Serial annotation (JDK-8202385) to
>> types in the desktop module to enable stricter compile-time checking of
>> serialization-related declarations.
>>
>> This annotation can be applied to
On Fri, 8 Jan 2021 11:03:36 GMT, Prasanta Sadhukhan
wrote:
> This test was failing on mach5 nightly on ubuntu systems long time back.
> Modified the test to add some delays and call robot.waitForIdle() to make it
> more stable and the resultant test passes on all mach5 systems
On Mon, 11 Jan 2021 05:31:15 GMT, Tejpal Rebari wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unneeded setAutoDelay
>
> test/jdk/javax/swing/JInternalFrame/8146321/JI
On Wed, 11 Nov 2020 08:00:09 GMT, Prasanta Sadhukhan
wrote:
> Issue is a JLabel with a translucent foreground color properly renders plain
> text, but with HTML text, the alpha component is discarded and the text is
> rendered using an opaque color.
> As per https://www.w3school
On Tue, 12 Jan 2021 20:42:18 GMT, Sergey Bylokhov wrote:
>> Please review the application of @java.io.Serial annotation (JDK-8202385) to
>> types in the desktop module to enable stricter compile-time checking of
>> serialization-related declarations.
>>
>> This annotation can be applied to
On Wed, 6 Jan 2021 12:43:41 GMT, Tejpal Rebari wrote:
> Please review the following fix for jdk17.
> In this fix i have deprecated and marked for removal following classes and
> methods
>public void intervalAdded(ListDataEvent e)
>public void intervalRemoved(ListDataEvent e)
>
On Tue, 12 Jan 2021 04:15:31 GMT, Pankaj Bansal wrote:
>> Please review a fix for jdk16
>>
>> Issue: In SwingSet2, if the user navigates through the demos, the demo gets
>> selected/starts on pressing left/right key only. There is no need to press
>> the "space" key. Earlier, on pressing the
On Mon, 11 Jan 2021 13:30:15 GMT, Pankaj Bansal wrote:
>> Please review a fix for jdk16
>>
>> Issue: In SwingSet2, if the user navigates through the demos, the demo gets
>> selected/starts on pressing left/right key only. There is no need to press
>> the "space" key. Earlier, on pressing the
On Sat, 9 Jan 2021 12:47:48 GMT, Pankaj Bansal wrote:
> Please review a fix for jdk16
>
> Issue: In SwingSet2, if the user navigates through the demos, the demo gets
> selected/starts on pressing left/right key only. There is no need to press
> the "space" key. Earlier, on pressing the
04 so we can remove the test
> from problemlist.
> mach5 job running for several iterations is posted in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Remove unneeded setAutoDelay
-
Chang
This test was failing on mach5 nightly on ubuntu systems long time back.
Modified the test to add some delays and call robot.waitForIdle() to make it
more stable and the resultant test passes on all mach5 systems including linux
consisting of ubuntu 19.10, 18.04,20.10,20.04 so we can remove the
On Wed, 6 Jan 2021 07:18:46 GMT, Prasanta Sadhukhan
wrote:
> These radiobutton tests were failing on macos in nightly testing. However
> recent run of these test are working fine on local mac10.14.6, 10.15.7
> systems as well as mach5 macos systems, so we can deproblemlist th
On Wed, 6 Jan 2021 08:57:42 GMT, Sergey Bylokhov wrote:
>> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we
>> dont see the issue now as can be seen by mach5 run.
>
>> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we
>> dont see the issue
On Wed, 6 Jan 2021 08:45:19 GMT, Sergey Bylokhov wrote:
>> These radiobutton tests were failing on macos in nightly testing. However
>> recent run of these test are working fine on local mac10.14.6, 10.15.7
>> systems as well as mach5 macos systems, so we can deproblemlist these tests.
>>
These radiobutton tests were failing on macos in nightly testing. However
recent run of these test are working fine on local mac10.14.6, 10.15.7 systems
as well as mach5 macos systems, so we can deproblemlist these tests. Mach5 job
link is in JBS.
-
Commit messages:
- 8233555:
On Mon, 4 Jan 2021 05:09:55 GMT, Prasanta Sadhukhan
wrote:
> This test use to fail in macos in mach5 nightly testing long time back. It
> used to fail in ubuntu17.10 due to unsupported wayland display mode. Recent
> run of this test on supported platforms does not fail.
> Modif
On Mon, 4 Jan 2021 20:14:11 GMT, Alexander Zuev wrote:
>> 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with
>> "Exception: Failed to hide opaque button"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 4 Jan 2021 23:01:25 GMT, Sergey Bylokhov wrote:
>> Yes, it works
>>
>> reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25
>> -Dsun.java2d.d3d=true ScaledFrameBackgroundTest
>> Mode: othervm [/othervm specified]
>> Additional options from @modules: --add-modules
On Mon, 4 Jan 2021 10:07:08 GMT, Alexander Zuev wrote:
> 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with
> "Exception: Failed to hide opaque button"
test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 105:
> 103: locy = bounds.y + insets.top;
> 104:
201 - 300 of 1233 matches
Mail list logo
