On Thu, 4 Feb 2021 11:10:19 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

> 
> 
> I have written automatic test for 
> [JDK-8260687](https://bugs.openjdk.java.net/browse/JDK-8260687): Inherited 
> font size is smaller than expected when using StyleSheet to add styles. You 
> can find it in my JDK-8260687 branch:
> https://github.com/aivanov-jdk/jdk/commits/JDK-8260687
> There's also a commit which modifies the test from 
> [JDK-8257664](https://bugs.openjdk.java.net/browse/JDK-8257664) to run in two 
> modes with and without W3C_LENGTH_UNITS.
> 
> We have several options:
> 
>     1. As this PR contains the fix for JDK-8260687, you can cherry-pick the 
> test into your branch.
> 
>     2. I can create a new JBS issue to add the test for JDK-8260687 
> separately.
> 
>     3. You can revert the fix in your PR, and I'll add it to the test and 
> then raise a new PR to resolve JDK-8260687.
> 
> 
> I have no strong preference for any of the options.

My preference will be 
1) if @mperktold can pick the test from 
https://github.com/aivanov-jdk/jdk/commit/6d0b40db4400dac03567b5cab4ad45b103ea94d0
 and add into this PR
else 2)
@mperktold can you also issue this comment "/issue add JDK-8260687" once 
@aivanov-jdk approves this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2256

Reply via email to