On Fri, 21 May 2021 19:37:19 GMT, Alexander Zuev wrote:
>> Didn't you answer your question already? If `FileSystemView.getRoots()`
>> returns Desktop in Windows shell namespace. Otherwise, I don't know a way to
>> get a reference to a *virtual* folder in Windows shell namespace which
>> doesn'
On Fri, 21 May 2021 19:11:45 GMT, Alexey Ivanov wrote:
>> But how you got them via this method? I am not sure what parameters should
>> be passed to it.
>
> Didn't you answer your question already? If `FileSystemView.getRoots()`
> returns Desktop in Windows shell namespace. Otherwise, I don't k
On Fri, 21 May 2021 18:16:36 GMT, Sergey Bylokhov wrote:
>>> It is accessible from the "JFileChooser" drop-down menu. On my system, the
>>> Libraries at that drop down menu contain "GIT", "Documents", "Music".
>>> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>>>
On Fri, 21 May 2021 06:32:02 GMT, Alexander Zuev wrote:
>> It is accessible from the "JFileChooser" drop-down menu. On my system, the
>> Libraries at that drop down menu contain "GIT", "Documents", "Music".
>> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>>
>> T
On Fri, 21 May 2021 05:42:46 GMT, Sergey Bylokhov wrote:
> It is accessible from the "JFileChooser" drop-down menu. On my system, the
> Libraries at that drop down menu contain "GIT", "Documents", "Music".
> https://docs.microsoft.com/en-us/windows/client-management/windows-libraries
>
> There
On Fri, 21 May 2021 04:15:41 GMT, Alexander Zuev wrote:
>> Maybe we can test this case by just reusing this method where the
>> "sf.getIcon(largeicon)" previously used in the WindowsPlacesBar class? That
>> old method has the special code for "folder.isLibrary()" so I assume it
>> supported th
On Fri, 21 May 2021 03:21:19 GMT, Sergey Bylokhov wrote:
>> The JFileChooser supports the libraries since it allows navigation inside
>> them. It is done via ShellFolder which extends the file class. The
>> FileSystemView feeds the JFileChooser by the data, so it may returns
>> "non-file" obje
On Fri, 21 May 2021 02:45:15 GMT, Sergey Bylokhov wrote:
>> No, libraries are not supported.
>>
>> I see no contradiction here: `JFileChooser` uses Windows Shell API to
>> enumerate objects and navigate the shell namespace. But it does not return
>> non-file objects, does it?
>>
>> The new me
On Thu, 20 May 2021 18:51:54 GMT, Alexey Ivanov wrote:
>> So the libraries are not supported? I doubt since JFileChooser should
>> support them, and supports of it is one of the reasons why we use shell
>> folder to iterate the folders and do not use the javaio.
>
> No, libraries are not suppor
On Thu, 20 May 2021 17:37:20 GMT, Sergey Bylokhov wrote:
>>> Are we sure that all possible paths can be pointed by the file object?
>>
>> We specify that we return the icon for a file. If path can not be resolved
>> in the file object we can not return the icon for it.
>
> So the libraries are
On Thu, 20 May 2021 16:45:35 GMT, Alexander Zuev wrote:
>> We do not test for that in the regression test but i did tested it manually
>> and we do return null for the non-existed files. I tested it on non-windows
>> platform too. We still return null.
>
>> Are we sure that all possible paths c
On Thu, 20 May 2021 16:43:05 GMT, Alexander Zuev wrote:
>> Later we say that this method returns null for non-existed files. is it
>> always correct? I am not sure that the file created for the library report
>> true for the exists() method; DId we test this usecase?
>
> We do not test for that
On Thu, 20 May 2021 16:06:37 GMT, Sergey Bylokhov wrote:
>> Are we sure that all possible paths can be pointed by the file object?
>> Especially some "Windows Libraries" which are accessed by the shell folder?
>
> Later we say that this method returns null for non-existed files. is it
> always
On Thu, 20 May 2021 07:40:35 GMT, Sergey Bylokhov wrote:
>> Good catch! Yes, fixed both here and in CSR.
>
> Are we sure that all possible paths can be pointed by the file object?
> Especially some "Windows Libraries" which are accessed by the shell folder?
Later we say that this method returns
On Mon, 17 May 2021 05:08:13 GMT, Alexander Zuev wrote:
>> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
>> line 271:
>>
>>> 269: * Example:
>>> 270: * FileSystemView fsv = FileSystemView.getFileSystemView();
>>> 271: * Icon icon = fsv.getSystemIcon("ap
On Sun, 16 May 2021 18:49:24 GMT, Alexander Zvegintsev
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Slight change of wording in javadoc
>> Fixed Win32ShellFolder2.getSystemIcon scaling issue
>
> src/java.de
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Slight change of wording in javadoc
> Fixed Win32ShellFolder2.getSystem
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Slight change of wording in javadoc
> Fixed Win32ShellFolder2.getSystem
> Fix updated after first round of review.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Slight change of wording in javadoc
Fixed Win32ShellFolder2.getSystemIcon scaling issue
-
Changes:
- all: https://git.openj
19 matches
Mail list logo