Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

On 10/31/19 5:59 am, Pankaj Bansal wrote: << I guess that the problem is that the "image" is accessed w/o synchronization on "this" like in other places, but it will be necessary to add one null check before usage of "image". I have updated the code to access image with synchronization. But

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Dmitry, 437 …by the operating system. … I'd modify the following text a bit: To run the test correctly, the default global key shortcut should be disabled. Follow the steps above, and then deselect "Turn keyboard access on or off" property which is responsible for `CTRL + F1` combination.

Re: [14] RFR JDK-8230235 - Rendering HTML with empty img attribute and documentBaseKey cause Exception

Hi Sergey/Alexey Webrev: http://cr.openjdk.java.net/~pbansal/8230235/webrev01/ << I guess that the problem is that the "image" is accessed w/o synchronization on "this" like in other places, but it will be necessary to add one null check before usage of "image". I have updated the code to

Re: [14] RFR : JDK-4949105 : Access Bridge lacks html tags parsing

Hi Sergey, Thanks for the review, Here is the updated webrev: http://cr.openjdk.java.net/~arapte/a11y/4949105/webrev.01/ Fixed both the review comments: 1. AccessibleContext.ACCESSIBLE_NAME_PROPERTY shall be set only if the text is html string, otherwise it is set to null which is existing

Re: RFR 8232880: Update test documentation with additional settings for client UI tooltip tests

Hi Alexey, I have updated the fix based on your recommendation. The new version is located at: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/ Also please find my answers inline. Thanks, Dmitry > On 29 Oct 2019, at 19:29, Alexey

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

Hi tejpal, Can you add a testcase to the fix? I guess one is there in the JBS itself. Regards Prasanta On 24-Oct-19 10:31 AM, Tejpal Rebari wrote: Hi All, Please review the following fix for jdk14. Bug: https://bugs.openjdk.java.net/browse/JDK-8190763 Webrev:

[14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Hi All, Please review the following fix for JDK 14. Bug : https://bugs.openjdk.java.net/browse/JDK-7020860 Webrev : http://cr.openjdk.java.net/~trebari/swing/7020860/webrev0/