Integrated: 8266510: Nimbus JTree default tree cell renderer does not use selected text color

On Mon, 26 Jul 2021 05:46:44 GMT, Tejpal Rebari wrote: > Please review the following fix for JDK-18. > This is revert of the fix for nimbus jtree renderer properties persist > across L(https://bugs.openjdk.java.net/browse/JDK-8249674), This fixed > caused nimbus jtree defau

Re: RFR: 8266510: Nimbus JTree default tree cell renderer does not use selected text color

On Mon, 26 Jul 2021 21:03:46 GMT, Sergey Bylokhov wrote: > Do we have a new bug to redo the > https://bugs.openjdk.java.net/browse/JDK-8249674 again? Yes, https://bugs.openjdk.java.net/browse/JDK-8271315. - PR: https://git.openjdk.java.net/jdk/pull/4903

RFR: 8266510: Nimbus JTree default tree cell renderer does not use selected text color

Please review the following fix for JDK-18. This is revert of the fix for nimbus jtree renderer properties persist across L(https://bugs.openjdk.java.net/browse/JDK-8249674), This fixed caused nimbus jtree default tree cell renderer to not use the selected text color, which was white

Re: RFR: 8268087: Update documentation of the JPasswordField

On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote: > Some useful documentation was added to the JPasswordField. Marked as reviewed by trebari (Committer). - PR: https://git.openjdk.java.net/jdk/pull/4296

Integrated: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic

On Wed, 6 Jan 2021 12:43:41 GMT, Tejpal Rebari wrote: > Please review the following fix for jdk17. > In this fix i have deprecated and marked for removal following classes and > methods >public void intervalAdded(ListDataEvent e) >public void intervalRemoved(

Integrated: 8264950: Set opaque for JTooltip in config file of NimbusLookAndFeel

On Mon, 3 May 2021 08:54:19 GMT, Tejpal Rebari wrote: > Set the opaque property for JToolTip in config file (skin.laf) of > NimbusLookAndFeel instead of setting up in the SynthToolTipUI. > This is related to the discussion on PR > https://github.com/openjdk/jdk/pull/3167. This

RFR: 8264950: Set opaque for JTooltip in config file of NimbusLookAndFeel

Set the opaque property for JToolTip in config file (skin.laf) of NimbusLookAndFeel instead of setting up in the SynthToolTipUI. This is related to the discussion on PR https://github.com/openjdk/jdk/pull/3167. - Commit messages: - set opaque for JTooltip in config file Changes:

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v9]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.

On Fri, 16 Apr 2021 09:52:35 GMT, Alexander Zuev wrote: > 8039270: The background color of the button can't be displayed and when > pressed the button, the background color can not be changed in accordance > with the case described. Marked as reviewed by trebari (Committer). -

Re: RFR: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.

On Fri, 16 Apr 2021 09:52:35 GMT, Alexander Zuev wrote: > 8039270: The background color of the button can't be displayed and when > pressed the button, the background color can not be changed in accordance > with the case described. Should we also remove the deprecated JApplet from the test

Re: RFR: 8265278: doc build fails after JDK-8262981

On Thu, 15 Apr 2021 13:51:57 GMT, Pankaj Bansal wrote: > The doc build fails after the JDK-8262981. The JDK-8262981 adds a new > function, but by mistake the param name used in function is different from > the param name mentioned in @param tag. This breaks the doc build. > > This change

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v8]

On Fri, 2 Apr 2021 22:36:04 GMT, Sergey Bylokhov wrote: > I think we can file a separate bug to add "for removal" in JDK 19 and then > remove them somewhere after JDK 22. I have filed a separate bug for this : https://bugs.openjdk.java.net/browse/JDK-8264743 - PR:

Integrated: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI

On Wed, 24 Mar 2021 06:17:04 GMT, Tejpal Rebari wrote: > Hi All, > Please review the following fix for jdk17. > > Issue : LookAndFeel.installProperty(list, "opaque", false) is not able to set > the opaque property for JList and JTable. > LookAndFeel.installProp

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 08:19:19 GMT, Tejpal Rebari wrote: >> src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21581: >> >>> (failed to retrieve contents of file, check the PR for context) >> Is this newline needed? > > No , it automatically got

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v6]

property is already not set. > > Test : Added a test to check the same. Also tested internal tests which all > are passing. > Link is in JBS. Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision: set skin.laf as before ---

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 07:44:59 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for JTree JTooltip and JViewport keeping default opaque value same, >

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v5]

property is already not set. > > Test : Added a test to check the same. Also tested internal tests which all > are passing. > Link is in JBS. Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision: set default opaque

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 07:08:32 GMT, Prasanta Sadhukhan wrote: >> No, it doesn't work, i have checked. >> The change needs to be skin.laf file only. > > I am not sure where you placed the code. I think it's need to be added after > updateStyle() as updateStyle() uninstall the default and install

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 05:19:06 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for JTree JTooltip and JViewport keeping default opaque value same, >

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 05:19:49 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for JTree JTooltip and JViewport keeping default opaque value same, >>

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v4]

property is already not set. > > Test : Added a test to check the same. Also tested internal tests which all > are passing. > Link is in JBS. Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision: removed wildcard imports

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

On Mon, 5 Apr 2021 05:20:26 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix for JTree JTooltip and JViewport keeping default opaque value same, >>

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v8]

On Thu, 1 Apr 2021 23:43:25 GMT, Phil Race wrote: >> Marked as reviewed by prr (Reviewer). > > The CSR still had forRemoval. I've updated it and generally tidied it, but > you may want to check my work. I have checked the CSR, made minor corrections. Overall looks good, thanks for updating

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v2]

On Thu, 1 Apr 2021 14:43:36 GMT, Tejpal Rebari wrote: >> Please wait for the @prsadhuk approval as well. > > I have fixed the issue with JTree, JTooltip and JViewport same way. > While fixing for JTooltip discovered that default value for JToolTip opaque > property for Nimbus

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v2]

On Wed, 31 Mar 2021 20:34:51 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added default value check for opaque property > > Please wait for the @prsadhuk a

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v3]

property is already not set. > > Test : Added a test to check the same. Also tested internal tests which all > are passing. > Link is in JBS. Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision: Fix for JTree JTooltip

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

On Wed, 10 Feb 2021 18:04:16 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed deprecation from methods of class which is also getting deprecated > > Are these m

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v2]

On Wed, 24 Mar 2021 08:27:40 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added default value check for opaque property > > I am not sure if this is the

Re: RFR: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java

On Sun, 28 Mar 2021 00:21:16 GMT, Sergey Bylokhov wrote: > This test has a broken license: > /* > * To change this license header, choose License Headers in Project > Properties. > * To change this template file, choose Tools | Templates > /* > * Copyright (c) 2015, Oracle and/or its

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI [v2]

property is already not set. > > Test : Added a test to check the same. Also tested internal tests which all > are passing. > Link is in JBS. Tejpal Rebari has updated the pull request incrementally with one additional commit since the last revision: Added default valu

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI

On Thu, 25 Mar 2021 06:44:10 GMT, Sergey Bylokhov wrote: >> Hi All, >> Please review the following fix for jdk17. >> >> Issue : LookAndFeel.installProperty(list, "opaque", false) is not able to >> set the opaque property for JList and JTable. >> LookAndFeel.installProperty calls the

Re: RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI

On Wed, 24 Mar 2021 08:27:40 GMT, Prasanta Sadhukhan wrote: > I am not sure if this is the correct fix, as then we would have to remove > setOpaque call for JTree, JToolTip, JRootPane etc where we might face same > installProperty issue. Yes we face the same issue in JTree, JToolTip, and

Re: RFR: 8263454: com.apple.laf.AquaFileChooserUI ignores the result of String.trim() [v2]

On Tue, 23 Mar 2021 14:55:58 GMT, Alexander Zvegintsev wrote: >> Looks like the original idea was to set `fallbacktext` on strings containing >> only spaces. >> >> I decided to remove the `trim()` call to keep the same behavior and to >> allows to set such meaningless space only

RFR: 8253266 : JList and JTable constructors should clear OPAQUE_SET before calling updateUI

Hi All, Please review the following fix for jdk17. Issue : LookAndFeel.installProperty(list, "opaque", false) is not able to set the opaque property for JList and JTable. LookAndFeel.installProperty calls the setUIProperty, and setUIProperty checks for OPAQUE_SET to change the opaque property

Re: RFR: 8263768: JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() spec doesn't mention what the default impls return and what does it mean

On Thu, 18 Mar 2021 04:46:03 GMT, Prasanta Sadhukhan wrote: > Default implementation of > JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter() > returns null but it is not mentioned in the spec. > It is now explicitly mentioned in the spec by @impNote tag. Marked

Re: RFR: 8263170: ComboBoxModel documentation refers to a nonexistant type

On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan wrote: > javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but > actually it extends ListModel and there is no such interface as > ListDataModel. Rectified the anomaly. Marked as reviewed by trebari (Committer).

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

On Wed, 10 Feb 2021 18:04:16 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed deprecation from methods of class which is also getting deprecated > > Are these m

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v8]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

On Fri, 19 Feb 2021 15:45:55 GMT, Tejpal Rebari wrote: > Are these methods all expected to be used only by a L rather than an > application ? > If by an application, then forRemoval seems too strong to me. > If by a L then I think you need to go research what open source L ther

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v7]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

On Wed, 10 Feb 2021 18:04:16 GMT, Phil Race wrote: > Are these methods all expected to be used only by a L rather than an > application ? > If by an application, then forRemoval seems too strong to me. > If by a L then I think you need to go research what open source L there > are out there

Re: RFR: 8260291: The case instruction is not visible in dark mode [v2]

On Mon, 15 Feb 2021 06:36:58 GMT, Pankaj Bansal wrote: >> Please review a trivial test only fix. >> >> This is a GTKL specific manual test and create an instruction panel >> containing JTextArea. The JTextArea background color is hardcoded as white >> color, which is causing issues on dark

Re: RFR: 8260291: The case instruction is not visible in dark mode

On Sun, 14 Feb 2021 07:49:39 GMT, Pankaj Bansal wrote: > Please review a trivial test only fix. > > This is a GTKL specific manual test and create an instruction panel > containing JTextArea. The JTextArea background color is hardcoded as white > color, which is causing issues on dark mode in

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v5]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v4]

On Mon, 1 Feb 2021 08:56:32 GMT, Prasanta Sadhukhan wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated documentation > > It probably will need CSR I have crea

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v4]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v4]

On Mon, 25 Jan 2021 12:14:51 GMT, Prasanta Sadhukhan wrote: > > The methods intervalAdded(ListDataEvent e) ,intervalRemoved(ListDataEvent > > e) and lt(File a, File b) of > > javax/swing/plaf/basic/BasicDirectoryModel.java states that "Obsolete - not > > used" ( in the doc). > > The

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v3]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8197825: [Test] Intermiitent timeout with javax/swing JColorChooser Test

On Mon, 25 Jan 2021 13:24:19 GMT, Prasanta Sadhukhan wrote: > This test was failing in our nightly mach5 testing. Appropriate stability > code in form of waitForIdle and delay is added. > mach5 job running for several iterations on all platforms is ok. Link in JBS. Marked as reviewed by

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v2]

om 8049700 not deprecated the paintText(Graphics g, JComponent c, Rectangle > textRect, String text) method in BasicButtonUI as AquaButtonUI, > MetalButtonUI and MetalToggleButtonUI overrides it. > Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and > MotifMenuUI u

Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic

On Wed, 13 Jan 2021 05:52:49 GMT, Prasanta Sadhukhan wrote: >> Please review the following fix for jdk17. >> In this fix i have deprecated and marked for removal following classes and >> methods >>public void intervalAdded(ListDataEvent e) >>public void intervalRemoved(ListDataEvent

Re: [jdk16] RFR: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"

On Wed, 13 Jan 2021 22:26:47 GMT, Alexander Zuev wrote: > Backport from mainline. Marked as reviewed by trebari (Committer). - PR: https://git.openjdk.java.net/jdk16/pull/119

Re: RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 [v2]

On Mon, 11 Jan 2021 04:50:09 GMT, Prasanta Sadhukhan wrote: >> This test was failing on mach5 nightly on ubuntu systems long time back. >> Modified the test to add some delays and call robot.waitForIdle() to make it >> more stable and the resultant test passes on all mach5 systems including

Re: RFR: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 [v2]

On Mon, 11 Jan 2021 04:50:09 GMT, Prasanta Sadhukhan wrote: >> This test was failing on mach5 nightly on ubuntu systems long time back. >> Modified the test to add some delays and call robot.waitForIdle() to make it >> more stable and the resultant test passes on all mach5 systems including

Integrated: 8048109: JToggleButton does not fire actionPerformed under certain conditions

On Mon, 12 Oct 2020 08:01:43 GMT, Tejpal Rebari wrote: > Please review the following fix for jdk16. > > Issue : There is a JToggleButton that will post/take down a JPopupMenu when > the button is selected. If the button is selected and the menu is not posted > the action lis

RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic

Please review the following fix for jdk17. In this fix i have deprecated and marked for removal following classes and methods public void intervalAdded(ListDataEvent e) public void intervalRemoved(ListDataEvent e) protected boolean lt(File a, File b) in BasicDirectoryModel.java

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Wed, 23 Dec 2020 23:47:29 GMT, Sergey Bylokhov wrote: >> yeah , i have checked in windows and ubuntu native apps and it is matching >> native behaviour. >> The issue is seen in Motif, Nimbus, GTK and windows which sets >> consumeEventOnClose to true. >> It is not seen in Metal And Aqua

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 18 Dec 2020 21:43:24 GMT, Sergey Bylokhov wrote: >> Before the fix the mouse event that cause the popup to close was consumed >> here as the "PopupMenu.consumeEventOnClose" was true. >> >> After the fix the mouse event that cause the popup to close will not be >> consumed here as

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 18 Dec 2020 00:18:22 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed mode of files > > src/java.desktop/share/classes/com/sun/java/swing/plaf/g

Re: RFR: 8258557: Deproblemlist fixed problemlisted test

On Thu, 17 Dec 2020 04:59:43 GMT, Prasanta Sadhukhan wrote: > javax/swing/PopupFactory/8048506/bug8048506.java was failing on windows in > nightly mach5 testing but was later fixed in JDK-6847157 but this test was > not removed from ProblemList. > We can remove this test from problemlist

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Wed, 14 Oct 2020 01:52:35 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changed mode of files > > Changes requested by serb (Reviewer). @mrserb please t

Re: RFR: 8258233: Reenable another fixed problemlisted test

On Mon, 14 Dec 2020 12:45:12 GMT, Prasanta Sadhukhan wrote: > javax/swing/JFileChooser/6868611/bug6868611.java was failing in windows in > mach5 testing but was fixed in JDK-8198004 later on, but this test was not > removed from problemList. We can remove it from problemlist now. > Tested for

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Fri, 11 Dec 2020 10:18:12 GMT, Prasanta Sadhukhan wrote: >> In case of the first attempt to bring down the popup menu the event was >> consumed by following code of BasicPopupMenuUI >> boolean consumeEvent = >> >>

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

On Tue, 1 Dec 2020 02:40:27 GMT, Tejpal Rebari wrote: >> Well, the comment was added on Oct 15 and it got hidden on Oct28 because the >> ac was not of github author/committer. I think the fix submitter should have >> seen the comment lying there for 2 weeks before it got

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v4]

and > feel. > > Fix : MouseGrabber is not removed while uninstalling the listeners in the > BasicPopupMenuUI. > By removing the mouseGrabber in the uninstallListeners() methods fixes this > issue. > > Added a test to test the same in all the LookAndFeels Tejpal Re

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v3]

On Wed, 14 Oct 2020 01:52:12 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reworked fix, also fixed for nimbus,motif,GTK LAF > > t

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v3]

and > feel. > > Fix : MouseGrabber is not removed while uninstalling the listeners in the > BasicPopupMenuUI. > By removing the mouseGrabber in the uninstallListeners() methods fixes this > issue. > > Added a test to test the same in all the LookAndFeels Tejpal Re

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

On Mon, 30 Nov 2020 17:53:48 GMT, Prasanta Sadhukhan wrote: >>> not wrong but different account but that doesnot make the comment invalid, >>> I guess. >> >> But nobody sees it, it is hidden. > > Well, the comment was added on Oct 15 and it got hidden on Oct28 because the > ac was not of

Re: RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions [v2]

and > feel. > > Fix : MouseGrabber is not removed while uninstalling the listeners in the > BasicPopupMenuUI. > By removing the mouseGrabber in the uninstallListeners() methods fixes this > issue. > > Added a test to test the same in all the LookAndFeels Tejpal Re

Re: RFR: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails

On Fri, 16 Oct 2020 03:31:41 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for an issue where the color is not chosen correctly. > The issue seems to stem from the fact that keys are not processed properly so > the proper color is not chosen. > Fixed by adding autoDelay during

RFR: 8048109: JToggleButton does not fire actionPerformed under certain conditions

Please review the following fix for jdk16. Issue : There is a JToggleButton that will post/take down a JPopupMenu when the button is selected. If the button is selected and the menu is not posted the action listener will post the menu. If the button is selected and the menu is displayed the

Re: RFR: 8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows [v2]

On Wed, 7 Oct 2020 08:54:22 GMT, Prasanta Sadhukhan wrote: >> Please review a test issue where the test was seen to be failing on windows >> mach5 system in hidpi mode. >> I have ran the test locally with different scale factors without reproducing >> the issue. Also, mach5 job running this

Integrated: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 16 Sep 2020 11:45:12 GMT, Tejpal Rebari wrote: > The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so >

Re: RFR: 6441211: Small Error in API at javax.swing.plaf.synth.Region

On Tue, 29 Sep 2020 08:27:43 GMT, Prasanta Sadhukhan wrote: > Fixed a small typo Marked as reviewed by trebari (Author). - PR: https://git.openjdk.java.net/jdk/pull/396

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v4]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

On Sat, 26 Sep 2020 06:13:43 GMT, Sergey Bylokhov wrote: >> I doubt that if some test will be added later the filechooser under the test >> became non-aqua. > > It is the Aqua from the beginning till the end or some other L Ok, in that case we can remove this line - PR:

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

On Fri, 25 Sep 2020 21:40:14 GMT, Sergey Bylokhov wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Added check for Aqua LAF instead of Mac OS and minor cleanup > > test/jdk/

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v3]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v2]

On Thu, 24 Sep 2020 16:11:11 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Testing filechooser on aqua at a different place, where context popup works > > test/jdk/

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 23 Sep 2020 06:50:52 GMT, Sergey Bylokhov wrote: >>> So the popup actually works in that dialog, we just need to test it in a >>> different place? >> >> Yes. > >> > So the popup actually works in that dialog, we just need to test it in a >> > different place? >> Yes. > > Then it

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v2]

> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for > Mac OS X > with the error message Popup was not shown on FileChooser. > > Popup doesn't appear for JFileChooser in MAC OS X platform so > skipping this test for Mac OS X. Tejpal Rebari has update

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Sat, 19 Sep 2020 02:30:54 GMT, Sergey Bylokhov wrote: > So the popup actually works in that dialog, we just need to test it in a > different place? Yes. - PR: https://git.openjdk.java.net/jdk/pull/204

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

On Wed, 16 Sep 2020 20:29:39 GMT, Sergey Bylokhov wrote: >> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for >> Mac OS X >> with the error message Popup was not shown on FileChooser. >> >> Popup doesn't appear for JFileChooser in MAC OS X platform so >> skipping this

RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for Mac OS X with the error message Popup was not shown on FileChooser. Popup doesn't appear for JFileChooser in MAC OS X platform so skipping this test for Mac OS X. - Commit messages: - Skip JFileChooser test

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

t; reserved. > > The same comment applies to *properties.html* and *componentProperties.html* > files in the webrev. I don't mind if you make this change before pushing > without creating an additional webrev. > > > Other that, it looks fine to me. > > Regards, > Alexe

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

ing/8251122/webrev03/> > On 27-Aug-2020, at 2:15 PM, Tejpal Rebari wrote: > > Hi Alexey, > Thanks for the review > >> On 21-Aug-2020, at 1:04 AM, Alexey Ivanov > <mailto:alexey.iva...@oracle.com>> wrote: >> >> Hi Tejpal, >> >> Loo

Re: RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

Hi Alexey, Thanks for the review > On 21-Aug-2020, at 1:04 AM, Alexey Ivanov wrote: > > Hi Tejpal, > > Looks good overall, however, I have a couple of comments. > > I suggest using the elements for setting width of table columns. Add > the following three lines before in *properties.html*:

RFR: 8251122: doclint html5 errors in java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8251122 Webrev : http://cr.openjdk.java.net/~trebari/swing/8251122/webrev00/ Issue

Re: RFR: 8251125: doclint errors about missing references in Swing javadoc

Hi Prasanta, > On 13-Aug-2020, at 6:52 PM, Prasanta Sadhukhan > wrote: > > > On 13-Aug-20 6:46 PM, Tejpal Rebari wrote: >> Hi Prasanta, >> Thanks for the review. >> >>> On 13-Aug-2020, at 6:36 PM, Prasanta Sadhukhan >>> wrote: >>&g

Re: RFR: 8251125: doclint errors about missing references in Swing javadoc

le. I have seen that there are other lines in the same file that doesn’t follow 80 chars per line. Regards Tejpal > > Regards > > Prasanta > > On 13-Aug-20 6:12 PM, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk16. >> >&

RFR: 8251125: doclint errors about missing references in Swing javadoc

Hi All, Please review the following fix for jdk16. Bug: https://bugs.openjdk.java.net/browse/JDK-8251125 Webrev : http://cr.openjdk.java.net/~trebari/swing/8251125/webrev00/ Issue :

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Gentle Reminder. > On 04-Aug-2020, at 11:46 AM, Tejpal Rebari wrote: > > Hi Phil, > I have updated the path of the test. > Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/ > <http://cr.openjdk.java.net/~trebari/swing/8249674/webrev02/&

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

away from using bug ids in path names or the names > of the tests themselves. > > -phil > > On 7/29/20, 4:53 AM, Prasanta Sadhukhan wrote: >> >> >> On 29-Jul-20 1:25 PM, Tejpal Rebari wrote: >>> Hi Prasanta, >>> >>>> On 27-Jul-2

Re: RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

9674/webrev01/> Thanks Tejpal > Regards > Prasanta > On 24-Jul-20 2:36 PM, Tejpal Rebari wrote: >> Hi All, >> Please review the following fix for jdk16. >> >> Bug : https://bugs.openjdk.java.net/browse/JDK-8249674 >> <https://bugs.openjdk.java.net/browse

RFR: 8249674: Redo: Nimbus JTree renderer properties persist across L changes

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249674 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249674/webrev00/ This

Re: RFR: Nimbus L Fix for 8041701 is causing some Nimbus tests to fail

> On 17-Jul-2020, at 8:59 PM, Philip Race wrote: > > Sound fine except do NOT re-open 8041701 - please file a new bug. Ok, sure I will file a new bug. Can somebody please push this change, as I don’t have commit rights. Thanks Tejpal > > -phil. > > On 7/17/20, 6:16 AM

RFR: Nimbus L Fix for 8041701 is causing some Nimbus tests to fail

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8249619 Webrev : http://cr.openjdk.java.net/~trebari/swing/8249619/webrev00/ This

Re: RFR: 8041701 Nimbus JTree renderer properties persist across L changes

Hi Sergey, Thanks for the review. > On 11-Jul-2020, at 11:41 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > The fix looks fine, could you please update the test to check that all > installed L work the same way. I have updated the test to check for all installed LAF. Updated webrev :

RFR: 8041701 Nimbus JTree renderer properties persist across L changes

Hi All, Please review the following fix for jdk16. Bug : https://bugs.openjdk.java.net/browse/JDK-8041701 Webrev : http://cr.openjdk.java.net/~trebari/swing/8041701/webrev00/ Issue

  1   2   >