On Thu, 24 Sep 2020 16:11:11 GMT, Phil Race <p...@openjdk.org> wrote:
>> Tejpal Rebari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Testing filechooser on aqua at a different place, where context popup works
>
> test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java line 105:
>
>> 103: if (System.getProperty("os.name").startsWith("Mac")) {
>> 104: isAquaFileChooser = true;
>> 105: } else {
>
> nitpick: it depends on the current L&F, doesn't it ?
Yes it does, this test was testing aqua by default on mac os x. that's why i
added a check of OS.
But adding a check for LAF sounds better so
I will add (UIManager.getLookAndFeel().getID()).equals("Aqua") check instead of
System.getProperty("os.name").startsWith("Mac")) in the next commit.
> test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java line 156:
>
>> 154: Point p = c.getLocationOnScreen();
>> 155: Dimension size = c.getSize();
>> 156: if (isAquaFileChooser){
>
> nit pick ){ -> ) { - ie add a space.
Will do.
-------------
PR: https://git.openjdk.java.net/jdk/pull/204
