Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-17 Thread Sergey Bylokhov
, November 12, 2019 11:30 AM *To:* Tejpal Rebari; Pankaj Bansal *Cc:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> <mailto:swing-dev@openjdk.java.net> *Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Please remove unu

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-14 Thread Tejpal Rebari
khan >>>> *Sent:* Tuesday, November 12, 2019 11:30 AM >>>> *To:* Tejpal Rebari; Pankaj Bansal >>>> *Cc:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> >>>> *Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on >>>&

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-14 Thread Sergey Bylokhov
:* swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> *Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Please remove ununsed imports from the test(no need for new webrev for me), other than that, looks ok to me. Regards Pr

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-13 Thread Tejpal Rebari
nta Sadhukhan >> *Sent:* Tuesday, November 12, 2019 11:30 AM >> *To:* Tejpal Rebari; Pankaj Bansal >> *Cc:* swing-dev@openjdk.java.net >> *Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on >> (CompoundEdit) UndoableEditEvent.getEdit() >> Please remove

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-12 Thread Sergey Bylokhov
*Subject:* Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Please remove ununsed imports from the test(no need for new webrev for me), other than that, looks ok to me. Regards Prasanta On 12-Nov-19 11:24 AM, Tejpal Rebari wrote: Hi Prasanta

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Pankaj Bansal
Looks good to me   -Pankaj   From: Prasanta Sadhukhan Sent: Tuesday, November 12, 2019 11:30 AM To: Tejpal Rebari; Pankaj Bansal Cc: swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()   Please remove ununsed

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Prasanta Sadhukhan
ue.  You should remove this. Regards, Pankaj *From:*Prasanta Sadhukhan *Sent:*Monday, November 11, 2019 11:47 AM *To:*Tejpal Rebari *Cc:*swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> *Subject:*Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEdit

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Tejpal Rebari
t;> 2. The test case name should be something meaningful instead of bug***. >>> 3. You should not need the GridBagConstraints code anywhere to >>> reproduce the issue. You should remove this. >>> >>> >>> Regards, >>> Pankaj >

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Prasanta Sadhukhan
swing-dev@openjdk.java.net> *Subject:*Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Fix looks ok to me. Regarding the test, dispose() should be called under EDT, just as you have done for createAndShowGUI().Also, I don't think createGridBagLayout()

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-11 Thread Tejpal Rebari
swing-dev@openjdk.java.net > Subject: Re: [14] RFR JDK-8190763 - Class cast exception on > (CompoundEdit) UndoableEditEvent.getEdit() > > Fix looks ok to me. Regarding the test, dispose() should be called under EDT, > just as you have done for createAndShowGUI().Also, I don't t

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-10 Thread Pankaj Bansal
remove this.     Regards, Pankaj   From: Prasanta Sadhukhan Sent: Monday, November 11, 2019 11:47 AM To: Tejpal Rebari Cc: swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()   Fix looks ok to me. Regarding the

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-10 Thread Prasanta Sadhukhan
Fix looks ok to me. Regarding the test, dispose() should be called under EDT, just as you have done for createAndShowGUI().Also, I don't think createGridBagLayout() code is necessary to recreate the issue. Regards Prasanta On 08-Nov-19 3:56 PM, Tejpal Rebari wrote: Hi Prasanta , I have added a

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-11-08 Thread Tejpal Rebari
Hi Prasanta , I have added a test to the fix. Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8190763/webrev1/ Regards Tejpal > On 31-Oct-2019, at 1:58 PM, Prasanta Sadhukhan > wrote: > > Hi tejpal, > > Can you add a

Re: [14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-10-31 Thread Prasanta Sadhukhan
Hi tejpal, Can you add a testcase to the fix? I guess one is there in the JBS itself. Regards Prasanta On 24-Oct-19 10:31 AM, Tejpal Rebari wrote: Hi All, Please review the following fix for jdk14. Bug: https://bugs.openjdk.java.net/browse/JDK-8190763 Webrev: http://cr.openjdk.java.net/~trebar

[14] RFR JDK-8190763 - Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit()

2019-10-23 Thread Tejpal Rebari
Hi All, Please review the following fix for jdk14. Bug : https://bugs.openjdk.java.net/browse/JDK-8190763 Webrev : http://cr.openjdk.java.net/~trebari/swing/8190763/webrev0/