Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Jan 10, 2017, at 8:42 AM, Sergey Bylokhov > wrote: > > Hello, > Please review the new version: > http://cr.openjdk.java.net/~serb/8149879/webrev.03 > > The specification of addResourceBundle() is updated. >

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

Hello, Please review the new version: http://cr.openjdk.java.net/~serb/8149879/webrev.03 The specification of addResourceBundle() is updated. > >> >> On Dec 22, 2016, at 1:33 AM, Semyon Sadetsky >

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Dec 22, 2016, at 1:33 AM, Semyon Sadetsky > wrote: > > > > On 20.12.2016 19:41, Mandy Chung wrote: >> >>> On Dec 20, 2016, at 8:24 AM, Sergey Bylokhov >> > wrote: >>> >> If this private

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 20.12.2016 19:41, Mandy Chung wrote: On Dec 20, 2016, at 8:24 AM, Sergey Bylokhov > wrote: If this private data can be loaded to the UIDefaults or to other class then it will be read anyway. Are the Swing/AWT properties

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Dec 20, 2016, at 8:24 AM, Sergey Bylokhov > wrote: > If this private data can be loaded to the UIDefaults or to other class then it will be read anyway. Are the Swing/AWT properties files content really secret? >>> My point is that there are no

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

>>> If this private data can be loaded to the UIDefaults or to other class then >>> it will be read anyway. Are the Swing/AWT properties files content really >>> secret? >> My point is that there are no secrets, but the bug description states that >> such bundles can be added some day later. >

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 19.12.2016 16:50, Sergey Bylokhov wrote: 16 дек. 2016 г., в 9:35, Semyon Sadetsky написал(а): On 15.12.2016 13:19, Sergey Bylokhov wrote: Because addResourceBundle() was modified to «not» allow the users to expose internal resource bundles(for example the

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Dec 19, 2016, at 5:59 AM, Sergey Bylokhov > wrote: > >> Sergey, >> >> I suggest to update the spec of UIDefaults::addResourceBundle to: >> >> Adds a resource bundle to the list of resource bundles that are >> searched for localized values. Resource bundles

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> Sergey, > > I suggest to update the spec of UIDefaults::addResourceBundle to: > > Adds a resource bundle to the list of resource bundles that are > searched for localized values. Resource bundles are searched in > the reverse order they were added, using the {@linkplain >

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Dec 15, 2016, at 10:35 PM, Semyon Sadetsky > wrote: > > On 15.12.2016 13:19, Sergey Bylokhov wrote: > Because addResourceBundle() was modified to «not» allow the users to expose internal resource bundles(for example the users are not able to

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 15.12.2016 13:19, Sergey Bylokhov wrote: Because addResourceBundle() was modified to «not» allow the users to expose internal resource bundles(for example the users are not able to read content of some random bundle), only if internal bundles were registered already by java.desktop the

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

>> Because addResourceBundle() was modified to «not» allow the users to expose >> internal resource bundles(for example the users are not able to read content >> of some random bundle), only if internal bundles were registered already by >> java.desktop the user will be able to

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 14.12.2016 20:11, Sergey Bylokhov wrote: Interesting. Does it mean that if I register some custom resource bundle it will not affect any UI values because all the values is already cached in some UIDefaults map, is that what you mean? The cache will be cleared when you register a new

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

>> Interesting. Does it mean that if I register some custom resource bundle >>> it will not affect any UI values because all the values is already >>> cached in some UIDefaults map, is that what you mean? >> >> The cache will be cleared when you register a new bundle. > And if

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 12/9/2016 10:21 PM, Sergey Bylokhov wrote: Interesting. Does it mean that if I register some custom resource bundle it will not affect any UI values because all the values is already cached in some UIDefaults map, is that what you mean? The cache will be cleared when you register a new

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

Interesting. Does it mean that if I register some custom resource bundle > it will not affect any UI values because all the values is already > cached in some UIDefaults map, is that what you mean? The cache will be cleared when you register a new bundle. >>> And if bundle

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 06.12.2016 23:00, Sergey Bylokhov wrote: 30 нояб. 2016 г., в 23:11, Semyon Sadetsky > написал(а): On 01.12.2016 02:52, Sergey Bylokhov wrote: On 30.11.16 21:12, Semyon Sadetsky wrote: On 30.11.2016 20:51, Sergey

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> 30 нояб. 2016 г., в 23:11, Semyon Sadetsky > написал(а): > > > > On 01.12.2016 02:52, Sergey Bylokhov wrote: >> On 30.11.16 21:12, Semyon Sadetsky wrote: >>> On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: >> The

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 01.12.2016 02:52, Sergey Bylokhov wrote: On 30.11.16 21:12, Semyon Sadetsky wrote: On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 21:12, Semyon Sadetsky wrote: On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about UIDefaults.removeResourceBundle()? This method removes the name of the

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about UIDefaults.removeResourceBundle()? This method removes the name of the bundle from the Vector in UIDefault, so when

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:33, Sergey Bylokhov wrote: On 30.11.16 19:55, Semyon Sadetsky wrote: The fix changes encapsulation of resources bundles inside java.desktop module. The UIDefaults::addResourceBundle() is a way to expose internal bundles(if the user requests the internal bundle he will be able

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:25, Mandy Chung wrote: On Nov 30, 2016, at 8:55 AM, Semyon Sadetsky wrote: On 30.11.2016 19:34, Sergey Bylokhov wrote: On 30.11.16 9:52, Semyon Sadetsky wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 19:55, Semyon Sadetsky wrote: The fix changes encapsulation of resources bundles inside java.desktop module. The UIDefaults::addResourceBundle() is a way to expose internal bundles(if the user requests the internal bundle he will be able to read it). The fix does not change the state

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Nov 30, 2016, at 8:55 AM, Semyon Sadetsky > wrote: > > > > On 30.11.2016 19:34, Sergey Bylokhov wrote: >> On 30.11.16 9:52, Semyon Sadetsky wrote: >>> On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: >>> Hello. Please review the fix for jdk9.

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 29.11.16 17:21, Alexandr Scherbatiy wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 9:52, Semyon Sadetsky wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the java.desktop module.

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

+1 -phil. On 11/28/2016 08:41 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

Looks okay to me. Mandy > On Nov 28, 2016, at 8:41 AM, Sergey Bylokhov > wrote: > > Hello. > > Please review the fix for jdk9. > > This fix improve encapsulation of java.desktop module. After the fix the > method "UIDefaults::addResourceBundle()" will not be

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the java.desktop module.

[9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which are located in the java.desktop module. Only the java.desktop module itself will be