Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

@openjdk.java.net Subject: Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet() Hi Jay, On 13-Mar-2020, at 3:55 PM, Jayathirth D v mailto:jayathirth@oracle.com"jayathirth@oracle.com> wrote: Hi Tejpal, Test case is not verifying all failure scenarios

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

+1. Thanks, Jay > On 13-Mar-2020, at 4:31 PM, Tejpal Rebari wrote: > > Hi Jay, >> On 13-Mar-2020, at 3:55 PM, Jayathirth D v > > wrote: >> >> Hi Tejpal, >> >> Test case is not verifying all failure scenarios properly (If both test >> cases fail exception wil

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Jay, > On 13-Mar-2020, at 3:55 PM, Jayathirth D v wrote: > > Hi Tejpal, > > Test case is not verifying all failure scenarios properly (If both test cases > fail exception will be thrown only for first test failure) > Make sure that you verify each test case failure and print appropriate > m

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Tejpal, Test case is not verifying all failure scenarios properly (If both test cases fail exception will be thrown only for first test failure) Make sure that you verify each test case failure and print appropriate message. Source change looks good to me. Thanks, Jay > On 13-Mar-2020, at 3

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Looks fine. On 3/13/20 2:30 am, Tejpal Rebari wrote: Hi Sergey, On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov mailto:sergey.bylok...@oracle.com>> wrote: On 3/10/20 1:04 am, Tejpal Rebari wrote: I am not getting how to cover this in the test. I that additional call is necessary, then it shoul

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Sergey, > On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov > wrote: > > On 3/10/20 1:04 am, Tejpal Rebari wrote: >> I am not getting how to cover this in the test. > > I that additional call is necessary, then it should be possible to trigger it > by the test. > > -- > Best regards, Sergey.

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

On 3/10/20 1:04 am, Tejpal Rebari wrote: I am not getting how to cover this in the test. I that additional call is necessary, then it should be possible to trigger it by the test. -- Best regards, Sergey.

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Sergey, > On 09-Mar-2020, at 5:27 PM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > Do not you need to call super.keySet() as well? > +set.addAll(super.keySet()); > return set; Yes, will update this. > > similar to public Set> entrySet() {...} > > It would be good to update the test to co

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi, Tejpal. Do not you need to call super.keySet() as well? +set.addAll(super.keySet()); return set; similar to public Set> entrySet() {...} It would be good to update the test to cover this. On 3/8/20 5:03 pm, Tejpal Rebari wrote: Hello Pankaj and Sergey, I have updated the keySet() met

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Thanks for review Pankaj. > On 09-Mar-2020, at 11:42 AM, Pankaj Bansal wrote: > > Hello Tejpal, > > The product fix part looks ok to me. > You are still not following the 80 chars max per line convention in line 44. > Also, you don’t need to print keysCount and KeySetCount if they are equal.

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

fails. Regards, Pankaj From: Tejpal Rebari Sent: Monday, March 9, 2020 5:33 AM To: Pankaj Bansal ; Sergey Bylokhov Cc: swing-dev@openjdk.java.net Subject: Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet() Hello Pankaj and Sergey, I have update

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hello Pankaj and Sergey, I have updated the keySet() method and test as per your suggestions. Please take a look. Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/ Regards Tejpal

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

On 3/5/20 11:40 pm, Pankaj Bansal wrote: Hello Tejpal, I think you need to iterate over the full "tables" array instead of just using the tables[0] as is being done in entrySet function in same class. Also, you need to create a copy of the key set like entrySet function instead of returning th

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hello Tejpal, I think you need to iterate over the full "tables" array instead of just using the tables[0] as is being done in entrySet function in same class. Also, you need to create a copy of the key set like entrySet function instead of returning the original handle. Also, please follow

RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8146330 Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev0/