Re: [sympy] Reviewing PRs and old SymPy issues

Do you have some guidelines you follow or just some general advice for people who are willing to do that work . It will also help new contributors like me understand what things need to be checked apart from the ones mentioned in the developer documentation before I make a pull request .

Re: [sympy] Reviewing PRs and old SymPy issues

I have found some old opened issues that should be closed, so, is it a good idea to open a new PR (which has title like "CLOSED [issue]..." with a test, if similar tests do not exists) or creating a new conversation here, IMO PR is a better option. PRs with title like CLOSED [issue].. could be

Re: [sympy] Reviewing PRs and old SymPy issues

Perhaps other things should be mentioned in the GSOC application instructions. I do think that the PR requirement is reasonable as a baseline for GSOC though. To be clear opening pull requests is a good thing. Reviewing pull requests is a lot of work for maintainers though. If lots of people

Re: [sympy] Closing Old Issues

On Tue, 6 Feb 2024 at 07:42, Shishir Kushwaha wrote: > > I was going over the open issues i could potentially solve and I think some > of them are still open after their solution PR has been merged. What do I do > about those issues . Should I leave a comment on the issue on its closing or >

Re: [sympy] Reviewing PRs and old SymPy issues

Sir I'd also like to review and test pull request , I've started contributing recently , My Github Id - *abhiphile* abhiphile (ABHISHEK KUMAR) (github.com) On Tue, Feb 6, 2024 at 10:35 AM Aaron Meurer wrote: > I'll also add that if you want to, we'll give triage

Re: [sympy] Reviewing PRs and old SymPy issues

IMO giving triage access to anyone will lead to future problems for SYMPY because wrong labels may lead to misunderstanding and complexities. Also, a better idea could be opening a root issue or root PR for this section (closing old issues). On Tue, 6 Feb 2024 at 20:08, 'Shishir Kushwaha 5-Yr

Re: [sympy] Reviewing PRs and old SymPy issues

Wouldn't creating another PR add to the problem of checking more PRs? On Tue, 6 Feb 2024, 5:52 pm Mohit Kumar, wrote: > I have found some old opened issues that should be closed, so, is it a > good idea to open a new PR (which has title like "CLOSED [issue]..." with a > test, if similar tests