Re: [sympy] ODE Refactoring

2021-03-17 Thread Marco Antônio Habitzreuter
Hi. > Although for now I didn't make much changes, if you are working on this PR, > do let me know so that I can start refactoring other solvers. Yes, I'm working on it. I began with the code made by the other author and now I'm trying to address Oscar's suggestions made in the original PR

Re: [sympy] ODE Refactoring

2021-03-17 Thread mohit balwani
Hello Marco, sorry, I didn't notice your first email earlier and I am also working to take over the same PR. Although for now I didn't make much changes, if you are working on this PR, do let me know so that I can start refactoring other solvers. Thanks, Mohit. On Wed, Mar 17, 2021 at 9:52 AM

Re: [sympy] ODE Refactoring

2021-03-16 Thread Marco Antônio Habitzreuter
Oscar, > When continuing an existing PR by another author it is important to > keep the note of who wrote what intact in the git commits. I would > checkout the branch of the other contributor and rebase it to master > and then add my own commits on top. I was able to rebase and get that code

Re: [sympy] ODE Refactoring

2021-03-16 Thread Oscar Benjamin
On Tue, 16 Mar 2021 at 09:10, Marco Antônio Habitzreuter wrote: > > Hello folks. I hope you and your families are doing well. > > I'm a physics undergraduate in my final semester. I have been using Sympy for > the last 6 months or so, after having some good experiences with Numpy to > analyze

[sympy] ODE Refactoring

2021-03-16 Thread Marco Antônio Habitzreuter
Hello folks. I hope you and your families are doing well. I'm a physics undergraduate in my final semester. I have been using Sympy for the last 6 months or so, after having some good experiences with Numpy to analyze experimental data. Before that, most of my coding was in C. It has been an