Hello together,
I recently stumbled over cdrom_id opening the device with the O_EXCL flag set,
if it is not currently mounted:
fd = open(node, O_RDONLY|O_NONBLOCK|(is_mounted(node) ? 0 : O_EXCL));
The effect of this is that automatically mounting a cdrom sometimes results in
resource busy, if
-Original Message-
From: Hoyer, Marko (ADITG/SW2)
Sent: Thursday, September 18, 2014 8:22 AM
To: systemd-devel@lists.freedesktop.org
Subject: cdrom_id opens device with O_EXCL, why?
Hello together,
I recently stumbled over cdrom_id opening the device with the O_EXCL flag set,
David Herrmann dh.herrm...@gmail.com writes:
Hi
On Mon, Sep 15, 2014 at 2:00 PM, Jan Synacek jsyna...@redhat.com wrote:
David Herrmann dh.herrm...@gmail.com writes:
Your original patch is right, too. But I'm not sure which one to
prefer. Given that we export systemd-sysctl as rpm macro, I
On 09/17/2014 11:10 PM, Cristian Rodríguez wrote:
---
src/libsystemd/sd-bus/bus-kernel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd/sd-bus/bus-kernel.c
b/src/libsystemd/sd-bus/bus-kernel.c
index 505f335..b3cc996 100644
---
On 09/18/2014 02:56 AM, Cristian Rodríguez wrote:
..by simply moving the declaration of unit into the STRV_FOREACH
loop as suggested by Andreas.
---
src/systemctl/systemctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/systemctl/systemctl.c
Hi
On Thu, Sep 18, 2014 at 8:22 AM, Hoyer, Marko (ADITG/SW2)
mho...@de.adit-jv.com wrote:
Hello together,
I recently stumbled over cdrom_id opening the device with the O_EXCL flag
set, if it is not currently mounted:
fd = open(node, O_RDONLY|O_NONBLOCK|(is_mounted(node) ? 0 : O_EXCL));
On s390 the big endianness and cast from pointers of integers to
the type of bool leads to the funny status messages that e.g.
all targets are set to AllowIsolate=no even for multi-user.target.
The gcc builtin type bool or _Bool has the size of one byte which
should be taken into account in
Hi
On Thu, Sep 18, 2014 at 11:16 AM, Werner Fink wer...@suse.de wrote:
On s390 the big endianness and cast from pointers of integers to
the type of bool leads to the funny status messages that e.g.
all targets are set to AllowIsolate=no even for multi-user.target.
The gcc builtin type bool
On Thu, Sep 18, 2014 at 12:43:00PM +0200, David Herrmann wrote:
Hi
On Thu, Sep 18, 2014 at 11:16 AM, Werner Fink wer...@suse.de wrote:
On s390 the big endianness and cast from pointers of integers to
the type of bool leads to the funny status messages that e.g.
all targets are set to
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Thursday, September 18, 2014 10:31 AM
To: Hoyer, Marko (ADITG/SW2)
Cc: systemd-devel@lists.freedesktop.org
Subject: Re: [systemd-devel] cdrom_id opens device with O_EXCL, why?
Hi
On Thu, Sep 18, 2014
Hi
On Thu, Sep 18, 2014 at 12:57 PM, Dr. Werner Fink wer...@suse.de wrote:
On Thu, Sep 18, 2014 at 12:43:00PM +0200, David Herrmann wrote:
Hi
On Thu, Sep 18, 2014 at 11:16 AM, Werner Fink wer...@suse.de wrote:
On s390 the big endianness and cast from pointers of integers to
the type of
Hi
On Thu, Sep 18, 2014 at 12:57 PM, Dr. Werner Fink wer...@suse.de wrote:
linuxadmin:~ # uname -m
s390x
linuxadmin:~ # systemctl show multi-user.target | grep -E '=(yes|no)'
CanStart=no
CanStop=no
CanReload=no
CanIsolate=no
StopWhenUnneeded=no
RefuseManualStart=no
Hi
On Thu, Sep 18, 2014 at 1:02 PM, Hoyer, Marko (ADITG/SW2)
mho...@de.adit-jv.com wrote:
Thx for the answer.
The automounter is listening to the udev socket so it is actually waiting for
the
event to be processed completely. But unfortunately, it appears that sequences
of change events
On Thu, Sep 18, 2014 at 01:20:47PM +0200, David Herrmann wrote:
Hi
On Thu, Sep 18, 2014 at 12:57 PM, Dr. Werner Fink wer...@suse.de wrote:
On Thu, Sep 18, 2014 at 12:43:00PM +0200, David Herrmann wrote:
Hi
On Thu, Sep 18, 2014 at 11:16 AM, Werner Fink wer...@suse.de wrote:
On s390
On Thu, Sep 18, 2014 at 01:29:26PM +0200, David Herrmann wrote:
Hi
On Thu, Sep 18, 2014 at 12:57 PM, Dr. Werner Fink wer...@suse.de wrote:
linuxadmin:~ # uname -m
s390x
linuxadmin:~ # systemctl show multi-user.target | grep -E '=(yes|no)'
CanStart=no
CanStop=no
Hi again
On Thu, Sep 18, 2014 at 1:34 PM, David Herrmann dh.herrm...@gmail.com wrote:
I'm putting Harald and Kay on CC, as they added O_EXCL to protect
against parallel burning-sessions. Maybe they can tell you whether
that is still needed today and whether we can drop it.
So my conception of
On 17/09/14 17:52, Jóhann B. Guðmundsson wrote:
On 09/17/2014 12:26 PM, David Sommerseth wrote:
Hi,
I've been playing with the systemd feature enabled in OpenVPN. And I
propose this change to systemd-ask-password to avoid masking usernames.
I tried looking for alternative ways querying
Hi,
Around the internet one can read statements such as systemd
is designed with glibc in mind and the systemd developers' idea
of a standard libc is one that has bug-for-bug compatibility with
glibc. So in a fit of naivety I decided to test this out and see
how much work it would take to make
---
src/shared/socket-util.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/shared/socket-util.c b/src/shared/socket-util.c
index e3e54e8..d4a1679 100644
--- a/src/shared/socket-util.c
+++ b/src/shared/socket-util.c
@@ -41,6 +41,16 @@
#include missing.h
#include fileio.h
If the standard library doesn't provide brace
expansion users just won't get it.
---
src/shared/util.c | 6 ++
src/tmpfiles/tmpfiles.c | 6 ++
2 files changed, 12 insertions(+)
diff --git a/src/shared/util.c b/src/shared/util.c
index 9157b2f..76899f5 100644
--- a/src/shared/util.c
---
src/shared/pty.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/shared/pty.c b/src/shared/pty.c
index 2863da4..21a87e5 100644
--- a/src/shared/pty.c
+++ b/src/shared/pty.c
@@ -61,6 +61,11 @@
#include termios.h
#include unistd.h
+/* If sys/ioctl.h doesn't provide TIOCSIG use
I'd like to make utmp/wtmp handling a configure option, but for
now this is the minimal change needed to make it compile with musl.
The musl utmp/wtmp functions doesn't do anything anyway.
---
src/shared/utmp-wtmp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/shared/utmp-wtmp.c
---
src/libsystemd/sd-rtnl/rtnl-message.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/libsystemd/sd-rtnl/rtnl-message.c
b/src/libsystemd/sd-rtnl/rtnl-message.c
index 30e3358..b501a52 100644
--- a/src/libsystemd/sd-rtnl/rtnl-message.c
+++ b/src/libsystemd/sd-rtnl/rtnl-message.c
---
src/socket-proxy/socket-proxyd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c
index 81d8457..ff2b24f 100644
--- a/src/socket-proxy/socket-proxyd.c
+++ b/src/socket-proxy/socket-proxyd.c
@@ -26,7 +26,7
---
configure.ac | 3 ++-
src/shared/missing.h | 11 +++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 1f2bbd0..3db0e24 100644
--- a/configure.ac
+++ b/configure.ac
@@ -301,9 +301,10 @@ LIBS=$save_LIBS
---
man/sd_journal_get_fd.xml | 2 +-
src/ask-password/ask-password.c | 2 +-
src/bus-proxyd/bus-proxyd.c | 2 +-
src/core/execute.c | 2 +-
src/core/manager.c |
---
src/shared/label.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/label.h b/src/shared/label.h
index 7294820..cb2ec79 100644
--- a/src/shared/label.h
+++ b/src/shared/label.h
@@ -24,6 +24,7 @@
#include sys/types.h
#include stdbool.h
#include sys/socket.h
+#include stdio.h
---
src/shared/util.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/util.h b/src/shared/util.h
index 08d556f..32e5090 100644
--- a/src/shared/util.h
+++ b/src/shared/util.h
@@ -24,6 +24,7 @@
#include alloca.h
#include fcntl.h
#include inttypes.h
+#include sys/reg.h
#include
---
src/shared/missing.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/missing.h b/src/shared/missing.h
index b441149..8389c28 100644
--- a/src/shared/missing.h
+++ b/src/shared/missing.h
@@ -353,7 +353,7 @@ static inline int name_to_handle_at(int fd, const char
---
src/shared/missing.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/shared/missing.h b/src/shared/missing.h
index 55e61f6..be099c5 100644
--- a/src/shared/missing.h
+++ b/src/shared/missing.h
@@ -147,6 +147,11 @@ static inline char *canonicalize_file_name(const char
*path) {
---
configure.ac | 3 ++-
src/shared/missing.h | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index fb16904..1f2bbd0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -301,8 +301,9 @@ LIBS=$save_LIBS
AC_CHECK_FUNCS([fanotify_init
---
src/shared/sparse-endian.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/sparse-endian.h b/src/shared/sparse-endian.h
index eb4dbf3..c913fda 100644
--- a/src/shared/sparse-endian.h
+++ b/src/shared/sparse-endian.h
@@ -21,6 +21,7 @@
#ifndef SPARSE_ENDIAN_H
#define
This is also the only place where FTW_ACTIONRETVAL is used, so
this makes systemd compile without SELinux or SMACK support
when the standard library doesn't support this extension.
---
src/core/mount-setup.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/core/mount-setup.c
---
src/udev/udevadm-hwdb.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/udev/udevadm-hwdb.c b/src/udev/udevadm-hwdb.c
index 65cbf61..3f31662 100644
--- a/src/udev/udevadm-hwdb.c
+++ b/src/udev/udevadm-hwdb.c
@@ -123,13 +123,13 @@ static void
---
src/core/execute.c | 6 +++---
src/core/load-fragment.c| 2 +-
src/core/manager.c | 2 +-
src/core/unit.c | 4 ++--
src/delta/delta.c | 14 +++---
src/journal/journalctl.c| 2 +-
---
configure.ac | 1 +
src/libsystemd-network/sd-ipv4ll.c | 25 +
2 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 397521e..9cd4c05 100644
--- a/configure.ac
+++ b/configure.ac
@@ -301,6 +301,7 @@
---
src/core/mount.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/core/mount.c b/src/core/mount.c
index e284357..f3ec736 100644
--- a/src/core/mount.c
+++ b/src/core/mount.c
@@ -903,10 +903,10 @@ static void mount_enter_mounting(Mount *m) {
In case we don't have the new gold linker,
linking with ld fails without this option.
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 3f17833..4be6e08 100644
--- a/configure.ac
+++ b/configure.ac
@@ -216,6 +216,7 @@
---
Makefile.am | 4 +
configure.ac | 2 +
src/journal/journal-send.c | 2 +-
src/shared/log.c | 2 +-
src/shared/parse-printf-format.c | 273 +++
src/shared/parse-printf-format.h | 57
---
units/initrd-udevadm-cleanup-db.service.in | 2 +-
units/kmod-static-nodes.service.in | 2 +-
units/systemd-journal-flush.service.in | 2 +-
units/systemd-udev-hwdb-update.service.in | 2 +-
units/systemd-udev-trigger.service.in | 2 +-
5 files changed, 5 insertions(+), 5
---
configure.ac | 2 ++
src/journal/journal-send.c| 36 +++-
src/libsystemd/sd-bus/bus-error.c | 14 +-
3 files changed, 42 insertions(+), 10 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9cd4c05..3f17833
Hi
On Mon, Sep 15, 2014 at 2:03 PM, Robert Milasan rmila...@suse.com wrote:
On Sat, 13 Sep 2014 15:29:23 +0200
Robert Milasan rmila...@suse.com wrote:
Hello, I've found a lingering bug in udev since udev changed it's
database name from long names to short names 'ex: b9:1'.
The bug is more
Hi
On Mon, Sep 15, 2014 at 11:07 PM, Michael Marineau
michael.marin...@coreos.com wrote:
This sentence can be misread to mean that \x20 is the escape code for
- which is the only character explicitly mentioned. This lead to at
least one user loosing hair over why a mount unit for /foo/bar-baz
Hi
On Tue, Sep 16, 2014 at 11:27 PM, philippedesw...@gmail.com wrote:
From: Philippe De Swert philippedesw...@gmail.com
There is a very unlikely case where this can happen since gcc usually
does the sane thing. But let's make sure found_last is initialized anyway.
Applied.
Thanks
David
-Original Message-
From: David Herrmann [mailto:dh.herrm...@gmail.com]
Sent: Thursday, September 18, 2014 1:57 PM
To: Hoyer, Marko (ADITG/SW2)
Cc: systemd-devel@lists.freedesktop.org; Harald Hoyer; Kay Sievers
Subject: Re: [systemd-devel] cdrom_id opens device with O_EXCL, why?
Hi
On 18 September 2014 15:56, Karol Lewandowski k.lewando...@samsung.com wrote:
I think it would be way better (and easy) to reimplement original
secure_getenv() rather than falling back to function with different
semantics. secure_ is there for a reason.
Agreed. Added to my TODO, thanks.
On 09/18/2014 01:24 PM, Emil Renner Berthing wrote:
The real reason is of course that I'd like to see systemd running
on my router and other small devices that usually run some OpenWRT
derivative.
The openwrt community is still going forward with their (re)-invention
of init system called
On 18 September 2014 16:10, Jóhann B. Guðmundsson johan...@gmail.com wrote:
On 09/18/2014 01:24 PM, Emil Renner Berthing wrote:
The real reason is of course that I'd like to see systemd running
on my router and other small devices that usually run some OpenWRT
derivative.
The openwrt
Hi,
On 18/09/14 17:13, Emil Renner Berthing wrote:
On 18 September 2014 16:10, Jóhann B. Guðmundsson johan...@gmail.com
wrote:
On 09/18/2014 01:24 PM, Emil Renner Berthing wrote:
The real reason is of course that I'd like to see systemd running
on my router and other small devices that
El 18/09/14 a las #4, Emil Renner Berthing escribió:
---
src/shared/missing.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/missing.h b/src/shared/missing.h
index b441149..8389c28 100644
--- a/src/shared/missing.h
+++ b/src/shared/missing.h
@@ -353,7 +353,7 @@
El 18/09/14 a las #4, Emil Renner Berthing escribió:
+#if !HAVE_DECL_CANONICALIZE_FILE_NAME
+static inline char *canonicalize_file_name(const char *path) {
+return realpath(path, NULL);
+}
+#endif
No, no reimplementations of library functions here, only wrappers for
syscalls which
El 18/09/14 a las #4, Emil Renner Berthing escribió:
+#if !HAVE_DECL_STRNDUPA
+#define strndupa(s, n) \
+ ({ \
+const char *__old = (s); \
+size_t __len = strnlen(__old, (n)); \
+char *__new = (char *)alloca(__len + 1); \
+__new[__len] = '\0'; \
+(char *)memcpy(__new,
On 09/18/2014 02:20 PM, Philippe De Swert wrote:
Hi,
On 18/09/14 17:13, Emil Renner Berthing wrote:
On 18 September 2014 16:10, Jóhann B. Guðmundsson johan...@gmail.com wrote:
On 09/18/2014 01:24 PM, Emil Renner Berthing wrote:
The real reason is of course that I'd like to see systemd
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
I'd like to make utmp/wtmp handling a configure option,
I think that would make more sense (and serve the same purpose), so I
suggest doing that instead.
but for
now this is the minimal change needed to make it
Applied. Thanks!
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/udev/net/link-config.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/udev/net/link-config.c b/src/udev/net/link-config.c
index ee2865a..25e3cc8 100644
---
Applied. Thanks!
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/libsystemd/sd-rtnl/rtnl-message.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/libsystemd/sd-rtnl/rtnl-message.c
b/src/libsystemd/sd-rtnl/rtnl-message.c
index
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
If the standard library doesn't provide brace
expansion users just won't get it.
I don't think we should do this, it would mean implicitly providing a
subtly different feature-set to users, which surely would lead to
This sholud definitely go in your libc instead.
Cheers,
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
Makefile.am | 4 +
configure.ac | 2 +
src/journal/journal-send.c | 2 +-
src/shared/log.c
No, this actually breaks the behaviour, so we absolutely cannot do
this. Again, I suggest adding the missing features to your libc.
Cheers,
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
configure.ac | 1 +
El 18/09/14 a las #4, Emil Renner Berthing escribió:
Hi,
Around the internet one can read statements such as systemd
is designed with glibc in mind and the systemd developers' idea
of a standard libc is one that has bug-for-bug compatibility with
glibc.
For all practical purposes this is
Handle sd_event_default returning error and bail out properly
as done in every other caller of this function.
Found by coverity. Fixes: CID#1238957
---
src/journal-remote/journal-remote.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/journal-remote/journal-remote.c
It does not make sense for us to work around this. Please add it to
your libc instead.
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/udev/udevadm-hwdb.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
From: Philippe De Swert philippedesw...@gmail.com
Gcc is spewing some warnings about uninitialized variables.
Let's get rid of the noise.
---
src/sysusers/sysusers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c
index
From: Philippe De Swert philippedesw...@gmail.com
Gcc is spewing some warnings about uninitialized variables.
Let's get rid of the noise.
---
src/core/bus-endpoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/core/bus-endpoint.c b/src/core/bus-endpoint.c
index
From: Philippe De Swert philippedesw...@gmail.com
When compiling we see this curl warning popping up:
src/journal-remote/journal-upload.c:194:17: warning: call to
‘_curl_easy_setopt_err_error_buffer’ declared with attribute
warning: curl_easy_setopt expects a char buffer of CURL_ERROR_SIZE
as
Applied. Thanks!
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/socket-proxy/socket-proxyd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/socket-proxy/socket-proxyd.c
b/src/socket-proxy/socket-proxyd.c
index
David Sommerseth wrote on 17/09/14 13:26:
If there are better ways how to solve this, please let me know and I'll
go that path instead.
I asked much the same question a looong time back on this list regarding
a generic API to ask for more than just passwords although it was hidden
in a comment
Hm, this one doesn't apply for me. If you rebase and resend I'll apply.
Thanks!
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
man/sd_journal_get_fd.xml | 2 +-
src/ask-password/ask-password.c | 2 +-
Hi
On Thu, Sep 18, 2014 at 6:03 PM, Tom Gundersen t...@jklm.no wrote:
Hm, this one doesn't apply for me. If you rebase and resend I'll apply.
And, please, where applicable, keep alphabetical order.
Thanks
David
___
systemd-devel mailing list
For kmod and systemctl this is fine (so I'd be happy to take a patch
to make that change), but for udevadm it feels weird as the
documentation there says the format should be udevadm trigger. Maybe
something to fix in the libc (assuming the problem is that it enforces
an order).
On Thu, Sep 18,
Applied. Thanks!
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/core/mount.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/core/mount.c b/src/core/mount.c
index e284357..f3ec736 100644
--- a/src/core/mount.c
+++
This needs a bit more explanation. Why this change?
Cheers,
Tom
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/core/execute.c | 6 +++---
src/core/load-fragment.c| 2 +-
src/core/manager.c | 2 +-
On Thu, Sep 18, 2014 at 4:01 PM, Emil Renner Berthing syst...@esmil.dk wrote:
On 18 September 2014 15:56, Karol Lewandowski k.lewando...@samsung.com
wrote:
I think it would be way better (and easy) to reimplement original
secure_getenv() rather than falling back to function with different
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
Around the internet one can read statements such as systemd
is designed with glibc in mind and the systemd developers' idea
of a standard libc is one that has bug-for-bug compatibility with
glibc. So in a fit of
Applied all three. Thanks!
Tom
On Thu, Sep 18, 2014 at 5:56 PM, philippedesw...@gmail.com wrote:
From: Philippe De Swert philippedesw...@gmail.com
Hi,
While compiling systemd I came across these warnings. And as I recompile
a lot these days for Coverity they started to bug me and I just
Applied. Thanks!
Tom
On Thu, Sep 18, 2014 at 5:52 PM, Andreas Henriksson andr...@fatal.se wrote:
Handle sd_event_default returning error and bail out properly
as done in every other caller of this function.
Found by coverity. Fixes: CID#1238957
---
src/journal-remote/journal-remote.c | 6
On Thu, Sep 18, 2014 at 06:10:06PM +0200, Tom Gundersen wrote:
For kmod and systemctl this is fine (so I'd be happy to take a patch
to make that change), but for udevadm it feels weird as the
documentation there says the format should be udevadm trigger. Maybe
something to fix in the libc
El 18/09/14 a las #4, Emil Renner Berthing escribió:
---
And all of this because the POSIX versions of basename modify the
argument .. see the problem ? it is the standard versions that are wrong.
what about implementing a gnu_basename in the C library and using that
instead ?
--
Cristian
I
Hi Tom,
On 18 September 2014 18:29, Tom Gundersen t...@jklm.no wrote:
In general, I don't think we should add patches for the sole purpose
of non-glibc compatibility. You would in most cases be much better
served by adding the missing functionality to your libc, rather than
to each of the
Hi
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/shared/pty.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/shared/pty.c b/src/shared/pty.c
index 2863da4..21a87e5 100644
--- a/src/shared/pty.c
+++ b/src/shared/pty.c
@@ -61,6 +61,11
Hi
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/shared/label.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/label.h b/src/shared/label.h
index 7294820..cb2ec79 100644
--- a/src/shared/label.h
+++ b/src/shared/label.h
@@ -24,6
Hi
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/shared/sparse-endian.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/sparse-endian.h b/src/shared/sparse-endian.h
index eb4dbf3..c913fda 100644
--- a/src/shared/sparse-endian.h
+++
Hi
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/shared/util.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/shared/util.h b/src/shared/util.h
index 08d556f..32e5090 100644
--- a/src/shared/util.h
+++ b/src/shared/util.h
@@ -24,6 +24,7 @@
Hi
On Thu, Sep 18, 2014 at 3:25 PM, Emil Renner Berthing syst...@esmil.dk wrote:
In case we don't have the new gold linker,
linking with ld fails without this option.
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 3f17833..4be6e08
Hi
On Thu, Sep 18, 2014 at 3:24 PM, Emil Renner Berthing syst...@esmil.dk wrote:
---
src/shared/missing.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/shared/missing.h b/src/shared/missing.h
index 55e61f6..be099c5 100644
--- a/src/shared/missing.h
+++
85 matches
Mail list logo
