Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-08-13 Thread Lucas De Marchi
ad > proxy-discoveryd: Add the basic parts for handling DBus methods > update TODO What happened to this patch set? Are you going to send a new version? Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-10 Thread Lucas De Marchi
was using github much more and I had forgotten. Looks like things didn't change since then. Now when I'm reviewing pullrequests I never trust to review them directly in the browser but I rather pull all the pullrequests with a variant of your "git pullnotes": alias.pullpr

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-05 Thread Lucas De Marchi
On Fri, Jun 5, 2015 at 7:02 AM, David Herrmann wrote: > Hi > > On Wed, Jun 3, 2015 at 7:48 PM, Lucas De Marchi > wrote: >> Of course this is a non-issue for several projects in github which >> don't have proper commit >> review. It's not the case of s

Re: [systemd-devel] [ANNOUNCE] Git development moved to github

2015-06-03 Thread Lucas De Marchi
per commit review. It's not the case of systemd and it seems it's even the reason why you are moving to github. So I'm just curious if anything changed in this regard or you solved it in another way. thanks -- Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-13 Thread lucas . de . marchi
From: Lucas De Marchi If we don't check the error of the child process, systemd-vconsole-setup would exit with 0 even if it could not really setup the console. For a simple test, move loadkeys elsewhere and execute systemd-vconsole-setup: [root@localhost ~]# strace -f -e execve

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-12 Thread Lucas De Marchi
On Thu, Mar 12, 2015 at 6:57 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Mar 12, 2015 at 11:00:55AM +0100, Kay Sievers wrote: >> On Thu, Mar 12, 2015 at 5:09 AM, Lucas De Marchi >> wrote: >> > On Tue, Mar 10, 2015 at 3:04 PM, Jeff Waugh wrote: >> >&

[systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-12 Thread lucas . de . marchi
From: Lucas De Marchi If we don't check the error of the child process, systemd-vconsole-setup would exit with 0 even if it could not really setup the console. For a simple test, move loadkeys elsewhere and execute systemd-vconsole-setup: [root@localhost ~]# strace -f -e execve

Re: [systemd-devel] [PATCH] build: generate pkg-config files during configure

2015-03-11 Thread Lucas De Marchi
dy up in Makefile.am, but not 100% > sure.) > > Signed-off-by: Jeff Waugh > --- Kay, please take a look on this. There's a similar patch pending to kmod on [1]. I'm still not sure what exactly it's fixing... seems like just that it would not replace/expand all occurrences

Re: [systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-11 Thread Lucas De Marchi
; >> Is there any reason to continue on r > 0 but not on r < 0? I'm ok with >> changing the current behavior, but just like to know which one is >> better. > > Yeah, not sure here. For most helpers here r<0 means serious error > (fork() failed, etc.), r>

Re: [systemd-devel] [PATCH] vconsole-setup: check error of child process

2015-03-11 Thread Lucas De Marchi
On Wed, Mar 11, 2015 at 12:55 PM, David Herrmann wrote: > Hi > > On Tue, Mar 10, 2015 at 8:56 PM, wrote: >> From: Lucas De Marchi >> >> If we don't check the error of the child process, systemd-vconsole-setup >> would exit with 0 even if it could not

Re: [systemd-devel] [PATCH] use dolt.m4 to speedup compilation

2015-03-05 Thread Lucas De Marchi
On Thu, Mar 5, 2015 at 10:37 PM, wrote: > On Thu, Mar 05, 2015 at 10:33:19PM -0300, Lucas De Marchi wrote: >> On Thu, Mar 5, 2015 at 9:58 PM, wrote: >> > On Fri, Mar 06, 2015 at 12:55:38AM +0100, Michael Biebl wrote: >> >> 2015-03-05 11:58 GMT+01:00

Re: [systemd-devel] [PATCH] use dolt.m4 to speedup compilation

2015-03-05 Thread Lucas De Marchi
0m24.724s >> >> >> libtool version is 2.4.2. > > That's more what I'd expect with current versions of libtool, which has > supposedly fixed many of the issues that motivated the creation of dolt > in the first place. Maybe it was a regression in libtool fro

Re: [systemd-devel] [PATCH] core: emit changes for NFailedUnits property

2015-02-25 Thread Lucas De Marchi
Ping? -- Lucas De Marchi On Wed, Feb 18, 2015 at 2:22 PM, wrote: > From: Lucas De Marchi > > By notifying the clients when this property is changed it's possible to > allow "system health monitor" tools to get transitions like > running<->degraded. This

[systemd-devel] [PATCH] core: emit changes for NFailedUnits property

2015-02-18 Thread lucas . de . marchi
From: Lucas De Marchi By notifying the clients when this property is changed it's possible to allow "system health monitor" tools to get transitions like running<->degraded. This is an alternative to send changes on the SystemState property since the latter is more difficul

[systemd-devel] [PATCH] build: export symbols to integrate mainloops

2015-01-21 Thread Lucas De Marchi
--- src/libsystemd/libsystemd.sym.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libsystemd/libsystemd.sym.m4 b/src/libsystemd/libsystemd.sym.m4 index 19a49f4..41418b9 100644 --- a/src/libsystemd/libsystemd.sym.m4 +++ b/src/libsystemd/libsystemd.sym.m4 @@ -382,6 +382,9 @@ global:

Re: [systemd-devel] Improving module loading

2014-12-24 Thread Lucas De Marchi
oad.d. Take a look in the output of 'kmod static-nodes'. All these dead nodes will be created by systemd during startup, but the module will only be loaded by the kernel when some one actually try to use them. $ ls /dev/loop-control /dev/loop-control $ lsmod | grep loop $ t

Re: [systemd-devel] Improving module loading

2014-12-22 Thread Lucas De Marchi
#x27;t this be used instead of filling modules-load-d with lots of entries? I really miss numbers here and more information on which modules are taking long because they are serialized. -- Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [RFC PATCH 1/2] Replace mkostemp+unlink with open(O_TMPFILE)

2014-01-27 Thread Lucas De Marchi
il; > } > -unlink(entry_array_path); > > #ifdef HAVE_GCRYPT > if ((le32toh(f->header->compatible_flags) & > ~HEADER_COMPATIBLE_SEALED) != 0) > diff --git a/src/shared/util.c b/src/shared/util.c > index 5551714..34b3d96 100644 > --- a/src/shared/util.c > +++ b/

Re: [systemd-devel] [systemd-commits] 4 commits - catalog/systemd-fr.catalog catalog/systemd-ru.catalog configure.ac Makefile.am po/.gitignore po/LINGUAS po/ru.po

2013-12-02 Thread Lucas De Marchi
epending on the build options due to the check in assert.h (in Arch i'm getting the C11 behavior): #if defined __USE_ISOC11 && !defined __cplusplus /* Static assertion. Requires support in the compiler. */ # undef static_assert # define static_assert _Static_as

Re: [systemd-devel] [RFC 02/12] ring: add basic ring-buffer helper

2013-11-27 Thread Lucas De Marchi
buf); > +r->buf = buf; > +r->size = nsize; > + > +return 0; > +} > + > +/* Compute next higher power-of-2 of @v. Returns 4096 in case v is 0. */ > +static size_t ring_pow2(size_t v) { > +size_t i; > + > +if (!v) &g

Re: [systemd-devel] [PATCH] libudev: enumerate: fix NULL-deref for subsystem-matches

2013-08-30 Thread Lucas De Marchi
I've seen this syntax before where the value between ? and : is > inherited from the test itself... nice! this is an extension: http://gcc.gnu.org/onlinedocs/gcc/Conditionals.html As far as I know it's supported both by clang and gcc Lucas De Marchi __

[systemd-devel] [ANNOUNCE] kmod 15

2013-08-22 Thread Lucas De Marchi
o the library is kind of an workaround for people doing initrd needing their tools to be statically linked. As usual, shortlog is below. Cheers Lucas De Marchi --- Jan Engelhardt (1): depmod: add missing "else" clause Lucas De Marchi (15): tools: Do not link dynamical

Re: [systemd-devel] [PATCH] travis: Add a travis.yml for doing CI after commits

2013-07-17 Thread Lucas De Marchi
g step > forward. And then we could work on enabling more tests as things go. > Talking about kmod and travis-ci. In kmod we are using it. Pretty cool, with an IRC bot integration. I only wish there were more options of distributions. Right now it's only Ubuntu 12.04 32 bits Lucas De M

Re: [systemd-devel] kmod-static-nodes.service doesn't care about udev?

2013-07-14 Thread Lucas De Marchi
g having to invoke > mkdir for a dir in /run exlicitly when prepping for a tool that, well, > is mostly concerned with creating dirs in /run. I'd rather prefer to > hide that fact... ;-) I agree. We are adding it to kmod so version 15 will create the parent dirs and this ExecStartPre wil

[systemd-devel] [ANNOUNCE] kmod 14

2013-07-03 Thread Lucas De Marchi
s to everyone involved in this release. Shortlog is below. Cheers Lucas De Marchi --- Chengwei Yang (2): Several minor fixes for documentation Add document for exported enums Jan Luebbe (1): libkmod: Avoid calling syscall() with -1 Johannes Berg (1): modprobe: don

Re: [systemd-devel] systemd fails to build with static kmod library

2013-06-03 Thread Lucas De Marchi
ocalize-hidden) 3) Extract the .o objects (ar -x) and relink them into a single .o (ld -r). Then turn it into a .a using libtool --static If you integrate (2) or (3) nicely in the build system I think it could be acceptable upstream. Another option is... while building systemd, you

Re: [systemd-devel] 2013 Plumber's CFP: Fastboot

2013-05-15 Thread Lucas De Marchi
e's also this MC we proposed: > > http://wiki.linuxplumbersconf.org/2013:boot_and_core_os > > which sounds pretty close to fastboot? > What if we merge the proposals? John, are you ok with proposing (some of) these topics in the "Boot and Core OS" track? I could help with the module-related part, too. Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v3] tools: add static-nodes tool

2013-04-16 Thread Lucas De Marchi
, min); > > Maybe even add an array with output name and function pointer pairs, so > that we could get a list of available formats using --format=?. For > consistency, --format=human should also work. Just seems nicer to me, in > case someone actually plans to extend this later. > Agree. Otherwise looks good. Kay, what's your opinion regarding this command? Is this sufficient to drop CAP_MKNOD from udev? Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] tools: add static-nodes tool

2013-04-15 Thread Lucas De Marchi
> +ret = EXIT_FAILURE; > +goto finish; > +} > +} > + > + if (argc < 2) { > +help(); > +ret = EXIT_FAILURE; > +goto finish; > +} > + &

Re: [systemd-devel] [RFC/PATCH] Use initalization instead of explicit zeroing

2013-04-05 Thread Lucas De Marchi
this definitely appears worthwile! (It makes things > more readable even...) > >> struct sock_filter *f; >> -struct sock_fprog prog; >> +struct sock_fprog prog = {}; > > I wonder if we should have a macro for this... {} looks so ugly... or > maybe not... it doesn't when you get used to it ;-) Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] pyload.service

2012-11-05 Thread Lucas De Marchi
er.targe typo: multi-user.target I just installed it here and tested it works. I didn't really use it, though Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

2012-07-18 Thread Lucas De Marchi
y doing that. > Sounds fine to me to try with all the internal stuff, but not the > libs. I'd like to see this experiment, too. I'll probably do that to kmod and see what happens. Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] setting up to allow separate udev and systemd builds

2012-06-14 Thread Lucas De Marchi
Hi William, On Tue, Jun 12, 2012 at 2:52 PM, William Hubbs wrote: > All, > > on source-based distros like gentoo or lfs, and on distros that do not Don't you have the ability to split the built package in gentoo? Lucas De Marchi ___

[systemd-devel] [PATCH 2/2] udev: use container_of() macro

2012-04-26 Thread Lucas De Marchi
--- src/libudev/libudev-list.c |8 ++-- src/udev/collect/collect.c |8 ++-- src/udev/udevd.c | 16 3 files changed, 8 insertions(+), 24 deletions(-) diff --git a/src/libudev/libudev-list.c b/src/libudev/libudev-list.c index 1fe46f3..aec334b 100644 ---

[systemd-devel] [PATCH 1/2] util: introduce container_of() macro

2012-04-26 Thread Lucas De Marchi
This macro comes from kernel and it's useful for unwrapping structs inside another one. The generated code is actually the same to the one where this logic is used in udev, but using this macro is much cleaner and less error prone. --- src/shared/util.h | 11 +++ 1 file changed, 11 inser

[systemd-devel] [PATCH 2/2] build-sys: separate ldflags from cflags

2012-03-19 Thread Lucas De Marchi
--- Makefile.am |1 + configure.ac |7 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8f736d0..0829f06 100644 --- a/Makefile.am +++ b/Makefile.am @@ -107,6 +107,7 @@ AM_CPPFLAGS = \ -I $(top_srcdir)/src/systemd AM_CFLAGS =

[systemd-devel] [PATCH 1/2] build-sys: do not set CFLAGS directly

2012-03-19 Thread Lucas De Marchi
(non-typed) symbols. dnl Copyright (c) 2006-2008 Diego Pettenò dnl Copyright (c) 2006-2008 xine project +dnl Copyright (c) 2012 Lucas De Marchi dnl dnl This program is free software; you can redistribute it and/or modify dnl it under the terms of the GNU General Public License as published

Re: [systemd-devel] [PATCH] man/daemon: Use pkg-config as default for --with-systemdsystemunitdir

2011-06-27 Thread Lucas De Marchi
systemsystemunitdir" option, it will autodetect with pkg-config. Am I missing something? I don't see a reason to change this behavior and lots of packages already use this. E.g., packages may use "--with-systemdsystemunitdir=" in 'make

[systemd-devel] [PATCH] build-sys: make less noise when checking file

2011-01-26 Thread Lucas De Marchi
There's already a condition that gives a warning if user is cross-compiling an relying on files from the build system. AC_CHECK_FILE macro only tests for file in the build system. Hence use a simple 'test -f' that does the same job, without the warning. --- configure.ac | 14 +++--- 1 fi

[systemd-devel] [PATCH] build-sys: fix AC_COMPILE_IFELSE tests

2011-01-26 Thread Lucas De Marchi
This removes some warnings when bootstrapping. The warnings were introduced in autoconf 2.68. Reference: http://www.flameeyes.eu/autotools-mythbuster/forwardporting/autoconf.html The following code AC_COMPILE_IFELSE([ ], ...) is changed to AC_CO

Re: [systemd-devel] [PATCH] Don't require vala if gtk is disabled

2010-11-16 Thread Lucas De Marchi
On Tue, Nov 16, 2010 at 8:04 PM, Lennart Poettering wrote: > On Tue, 16.11.10 11:47, Lucas De Marchi (lucas.demar...@profusion.mobi) wrote: > > Vala is actually not required for building the tarball, since the > tarball includes generated code. However, we do require people who buil

[systemd-devel] [PATCH] Don't require vala if gtk is disabled

2010-11-16 Thread Lucas De Marchi
--- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b37e994..56f9413 100644 --- a/configure.ac +++ b/configure.ac @@ -259,10 +259,10 @@ if test "$have_gtk" = "yes"; then PKG_CHECK_MODULES(LIBNOTIFY, [ libnotify >

Re: [systemd-devel] Log of all processes

2010-10-25 Thread Lucas De Marchi
emd-readahead-collect.service > systemd-readahead-replay.service Is that still supported given kernel 2.6.36 came with fanotify disabled (http://lwn.net/Articles/409681/) ? regards, Lucas De Marchi ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] vconsole-setup: fix path on Arch

2010-10-07 Thread Lucas De Marchi
On Thu, Oct 7, 2010 at 2:19 PM, Lennart Poettering wrote: > On Thu, 07.10.10 14:00, Lucas De Marchi (lucas.demar...@profusion.mobi) wrote: > >> Arch uses the same paths and default font of gentoo. Previously, >> systemd-vconsole-setup was failing with the following message: >

[systemd-devel] [PATCH] vconsole-setup: fix path on Arch

2010-10-07 Thread Lucas De Marchi
Arch uses the same paths and default font of gentoo. Previously, systemd-vconsole-setup was failing with the following message: systemd-vconsole-setup[59]: /bin/setfont failed with error code 1. --- Makefile.am |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Makefil

Re: [systemd-devel] Forgot break in switch? (+ PATCH)

2010-10-04 Thread Lucas De Marchi
fixes an assertion fail for me. systemd hits the > assertion in the default branch of the switch when I have a failing timer > unit and call daemon-reload. I have some failing units too and with this patch systemd is working for me again. Lucas De Marchi __