Re: [systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-08-14 Thread Ivan Shapovalov
On Thursday 14 August 2014 at 01:55:26, Lennart Poettering wrote: On Thu, 31.07.14 16:55, Ivan Shapovalov (intelfx...@gmail.com) wrote: Hello all, I'm trying to start from an udev rule a templated systemd unit, whose instance should be a properly escaped device node path (so

[systemd-devel] [PATCH] socket: add support for TCP fast Open

2014-08-14 Thread Susant Sahani
TCP Fast Open (TFO) speeds up the opening of successiveTCP) connections between two endpoints.It works by using a TFO cookie in the initial SYN packet to authenticate a previously connected client. It starts sending data to the client before the receipt of the final ACK packet of the three way

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Michael Marineau
On Aug 14, 2014 1:21 AM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: Patch looks pretty good, though I'd really prefer if we could do the UseDomain= thing as discussed in the other mail, and not propagate

Re: [systemd-devel] [PATCH 2/3] socket: Add support for TCP Fast Open

2014-08-14 Thread Susant Sahani
Hi Lennart, On 08/14/2014 06:16 AM, Lennart Poettering wrote: On Tue, 29.07.14 23:10, Susant Sahani (sus...@redhat.com) wrote: Looks good. Wanted to apply. But this requires your previous patch, so please rebase on a new version of that! Thanks! Since this patch does not depend on the other

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread Marc Haber
On Wed, Aug 13, 2014 at 06:42:13PM +0200, Lennart Poettering wrote: On Wed, 13.08.14 16:43, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: did I reach the wrong mailing list? Is there better forum to get systemd working with something resembling my current setup? No, this is the right

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 09:20, Ivan Shapovalov (intelfx...@gmail.com) wrote: The udev rule should be possible (provided that udevd does not need rootfs remounted read-write -- I'd like to preserve some decency towards initrd-less systems), but udev is a framework for handling events, whereas we don't

Re: [systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 10:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: The only thing: PROGRAM=..., ENV{SYSTEMD_WANTS}+=...%c... idiom seems a pretty ugly way to invoke systemd-escape. This looks like a pretty common thing to do; shouldn't there be a shorthand or something? (just a suggestion)

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 02:21, Lennart Poettering (lenn...@poettering.net) wrote: On Mon, 04.08.14 10:05, Michael Marineau (michael.marin...@coreos.com) wrote: Patch looks pretty good, though I'd really prefer if we could do the UseDomain= thing as discussed in the other mail, and not propagate

[systemd-devel] [PATCH] bus.h: add missing include to linux/kref.h

2014-08-14 Thread Alban Crequy
Symptoms: kdbus/bus.h:56:14: error: field ‘kref’ has incomplete type struct kref kref; Signed-off-by: Alban Crequy alban.cre...@collabora.co.uk --- bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/bus.h b/bus.h index a5832b8..c7ce2fa 100644 --- a/bus.h +++ b/bus.h @@ -16,6 +16,7 @@

Re: [systemd-devel] [PATCH 1/3] socket: Add Support for TCP keep alive variables

2014-08-14 Thread Susant Sahani
On 08/14/2014 06:13 AM, Lennart Poettering wrote: On Tue, 29.07.14 23:10, Susant Sahani (sus...@redhat.com) wrote: tcp_keepalive_time: The number of seconds a connection needs to be idle before TCP begins sending out keep-alive probes. Looks pretty OK. ---

[systemd-devel] [PATCH] [RFC] [WIP] [kdbus] Attempt to recursively pass fd

2014-08-14 Thread Alban Crequy
Before Linux commit 25888e (from 2.6.37-rc4, Nov 2010), fd-passing on Unix sockets could recursively be stacked, allowing a process to exhaust the open files limit (/proc/sys/fs/file-max) on the system without restriction from ulimit -n. This DoS on Unix sockets was fixed by commit: commit

Re: [systemd-devel] [PATCH] socket: add support for TCP fast Open

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 14:31, Susant Sahani (sus...@redhat.com) wrote: Thanks! Applied! TCP Fast Open (TFO) speeds up the opening of successiveTCP) connections between two endpoints.It works by using a TFO cookie in the initial SYN packet to authenticate a previously connected client. It starts

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Tom Gundersen
On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp option 15 and 119 to the list of domains for the interface. And sd_network_get_link_domains() should then return a single list, of deduplicated

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 13:27, Tom Gundersen (t...@jklm.no) wrote: On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp option 15 and 119 to the list of domains for the interface. And

Re: [systemd-devel] [PATCH] bus.h: add missing include to linux/kref.h

2014-08-14 Thread Daniel Mack
On 08/14/2014 01:13 PM, Alban Crequy wrote: Symptoms: kdbus/bus.h:56:14: error: field ‘kref’ has incomplete type struct kref kref; Signed-off-by: Alban Crequy alban.cre...@collabora.co.uk Strange I don't see this error here. Anyway, applied. Thanks! --- bus.h | 1 + 1 file

Re: [systemd-devel] networkd losing dhcp lease with dracut / nfs root

2014-08-14 Thread Tom Gundersen
On Tue, Jul 15, 2014 at 3:50 AM, Rich Freeman r-syst...@thefreemanclan.net wrote: not update valid_lft A minute later it again renews DHCP, but also does not update valid_lft. 51 seconds later it again renews DHCP, and this time it updates valid_lft. So, the interface never drops, but it

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Lennart Poettering
On Sun, 27.07.14 19:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Sat, Jul 26, 2014 at 02:46:05PM +0200, Reindl Harald wrote: after that happend a few minutes ago systemd on F19: https://bugzilla.redhat.com/show_bug.cgi?id=1123557 since the sleep 1 was enough over

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Lennart Poettering
On Sun, 27.07.14 20:04, Reindl Harald (h.rei...@thelounge.net) wrote: but that still don't explain why ExecStopPost=/sur/bin/true or whatever ExecStopPost solves that and if it is not supported why systemctl don't return after the one and only process exited Well, this is a misunderstanding

Re: [systemd-devel] [PATCH] resolved: re-add support for getting local domain from DHCP

2014-08-14 Thread Tom Gundersen
On Thu, Aug 14, 2014 at 1:47 PM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 14.08.14 13:27, Tom Gundersen (t...@jklm.no) wrote: On Thu, Aug 14, 2014 at 1:11 PM, Lennart Poettering lenn...@poettering.net wrote: UseDomain= should have the effect of adding the domains from dhcp

[systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Vlad Orlov
Hi, I have Debian Testing running with some additional packages from Linux Mint which are installed for testing purposes. One of them is mintsystem, which causes an ordering cycle during the boot: авг 14 13:51:06 jessica systemd[1]: Found ordering cycle on basic.target/start авг 14 13:51:06

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Reindl Harald
Am 14.08.2014 um 14:22 schrieb Lennart Poettering: On Sun, 27.07.14 19:53, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Sat, Jul 26, 2014 at 02:46:05PM +0200, Reindl Harald wrote: after that happend a few minutes ago systemd on F19:

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Reindl Harald
Am 14.08.2014 um 14:24 schrieb Lennart Poettering: On Sun, 27.07.14 20:04, Reindl Harald (h.rei...@thelounge.net) wrote: but that still don't explain why ExecStopPost=/usr/bin/true or whatever ExecStopPost solves that and if it is not supported why systemctl don't return after the one and

Re: [systemd-devel] Bug#758050: udev: ID_VENDOR_FROM_DATABASE, ID_MODEL_FROM_DATABASE for unrecognised USB device are taken from USB hub

2014-08-14 Thread Simon McVittie
I recently opened this Debian bug, for which I attach a patch that seems to work. Bug report quoted in full below. I would appreciate udev maintainers' opinions on whether this is likely to break non-USB devices, or whether there is a better way to do it. S Steps to reproduce: plug in a

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 16:27, Vlad Orlov (mon...@inbox.ru) wrote: Hi, I have Debian Testing running with some additional packages from Linux Mint which are installed for testing purposes. One of them is mintsystem, which causes an ordering cycle during the boot: авг 14 13:51:06 jessica

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Simon McVittie
On 14/08/14 13:27, Vlad Orlov wrote: ### BEGIN INIT INFO # Provides: mintsystem # Required-Start:$local_fs $syslog $remote_fs dbus # Required-Stop: $local_fs $syslog $remote_fs # Default-Start: S # Default-Stop: ### END INIT INFO As Lennart said, this is

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Simon McVittie
On 14/08/14 14:31, Simon McVittie wrote: Default-Start: S means basic-target.target depends on mintsystem.service, which depends on dbus.service, which does not have DefaultDependencies=no, so it implicitly depends on sysinit.target, so you lose. Sorry, that's not quite right. Default-Start:

Re: [systemd-devel] [PATCH] socket: add support for TCP fast Open

2014-08-14 Thread Dave Reisner
On Thu, Aug 14, 2014 at 02:31:47PM +0530, Susant Sahani wrote: TCP Fast Open (TFO) speeds up the opening of successiveTCP) connections between two endpoints.It works by using a TFO cookie in the initial SYN packet to authenticate a previously connected client. It starts sending data to the

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 14:31, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: In Debian, support for sysvinit scripts in rcS was patched back in to avoid breaking existing software, because it's unlikely that all of the packages listed in

Re: [systemd-devel] [PATCH] Removed PPC 32 bit LE architecture

2014-08-14 Thread Samuli Suominen
On 11/08/14 17:14, Lennart Poettering wrote: On Mon, 11.08.14 15:57, Lennart Poettering (lenn...@poettering.net) wrote: On Fri, 08.08.14 17:00, har...@redhat.com (har...@redhat.com) wrote: From: Harald Hoyer har...@redhat.com According to Brent Baude bba...@redhat.com, who provided the

Re: [systemd-devel] [PATCH] socket: add support for TCP fast Open

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 09:54, Dave Reisner (d...@falconindy.com) wrote: On Thu, Aug 14, 2014 at 02:31:47PM +0530, Susant Sahani wrote: TCP Fast Open (TFO) speeds up the opening of successiveTCP) connections between two endpoints.It works by using a TFO cookie in the initial SYN packet to

Re: [systemd-devel] networkd Promiscuous mode

2014-08-14 Thread Lennart Poettering
On Wed, 13.08.14 18:53, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Lennart, There seems to be no way in systemd-networkd to put a link in Promiscuous mode. This is needed to make macvlan work correctly (Otherwise it receives no traffic with its mac address as the destination).

Re: [systemd-devel] networkd Promiscuous mode

2014-08-14 Thread Tom Gundersen
On Thu, Aug 14, 2014 at 3:53 AM, Marcel Holtmann mar...@holtmann.org wrote: Hi Lennart, There seems to be no way in systemd-networkd to put a link in Promiscuous mode. This is needed to make macvlan work correctly (Otherwise it receives no traffic with its mac address as the destination). If

Re: [systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-08-14 Thread Harald Hoyer
On 14.08.2014 13:00, Lennart Poettering wrote: On Thu, 14.08.14 10:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: The only thing: PROGRAM=..., ENV{SYSTEMD_WANTS}+=...%c... idiom seems a pretty ugly way to invoke systemd-escape. This looks like a pretty common thing to do; shouldn't there

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Aug 14, 2014 at 02:31:00PM +0100, Simon McVittie wrote: On 14/08/14 13:27, Vlad Orlov wrote: ### BEGIN INIT INFO # Provides: mintsystem # Required-Start:$local_fs $syslog $remote_fs dbus # Required-Stop: $local_fs $syslog $remote_fs # Default-Start: S #

Re: [systemd-devel] eye of cylon / timeout timer is cut off

2014-08-14 Thread Lennart Poettering
On Sun, 27.07.14 21:47, Michael Biebl (mbi...@gmail.com) wrote: Hi, as you can see at the attached diff, there is a small issue with the timer that is disabled, when systemd is waiting for a job. In this case, the job is already running 1min 17secs, but only 17 secs is displayed, the

Re: [systemd-devel] Reason for IgnoreSIGPIPE=true by default

2014-08-14 Thread Lennart Poettering
On Fri, 25.07.14 20:22, Ansgar Burchardt (ans...@debian.org) wrote: Heya! I think I replied to this since on IRC, but just for the sake of completeness of the ML archives: I'm wondering what the reason for IgnoreSIGPIPE to default to true is. The documentation just states that SIGPIPE is

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Simon McVittie
On 14/08/14 16:04, Zbigniew Jędrzejewski-Szmek wrote: Actually, most of them probably don't need to run at all: Many of the ones you quoted indeed don't make sense with systemd and are either explicitly masked by a symlink to /dev/null, or have a corresponding native systemd service that

Re: [systemd-devel] Pairing udev's SYSTEMD_WANTS and systemd's templated units

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 17:10, Harald Hoyer (harald.ho...@gmail.com) wrote: On 14.08.2014 13:00, Lennart Poettering wrote: On Thu, 14.08.14 10:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: The only thing: PROGRAM=..., ENV{SYSTEMD_WANTS}+=...%c... idiom seems a pretty ugly way to invoke

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 17:04, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: systemd: Copy rules generated while the root was ro Hmm, wut? What's that supposed to be? Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list

Re: [systemd-devel] Changing configurations with networkd

2014-08-14 Thread Lennart Poettering
On Thu, 24.07.14 10:49, Tom Gundersen (t...@jklm.no) wrote: I think there was some misunderstanding here. I don't want to keep the lease across reboots. I don't care about that. I think networkd should remember the lease when restarting networkd only and not send a new dhcp discover.

Re: [systemd-devel] Changing configurations with networkd

2014-08-14 Thread Lennart Poettering
On Fri, 25.07.14 09:48, Michael Olbrich (m.olbr...@pengutronix.de) wrote: What I'm _not_ seeing, and what usually comes when anything else changes in the network configuration is: systemd-timesyncd[348]: Network configuration changed, trying to establish connection. I would expect, that

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Simon McVittie
On 14/08/14 16:29, Lennart Poettering wrote: On Thu, 14.08.14 17:04, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: systemd: Copy rules generated while the root was ro Hmm, wut? What's that supposed to be? I think it's glue for running udev when pid 1 != systemd and there was no

Re: [systemd-devel] sysusers and login.defs checks

2014-08-14 Thread Lennart Poettering
On Thu, 24.07.14 13:32, Colin Guthrie (gm...@colin.guthr.ie) wrote: I guess my main concern still remains that uid range settings for system users would now be in two places - one used by sysusers and another by adduser (I now accept your argument that the other two places are different

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 16:41, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: On 14/08/14 16:29, Lennart Poettering wrote: On Thu, 14.08.14 17:04, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: systemd: Copy rules generated while the root was ro Hmm, wut? What's that

Re: [systemd-devel] eye of cylon / timeout timer is cut off

2014-08-14 Thread Michael Biebl
2014-08-14 17:17 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sun, 27.07.14 21:47, Michael Biebl (mbi...@gmail.com) wrote: Hi, as you can see at the attached diff, there is a small issue with the timer that is disabled, when systemd is waiting for a job. In this case, the job is

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Michael Biebl
2014-08-14 17:57 GMT+02:00 Lennart Poettering lenn...@poettering.net: Hmm, Debian still generates persistent rules at boot? Yuck! Correct. We still use the old persistent network naming scheme and have not transitioned to the new scheme [1] yet. We might in the future or not. This needs further

Re: [systemd-devel] [PATCH 3/3] socket: Add support for TCP defer accept

2014-08-14 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 29, 2014 at 11:10:09PM +0530, Susant Sahani wrote: TCP_DEFER_ACCEPT Allow a listener to be awakened only when data arrives on the socket. If TCP_DEFER_ACCEPT set on a server-side listening socket, the TCP/IP stack will not to wait for the final ACK packet and not to initiate the

Re: [systemd-devel] eye of cylon / timeout timer is cut off

2014-08-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Aug 14, 2014 at 06:13:47PM +0200, Michael Biebl wrote: 2014-08-14 17:17 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sun, 27.07.14 21:47, Michael Biebl (mbi...@gmail.com) wrote: Hi, as you can see at the attached diff, there is a small issue with the timer that is

Re: [systemd-devel] eye of cylon / timeout timer is cut off

2014-08-14 Thread Michael Biebl
2014-08-14 18:36 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: It would be more useful to remove the / 1min 30s part. Maybe the cylon code could be smart enough for that. I think it's useful information to know that the timeout is 90s. An alternative could be, to simply use seconds

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Michael Biebl
2014-08-14 17:04 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: On Thu, Aug 14, 2014 at 02:31:00PM +0100, Simon McVittie wrote: On 14/08/14 13:27, Vlad Orlov wrote: ### BEGIN INIT INFO # Provides: mintsystem # Required-Start:$local_fs $syslog $remote_fs dbus #

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Dan Williams
On Wed, 2014-08-13 at 18:55 -0700, Marcel Holtmann wrote: Hi Lennart, Now that networkd can send the systems hostname to the dhcp server, I would find it useful to have an option to override the hostname that gets sent. In my use case, I would like to setup a number of macvlans

Re: [systemd-devel] [PATCH 1/2] core: do not add default dependencies to /usr mount unit

2014-08-14 Thread Lennart Poettering
On Tue, 22.07.14 00:39, Jon Severinsson (j...@severinsson.net) wrote: This makes no difference if /usr was mounted in the initrd, and brings the behaviour of legacy systems closer to those with a propper initrd. I applied this one now, as /usr is probably indeed mostly like /, and we

Re: [systemd-devel] [PATCH 2/2] units: add RequiresMountsFor=/usr/… to various systemd service files

2014-08-14 Thread Lennart Poettering
On Tue, 22.07.14 14:45, Jon Severinsson (j...@severinsson.net) wrote: At Tuesday 22 July 2014 13:01:24 Lennart Poettering wrote: I am totally not convinced this would be a good idea. You cannot fix this anyway... Think about udevd: if you start it without /usr is around, then it won't

Re: [systemd-devel] [PATCH v3] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-08-14 Thread Lennart Poettering
On Mon, 21.07.14 20:23, Timofey Titovets (nefelim...@gmail.com) wrote: Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO Hmm, the patch is line broken... But this patch only replaces one ioctl with another right? It doesn't actually

[systemd-devel] [HEADS-UP] Intent to remove readahead from systemd

2014-08-14 Thread Lennart Poettering
Heya, Since its early days systemd contained the systemd-readahead tool, whose job was to improve boot times by reading files in their order on disk, before they would actually be needed by applications. In times of SSD the benefit of systemd-readahead is much less convincing, in many case it

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Andrei Borzenkov
В Thu, 14 Aug 2014 14:24:49 +0200 Lennart Poettering lenn...@poettering.net пишет: On Sun, 27.07.14 20:04, Reindl Harald (h.rei...@thelounge.net) wrote: but that still don't explain why ExecStopPost=/sur/bin/true or whatever ExecStopPost solves that and if it is not supported why

Re: [systemd-devel] eye of cylon / timeout timer is cut off

2014-08-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Aug 14, 2014 at 06:44:03PM +0200, Michael Biebl wrote: 2014-08-14 18:36 GMT+02:00 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl: It would be more useful to remove the / 1min 30s part. Maybe the cylon code could be smart enough for that. I think it's useful information to know that

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 21:16, Andrei Borzenkov (arvidj...@gmail.com) wrote: В Thu, 14 Aug 2014 14:24:49 +0200 Lennart Poettering lenn...@poettering.net пишет: On Sun, 27.07.14 20:04, Reindl Harald (h.rei...@thelounge.net) wrote: but that still don't explain why ExecStopPost=/sur/bin/true

Re: [systemd-devel] How to get rid of this ordering cycle?

2014-08-14 Thread Marco d'Itri
On Aug 14, Lennart Poettering lenn...@poettering.net wrote: Hmm, Debian still generates persistent rules at boot? Yuck! Experience shows that it worked better than the alternatives for our users, so I think that we will just keep it around for a while, probably until most hardware will provide

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-08-14 Thread Lennart Poettering
On Tue, 22.07.14 06:29, Andrey Borzenkov (arvidj...@gmail.com) wrote: В Mon, 21 Jul 2014 18:15:37 +0300 Timofey Titovets nefelim...@gmail.com пишет: Zbyszek, i research problem and i found what in btrfs.h struct btrfs_ioctl_defrag_range_args not defined This acceptable if i add it in

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-08-14 Thread Lennart Poettering
On Mon, 21.07.14 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Mon, Jul 21, 2014 at 09:38:57AM +0300, Timofey Titovets wrote: Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG This is still not an explanation. What is the

[systemd-devel] [PATCH 1/3] socket: Add Support for TCP keep alive variables

2014-08-14 Thread Susant Sahani
The tcp keep alive variables now can be configured via conf parameter. Follwing variables are now supported by this patch. tcp_keepalive_intvl: The number of seconds between TCP keep-alive probes tcp_keepalive_probes: The maximum number of TCP keep-alive probes to send before giving up and

[systemd-devel] [PATCH 2/3] socket: Add support for TCP defer accept

2014-08-14 Thread Susant Sahani
TCP_DEFER_ACCEPT Allow a listener to be awakened only when data arrives on the socket. If TCP_DEFER_ACCEPT set on a server-side listening socket, the TCP/IP stack will not to wait for the final ACK packet and not to initiate the process until the first packet of real data has arrived. After

[systemd-devel] [PATCH 3/3] socket: add bus property for bus property NoDelay

2014-08-14 Thread Susant Sahani
Missed to add the SD_BUS_PROPERTY for no_delay. --- src/core/dbus-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/dbus-socket.c b/src/core/dbus-socket.c index cc55b8d..e9e2430 100644 --- a/src/core/dbus-socket.c +++ b/src/core/dbus-socket.c @@ -101,6 +101,7 @@ const

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Andrei Borzenkov
В Thu, 14 Aug 2014 19:24:54 +0200 Lennart Poettering lenn...@poettering.net пишет: On Thu, 14.08.14 21:16, Andrei Borzenkov (arvidj...@gmail.com) wrote: В Thu, 14 Aug 2014 14:24:49 +0200 Lennart Poettering lenn...@poettering.net пишет: On Sun, 27.07.14 20:04, Reindl Harald

Re: [systemd-devel] [PATCH v2] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
Okay, i will rebase and resend, and add warning But what i must do with message: symlink.mount failed to run 'mount' task: Too many levels of symbolic links? Just leave and add additional massage error or replace? 2014-08-14 20:31 GMT+03:00 Timofey Titovets nefelim...@gmail.com: Okay, i will

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread Lennart Poettering
On Mon, 21.07.14 10:46, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: Heya, I have read the thread (from 2012?) where those things were discussed here and I understand that I should replace my keyscript with a passwort agent. Things would then work like this: There's currently no

Re: [systemd-devel] [PATCH v2] Refuse mount on symlink

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 20:31, Timofey Titovets (nefelim...@gmail.com) wrote: Okay, i will rebase and resend, and add warning But what i must do with message: symlink.mount failed to run 'mount' task: Too many levels of symbolic links? Just leave and add additional massage error or replace? Yeah,

Re: [systemd-devel] race conditions after SIGTERM

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 21:38, Andrei Borzenkov (arvidj...@gmail.com) wrote: Which is what we do. Except when you specify ExecStop= which basically tells systemd that you want to do it instead. So there you go! Those daemons I have seen are terminated after receiving signal/command to do it.

Re: [systemd-devel] [PATCH] resolved: fix warnings

2014-08-14 Thread Lennart Poettering
On Sat, 19.07.14 10:37, Thomas H.P. Andersen (pho...@gmail.com) wrote: --- a/src/resolve/resolved-dns-scope.c +++ b/src/resolve/resolved-dns-scope.c @@ -292,7 +292,7 @@ int dns_scope_llmnr_membership(DnsScope *s, bool b) { if (s-family == AF_INET) { struct ip_mreqn

[systemd-devel] [PATCH] machine_kill(): Don't kill the unit when killing the leader

2014-08-14 Thread Eelco Dolstra
If machinectl poweroff or machinectl reboot is used on a systemd-nspawn container started with --keep-unit and --register, it should *only* send the appropriate signal to the leader PID (i.e. the container's systemd process). It shouldn't fall through to manager_kill_unit() to also send the signal

Re: [systemd-devel] compile with clang broken

2014-08-14 Thread Lennart Poettering
On Fri, 18.07.14 16:02, Thomas H.P. Andersen (pho...@gmail.com) wrote: 1716f6dcf54d4c181c2e2558e3d5414f54c8d9ca (resolved: add LLMNR support for looking up names) broke the build on clang. src/resolve/resolved-manager.c:553:43: error: non-const static data member must be initialized out of

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread David Herrmann
Hi On Thu, Aug 14, 2014 at 7:44 PM, Lennart Poettering lenn...@poettering.net wrote: On Mon, 21.07.14 10:46, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: Heya, I have read the thread (from 2012?) where those things were discussed here and I understand that I should replace my keyscript

Re: [systemd-devel] [PATCH] machine_kill(): Don't kill the unit when killing the leader

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 19:59, Eelco Dolstra (eelco.dols...@logicblox.com) wrote: Thanks! Applied! If machinectl poweroff or machinectl reboot is used on a systemd-nspawn container started with --keep-unit and --register, it should *only* send the appropriate signal to the leader PID (i.e. the

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread Marc Haber
Hi Lennart, thanks for your thoughts. On Thu, Aug 14, 2014 at 07:44:59PM +0200, Lennart Poettering wrote: On Mon, 21.07.14 10:46, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: (4) My PasswordAgent indicates taking responsibility by unlinking the ask.xxx file from

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread Marc Haber
Hi, On Thu, Aug 14, 2014 at 08:09:05PM +0200, David Herrmann wrote: That is, to solve your problem, I'd recommend to make systemd allow external scripts like keyscript= before placing *.ask files (or some other hookup or configuration, if scripts are not suitable for that). If systemd would

Re: [systemd-devel] Thoughts about /etc/crypttab keyscript options

2014-08-14 Thread Lennart Poettering
On Thu, 14.08.14 20:10, Marc Haber (mh+systemd-de...@zugschlus.de) wrote: Not aware of an C++ code. There's a vala one, and of course the one we ship in systemd itself in C, but c++ i cannot help you with, sorry. Is it possible to write a PasswordAgent in shell? Example code please ;)

Re: [systemd-devel] Start Up services using systemd

2014-08-14 Thread Lennart Poettering
On Mon, 21.07.14 17:26, Bharath Chandra (ellurubharat...@gmail.com) wrote: Heya, Hi, I am trying to analyze what all services that would start during boot up process statically, i.e just by looking into the unit files, without running the system. I have understood the dependecies of unit

Re: [systemd-devel] Forcing default route as the one provided by one interface

2014-08-14 Thread Lennart Poettering
On Thu, 17.07.14 15:44, Mauricio Tavares (raubvo...@gmail.com) wrote: Newbie question: if I have two interfaces (in separate networks) with each of them using DHCP, how can I specify that I want the default route to be the one being obtained by, say, interface A? I read through

Re: [systemd-devel] Warnings from recent commits

2014-08-14 Thread Lennart Poettering
On Mon, 21.07.14 16:09, Samuli Suominen (ssuomi...@gentoo.org) wrote: 4.6 is the minimum dependency as-is, for eg. _Static_assert, DISABLE_WARNING_{DECLARATION_AFTER_STATEMENT,FORMAT_NONLITERAL,MISSING_PROTOTYPES,NONNULL}, REENABLE_WARNING Just to get the udev part of the systemd tree

Re: [systemd-devel] Bug#758050: udev: ID_VENDOR_FROM_DATABASE, ID_MODEL_FROM_DATABASE for unrecognised USB device are taken from USB hub

2014-08-14 Thread Kay Sievers
On Thu, Aug 14, 2014 at 3:07 PM, Simon McVittie simon.mcvit...@collabora.co.uk wrote: I recently opened this Debian bug, for which I attach a patch that seems to work. Bug report quoted in full below. I would appreciate udev maintainers' opinions on whether this is likely to break non-USB

Re: [systemd-devel] [PATCH] resolved: fix warnings

2014-08-14 Thread Daniel Buch
I just hit this assert on my arch system with gcc 4.9, dbuch-laptop systemd-resolved[457]: Assertion 's-protocol == DNS_PROTOCOL_LLMNR' failed at src/resolve/resolved-dns-scope.c:369 2014-08-14 19:58 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 19.07.14 10:37, Thomas H.P.

Re: [systemd-devel] [PATCH v2] readahead: use BTRFS_IOC_DEFRAG_RANGE

2014-08-14 Thread Timofey Titovets
Just completed TODO: * readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO Hmm, the patch is line broken... But this patch only replaces one ioctl with another right? It doesn't actually improve anything effectively, does it? I am not really convinced

Re: [systemd-devel] [PATCH v3 2/3] cxgb4: use module_long_probe_init()

2014-08-14 Thread Luis R. Rodriguez
On Thu, Aug 14, 2014 at 09:42:49AM -0700, Casey Leedom wrote: On 08/13/2014 04:33 PM, Anish Bhatt wrote: Adding Casey who's actually incharge of this code and missing from the CC list Thanks Anish! As I mentioned to Anish, there are fundamentally two problems here in the time being

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Marcel Holtmann
Hi Dan, Now that networkd can send the systems hostname to the dhcp server, I would find it useful to have an option to override the hostname that gets sent. In my use case, I would like to setup a number of macvlans with different hostnames. Something as simple as [DHCP]

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Thomas Suckow
Typically the send-hostname thing is actually used for DNS updates, where you send the hostname to the DHCP server, which then gives you a lease and sends the hostname + IP to the DNS server, so that your machine is accessible via DNS automatically. I've never heard of it being used as a

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Dan Williams
On Thu, 2014-08-14 at 14:29 -0700, Thomas Suckow wrote: Typically the send-hostname thing is actually used for DNS updates, where you send the hostname to the DHCP server, which then gives you a lease and sends the hostname + IP to the DNS server, so that your machine is accessible via DNS

[systemd-devel] [RFC] Remove warning: var may be used uninitialized

2014-08-14 Thread Timofey Titovets
Good time of day, when i compile systemd i get ton of warning like: var may be used uninitialized in function... May be i can spend some time and create patches with fixes of that warnings? As example declare it by default to 0 or something like that. Or this is not a bug, just feature? %) --

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Thomas Suckow
It's used as a general identifier of the client in any situation, so that the server can pass back specific options. Yes, this can be done by looking at the client MAC address, but that's not sufficient in the following cases: 1) non-Ethernet hardware addresses 2) dual-stack clients using

Re: [systemd-devel] Unit to test if a domain is reachable

2014-08-14 Thread Lennart Poettering
On Thu, 17.07.14 11:37, Moviuro (movi...@gmail.com) wrote: However, everything I tried proved an utter failure: target says reached even though it doesn't even have an IP on any link; wait-online obviously didn't even check if I had a DNS whatsoever. This sounds like a shortcoming of your

Re: [systemd-devel] Socket activated SSHD service showing up as a failure when the client connection fReply-To:

2014-08-14 Thread Lennart Poettering
On Thu, 17.07.14 13:49, Roger Qiu (roger@polycademy.com) wrote: I've googled around and saw that 255 error code comes up a lot. But most resources talked about ssh not necessarily the sshd. If we ignore 255 code, is it possible we're also ignoring some other real errors, and not just the

Re: [systemd-devel] Logind error - Failed to abandon session scope: Connection reset

2014-08-14 Thread Lennart Poettering
On Thu, 17.07.14 11:49, Roger Qiu (roger@polycademy.com) wrote: Hi, (sorry for the late response) Are you saying that logind should be terminated first then dbus should be terminated second? Yes, dbus should best be stopped after logind. In what situations would their termination

[systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
Just complete TODO: * refuse mounting on symlinks I not add this TODO, but i think what it avoid potential security {and/or} bug issues v2 - v3: Rebase on latest git Add message unit: Mount on symlink path not allowed. if systemd try mounting entry from fstab on symlink, user get: $

Re: [systemd-devel] [PATCH 05/10] rules: skip 99-systemd.rules when not running systemd as init

2014-08-14 Thread Lennart Poettering
On Wed, 16.07.14 20:45, Jon Severinsson (j...@severinsson.net) wrote: onsdagen den 16 juli 2014 16:49:55 skrev Lennart Poettering: On Wed, 16.07.14 12:09, Jon Severinsson (j...@severinsson.net) wrote: From: Tollef Fog Heen tfh...@err.no If you really want to support systems without

Re: [systemd-devel] [RFC] Remove warning: var may be used uninitialized

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 01:11, Timofey Titovets (nefelim...@gmail.com) wrote: Good time of day, when i compile systemd i get ton of warning like: var may be used uninitialized in function... May be i can spend some time and create patches with fixes of that warnings? As example declare it by default

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 01:43, Timofey Titovets (nefelim...@gmail.com) wrote: +int fail_if_symlink(const char *unit, const char* where) { +assert(where); + +if (is_symlink(where) 0) { +log_struct_unit(LOG_WARNING, +unit, +

Re: [systemd-devel] [RFC] Remove warning: var may be used uninitialized

2014-08-14 Thread Timofey Titovets
I just use: ./autogen.sh ./configure make But did not matter, thanks for explanation, i think what this thread can be closed. 2014-08-15 1:57 GMT+03:00 Lennart Poettering lenn...@poettering.net: On Fri, 15.08.14 01:11, Timofey Titovets (nefelim...@gmail.com) wrote: Good time of day, when i

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Timofey Titovets
2014-08-15 2:00 GMT+03:00 Lennart Poettering lenn...@poettering.net: On Fri, 15.08.14 01:43, Timofey Titovets (nefelim...@gmail.com) wrote: +int fail_if_symlink(const char *unit, const char* where) { +assert(where); + +if (is_symlink(where) 0) { +

Re: [systemd-devel] [RFC][PATCH] socket: show full instance name in services' description

2014-08-14 Thread Lennart Poettering
On Tue, 15.07.14 16:36, Łukasz Stelmach (l.stelm...@samsung.com) wrote: Change the way socket activated services are instantiated so that the full instnace name with addresses of both parties and not only the counter make it into units' descriptions visible in the journal. Hmm, what I really

Re: [systemd-devel] [PATCH v3] Refuse mount on symlink

2014-08-14 Thread Lennart Poettering
On Fri, 15.08.14 02:17, Timofey Titovets (nefelim...@gmail.com) wrote: Applied! Thanks! Signed-off-by: Timofey nefelim...@gmail.com We don't do Signed-off-by on systemd, so I drop this when I pushed it. Thanks! Lennart -- Lennart Poettering, Red Hat

  1   2   >