[systemd-devel] [PATCH 1/2] label: move selinux label APIs to its util file

2014-08-18 Thread WaLyong Cho
And add prefix selinux_ to each APIs like smack. --- src/core/main.c | 4 +- src/core/namespace.c | 4 +- src/core/selinux-setup.c | 4 +- src/core/socket.c | 12 +- src/hostname/hostnamed.c | 2 +- src/locale/localed.c | 2 +-

[systemd-devel] [PATCH 2/2] udev: do NOT re-label smack

2014-08-18 Thread WaLyong Cho
If selinux is disabled and smack is only enabled, smack label is re-lable-ed by label_fix. To avoid, make only be labeled for selinux. --- src/udev/udev-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/udev/udev-node.c b/src/udev/udev-node.c index

[systemd-devel] Link down for systemd articles

2014-08-18 Thread Saket Sinha
Hi, I have been working on systemd recently and was referring to articles by Lennart Poettering for the same. However, I am not able to access the articles hosted at the below link - http://0pointer.de/blog/projects/ Is the server down or something ? If anyone else is facing the same issues,

Re: [systemd-devel] Link down for systemd articles

2014-08-18 Thread Dietrich
This server is Lennarts Blog and other server and yes it seems to be down... Lennart is probably fixing it soonish. Meanwhile there is still google cache: http://webcache.googleusercontent.com/search?q=cache:i83NF0kf5wkJ:0pointer.de/blog/projects+cd=1hl=enct=clnkgl=declient=firefox-a On Mo,

Re: [systemd-devel] Link down for systemd articles

2014-08-18 Thread Saket Sinha
Thanks Dietrich. That was helpful. Regards, Saket Sinha On Mon, Aug 18, 2014 at 12:52 PM, Dietrich enau...@googlemail.com wrote: This server is Lennarts Blog and other server and yes it seems to be down... Lennart is probably fixing it soonish. Meanwhile there is still google cache:

Re: [systemd-devel] Networkd fails to activate the device on boot

2014-08-18 Thread Tom Gundersen
On Sat, Aug 16, 2014 at 6:53 PM, Thomas Bächler tho...@archlinux.org wrote: Hello Tom, I am using systemd 215-4 from Arch Linux. I have the following configuration files in /etc/systemd/network: # 01-lan.network [Match] Name=enp3s0 [Network] Address=10.23.42.4/26 Gateway=10.23.42.3

[systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Philippe De Swert
Hi, Having to often use journalctl it has slowly driven me insane with the default options not matching common use cases. Attached is already a patch to start the journal at the end. Usually people check the logs when something went wrong, and don't care about what happened three weeks ago

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Ronny Chevalier
2014-08-18 13:46 GMT+02:00 Philippe De Swert philippedesw...@gmail.com: Hi, Hi, Having to often use journalctl it has slowly driven me insane with the default options not matching common use cases. Attached is already a patch to start the journal at the end. Usually people check the logs

Re: [systemd-devel] compile with clang broken

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 13:29, Daniele Nicolodi (dani...@grinta.net) wrote: On 16/08/2014 12:35, David Herrmann wrote: On Fri, Aug 15, 2014 at 5:22 PM, Daniele Nicolodi dani...@grinta.net wrote: this may be completely stupid, but if the only use case you have for CONST_MAX() is for computing

Re: [systemd-devel] [RFC] Integrate export mount command in code

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 00:25, Timofey Titovets (nefelim...@gmail.com) wrote: Good time of day, i just want to ask: Systemd depend on util-linux mount command and in code we call him, may have a sense to import and cleanup code to systemd base, and just call function in systemd, instead of using

Re: [systemd-devel] [PATCH] bus-control: Fix cgroup handling

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 13:55, Denis Kenzior (denk...@gmail.com) wrote: On systems without properly setup systemd, cg_get_root_path returns -ENOENT. This means that busctl doesn't display much information. busctl monitor also fails whenever it intercepts messages. This fix fakes creates a fake

Re: [systemd-devel] suspend-utils and systemd

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 13:48, Rodolfo García Peñas (kix) (k...@debian.org) wrote: Heya, Hi, I am new on the list. Thanks for your work with systemd. I am trying to run systemd and suspend-utils (uswsusp in Debian) and I don't know how to do it. I was checking how to include support for

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Philippe De Swert
Hi, Seems the patch has been scrubbed. Will re-send it later if there is interest to have it. Should have used git send-email I guess, but now badly inlined at the bottom of this email. Thank you for your help, but you seem to have misunderstood what I am after. On 18/08/14 15:08, Ronny

Re: [systemd-devel] [PATCH 1/2] label: move selinux label APIs to its util file

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 15:06, WaLyong Cho (walyong@samsung.com) wrote: And add prefix selinux_ to each APIs like smack. I am a bit concerned about this, as selinux_ is really the prefix the selinux libraries use for most of their newer symbols. And they have a lot of symbols that actually are

Re: [systemd-devel] PGP replacement?

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 08:35, Mauricio Tavares (raubvo...@gmail.com) wrote: So http://blog.cryptographyengineering.com/2014/08/whats-matter-with-pgp.html makes the point that pgp is old school and should be taken to the pasture to die. Like upstart and inetd I take. Is there a replacement

Re: [systemd-devel] PGP replacement?

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 15:13, Mauricio Tavares (raubvo...@gmail.com) wrote: post seem to be obvious trolling. Please do not do that. I was thinking on secure event reporting, maybe with firewalld or even earlier. I was not aware that is obviously trolling, so I do apologize and will say

Re: [systemd-devel] seat1 ACL

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 20:17, Floris (jkflo...@dds.nl) wrote: Hey, maybe I'm missing something, but a user on the second seat (seat1) does not get the right rights from logind. What version of systemd is this? Please only report bugs upstream that are about somewhat recent systemd versions. A

Re: [systemd-devel] Link down for systemd articles

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 12:45, Saket Sinha (saket.sinh...@gmail.com) wrote: Hi, I have been working on systemd recently and was referring to articles by Lennart Poettering for the same. However, I am not able to access the articles hosted at the below link - http://0pointer.de/blog/projects/

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 14:46, Philippe De Swert (philippedesw...@gmail.com) wrote: Hi, Having to often use journalctl it has slowly driven me insane with the default options not matching common use cases. Attached is already a patch to start the journal at the end. Usually people check the

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 16:02, Philippe De Swert (philippedesw...@gmail.com) wrote: The point is that I think that -a should be default. I can't think of any reason to have truncated and mangled logs by default. As it too often happens that you forget to add the flag as I just explained, you

Re: [systemd-devel] [PATCH 2/2] tmpfiles: explicitly check for existing files

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 09:45, Michael Olbrich (m.olbr...@pengutronix.de) wrote: On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. Hmm, what precisely fails with EROFS? if there's an existing directory on some read-only fs, and we issue mkdir() on it,

Re: [systemd-devel] [PATCH 1/2] label: move selinux label APIs to its util file

2014-08-18 Thread WaLyong Cho
On 08/18/2014 10:09 PM, Lennart Poettering wrote: On Mon, 18.08.14 15:06, WaLyong Cho (walyong@samsung.com) wrote: And add prefix selinux_ to each APIs like smack. I am a bit concerned about this, as selinux_ is really the prefix the selinux libraries use for most of their newer

Re: [systemd-devel] Build errors with lto and compat-libs

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pengutronix.de) wrote: Hi, With --enable-compat-libs building fails like this: CCLD libsystemd-journal.la [...] /tmp/ccISOiYU.ltrans1.ltrans.o: In function `sd_journal_process': ccISOiYU.ltrans1.o:(.text+0x0): multiple definition

Re: [systemd-devel] [PATCH] bootchart: use NSEC_PER_SEC

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: --- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..d838a53 100644 --- a/src/bootchart/store.c +++

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: What's the rationale here? I think it makes a lot of sense to output an error if people drop non-executable files in such a directory... --- src/shared/util.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-18 Thread Lennart Poettering
On Fri, 15.08.14 15:35, Ivan Shapovalov (intelfx...@gmail.com) wrote: That should be enough. (You don't need to individually order the systemd-fsck@.service instances for the other devices after your service, since they are already ordered after systemd-fsck-root.service, and you order

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-18 Thread Ivan Shapovalov
On Monday 18 August 2014 at 15:57:25, Lennart Poettering wrote: On Fri, 15.08.14 15:35, Ivan Shapovalov (intelfx...@gmail.com) wrote: That should be enough. (You don't need to individually order the systemd-fsck@.service instances for the other devices after your service, since they

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-18 Thread Lennart Poettering
On Fri, 15.08.14 14:16, Marcel Holtmann (mar...@holtmann.org) wrote: Hi Daniel, To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann

Re: [systemd-devel] [PATCH] core: collapse JOB_RELOAD on an inactive unit into JOB_NOP

2014-08-18 Thread Lennart Poettering
On Fri, 15.08.14 21:10, Michael Biebl (mbi...@gmail.com) wrote: 2014-08-15 12:50 GMT+02:00 Lennart Poettering lenn...@poettering.net: I think most of the confusion here comes from the fact that sysv service restarts don't care about ordering at all, really, and we do. But the answer to

Re: [systemd-devel] seat1 ACL

2014-08-18 Thread Floris
Op Mon, 18 Aug 2014 15:14:31 +0200 schreef Lennart Poettering lenn...@poettering.net: On Sun, 17.08.14 20:17, Floris (jkflo...@dds.nl) wrote: Hey, maybe I'm missing something, but a user on the second seat (seat1) does not get the right rights from logind. What version of systemd is

Re: [systemd-devel] seat1 ACL

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 16:05, Floris (jkflo...@dds.nl) wrote: Op Mon, 18 Aug 2014 15:14:31 +0200 schreef Lennart Poettering lenn...@poettering.net: On Sun, 17.08.14 20:17, Floris (jkflo...@dds.nl) wrote: Hey, maybe I'm missing something, but a user on the second seat (seat1) does not get

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-18 Thread Marcel Holtmann
Hi Lennart, To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Philippe De Swert
Hi, Thanks for answering. On 18/08/14 16:27, Lennart Poettering wrote: On Mon, 18.08.14 14:46, Philippe De Swert (philippedesw...@gmail.com) wrote: Well, its more complex than that. I know that a lot of people do journalctl -b more often than journalctl -e. I really don#t want to be in the

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 17:19, Philippe De Swert (philippedesw...@gmail.com) wrote: Moreover, journalctl is frequently now used in scripts, we cannot change the defaults really now, that would break all scripts. journalctl is API now. I could argue that most people who use -b might not know

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Aug 18, 2014 at 04:42:52PM +0200, Lennart Poettering wrote: On Mon, 18.08.14 17:19, Philippe De Swert (philippedesw...@gmail.com) wrote: Moreover, journalctl is frequently now used in scripts, we cannot change the defaults really now, that would break all scripts. journalctl is

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-18 Thread David Herrmann
Hi On Mon, Aug 18, 2014 at 4:15 PM, Marcel Holtmann mar...@holtmann.org wrote: Hi Lennart, To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann

Re: [systemd-devel] [PATCH] core: collapse JOB_RELOAD on an inactive unit into JOB_NOP

2014-08-18 Thread Colin Guthrie
Lennart Poettering wrote on 18/08/14 15:05: On Fri, 15.08.14 21:10, Michael Biebl (mbi...@gmail.com) wrote: 2014-08-15 12:50 GMT+02:00 Lennart Poettering lenn...@poettering.net: I think most of the confusion here comes from the fact that sysv service restarts don't care about ordering at

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-18 Thread Daniel Mack
On 08/18/2014 04:02 PM, Lennart Poettering wrote: On Fri, 15.08.14 14:16, Marcel Holtmann (mar...@holtmann.org) wrote: Blindly sending messages is never a good idea. You want to poll for POLLOUT first. This does not make a big difference for current kernel, but it allows future extensions

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Andrei Borzenkov
В Mon, 18 Aug 2014 16:42:52 +0200 Lennart Poettering lenn...@poettering.net пишет: I am pretty sure doing the auto-paging thing (the same way as git, and others do it) improves end-user experience for most people. I mean, I think having arrow keys is the common case. Not having them is the

Re: [systemd-devel] Link down for systemd articles

2014-08-18 Thread Colin Guthrie
Lennart Poettering wrote on 18/08/14 14:19: On Mon, 18.08.14 12:45, Saket Sinha (saket.sinh...@gmail.com) wrote: Hi, I have been working on systemd recently and was referring to articles by Lennart Poettering for the same. However, I am not able to access the articles hosted at the below

Re: [systemd-devel] Work on adding polkit support to systemd1

2014-08-18 Thread Lennart Poettering
On Fri, 15.08.14 19:28, Stef Walter (st...@redhat.com) wrote: On 15.08.2014 18:56, Lennart Poettering wrote: On Fri, 15.08.14 18:25, Stef Walter (st...@redhat.com) wrote: On 13.08.2014 20:27, Lennart Poettering wrote: On Wed, 06.08.14 13:23, Stef Walter (st...@redhat.com) wrote:

Re: [systemd-devel] [PATCH] man: fix typo

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: Thanks! Applied! --- man/systemd-firstboot.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-firstboot.xml b/man/systemd-firstboot.xml index 42fd753..c3fe0ed 100644 ---

Re: [systemd-devel] [PATCHv2 1/2] tmpfiles: only execute chmod()/chown() when needed

2014-08-18 Thread Lennart Poettering
On Sun, 17.08.14 09:45, Michael Olbrich (m.olbr...@pengutronix.de) wrote: This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system Applied! Thanks! The original code checked for 'stat() = 0'. Any

Re: [systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 18:00, Ivan Shapovalov (intelfx...@gmail.com) wrote: On Monday 18 August 2014 at 15:57:25, Lennart Poettering wrote: On Fri, 15.08.14 15:35, Ivan Shapovalov (intelfx...@gmail.com) wrote: That should be enough. (You don't need to individually order the

Re: [systemd-devel] [PATCH 1/2] label: move selinux label APIs to its util file

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 22:40, WaLyong Cho (walyong@samsung.com) wrote: On 08/18/2014 10:09 PM, Lennart Poettering wrote: On Mon, 18.08.14 15:06, WaLyong Cho (walyong@samsung.com) wrote: And add prefix selinux_ to each APIs like smack. I am a bit concerned about this, as selinux_

Re: [systemd-devel] [PATCH 8/8] tests: add missing entry to test-tables

2014-08-18 Thread Lennart Poettering
On Sat, 16.08.14 14:19, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: All 8 applied! Thanks! --- src/test/test-tables.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test-tables.c b/src/test/test-tables.c index cb9185e..88e7d10 100644 --- a/src/test/test-tables.c +++

Re: [systemd-devel] Networkd fails to activate the device on boot

2014-08-18 Thread Thomas Bächler
Am 18.08.2014 um 12:41 schrieb Tom Gundersen: 1) The enp3s0 interface does not activate on boot. I need to restart networkd manually to make it work. Hm, that is decidedly uncool. It seems we are not aware of the link. Could you try with Environment=SYSTEMD_LOG_LEVEL=debug in your service

[systemd-devel] Impossible to enable instantiated symlink (foo@bar)

2014-08-18 Thread Andrei Borzenkov
If foo@bar.service symlink is present, it is impossible to enable it: bor@opensuse:~ ll /run/systemd/system итого 8 lrwxrwxrwx 1 root root 32 авг 18 21:06 foo@bar.service - /run/systemd/system/foo@.service -rwxr-xr-x 1 root root 1032 авг 18 21:06 foo@.service bor@opensuse:~ sudo systemctl

Re: [systemd-devel] Impossible to enable instantiated symlink (foo@bar)

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 21:10, Andrei Borzenkov (arvidj...@gmail.com) wrote: If foo@bar.service symlink is present, it is impossible to enable it: bor@opensuse:~ ll /run/systemd/system итого 8 lrwxrwxrwx 1 root root 32 авг 18 21:06 foo@bar.service - /run/systemd/system/foo@.service -rwxr-xr-x

Re: [systemd-devel] Networkd fails to activate the device on boot

2014-08-18 Thread Tom Gundersen
On Mon, Aug 18, 2014 at 7:02 PM, Thomas Bächler tho...@archlinux.org wrote: Am 18.08.2014 um 12:41 schrieb Tom Gundersen: 1) The enp3s0 interface does not activate on boot. I need to restart networkd manually to make it work. Hm, that is decidedly uncool. It seems we are not aware of the

Re: [systemd-devel] Impossible to enable instantiated symlink (foo@bar)

2014-08-18 Thread Andrei Borzenkov
В Mon, 18 Aug 2014 19:22:01 +0200 Lennart Poettering lenn...@poettering.net пишет: On Mon, 18.08.14 21:10, Andrei Borzenkov (arvidj...@gmail.com) wrote: If foo@bar.service symlink is present, it is impossible to enable it: bor@opensuse:~ ll /run/systemd/system итого 8 lrwxrwxrwx 1

Re: [systemd-devel] Implementing resume from hibernation as a systemd unit file

2014-08-18 Thread Ivan Shapovalov
On Monday 18 August 2014 at 18:40:59, Lennart Poettering wrote: On Mon, 18.08.14 18:00, Ivan Shapovalov (intelfx...@gmail.com) wrote: On Monday 18 August 2014 at 15:57:25, Lennart Poettering wrote: On Fri, 15.08.14 15:35, Ivan Shapovalov (intelfx...@gmail.com) wrote: That

[systemd-devel] [PATCHv2] bus-control: Fix cgroup handling

2014-08-18 Thread Denis Kenzior
On systems without properly setup systemd, cg_get_root_path returns -ENOENT. This means that busctl doesn't display much information. busctl monitor also fails whenever it intercepts messages. This fix fakes creates a fake / root cgroup which lets busctl work on such systems. ---

Re: [systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-18 Thread Ronny Chevalier
2014-08-18 18:34 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: To follow the same behavior that src/core/condition.c do --- src/shared/condition-util.c| 2 +- src/test/test-condition-util.c | 4 2

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 Thread Ronny Chevalier
2014-08-18 15:51 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: What's the rationale here? I think it makes a lot of sense to output an error if people drop non-executable files in such a directory... Yeah it

[systemd-devel] [PATCH] pager: wrap long lines by default

2014-08-18 Thread Tobias Geerinckx-Rice
Wrap lines longer than the screen width to multiple rows instead of making them stumble abruptly off the edge. --- man/less-variables.xml | 2 +- src/shared/pager.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/less-variables.xml b/man/less-variables.xml index

Re: [systemd-devel] Impossible to enable instantiated symlink (foo@bar)

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 21:52, Andrei Borzenkov (arvidj...@gmail.com) wrote: В Mon, 18 Aug 2014 19:22:01 +0200 Lennart Poettering lenn...@poettering.net пишет: On Mon, 18.08.14 21:10, Andrei Borzenkov (arvidj...@gmail.com) wrote: If foo@bar.service symlink is present, it is impossible to

Re: [systemd-devel] Make journalctl start at the end of the journal by default

2014-08-18 Thread Tobias Geerinckx-Rice
On 18 August 2014 17:33, Andrei Borzenkov arvidj...@gmail.com wrote: Personally I find default (lack of) line wrapping quite annoying [...] I think line wrapping by default is really more user friendly. Agreed. I assume there was a good reason to add -S to the default pager options, but I

[systemd-devel] [PATCH v2] bootchart: use NSEC_PER_SEC

2014-08-18 Thread Ronny Chevalier
--- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..2d2ea42 100644 --- a/src/bootchart/store.c +++ b/src/bootchart/store.c @@ -34,6 +34,7 @@ #include time.h #include util.h +#include

[systemd-devel] [PATCH] man: fix typo

2014-08-18 Thread Ronny Chevalier
--- man/systemd.exec.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml index cfcf996..af103ff 100644 --- a/man/systemd.exec.xml +++ b/man/systemd.exec.xml @@ -1013,7 +1013,7 @@ made inaccessible and

Re: [systemd-devel] [PATCH v2] bootchart: use NSEC_PER_SEC

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 20:59, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: Thanks! Applied! --- src/bootchart/store.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bootchart/store.c b/src/bootchart/store.c index cedcba8..2d2ea42 100644 ---

Re: [systemd-devel] [PATCH] man: fix typo

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 21:00, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: Thanks! Applied! --- man/systemd.exec.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.exec.xml b/man/systemd.exec.xml index cfcf996..af103ff 100644 --- a/man/systemd.exec.xml

Re: [systemd-devel] [PATCHv2] bus-control: Fix cgroup handling

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 13:21, Denis Kenzior (denk...@gmail.com) wrote: Thanks! Applied! On systems without properly setup systemd, cg_get_root_path returns -ENOENT. This means that busctl doesn't display much information. busctl monitor also fails whenever it intercepts messages. This fix

Re: [systemd-devel] [PATCH] condition-util: do not validate condition if paramater is garbage

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 20:33, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: By the way, there is a couple of places, like this one, where we should add a warning when we could not parse the boolean, I think. yeah, we should. but this is actually not as easy as it sounds, since we really should

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 Thread Lennart Poettering
On Mon, 18.08.14 20:47, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: 2014-08-18 15:51 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: What's the rationale here? I think it makes a lot of sense to output

Re: [systemd-devel] [PATCH] util: do not execute files without exec permission

2014-08-18 Thread Ronny Chevalier
2014-08-18 21:10 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Mon, 18.08.14 20:47, Ronny Chevalier (chevalier.ro...@gmail.com) wrote: 2014-08-18 15:51 GMT+02:00 Lennart Poettering lenn...@poettering.net: On Sat, 16.08.14 14:24, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:

Re: [systemd-devel] Logind error - Failed to abandon session scope: Connection reset

2014-08-18 Thread Roger Qiu
Hello Lennart, I'm not familiar with the SystemD codebase https://github.com/systemd/systemd so I don't where I could patch the error message. On the other hand, is the kdbus production ready even though it hasn't been merged into the kernel? I'm curious what would be the procedure to

[systemd-devel] [PATCH 0/3] kdbus: metadata improvements

2014-08-18 Thread Djalal Harouni
Hi, Patch 1 and 2 should be applied. For patch 3 it can be discussed :-) Please apply on top of the test series that contain the test-kdbus-metadta-ns tool. Thanks! ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH 1/3] metadata: document creds_item_off and auxgrps_item_off fields

2014-08-18 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- metadata.c | 3 ++- metadata.h | 8 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/metadata.c b/metadata.c index eb286aa..3dff9ac 100644 --- a/metadata.c +++ b/metadata.c @@ -130,7 +130,8 @@ kdbus_meta_append_item(struct

[systemd-devel] [PATCH 2/3] connection: move the install creds into the slice to its own function

2014-08-18 Thread Djalal Harouni
Move the install creds into the receiver's slice to its own function kdbus_conn_creds_install(). Use from_kuid_munged(), so the uid mapping never fails. Signed-off-by: Djalal Harouni tix...@opendz.org --- connection.c | 32 1 file changed, 20 insertions(+), 12

[systemd-devel] [PATCH 3/3] kdbus: get some creds during meta append for optimization

2014-08-18 Thread Djalal Harouni
Some creds can be gathered during kdbus_meta_append() instead of kdbus_conn_queue_alloc() where they will be gathered for all the receivers and saved into each receivers queue before installing on the slices. By moving to kdbus_meta_append() it permits to do it only one time for all the