[systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Per Bergqvist
Hej, There was a request for addition of NVMe disks Feb 10 2014 by Harald Hoyer which was sort of rejected by Kay Sievers by referring to “we should find out what to do for nvme before adding new users of scsi_id”. More than a year later nothing has happened and recent commits actually branch

[systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-14 Thread Martin Pitt
Martin Pitt [2015-05-13 17:01 +0200]: > I got a report [1] that you can trivially crash systemd (pid1) at boot > by creating a unit with an Exec= line with a modifier and a space: > > $ cat /tmp/foo.service > [Service] > ExecStart=- /bin/echo hello > > $ systemd-analyze verify /tmp/foo.service >

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Robert Milasan
On Thu, 14 May 2015 09:10:40 +0200 "Per Bergqvist" wrote: > > +KERNEL=="nvme*",ENV{DEVTYPE}=="disk", ENV{ID_SCSI_SERIAL}=="?*", Wouldn't this make sense: KERNEL=="nvme*[!0-9]" (this is disk) > +KERNEL=="nvme*",ENV{DEVTYPE}=="partition", ENV{ID_SCSI_SERIAL}=="?*", and this KERNEL=="nvme*[0-9]"

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Per Bergqvist
Not really the point. I do however prefer to trust an explicit indication in ENV{DEVTYPE} rather than to guess device type based on device naming. And so does the standard scsi rules. BR Per On 14 May 2015, at 9:20 , Robert Milasan wrote: > On Thu, 14 May 2015 09:10:40 +0200 > "Per Bergqvist"

Re: [systemd-devel] [PATCH] systemctl: introduce -e and -d for start and stop

2015-05-14 Thread Jan Synacek
Lennart Poettering writes: > On Wed, 13.05.15 15:21, jsyna...@redhat.com (jsyna...@redhat.com) wrote: > >> From: Jan Synacek > > Hmm, do we really need two options for this? I mean, since -e would > only ever be combined with start, and -d only with stop it could as > well be a single option tha

Re: [systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-14 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing list systemd-devel@

Re: [systemd-devel] [PATCH] sd-bus: fix potential UB in bus_socket_auth_verify_client()

2015-05-14 Thread Lennart Poettering
On Wed, 13.05.15 19:16, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > When built with GCC undefined behaviour sanitizer the following problem > surfaces: > > src/libsystemd/sd-bus/bus-socket.c:180:11: runtime error: null pointer > passed as argument 1, which is declared to never be null

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Dimitri John Ledkov
Hello, On 14 May 2015 at 08:10, Per Bergqvist wrote: > Hej, > > There was a request for addition of NVMe disks Feb 10 2014 by Harald Hoyer > which was > sort of rejected by Kay Sievers by referring to “we should find out what to > do for nvme before > adding new users of scsi_id”. > > More than a

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-14 Thread Martin Pitt
Hello all, Dimitri John Ledkov [2015-05-13 12:48 +0100]: > I am booting without initramfs, using a plan9 filesystem as rootfs in a kvm. > > Thus my /proc/cmdline has: > root=/dev/root rootflags=rw,trans=virtio,version=9p2000.L rootfstype=9p > > # mount > /dev/root on / type 9p > (rw,relatime,syn

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-14 Thread Andrei Borzenkov
В Thu, 14 May 2015 12:51:37 +0200 Martin Pitt пишет: > Hello all, > > Dimitri John Ledkov [2015-05-13 12:48 +0100]: > > I am booting without initramfs, using a plan9 filesystem as rootfs in a kvm. > > > > Thus my /proc/cmdline has: > > root=/dev/root rootflags=rw,trans=virtio,version=9p2000.L r

[systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread Karel Zak
Currently we have no way how to specify dependencies between fstab entries (or another units) in the /etc/fstab. It means that users are forced to bypass fstab and write .mount units manually. The patch introduces new systemd fstab options: x-systemd.requires= - to specify dependence an another

Re: [systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread Karel Zak
On Thu, May 14, 2015 at 01:27:40PM +0200, Karel Zak wrote: > +static int write_requires_mounts_for(FILE *f, const char *opts) { > +_cleanup_free_ char **optsv = NULL, **paths = NULL, *res = NULL; _cleanup_strv_free_ **optsv = NULL, **paths = NULL; Do I need to resend the patch? ;-)

Re: [systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel mailing l

[systemd-devel] [PATCH] systemctl: introduce --now for enable, disable and mask

2015-05-14 Thread jsynacek
From: Jan Synacek --- Makefile.am | 1 + man/systemctl.xml| 33 - src/libsystemd/sd-bus/bus-util.c | 6 +- src/libsystemd/sd-bus/bus-util.h | 3 ++- src/machine/machinectl.c | 2 +- src/shared/install.c

Re: [systemd-devel] [PATCH] core: Fix assertion with empty Exec*= paths

2015-05-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, May 14, 2015 at 09:15:10AM +0200, Martin Pitt wrote: > From 10f6ac7c8b3dad0197ce795e33383c24ea2d53b1 Mon Sep 17 00:00:00 2001 > From: Martin Pitt > Date: Thu, 14 May 2015 09:06:40 +0200 > Subject: [PATCH] core: Fix assertion with empty Exec*= paths > > An Exec*= line with whitespace after

Re: [systemd-devel] [PATCH] systemctl: introduce --now for enable, disable and mask

2015-05-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, May 14, 2015 at 02:26:34PM +0200, jsyna...@redhat.com wrote: > From: Jan Synacek > > --- > Makefile.am | 1 + > man/systemctl.xml| 33 - > src/libsystemd/sd-bus/bus-util.c | 6 +- > src/libsystemd/sd-bus/bus-util.

Re: [systemd-devel] [PATCH] systemctl: introduce --now for enable, disable and mask

2015-05-14 Thread systemd github import bot
Patchset imported to github. Pull request: -- Generated by https://github.com/haraldh/mail2git ___ systemd-devel maili

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Keith Busch
On Thu, 14 May 2015, Dimitri John Ledkov wrote: On 14 May 2015 at 08:10, Per Bergqvist wrote: +# NVMe +KERNEL=="nvme*", ENV{ID_SCSI_SERIAL}!="?*", IMPORT{program}="scsi_id --export --whitelisted -d $devnode" +KERNEL=="nvme*", ENV{DEVTYPE}=="disk", ENV{ID_SCSI_SERIAL}=="?*", SYMLINK+="disk/by-id

Re: [systemd-devel] [PATCH v2] fstab-generator: add x-systemd.requires and x-systemd.requires-mounts-for

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 13:27, Karel Zak (k...@redhat.com) wrote: > +r = fstab_filter_options(opts, "x-systemd.requires\0", NULL, &arg, > NULL); > +if (r < 0) > +return log_warning_errno(r, "Failed to parse options: %m"); > +if (r == 0) > +return 0

Re: [systemd-devel] [PATCH] systemctl: introduce --now for enable, disable and mask

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 14:26, jsyna...@redhat.com (jsyna...@redhat.com) wrote: > const char *unit_file_preset_mode_to_string(UnitFilePresetMode m) _const_; > UnitFilePresetMode unit_file_preset_mode_from_string(const char *s) _pure_; > + > + > +int add_file_change(UnitFileChange **changes, unsigned *n

Re: [systemd-devel] dev-root.device is not active, results in an umount spree

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 12:51, Martin Pitt (martin.p...@ubuntu.com) wrote: > > This is very bad. As a harmless action like following: > > > > # mount --bind /opt /opt > > > > Results in opt.mount unit to be generated which BindsTo > > dev-root.device, which is inactive, thus systemd tries to stop that

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 09:10, Per Bergqvist (p...@bst.lu) wrote: > Hej, > > There was a request for addition of NVMe disks Feb 10 2014 by Harald Hoyer > which was > sort of rejected by Kay Sievers by referring to “we should find out what to > do for nvme before > adding new users of scsi_id”. Well,

[systemd-devel] preset activation on first boot takes too long

2015-05-14 Thread Dimitri John Ledkov
Heya, I'm looking at bootcharts and it seems like first boot preset activation takes too much time... So at the moment, we iterate all units, then iterate through presets until we find a match and act upon it. However, most distros have "disable *" as their last setting, or don't use presets at

Re: [systemd-devel] Booting to systemd in a chroot

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 06:12, JT Olds (jto...@xnet5.com) wrote: > Hey folks! > > I'm getting lots of systemd errors like > `Failed at step NAMESPACE spawning /usr/lib/rtkit/rtkit-daemon: Invalid > argument` and just wondering what I'm doing wrong. > > For background: I have a linux computer that's run

Re: [systemd-devel] systemd-socket-proxyd usage: remote's directly ping-/telnet-able, but via proxy "Network is unreachable"?

2015-05-14 Thread Lennart Poettering
On Wed, 13.05.15 21:53, PGNd (d...@pgnd.us) wrote: > > [Service] > ExecStart=/usr/lib/systemd/systemd-socket-proxyd 10.2.2.12:25 > PrivateTmp=yes > PrivateNetwork=yes The PrivateNetwork=yes will lock your service into its own virtual networ

Re: [systemd-devel] Booting to systemd in a chroot

2015-05-14 Thread JT Olds
Thanks Lennart, I tried pivot_root briefly last night after emailing but my initial attempt didn't work. Unfortunately I next tried switch_root, which, lol, wiped my root partition. I'll try pivot_root when I get a working computer again. Thanks again -JT On Thu, May 14, 2015, 10:25 AM Lennart

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Kay Sievers
On Thu, May 14, 2015 at 6:12 PM, Lennart Poettering wrote: > On Thu, 14.05.15 09:10, Per Bergqvist (p...@bst.lu) wrote: > >> There was a request for addition of NVMe disks Feb 10 2014 by Harald Hoyer >> which was >> sort of rejected by Kay Sievers by referring to “we should find out what to >> d

Re: [systemd-devel] loginctl - multi-seats - lightdm - Xorg

2015-05-14 Thread poma
To conclude. $ loginctl SESSIONUID USER SEAT 1 1000 poma c3105 lightdm seat1 c4105 lightdm seat0 3 sessions listed. $ ps ax | grep [X]org 1344 ?

Re: [systemd-devel] preset activation on first boot takes too long

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 17:13, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > Heya, > > I'm looking at bootcharts and it seems like first boot preset > activation takes too much time... > > So at the moment, we iterate all units, then iterate through presets > until we find a match and act u

Re: [systemd-devel] systemd-socket-proxyd usage: remote's directly ping-/telnet-able, but via proxy "Network is unreachable"?

2015-05-14 Thread PGNd
> The PrivateNetwork=yes will lock your service into its own virtual > network without any connectivity outside (it will contain only a > single loopback device). Drop this like and it should > work. Yep, Thanks. Inbound traffic via the staticIP now works exactly as intended -- mail is received

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Keith Busch
Kay Sievers vrfy.org> writes: > On Thu, May 14, 2015 at 6:12 PM, Lennart Poettering > poettering.net> wrote: > > Well, nothing changed really: we'd like to remove scsi_id from > > systemd/udev upstream. Please ask sg_utils to pick it up > > instead. We'll continue to support the status quo for a

Re: [systemd-devel] 60-persistent-storage.rules: add NVMe disks and partitions (again)

2015-05-14 Thread Per Bergqvist
Hej, The kernel driver in /sys provide little useful information with current releases. Even if the nvme driver is extended in future kernels as proposed by Keith Busch this will not solve the problem with kernels used today. NVMe drives are being deployed now (in mass) and it will only incre

[systemd-devel] systemd-218 - Requisite implies TriggeredByRestartOf

2015-05-14 Thread Evert
Hi, According to the systemd documentation, Requisite disallows starting a unit unless the specified unit has been started. This seems to work fine, however, if the specified unit has been restarted, this unit will be started too! This is not what should happen and it doesn't happen with a stop an

Re: [systemd-devel] [PATCH 0/5] systemd-importd - support for pulling from V2 Dkr registries

2015-05-14 Thread Vincent Batts
On 11/05/15 11:15 -0400, Vincent Batts wrote: On 11/05/15 17:07 +0200, Pavel Odvody wrote: On Mon, 2015-05-11 at 10:32 -0400, Vincent Batts wrote: On 09/05/15 00:31 +0200, Pavel Odvody wrote: On Fri, 2015-05-08 at 14:33 -0400, Vincent Batts wrote: On 08/05/15 11:31 +1000, Daurnimator wrote: >

Re: [systemd-devel] Booting to systemd in a chroot

2015-05-14 Thread Kai Krakow
JT Olds schrieb: > Thanks Lennart, > > I tried pivot_root briefly last night after emailing but my initial > attempt didn't work. Unfortunately I next tried switch_root, which, lol, > wiped my root partition. > > I'll try pivot_root when I get a working computer again. Since you are reinstalli

Re: [systemd-devel] systemd-socket-proxyd usage: remote's directly ping-/telnet-able, but via proxy "Network is unreachable"?

2015-05-14 Thread Lennart Poettering
On Thu, 14.05.15 10:02, PGNd (d...@pgnd.us) wrote: > > The PrivateNetwork=yes will lock your service into its own virtual > > network without any connectivity outside (it will contain only a > > single loopback device). Drop this like and it should > > work. > > Yep, Thanks. > > Inbound traffic

Re: [systemd-devel] Booting to systemd in a chroot

2015-05-14 Thread JT Olds
> Since you are reinstalling anyways, I'd suggest trying out btrfs as your > filesystem. Create separate subvolumes for each OS and you can get rid of > chrooting anything. Plus, you can share your home subvolume if you like. > To be totally honest, I was trying this out mainly because we're evalu

Re: [systemd-devel] Supporting ExecStartPre= and friends in `systemctl set-property` or `systemd-run -p`

2015-05-14 Thread Lennart Poettering
On Thu, 07.05.15 04:37, Ivan Shapovalov (intelfx...@gmail.com) wrote: > On 2015-05-06 at 18:59 +0200, Lennart Poettering wrote: > > On Wed, 06.05.15 19:53, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > > > I still think that being able to define and start group of units > > > as one > > >

Re: [systemd-devel] [PATCH] sd-bus: fix memory leak in test-bus-chat

2015-05-14 Thread Lennart Poettering
On Sat, 09.05.15 22:14, Cristian Rodríguez (crrodrig...@opensuse.org) wrote: > Building with address sanitizer enabled on GCC 5.1.x a memory leak > is reported because we never close the bus, fix it by using > cleanup variable attribute. Thanks! Applied! > --- > src/libsystemd/sd-bus/test-bus-c

Re: [systemd-devel] Booting to systemd in a chroot

2015-05-14 Thread Colin Walters
On Thu, May 14, 2015, at 04:30 PM, JT Olds wrote: > >> Since you are reinstalling anyways, I'd suggest trying out btrfs >> as your >> filesystem. Create separate subvolumes for each OS and you can get rid of >> chrooting anything. Plus, you can share your home subvolume if you like. > > To be total

Re: [systemd-devel] [PATCH] systemctl: introduce --now for enable, disable and mask

2015-05-14 Thread Cam Hutchison
jsyna...@redhat.com writes: >diff --git a/man/systemctl.xml b/man/systemctl.xml >index 4dbdfe1..951ce4d 100644 >--- a/man/systemctl.xml >+++ b/man/systemctl.xml >@@ -456,6 +456,17 @@ > > > >+--now >+ >+ >+ When used with enable, the units >+ will al

Re: [systemd-devel] systemd-218 - Requisite implies TriggeredByRestartOf

2015-05-14 Thread Andrei Borzenkov
В Thu, 14 May 2015 21:23:38 +0200 Evert пишет: > Hi, > > According to the systemd documentation, Requisite disallows starting a > unit unless the specified unit has been started. This seems to work > fine, however, if the specified unit has been restarted, this unit will > be started too! > This