Le 03/04/2015 14:58, Lennart Poettering a écrit :
Heya,
Hey Lennart,
so we discussed the whole fsckd situation a bit more here in Berlin,
and we came to the conclusion that fsckd really should not exist the
way it does in systemd.
To start with, the code is really wrong, it should never have
:
commit e26169bd48c64753510a1194abdf4fb5dc907123
Author: Didier Roche
Date: Tue Mar 10 10:05:19 2015 +0100
fsckd: check if plymouth is running before attempting connection
diff --git a/src/fsckd/fsckd.c b/src/fsckd/fsckd.c
index f24715c..6b35fc2 100644
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd
Le 16/03/2015 18:23, Tom Gundersen a écrit :
On Mon, Mar 16, 2015 at 6:15 PM, Didier Roche
wrote:
Le 16/03/2015 17:53, Tom Gundersen a écrit :
Thanks! Enthusiastically applied.
Tom
PS
There is still some plymouth integration left in case anyone wants to
work on getting rid of that.
Hey
Le 16/03/2015 17:53, Tom Gundersen a écrit :
Thanks! Enthusiastically applied.
Tom
PS
There is still some plymouth integration left in case anyone wants to
work on getting rid of that.
Hey Tom, Jasper,
Note that systemd-fsckd (in the new set of patch posted last week on
that ML to address L
Le 14/03/2015 21:37, Mikhail Morfikov a écrit :
This is the full log I got when I tried to mount the device:
Mar 14 20:46:08 morfikownia polkitd(authority=local)[1266]: Registered
Authentication Agent for unix-process:11439:94979 (system bus name :1.41
[/usr/bin/pkttyagent --notify-fd 5 --fall
Le 10/03/2015 16:53, Lennart Poettering a écrit :
On Mon, 09.03.15 11:27, Didier Roche (didro...@ubuntu.com) wrote:
However, some file systems (seems overlayfs at least) would report a
major(st_dev) as 0 on directories and not on files. The current
path_is_mount_point() fallback logic would
will satisfy your
original vision more :)
Cheers,
Didier
>From cdfcfb8490cd07c7b9129e6ce7c382c962c2c4dd Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Wed, 11 Mar 2015 12:58:39 +0100
Subject: [PATCH 3/3] fsckd: directly connect fsck output to systemd-fsckd
* Remove the intermediate structure to
Le 11/03/2015 09:34, Didier Roche a écrit :
Le 11/03/2015 09:29, Martin Pitt a écrit :
Hello all,
Didier Roche [2015-03-10 17:56 +0100]:
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd/fsckd.c
@@ -272,7 +272,7 @@ static int plymouth_send_message(int
plymouth_fd, const char *message, bool upda
Le 11/03/2015 09:29, Martin Pitt a écrit :
Hello all,
Didier Roche [2015-03-10 17:56 +0100]:
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd/fsckd.c
@@ -272,7 +272,7 @@ static int plymouth_send_message(int plymouth_fd, const
char *message, bool upda
}
static int manager_send_plymouth_message
Le 10/03/2015 18:54, Lennart Poettering a écrit :
On Tue, 10.03.15 18:01, Didier Roche (didro...@ubuntu.com) wrote:
The context is bug
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1411140, where
systemd-machine-id-commit unit is entering in failed state (the binary
handles gracefully
Le 10/03/2015 11:44, Lennart Poettering a écrit :
On Tue, 10.03.15 11:34, Didier Roche (didro...@ubuntu.com) wrote:
I think it would make more sense to return 0 when ply isn't running,
and 1 if it is, no?
Did this in the attached patch. Due to this, I needed then to return 1
even if w
Le 10/03/2015 11:41, Lennart Poettering a écrit :
On Tue, 10.03.15 11:33, Didier Roche (didro...@ubuntu.com) wrote:
diff --git a/src/fsckd/fsckd.c b/src/fsckd/fsckd.c
index 3fc923b..9393379 100644
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd/fsckd.c
@@ -220,7 +220,7 @@ static int
Le 10/03/2015 11:36, Lennart Poettering a écrit :
On Tue, 10.03.15 11:32, Didier Roche (didro...@ubuntu.com) wrote:
static int manager_send_plymouth_message(Manager *m, const char *message) {
-const char *plymouth_cancel_message = NULL;
+_cleanup_free_ const char
>From 32c1aec9bddf21b1380eb8f7b801468d3875e2a9 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 10:18:00 +0100
Subject: [PATCH 5/5] fsckd: clean up log messages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Avoid double l
>From fd28f24d9eaa16737cbc8f33b8fe1a806dc291b1 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 10:05:19 +0100
Subject: [PATCH 4/5] fsckd: check if plymouth is running before attempting
connection
---
src/fsckd/fsckd.c | 6 ++
1 file changed, 6 insertions(+)
diff --
>From 3e877d1d493476f63fa6af7997914f93b50218bd Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 09:57:38 +0100
Subject: [PATCH 3/5] fsckd: Reduce the SAK window when writing to console
We don't want to keep /dev/console open all the time, but only open it when
ne
>From 689c3c1808bd286ed96d36e4fc7ff875e2477697 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 09:01:11 +0100
Subject: [PATCH 2/5] fsckd: Fix some error return values
Change slightly recent changes introduced by
0b02c7c36dbb6f2ec7434eb8d18e0410ee1cc74c
rom 4d279e1818dd05dccdf4595a5bf1f3dc32c3e8c2 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Tue, 10 Mar 2015 08:58:23 +0100
Subject: [PATCH 1/5] fsckd: Don't use strjoina on gettext() call
---
src/fsckd/fsckd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/
Le 10/03/2015 08:33, Martin Pitt a écrit :
Lennart Poettering [2015-03-09 19:11 +0100]:
Oh, and I am only realizing now that the whole thing doesn't do *at
all* what we discussed. The idea was to invoke the actual fsck tools
with their stdout connected directly to fsckd. Instead the old
systemd
Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 9 Mar 2015 13:44:39 +0100
Subject: [PATCH] Fsckd: only connect to plymouth if running
Ensure that we are not trying to send plymouth messages if the plymouth pid
file is not present.
---
src/fsckd/fsckd.c | 8 +---
1 file changed
this patch.
Cheers,
Didier
>From 47a8d7546f3fa959344431770f75d8e422192ba3 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 9 Mar 2015 09:09:30 +0100
Subject: [PATCH] path_is_mount_point: handle false positive on some fs
path_is_mount_point detection mechanism was wrongly reporting every
Le 06/03/2015 16:17, Michael Biebl a écrit :
2015-03-06 11:20 GMT+01:00 Didier Roche :
It seems like tmp.mount unit was skipped as nothing declared any explicit
dependency against it. What seems to confirm this is that if I add any
enabled foo.service which declares After=tmp.mount, or if I add
Le 04/03/2015 13:40, Lennart Poettering a écrit :
On Wed, 04.03.15 13:19, Didier Roche (didro...@ubuntu.com) wrote:
Before=systemd-timesyncd.service foo.service local-fs.target umount.target
systemd-timesyncd.service though is condition failed:
Condition: start condition failed at Wed 2015-03
Le 04/03/2015 16:27, Michael Biebl a écrit :
2015-03-04 15:41 GMT+01:00 Lennart Poettering :
Well, just removing the symlink is kinda pointless. It might still be pulled
in by anything else that implicitly depepends on /tmp.
What unit is supposed to pull in tmp.mount explicitly? If a generic
un
Le 04/03/2015 13:40, Lennart Poettering a écrit :
On Wed, 04.03.15 13:19, Didier Roche (didro...@ubuntu.com) wrote:
Le 04/03/2015 12:49, Lennart Poettering a écrit :
On Wed, 04.03.15 09:21, Didier Roche (didro...@ubuntu.com) wrote:
Hey,
It seems that we discovered an issue if a service
Le 04/03/2015 12:49, Lennart Poettering a écrit :
On Wed, 04.03.15 09:21, Didier Roche (didro...@ubuntu.com) wrote:
Hey,
It seems that we discovered an issue if a service declares some relationship
with a .mount unit.
For instance, having tmp.mount disable (and nothing mounting /tmp as tmpfs
Le 04/03/2015 09:29, Andrei Borzenkov a écrit :
On Wed, Mar 4, 2015 at 11:21 AM, Didier Roche wrote:
tmpfs on /tmp type tmpfs (rw)
status on tmp.mount:
Loaded: loaded (/lib/systemd/system/tmp.mount; disabled; vendor preset:
enabled)
It says "enabled" here, although I'
Just for the record: I didn't try on trunk yet, only systemd v219 that
we ship in vivid.
Cheers,
Didier
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Hey,
It seems that we discovered an issue if a service declares some
relationship with a .mount unit.
For instance, having tmp.mount disable (and nothing mounting /tmp as
tmpfs in fstab):
foo.service:
[Unit]
After=tmp.mount
[Service]
ExecStart=/bin/echo foo
[Install]
WantedBy=multi-user.tar
Le 20/02/2015 15:41, Michael Biebl a écrit :
2015-02-20 15:36 GMT+01:00 Martin Pitt :
Hello all,
Since we updated to 219 in Ubuntu, several people reported boot
failures. Booting hangs a long time after starting D-Bus, in the
journal you get a lot of error messages like
systemd[1]: Failed
Le 18/02/2015 17:00, Martin Pitt a écrit :
Ça va Didier,
these now apply/build/check fine against master, I tested the binaries
on my laptop and in a VM, all review comments were addressed. As
discussed with Zbigniew on IRC I landed them now.
Thanks a lot Martin for doing this further testing
>From 59d7202a3755dd73ebad94a20921975330a4ee83 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:46:36 +0100
Subject: [PATCH 9/9] Add mock fsck process
---
test/mocks/fsck | 27 +++
1 file changed, 27 insertions(+)
create mode 100755 test/mo
>From 9db0d5cd0cc20b899ddf77ccdfcbe214978eb463 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 8/9] Add man page and references to it.
Add man page explaining the plymouth theme protocol, usage of the daemon
as well as the socket activat
>From 03f05550e81941d2073d151aaedfe3d06c1f95b0 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:23:08 +0100
Subject: [PATCH 6/9] Refresh po files
Also, add new plymouth fsckd translated strings in french.
Refreshed with "make update-po".
---
po/
>From 3f029b3549b736f57cfb73c016022f13185187f8 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:12:54 +0100
Subject: [PATCH 5/9] Translate fsckd messages for plymouth
For plymouth themes not supporting i18n (like .script), send translated
messages to display to user, wh
>From 20b16b76f4197604525579cef99c8d6b8b5484e5 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:30:00 +0100
Subject: [PATCH 7/9] Add fsckd service and socket, retarget systemd-fsck
systemd-fsckd can be socket-activated by systemd-fsck process. Reflect that
in the differ
Le 18/02/2015 00:30, Zbigniew Jędrzejewski-Szmek a écrit :
On Tue, Feb 17, 2015 at 05:26:05PM +0100, Didier Roche wrote:
+r = send_message_plymouth_socket(m->plymouth_fd,
plymouth_cancel_message, false);
+if (r < 0)
+log_warning_e
>From 9227f9a919084f937fd29856935016e0ee9e754e Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Thu, 29 Jan 2015 16:12:58 +0100
Subject: [PATCH 4/9] Add gettext support
---
configure.ac | 1 +
src/shared/util.c | 8
src/shared/util.h | 2 ++
3 files changed, 11 inserti
>From 6006bedd30530a91c2dee7e3822a8840799752e4 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:01:11 +0100
Subject: [PATCH 2/9] systemd-fsck: always connect to systemd-fsckd
Remove the plymouth running or show-status checks from systemd-fsck. Instead,
always connect
17 00:00:00 2001
From: Didier Roche
Date: Wed, 4 Feb 2015 16:42:47 +0100
Subject: [PATCH 1/9] fsckd daemon for inter-fsckd communication
Add systemd-fsckd multiplexer which accepts multiple systemd-fsck
instances to connect to it and sends progress report. systemd-fsckd then
computes and writes to
Updated to latest (impacted by a change in 3/9)
Didier
>From b0209d20c648f6d275ed72bd78e74e3d48fc4068 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:12:54 +0100
Subject: [PATCH 5/9] Translate fsckd messages for plymouth
For plymouth themes not supporting i18n (l
Le 14/02/2015 17:21, Zbigniew Jędrzejewski-Szmek a écrit :
Thanks for the review, reattached the patch with those fixes.
On Thu, Feb 05, 2015 at 06:06:50PM +0100, Didier Roche wrote:
+if (fsckd_fd < 0) {
+log_warning_errno(errno, "Cannot open fsckd socket,
Le 14/02/2015 17:38, Zbigniew Jędrzejewski-Szmek a écrit :
On Thu, Feb 05, 2015 at 06:09:24PM +0100, Didier Roche wrote:
From ec3b3d2cd4b0097f9fafa6c3f0f400e06292e21c Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Thu, 5 Feb 2015 17:08:18 +0100
Subject: [PATCH 3/9] Connect to plymouth and
Le 14/02/2015 17:58, Zbigniew Jędrzejewski-Szmek a écrit :
On Thu, Feb 05, 2015 at 06:11:24PM +0100, Didier Roche wrote:
Thanks for the suggestions, all applied!
+
+The first time it connects to plymouth, a request
+to grab Control+C keypresses is sent, as well as a text message
Le 05/02/2015 17:11, Dimitri John Ledkov a écrit :
Some context for this patch.
Hey Dimitri, thanks for working on that. I'm just giving a broader
context for everyone who followed the past discussion we had in
december/january.
This is a followup on our discussion and what we discussed on
>From 0c33545e512307774cb280cbf83e7b2c3e2137ef Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:46:36 +0100
Subject: [PATCH 9/9] Add mock fsck process
---
test/mocks/fsck | 27 +++
1 file changed, 27 insertions(+)
create mode 100755 test/mo
>From 2533acf15135d9db18fbd79e63de9a702e3859cc Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 8/9] Add man page and references to it.
Add man page explaining the plymouth theme protocol, usage of the daemon
as well as the socket activat
>From 045e99a6865fec2a3e6167d271e01b77236c477d Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:30:00 +0100
Subject: [PATCH 7/9] Add fsckd service and socket, retarget systemd-fsck
systemd-fsckd can be socket-activated by systemd-fsck process. Reflect that
in the differ
>From e850b1cf9b49918265609da8a6ef2fd4e78541b6 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:12:54 +0100
Subject: [PATCH 5/9] Translate fsckd messages for plymouth
For plymouth themes not supporting i18n (like .script), send translated
messages to display to user, wh
>From ec3b3d2cd4b0097f9fafa6c3f0f400e06292e21c Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Thu, 5 Feb 2015 17:08:18 +0100
Subject: [PATCH 3/9] Connect to plymouth and support cancellation of in
progress fsck
Try to connect and send to plymouth (if running) some checked report progr
>From 94bc7097a176c90127a9ff0106e81b4fce6e9ff2 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Thu, 29 Jan 2015 16:12:58 +0100
Subject: [PATCH 4/9] Add gettext support
---
configure.ac | 1 +
src/shared/util.c | 8
src/shared/util.h | 2 ++
3 files changed, 11 inserti
>From 1579acc911be682cddf4fc91646c4ded231a409a Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:01:11 +0100
Subject: [PATCH 2/9] systemd-fsck: always connect to systemd-fsckd
Remove the plymouth running or show-status checks from systemd-fsck. Instead,
always connect
rrent connection state (they will only disappear once
they are actually cleaned).
As always, I'm opened to any comments.
Cheers,
Didier
>From ac8d6f10768a5bcba0b7932547419637983637b2 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Wed, 4 Feb 2015 16:42:47 +0100
Subject: [PATCH 1/9] fsc
Le 04/02/2015 18:20, Lennart Poettering a écrit :
On Wed, 04.02.15 17:40, Didier Roche (didro...@ubuntu.com) wrote:
Le 04/02/2015 17:10, Lennart Poettering a écrit :
On Wed, 04.02.15 17:05, Didier Roche (didro...@ubuntu.com) wrote:
Hey,
I rewrote a version of this patch including the
Le 04/02/2015 17:24, Zbigniew Jędrzejewski-Szmek a écrit :
Thanks again for the quick review! Fixed if not commented (sorry, some
issues were back due to the refactoring).
On Wed, Feb 04, 2015 at 05:06:45PM +0100, Didier Roche wrote:
+typedef struct Clients {
+struct Manager *manager
Le 04/02/2015 17:10, Lennart Poettering a écrit :
On Wed, 04.02.15 17:05, Didier Roche (didro...@ubuntu.com) wrote:
Hey,
I rewrote a version of this patch including the feedback on the list. As per
IRC discussion, (and after giving up the busy loop for a rewrite with
epool), I did rebase it
ation, cancel support, i18n, man pages and the service
and socket) so that I don't have to rebase all other 10 patches on a
moving ground.
I'm opened to any feedback and fixes to do :)
Cheers,
Didier
>From 52d3c92280ec6198a0566bd3a077c0fbb6990782 Mon Sep 17 00:00:00 2001
From: Didier R
>From 74291bace60f64efb96287f8170df4c38058cc46 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Wed, 4 Feb 2015 16:42:47 +0100
Subject: [PATCH 2/2] fsckd daemon for inter-fsckd communication
Add systemd-fsckd multiplexer which accepts multiple systemd-fsck
instances to connect to it and se
Le 31/01/2015 01:34, Zbigniew Jędrzejewski-Szmek a écrit :
On Thu, Jan 29, 2015 at 06:37:53PM +0100, Didier Roche wrote:
Le 28/01/2015 15:37, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:20:40PM +0100, Didier Roche wrote:
\ No newline at end of file
diff --git a/src/fsckd
Le 31/01/2015 01:44, Zbigniew Jędrzejewski-Szmek a écrit :
On Thu, Jan 29, 2015 at 06:42:42PM +0100, Didier Roche wrote:
Le 28/01/2015 15:44, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:22:04PM +0100, Didier Roche wrote:
bool plymouth_running(void) {
return
Le 31/01/2015 01:39, Zbigniew Jędrzejewski-Szmek a écrit :
On Thu, Jan 29, 2015 at 06:43:22PM +0100, Didier Roche wrote:
Le 28/01/2015 21:22, Lennart Poettering a écrit :
On Wed, 28.01.15 14:22, Didier Roche (didro...@ubuntu.com) wrote
Le 28/01/2015 17:13, Martin Pitt a écrit :
Zbigniew Jędrzejewski-Szmek [2015-01-28 16:08 +0100]:
+#!/bin/bash
I think you can change this to /bin/sh, I don't see any bashisms.
+declare -a maxpass=(30 5 2 30 60)
I do :-) POSIX shell doesn't have arrays AFAIK, and declare -a
definitively doesn
Le 28/01/2015 16:06, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:24:55PM +0100, Didier Roche wrote:
From 6b13d8fb248bf4176f1ad7e1d4736683462bf196 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 11/12] Add man page and
Le 28/01/2015 16:00, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:24:32PM +0100, Didier Roche wrote:
From 000f1b6ff4f5f80a2a13309590d255de6d6526ec Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:30:00 +0100
Subject: [PATCH 10/12] Add fsckd service and
Le 28/01/2015 21:25, Lennart Poettering a écrit :
On Wed, 28.01.15 14:22, Didier Roche (didro...@ubuntu.com) wrote:
src/fsck/fsck.c | 29 +
src/fsckd/fsckd.c | 43 +++
src/fsckd/fsckd.h | 5 +
3 files changed, 69
Le 28/01/2015 15:53, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:22:54PM +0100, Didier Roche wrote:
From 104cf82ba28941e907f277a713f834ceb3d909f0 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:40:52 +0100
Subject: [PATCH 06/12] Support cancellation
Le 28/01/2015 21:22, Lennart Poettering a écrit :
On Wed, 28.01.15 14:22, Didier Roche (didro...@ubuntu.com) wrote:
#
--
+have_plymouth=no
+AC_ARG_ENABLE(plymouth, AS_HELP_STRING([--disable-plymouth], [disable
Le 28/01/2015 15:44, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:22:04PM +0100, Didier Roche wrote:
From 7afe9270e3210668053089caaff8a1dd790a48f5 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:07:32 +0100
Subject: [PATCH 04/12] Add some plymouth
Le 28/01/2015 21:16, Lennart Poettering a écrit :
Thanks for your feedbacks! Changes integrated, some remaining questions
though:
On Wed, 28.01.15 14:20, Didier Roche (didier.ro...@canonical.com) wrote:
+last_activity = now(CLOCK_MONOTONIC);
+
+for
Le 28/01/2015 15:37, Zbigniew Jędrzejewski-Szmek a écrit :
On Wed, Jan 28, 2015 at 02:20:40PM +0100, Didier Roche wrote:
Hey Zbigniew,
Thanks for the quick feedbacks! Integrated your changes in the incoming
patches. Just answered to some comments here:
From
>From 6b13d8fb248bf4176f1ad7e1d4736683462bf196 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:34:59 +0100
Subject: [PATCH 11/12] Add man page and references to it.
Add man page explaining the plymouth theme protocol, usage of the daemon
as well as the socket activat
>From aefe0667ed62d5d7e17193c0f5ae302ed57e4727 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:46:36 +0100
Subject: [PATCH 12/12] Add mock fsck process
---
test/mocks/fsck | 27 +++
1 file changed, 27 insertions(+)
create mode 100755 test/mo
>From 000f1b6ff4f5f80a2a13309590d255de6d6526ec Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:30:00 +0100
Subject: [PATCH 10/12] Add fsckd service and socket, retarget systemd-fsck
systemd-fsckd can be socket-activated by systemd-fsck process. Reflect that
in
>From a56e70d026565b4da79acfdad1d83d6521ec42f5 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:51:05 +0100
Subject: [PATCH 07/12] Add gettext support
---
configure.ac | 1 +
src/shared/util.c | 8
src/shared/util.h | 2 ++
3 files changed, 11 inserti
>From cb822ca631b8cddfe03930ef68a12c97372bb8c1 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:12:54 +0100
Subject: [PATCH 08/12] Translate fsckd messages for plymouth
For plymouth themes not supporting i18n (like .script), send translated
messages to display to u
>From 104cf82ba28941e907f277a713f834ceb3d909f0 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:40:52 +0100
Subject: [PATCH 06/12] Support cancellation of fsck in progress
Grab in fsckd plymouth watch key for C or c, and propagate this cancel request
to systemd-fsck wh
>From 7afe9270e3210668053089caaff8a1dd790a48f5 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 17:07:32 +0100
Subject: [PATCH 04/12] Add some plymouth functionality to connect and send
messages
Connect to plymouth (if running).
Automatic reconnect if plymouth
>From c60d4f41e279dd5ed7134d97d95549aac1f38e69 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:29:30 +0100
Subject: [PATCH 05/12] Connect and send to plymouth progress report
Try to connect and send to plymouth (if running) some check report progress,
using libplymo
>From feb8f332313c3ac2542f618028f8a6a6a36daf50 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 16:01:11 +0100
Subject: [PATCH 03/12] systemd-fsck: always connect to systemd-fsckd
Remove the plymouth running or show-status checks from systemd-fsck. Instead,
always connect
>From 0ef3127531c95ad9a740cb997a1f94ef257dd4f0 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 15:45:46 +0100
Subject: [PATCH 02/12] Factorize plymouth_running in plymouth.c
Add plymouth.c/h facility which will contains all plymouth related
functionalities. This is part
>From d0f49b4e0994b9a1dd2738da18c5a2a6708b444f Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 26 Jan 2015 15:35:50 +0100
Subject: [PATCH 01/12] fsckd daemon for inter-fsckd communication
Add systemd-fsckd multiplexer which accept multiple systemd-fsck
instances to connect to it
Hi,
Here is a suite of patches up to review to add fsckd integration to
plymouth. This work is mostly based on Lennart's suggestion on an email
thread few years ago
(http://lists.freedesktop.org/archives/systemd-devel/2011-April/002063.html)
where the proposal was to add a systemd-fsckd daemo
Le 05/12/2014 16:42, Lennart Poettering a écrit :
On Fri, 05.12.14 16:02, Didier Roche (didro...@ubuntu.com) wrote:
This would also only "fix" the newly installed case, not the upgrade with
new distro defaults or various purge vs remove ones. That's why I think some
kind of pr
Le 05/12/2014 14:52, Lennart Poettering a écrit :
On Fri, 05.12.14 11:06, Didier Roche (didro...@ubuntu.com) wrote:
It seems maintaining this list in sync for all flavors would be a growing
pain (this is a positive effect of the disable by default: you don't have to
maintain such a list
Le 05/12/2014 02:13, Lennart Poettering a écrit :
On Tue, 02.12.14 12:50, Didier Roche (didro...@ubuntu.com) wrote:
Just to sum up other branches of this thread: we are trying to avoid having
systemctl calls in debian/ubuntu postinst (or duplicated manual symlinks
logic as we currently have
Le 03/12/2014 03:44, Lennart Poettering a écrit :
On Tue, 02.12.14 11:43, Didier Roche (didro...@ubuntu.com) wrote:
Heya!
Applied the patch with some changes (converted all log messages to the
new errno logging). Please check if everything still works as
intended.
Also applied patches 3, 4, 5
enable newly installed package by default (difference
from other distributions)
Le 02/12/2014 01:59, Lennart Poettering a écrit :
On Fri, 28.11.14 11:15, Didier Roche (didro...@ubuntu.com) wrote:
The distribution comes preinstalled with one dm, enable * -> enable it, have
the Alias=disp
Le 01/12/2014 18:38, Lennart Poettering a écrit :
On Mon, 24.11.14 12:35, Didier Roche (didro...@ubuntu.com) wrote:
+static int get_valid_machine_id(int fd, char id[34]) {
+assert(fd >= 0);
+assert(id);
+
+if (loop_read(fd, id, 33, false) == 33 && id
Le 01/12/2014 18:37, Lennart Poettering a écrit :
On Mon, 24.11.14 12:35, Didier Roche (didro...@ubuntu.com) wrote:
+static int is_on_temporary_fs(int fd) {
+struct statfs s;
+
+if (fstatfs(fd, &s) < 0)
+return -errno;
+
+return F_TYPE_EQUAL(s
Le 21/11/2014 12:08, Colin Guthrie a écrit :
Hello again!
Hey, trying to revive the topic :)
Didier Roche wrote on 18/11/14 15:40:
Le 18/11/2014 15:59, Colin Guthrie a écrit :
Hiya,
Hey,
Didier Roche wrote on 18/11/14 13:58:
This would be maybe a nice way for the admin to know what&#
>From 9b8d7613894838ce67db5141b8012b5abf7c02e4 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 24 Nov 2014 11:14:22 +0100
Subject: [PATCH 5/5] machine-id-commit: add man pages
Add man pages for systemd-machine-id-commit.service and
systemd-machine-id-commit.
---
Makefile-man
>From 6821788f561770ea7e49f170a5bea4a7033f6ad3 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 24 Nov 2014 10:12:06 +0100
Subject: [PATCH 4/5] machine-id-commit: add unit file
The unit file only active the machine-id-commit helper if /etc is mounted
writable and /etc/machine-id is
>From 6a9dfa52ea8a5564c86942ac55c9173ee06f53fe Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 24 Nov 2014 09:54:18 +0100
Subject: [PATCH 3/5] Introduce machine-id-commit binary
This binary enables to commit transient machine-id on disk if it becomes
writable.
---
.gitign
>From 7506756189164ad7512a896b5d74e4eb1b19a1a5 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 24 Nov 2014 09:43:29 +0100
Subject: [PATCH 2/5] Add a machine_id_commit call to commit on disk a
transient machine-id
If /etc was read only at boot time with an empty /etc/machine-id,
>From b4619f01b6f25752220b2fe5c5ccd22e248f4015 Mon Sep 17 00:00:00 2001
From: Didier Roche
Date: Mon, 24 Nov 2014 09:40:57 +0100
Subject: [PATCH 1/5] Factorize some machine-id-setup functions to be reused
---
src/core/machine-id-setup.c | 41 +++--
1 f
Le 21/11/2014 00:41, Lennart Poettering a écrit :
On Thu, 20.11.14 17:23, Didier Roche (didro...@ubuntu.com) wrote:
a) make /etc writable before systemd is invoked. If you use an initrd
this is without risk, given that the initrd should really invoke
fsck on the root disk anyway, and
Le 20/11/2014 13:45, Lennart Poettering a écrit :
On Wed, 19.11.14 09:45, Didier Roche (didro...@ubuntu.com) wrote:
Hey,
Some other topic related to "empty /etc" discussions: when preparing some
generic distro images, we are have the desire to ensure that all new
instances
Hey,
Some other topic related to "empty /etc" discussions: when preparing
some generic distro images, we are have the desire to ensure that all
new instances will get a different /etc/machine-id file.
As part of the empty /etc at boot, we first thought that removing
/etc/machine-id would be su
Le 18/11/2014 17:17, Tom Gundersen a écrit :
On Tue, Nov 18, 2014 at 4:21 PM, Didier Roche wrote:
Let's say as an admin that I want to disable plymouth-quit.service (which is
a static unit file and symlinked in /usr/lib… on the multi-user target).
Without knowing the systemd internal
Le 18/11/2014 15:59, Colin Guthrie a écrit :
Hiya,
Hey,
Didier Roche wrote on 18/11/14 13:58:
This would be maybe a nice way for the admin to know what's coming from
a distribution default or not. However, let's say I want to ensure that
ssh will always be available on my serve
1 - 100 of 103 matches
Mail list logo
