[systemd-devel] Bugfix release(s)

2019-01-14 Thread Jan Synacek
Hi, since v240 didn't go too well, I would like to suggest that the next one (preferably two) release(s) are bugfix only. Please, consider it. Thank you, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] Strange problem: Failed to get properties: Failed to activate service

2018-10-22 Thread Jan Synacek
If you see a SIGSEGV, let me know. Note that this problem is *not* present in the upstream code base. Cheers, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] Use of SystemKeepFree=

2018-10-11 Thread Jan Synacek
that SystemKeepFree= should be honored. Is it a bug? When is SystemKeepFree= actually used? Why have SystemKeepFree= at all if it's the "other way around" of SystemMaxUse= ? Cheers, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel ma

Re: [systemd-devel] Github systemd issue 6237

2017-07-11 Thread Jan Synacek
On Mon, Jul 10, 2017 at 4:41 PM, Lennart Poettering <lenn...@poettering.net> wrote: > On Mon, 10.07.17 15:58, Lennart Poettering (lenn...@poettering.net) wrote: > >> On Mon, 10.07.17 15:16, Jan Synacek (jsyna...@redhat.com) wrote: >> >> > On Mon, Jul 10, 201

Re: [systemd-devel] Github systemd issue 6237

2017-07-10 Thread Jan Synacek
OSIX explicitly suggests, btw) > 5. We require that the user name fits in the utmp user name field, so >that we can always log properly about it. Is this documented somewhere? If not, it would be great to have it documented. I'm pretty sure that this exact paragraph would be ok.

Re: [systemd-devel] Disabling 'Predictable Network Interface Names'

2017-03-07 Thread Jan Synacek
param is present. Hi, check out the official Red Hat documentation [1] on how to disable the naming scheme. If what's described there doesn't work, please, file a bug report. [1] https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Networking_Guide/sec-Disabling_Consiste

Re: [systemd-devel] Scheme bindings

2015-11-20 Thread Jan Synacek
oted(void) { return laccess("/run/systemd/system/", F_OK) >= 0; } This returns a "boolean" value. I'm not really sure why it would return anything else. But, the documentation indeed says that it can return negative values

Re: [systemd-devel] Scheme bindings

2015-11-20 Thread Jan Synacek
; activated services in scheme! >> >> [1] https://github.com/jsynacek/guile-systemd >> >> Have fun, >> -- >> Jan Synacek >> Software Engineer, Red Hat >> ___ >> systemd-devel mailing list >> systemd

Re: [systemd-devel] systemd-211 patch for FailureAction

2015-11-18 Thread Jan Synacek
prepared to hunt for them, though, as systemd-211 is pretty old. [1] https://github.com/systemd/systemd/ Cheers, -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists

Re: [systemd-devel] systemd and intltool

2015-10-09 Thread Jan Synacek
Jan Synacek <jsyna...@redhat.com> writes: > Lennart Poettering <lenn...@poettering.net> writes: > >> On Thu, 10.09.15 19:10, Michael Biebl (mbi...@gmail.com) wrote: >> >>> Hi, >>> >>> reading https://wiki.gnome.org/Projects/GnomeCommon

Re: [systemd-devel] systemd and intltool

2015-10-08 Thread Jan Synacek
Michael Biebl <mbi...@gmail.com> writes: > 2015-10-07 14:43 GMT+02:00 Jan Synacek <jsyna...@redhat.com>: >> Lennart Poettering <lenn...@poettering.net> writes: > >>> Happy to take a patch that removes the intltool hookup if it replaces >>> it wit

Re: [systemd-devel] systemd and intltool

2015-10-07 Thread Jan Synacek
d this a bit... AFAIK, gettext cannot be directly used to parse and merge translations into XML files. However, a simple python script instead of intltools should be enough for systemd's needs. I'll investigate further and possibly submit a pull request. -- Jan Synacek Softwa

Re: [systemd-devel] remote-fs dependency/ordering on network

2015-06-23 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 22.06.15 14:49, Jan Synacek (jsyna...@redhat.com) wrote: Lukáš Nykrýn lnyk...@redhat.com writes: Jan Synáček píše v Čt 18. 06. 2015 v 15:41 +0200: Is remote-fs.target somehow dependent/ordered on network.target or network

Re: [systemd-devel] remote-fs dependency/ordering on network

2015-06-22 Thread Jan Synacek
dependency between remote-fs.target, and network*. I'm quite puzzled how NFS mounts mounted on boot can actually work correctly right now. -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH] journal, coredump: allow relative values in some configuration options

2015-05-28 Thread Jan Synacek
is the advantage of the mapping again? Sorry if I'm being thick. Cheers, -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [systemd-devel] [PATCH] WIP: conf-parser: allow config_parse_iec_off to parse percentages

2015-05-22 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 20.05.15 10:37, jsyna...@redhat.com (jsyna...@redhat.com) wrote: From: Jan Synacek jsyna...@redhat.com Allow certain configuration options to be specified as percentages. For example, in journald.conf, SystemMaxUse= can now also

Re: [systemd-devel] [PATCH] systemctl: introduce -e and -d for start and stop

2015-05-14 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 13.05.15 15:21, jsyna...@redhat.com (jsyna...@redhat.com) wrote: From: Jan Synacek jsyna...@redhat.com Hmm, do we really need two options for this? I mean, since -e would only ever be combined with start, and -d only with stop

Re: [systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-04-24 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 20.02.15 10:56, Jan Synacek (jsyna...@redhat.com) wrote: Sorry for the late review. What's the precise background of this? Can you elaborate? Is there some feature request for this? Hi, I can see that Andrei already answered most

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 01.04.15 15:45, Jan Synacek (jsyna...@redhat.com) wrote: I am also against this since chrooting is an implementation detail of mock, nothing more, and the fact that mock's recursive deletion logic cannot handle removal

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Thu, 02.04.15 08:59, Jan Synacek (jsyna...@redhat.com) wrote: think that systemd shouldn't create them where it doesn't make sense. I don't think that that's achievable with the current logic. Am I missing something? But why do you

[systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
Creating subvolumes in chrooted environments makes them undeletable and breaks mock. https://bugzilla.redhat.com/show_bug.cgi?id=1205564 Jan Synacek (1): tmpfiles: don't create subvolumes in chroot src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion

[systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
--- src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 494fd1a..9280fd7 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -1099,9 +1099,15 @@ static int create_item(Item *i)

Re: [systemd-devel] [PATCH] tmpfiles: don't create subvolumes in chroot

2015-04-01 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 01.04.15 14:33, Jan Synacek (jsyna...@redhat.com) wrote: Creating subvolumes in chrooted environments makes them undeletable and breaks mock. Humm, I am not convinced that this is a good idea. The chroot environments are hardly

Re: [systemd-devel] SELinux labels on unix sockets

2015-03-10 Thread Jan Synacek
(SELINUX_CB_POLICYLOAD, cb) doesn't do anything. So, I think that the code that explictly labels the socket files should be removed. It would be nice to hear from Dan, though. Cheers, -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature

Re: [systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-02-24 Thread Jan Synacek
Andrei Borzenkov arvidj...@gmail.com writes: В Fri, 20 Feb 2015 10:56:41 +0100 Jan Synacek jsyna...@redhat.com пишет: First version of the patch that allows rd.luks.key to be specified almost the same way as dracut can read it. This sounds like working around dracut bug. Dracut already

[systemd-devel] [PATCH] nspawn: fix whitespace in partition table blurb

2015-02-23 Thread Jan Synacek
--- src/nspawn/nspawn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index 0d8d199..9c5b8cd 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -2754,7 +2754,7 @@ static int setup_image(char **device_path, int *loop_nr) {

[systemd-devel] [PATCH] nspawn: fix whitespace and typo in partition table blurb

2015-02-23 Thread Jan Synacek
--- Changes in v2: - fix additional typo on the same line, doh src/nspawn/nspawn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index 0d8d199..a9b9a3e 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -2754,7 +2754,7 @@

Re: [systemd-devel] [PATCH] nspawn: fix whitespace in partition table blurb

2015-02-23 Thread Jan Synacek
Mantas Mikulėnas graw...@gmail.com writes: While you're at it, -sinlge +single I have no idea how this one escaped me... Will fix, thanks! -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel

Re: [systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-02-22 Thread Jan Synacek
Andrei Borzenkov arvidj...@gmail.com writes: В Fri, 20 Feb 2015 10:56:42 +0100 Jan Synacek jsyna...@redhat.com пишет: To be more consistent with how dracut parses rd.luks.key, it is now allowed to specified it in the format keyfile[:keyfile_device]. Should keyfile_device be provided

Re: [systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-02-20 Thread Jan Synacek
probably make sense. -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

[systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-02-20 Thread Jan Synacek
be appreciated. Once the above problems are sorted out, an extension of this patch (perhaps another patch?) would be to also support the third argument that rd.luks.key can take in dracut. Jan Synacek (1): cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device src/cryptsetup

[systemd-devel] [PATCH] cryptsetup-generator: support rd.luks.key=keyfile:keyfile_device

2015-02-20 Thread Jan Synacek
To be more consistent with how dracut parses rd.luks.key, it is now allowed to specified it in the format keyfile[:keyfile_device]. Should keyfile_device be provided, it needs to be in UUID=uuid-here format. Also, keyfile path is then treated relatively to the root of the keyfile device. If no

Re: [systemd-devel] test-dhcp-client failing in mock builds

2015-02-01 Thread Jan Synacek
/systemd-devel/2014-December/026190.html I haven't got time to properly analyze the problem since then... -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH] systemctl: fix argument handling when invoked as shutdown

2014-12-15 Thread Jan Synacek
--- src/systemctl/systemctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c index 8400bc8..91e8f7c 100644 --- a/src/systemctl/systemctl.c +++ b/src/systemctl/systemctl.c @@ -6942,7 +6942,7 @@ static int

[systemd-devel] [PATCH] virt: fix container detection when we're not PID 1

2014-12-10 Thread Jan Synacek
systemd-detect-virt would print none when using nspawn to run a shell inside a container and then running systemd-detect-virt in it, because the shell would be PID 1, not the actuall systemd-detect-virt process. --- src/shared/virt.c | 19 ++- 1 file changed, 6 insertions(+), 13

Re: [systemd-devel] [PATCH] test: fix some tests when running inside a container

2014-12-10 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: --- src/test/test-execute.c | 2 +- src/test/test-util.c| 3 --- test/udev-test.pl | 8 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/test/test-util.c b/src/test/test-util.c index 20e711d..c055955 100644

[systemd-devel] [PATCH v2] test: fix some tests when running inside a container

2014-12-10 Thread Jan Synacek
--- v2: * don't remove the assert, run in if not in a container src/test/test-execute.c | 2 +- src/test/test-util.c| 4 +++- test/udev-test.pl | 8 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/test/test-execute.c b/src/test/test-execute.c index

[systemd-devel] [PATCH] test: fix some tests when running inside a container

2014-12-10 Thread Jan Synacek
--- src/test/test-execute.c | 2 +- src/test/test-util.c| 3 --- test/udev-test.pl | 8 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/test/test-execute.c b/src/test/test-execute.c index 85deb27..60466f0 100644 --- a/src/test/test-execute.c +++

Re: [systemd-devel] [PATCH] virt: fix container detection when we're not PID 1

2014-12-10 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 10.12.14 09:21, Jan Synacek (jsyna...@redhat.com) wrote: systemd-detect-virt would print none when using nspawn to run a shell inside a container and then running systemd-detect-virt in it, because the shell would be PID 1

Re: [systemd-devel] emergency, rescue and single-user

2014-12-09 Thread Jan Synacek
to the emergency mode that sysvinit already knew: it just starts a shell, and does nothing else. No early-boot services are run. No udev, no file system checks, no nothing. Lennart Thanks for the explanation! -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature

Re: [systemd-devel] emergency, rescue and single-user

2014-12-09 Thread Jan Synacek
. rescue.target pulls in sysinit.target (mounts, swaps, udev, sysctl...), while emergency.target starts a sulogin shell and nothing more. See the graph in bootup(7). Ok, good to know about bootup(7), thanks! -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature

[systemd-devel] [PATCH v2] localed: log xkbcommon errors

2014-12-03 Thread Jan Synacek
The errors are prefixed with libxkbcommon to provide some context, because they are quite confusing without it. With the prefix, we at least know where they come from. --- Changes in v2: - don't log a null message if vasprintf() fails src/locale/localed.c | 19 +++ 1 file

[systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-12-02 Thread Jan Synacek
The errors are prefixed with libxkbcommon, because they are quite confusing. With the prefix, we at least know where they come from. --- src/locale/localed.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-12-02 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 02.12.14 14:02, Jan Synacek (jsyna...@redhat.com) wrote: The errors are prefixed with libxkbcommon, because they are quite confusing. With the prefix, we at least know where they come from. --- src/locale/localed.c | 15

[systemd-devel] [PATCH] localed: log xkbcommon errors

2014-12-02 Thread Jan Synacek
The errors are prefixed with libxkbcommon to provide some context, because they are quite confusing without it. With the prefix, we at least know where they come from. --- src/locale/localed.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-12-01 Thread Jan Synacek
' in the first case and No variant 'QQ' for layout 'us' in the second. So, is it worth logging this information? Any other ideas? Cheers, -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list

[systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-11-25 Thread Jan Synacek
The errors are prefixed with libxkbcommon, because they are quite confusing. With the prefix, we at least know where they come from. --- src/locale/localed.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/locale/localed.c b/src/locale/localed.c index

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-11-25 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi Jan! Hello! On Tue, Nov 25, 2014 at 9:23 AM, Jan Synacek jsyna...@redhat.com wrote: The errors are prefixed with libxkbcommon, because they are quite confusing. With the prefix, we at least know where they come from. --- src/locale/localed.c

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-24 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 14.11.14 12:42, Jan Synacek (jsyna...@redhat.com) wrote: +if (look_for == LAYOUTS) { +Set *s; +char *k; +Iterator i; +/* XXX: Is there a better way to sort

Re: [systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-19 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Fri, Nov 14, 2014 at 12:42 PM, Jan Synacek jsyna...@redhat.com wrote: Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning

[systemd-devel] [PATCH v2] localed: validate set-x11-keymap input

2014-11-14 Thread Jan Synacek
Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning that the user doesn't want any particular variant for the respective layout. Variants are validated respectively to their

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: diff --git a/src/locale/localectl.c b/src/locale/localectl.c index d4a2d29..8f9e4da 100644 --- a/src/locale/localectl.c +++ b/src/locale/localectl.c @@ -46,6 +46,7

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: +int xkb_validate_keymaps(const char *model, + const char *layouts_arg, + const char

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: One more addition: +} + +int xkb_get_keymaps(char ***list, enum keymap_state look_for, const char *layout_prefix) +{ +_cleanup_fclose_ FILE *f; +char line

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

2014-11-07 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: I think that this patch might be a bit ineffective, as it calls unit_file_load() again just to get an InstallContext. I wasn't sure how to get Also= targets in any other way

[systemd-devel] [PATCH] shared/install: when unit contains only Also=, report 'indirect'

2014-11-07 Thread Jan Synacek
Continuation of http://lists.freedesktop.org/archives/systemd-devel/2014-November/025041.html. Jan Synacek (1): shared/install: when unit contains only Also=, report 'indirect' man/systemctl.xml | 5 + src/shared/install.c | 45

[systemd-devel] [PATCH] shared/install: when unit contains only Also=, report 'indirect'

2014-11-07 Thread Jan Synacek
If a unit contains only Also=, with no Alias= or WantedBy=, it shouldn't be reported as static. New 'indirect' status shall be introduced. https://bugzilla.redhat.com/show_bug.cgi?id=864298 --- man/systemctl.xml | 5 + src/shared/install.c | 45

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

2014-11-07 Thread Jan Synacek
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl writes: On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote: On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: Lennart Poettering lenn...@poettering.net writes: On Thu, 06.11.14 10:49, Jan Synacek (jsyna

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

2014-11-07 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: Lennart Poettering lenn...@poettering.net writes: On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: I think that this patch might be a bit ineffective

Re: [systemd-devel] [PATCH] shared/install: when unit contains only Also=, report 'indirect'

2014-11-07 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Fri, 07.11.14 15:18, Jan Synacek (jsyna...@redhat.com) wrote: } if (!isempty(state)) log_syntax(unit, LOG_ERR, filename, line, EINVAL, @@ -1043,7 +1049,8 @@ static int unit_file_load

[systemd-devel] [PATCH v2] shared/install: when unit contains only Also=, report 'indirect'

2014-11-07 Thread Jan Synacek
If a unit contains only Also=, with no Alias= or WantedBy=, it shouldn't be reported as static. New 'indirect' status shall be introduced. https://bugzilla.redhat.com/show_bug.cgi?id=864298 --- Changes in version 2 - don't pass the whole strv to the higher level calls, use bool instead

[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

2014-11-06 Thread Jan Synacek
away. Jan Synacek (1): shared/install: don't report 'static' when unit contains only Also= src/shared/install.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) -- 1.9.3 ___ systemd-devel mailing list systemd-devel

[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

2014-11-06 Thread Jan Synacek
If a unit contains only Also=, with no Alias= or WantedBy=, it shouldn't be reported as static. If any target unit specified in Also= is enabled or disabled, report this unit as enabled or disabled as well. https://bugzilla.redhat.com/show_bug.cgi?id=864298 --- src/shared/install.c | 23

[systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-04 Thread Jan Synacek
As mentioned in [1], it would probably be better if the validation errors were just warnings, but I'm not sure if that can be achieved over dbus. [1] http://lists.freedesktop.org/archives/systemd-devel/2014-October/024129.html Jan Synacek (1): localed: validate set-x11-keymap input

[systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-04 Thread Jan Synacek
Try to validate the input similarly to how setxkbmap does it. Multiple layouts and variants can be specified, separated by a comma. Variants can also be left out, meaning that the user doesn't want any particular variant for the respective layout. Variants are validated respectively to their

[systemd-devel] [PATCH] man/tmpfiles.d: fix typo

2014-11-04 Thread Jan Synacek
--- man/tmpfiles.d.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/tmpfiles.d.xml b/man/tmpfiles.d.xml index f2360ba..1b14d69 100644 --- a/man/tmpfiles.d.xml +++ b/man/tmpfiles.d.xml @@ -108,8 +108,8 @@ filename in lexicographic order, regardless

[systemd-devel] [PATCH] localectl: fix localectl set-x11-keymap syntax description

2014-11-03 Thread Jan Synacek
This complements the fix in commit cd4c6fb12598435fe24431f1dd616f9582f0e3b. --- src/locale/localectl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locale/localectl.c b/src/locale/localectl.c index 3690f9f..d4a2d29 100644 --- a/src/locale/localectl.c +++

Re: [systemd-devel] [PATCH] localectl: fix localectl set-x11-keymap syntax description

2014-11-03 Thread Jan Synacek
David Herrmann dh.herrm...@gmail.com writes: Hi On Mon, Nov 3, 2014 at 2:01 PM, Jan Synacek jsyna...@redhat.com wrote: This complements the fix in commit cd4c6fb12598435fe24431f1dd616f9582f0e3b. Applied! I don't think it was, I can't see the patch anywhere in the logs. Thanks David

Re: [systemd-devel] Switch root slowness

2014-10-31 Thread Jan Synacek
fallback to /dev/urandom on EAGAIN I guess, and always pass GRND_NONBLOCK. I have now implemented that. Please test! Lennart It works now, thanks! -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel

[systemd-devel] [PATCH v3] core: improve error message when machine id is missing

2014-10-31 Thread Jan Synacek
--- Changes in v3: - check correct errno Changes in v2: - show long explanation only when errno == EROFS src/core/machine-id-setup.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c index efb074f..e54b879

Re: [systemd-devel] [PATCH] bash-completion: fix systemctl isolate

2014-10-30 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Jan Synacek (1): bash-completion: fix systemctl isolate I've just tested the latest systemd (commit 81333ec) and after the bash-completion patches, this patch seems obsolete and not needed anymore. -- Jan Synacek Software Engineer, Red Hat

[systemd-devel] [PATCH v2] core: improve error message when machine id is missing

2014-10-30 Thread Jan Synacek
--- Changes in v2: - show long explanation only when errno == EROFS src/core/machine-id-setup.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c index efb074f..2360904 100644 --- a/src/core/machine-id-setup.c

Re: [systemd-devel] Switch root slowness

2014-10-30 Thread Jan Synacek
/systemd/commit/?id=74a550c5d8228 Nope, still slow. -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [systemd-devel] [PATCH] tmpfiles: only change device permissions if mknod succeeded

2014-10-29 Thread Jan Synacek
Poettering lenn...@poettering.net wrote: On Tue, 14.10.14 16:19, Jan Synacek (jsyna...@redhat.com) wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1147248 Hmm, so far tmpfiles always adjust access modes, for all types of lines, if that's possible. I think this makes sense. The bug

Re: [systemd-devel] [PATCH] swap: rework discard

2014-10-29 Thread Jan Synacek
! Lennart Works well on my system. Thanks again! -- Jan Synacek Software Engineer, Red Hat signature.asc Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd

Re: [systemd-devel] Possible documentation problems

2014-10-29 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Wed, 15.10.14 11:07, Jan Synacek (jsyna...@redhat.com) wrote: Hello, in the documentation for systemd.service, under Type= option, it reads: Behavior of oneshot is similar to simple; however, it is expected that the process has

[systemd-devel] [PATCH] core: improve error message when machine id is missing

2014-10-24 Thread Jan Synacek
--- src/core/machine-id-setup.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c index efb074f..eba35be 100644 --- a/src/core/machine-id-setup.c +++ b/src/core/machine-id-setup.c @@ -191,7 +191,11 @@ int

Re: [systemd-devel] Unicode support in console after boot

2014-10-24 Thread Jan Synacek
Michal Sekletar msekl...@redhat.com writes: On Mon, Oct 13, 2014 at 09:36:16AM +0200, Jan Synacek wrote: Hello, currently, unicode characters are not correctly displayed in the console. After login, when I run /usr/bin/unicode_start, unicode works fine. I tried to create a service file

Re: [systemd-devel] Should user mode linux register with machined?

2014-10-24 Thread Jan Synacek
quite a lot of confusion in discussion and patch submission. I'm not sure who to report this to. -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[systemd-devel] [PATCH] swap: rework discard

2014-10-23 Thread Jan Synacek
Instead of a dedicated Discard option, use more general Options. When the swapon command learns -o, it will be possible to pass the value of Options as is. The code now assumes that the only possible value to Options is related to discard.

Re: [systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-23 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 20.10.14 12:43, Jan Synacek (jsyna...@redhat.com) wrote: When setting any of those using set-x11-keymap, check that their values are available on the system. --- src/locale/localectl.c | 208

Re: [systemd-devel] [PATCH] core: improve error message when machine id is missing

2014-10-23 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: --- src/core/machine-id-setup.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/machine-id-setup.c b/src/core/machine-id-setup.c index efb074f..eba35be 100644 --- a/src/core/machine-id-setup.c +++ b/src/core/machine

Re: [systemd-devel] [PATCH] swap: introduce Discard property

2014-10-21 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Mon, 20.10.14 11:08, Karel Zak (k...@redhat.com) wrote: On Fri, Oct 03, 2014 at 07:16:55AM +0200, Jan Synacek wrote: Karel Zak k...@redhat.com writes: Karel, any chance you can add a -o option to swapon? No problem, added to TODO

Re: [systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-20 Thread Jan Synacek
Ran Benita ran...@gmail.com writes: On Fri, Oct 17, 2014 at 02:02:13PM +0200, Jan Synacek wrote: When setting any of those using set-x11-keymap, check that their values are available on the system. I have only skimmed this patch, but generally: 1. There can only be one model. 2. There can

[systemd-devel] [PATCH 1/2] man: fix localectl set-x11-keymap syntax description

2014-10-20 Thread Jan Synacek
--- man/localectl.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/localectl.xml b/man/localectl.xml index 38e73c7..c332027 100644 --- a/man/localectl.xml +++ b/man/localectl.xml @@ -178,7 +178,7 @@ /varlistentry

[systemd-devel] [PATCHv2 0/2] localectl: verify layout, model, variant and options; fix man page

2014-10-20 Thread Jan Synacek
Changes in v2: - correctly verify multiple layouts, variants and options when specified in a comma separated list Jan Synacek (2): man: fix localectl set-x11-keymap syntax description localectl: verify layout, model, variant and options man/localectl.xml | 2 +- src/locale

[systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-20 Thread Jan Synacek
When setting any of those using set-x11-keymap, check that their values are available on the system. --- src/locale/localectl.c | 208 + 1 file changed, 139 insertions(+), 69 deletions(-) diff --git a/src/locale/localectl.c b/src/locale/localectl.c

[systemd-devel] [PATCH 0/2] localectl: verify layout, model, varian and options; fix manpage

2014-10-17 Thread Jan Synacek
Small localectl fixes. Both patches fix https://bugzilla.redhat.com/show_bug.cgi?id=1049306. Jan Synacek (2): man: fix localectl set-x11-keymap syntax description localectl: verify layout, model, variant and options man/localectl.xml | 2 +- src/locale/localectl.c | 179

[systemd-devel] [PATCH 1/2] man: fix localectl set-x11-keymap syntax description

2014-10-17 Thread Jan Synacek
--- man/localectl.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/localectl.xml b/man/localectl.xml index 38e73c7..c332027 100644 --- a/man/localectl.xml +++ b/man/localectl.xml @@ -178,7 +178,7 @@ /varlistentry

[systemd-devel] [PATCH 2/2] localectl: verify layout, model, variant and options

2014-10-17 Thread Jan Synacek
When setting any of those using set-x11-keymap, check that their values are available on the system. --- src/locale/localectl.c | 179 ++--- 1 file changed, 110 insertions(+), 69 deletions(-) diff --git a/src/locale/localectl.c b/src/locale/localectl.c

[systemd-devel] [PATCH] man: fix typos

2014-10-15 Thread Jan Synacek
--- man/systemd.service.xml | 6 +++--- man/systemd.socket.xml | 2 +- man/systemd.swap.xml| 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/man/systemd.service.xml b/man/systemd.service.xml index 50ff2f5..b9604b8 100644 --- a/man/systemd.service.xml +++

[systemd-devel] Possible documentation problems

2014-10-15 Thread Jan Synacek
, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] Possible documentation problems

2014-10-15 Thread Jan Synacek
Mantas Mikulėnas graw...@gmail.com writes: On Oct 15, 2014 12:07 PM, Jan Synacek jsyna...@redhat.com wrote: Hello, in the documentation for systemd.service, under Type= option, it reads: Behavior of oneshot is similar to simple; however, it is expected that the process has to exit

[systemd-devel] [PATCH] tmpfiles: only change device permissions if mknod succeeded

2014-10-14 Thread Jan Synacek
https://bugzilla.redhat.com/show_bug.cgi?id=1147248 --- src/tmpfiles/tmpfiles.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 8108b43..ae0289d 100644 --- a/src/tmpfiles/tmpfiles.c +++

Re: [systemd-devel] Should user mode linux register with machined?

2014-10-13 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Lennart Poettering lenn...@poettering.net writes: On Fri, 10.10.14 18:48, Richard Weinberger (rich...@nod.at) wrote: Lennart, Am 10.10.2014 um 18:44 schrieb Lennart Poettering: It's a bit more complex. While UML, qemu, kvm, currently don't, LXC

[systemd-devel] Unicode support in console after boot

2014-10-13 Thread Jan Synacek
on unicode support in console after boot using a service file? Or any other type of unit? Or is this something that has to be patched in the source (logind perhaps?)? Cheers, -- Jan Synacek Software Engineer, Red Hat ___ systemd-devel mailing list systemd-devel

Re: [systemd-devel] Unicode support in console after boot

2014-10-13 Thread Jan Synacek
Mantas Mikulėnas graw...@gmail.com writes: On Mon, Oct 13, 2014 at 10:36 AM, Jan Synacek jsyna...@redhat.com wrote: Hello, currently, unicode characters are not correctly displayed in the console. After login, when I run /usr/bin/unicode_start, unicode works fine. I tried to create a service

Re: [systemd-devel] Unicode support in console after boot

2014-10-13 Thread Jan Synacek
Andrei Borzenkov arvidj...@gmail.com writes: On Mon, Oct 13, 2014 at 12:48 PM, Jan Synacek jsyna...@redhat.com wrote: Mantas Mikulėnas graw...@gmail.com writes: On Mon, Oct 13, 2014 at 10:36 AM, Jan Synacek jsyna...@redhat.com wrote: Hello, currently, unicode characters are not correctly

Re: [systemd-devel] Unicode support in console after boot

2014-10-13 Thread Jan Synacek
Andrei Borzenkov arvidj...@gmail.com writes: On Mon, Oct 13, 2014 at 4:33 PM, Jan Synacek jsyna...@redhat.com wrote: Andrei Borzenkov arvidj...@gmail.com writes: On Mon, Oct 13, 2014 at 12:48 PM, Jan Synacek jsyna...@redhat.com wrote: Mantas Mikulėnas graw...@gmail.com writes: On Mon, Oct 13

[systemd-devel] [PATCH] bash-completion: fix systemctl isolate

2014-10-09 Thread Jan Synacek
I didn't dare fix this in zsh completion (not sure if it's required, though, so I didn't even remove the TODO entry that mentions this fix is required). Jan Synacek (1): bash-completion: fix systemctl isolate shell-completion/bash/systemctl.in | 4 +++- 1 file changed, 3 insertions(+), 1

  1   2   >