Re: [systemd-devel] systemd doesn't see ttyPS0 devices from udev

2020-09-23 Thread Michael Olbrich
Hi, On Wed, Sep 23, 2020 at 04:58:57PM +0800, ZhouPeng wrote: > I find that boot with the 'rescue' option, then exit 'rescue' mode, then > I can login to the ttyPS0, as below You're using a custom kernel, right? Please check the README in the systemd source tree. Specifically the kernel config op

Re: [systemd-devel] Bugfix release(s)

2019-02-03 Thread Michael Olbrich
On Tue, Jan 15, 2019 at 01:12:13PM +0100, Lennart Poettering wrote: > On Di, 15.01.19 09:51, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > On Mon, Jan 14, 2019 at 04:36:49PM +0100, Lennart Poettering wrote: > > > I'd love to see some more CI hookup with Arch

Re: [systemd-devel] Bugfix release(s)

2019-01-15 Thread Michael Olbrich
On Mon, Jan 14, 2019 at 04:36:49PM +0100, Lennart Poettering wrote: > I'd love to see some more CI hookup with Arch and Debian for example > (right now there is zero) or even just a git preview package set or so > that interested people can test. Without either it's very likely that > things break

Re: [systemd-devel] ShutdownWatchdogSec does not work as described

2018-03-19 Thread Michael Olbrich
On Mon, Mar 19, 2018 at 11:41:33AM +0530, prashantkumar dhotre wrote: > I am observing that ShutdownWatchdogSec setting in system.conf > > In man page, for ShutdownWatchdogSec, I see : > " It works as a safety net to ensure that the reboot takes place even if a > clean reboot attempt times

Re: [systemd-devel] stacked automounts

2017-11-26 Thread Michael Olbrich
On Fri, Nov 24, 2017 at 09:03:23PM +0100, Olaf Hering wrote: > Is there a way to have stacked automounts? Not really. > In this example only /d is mounted when /d/l/1/ is accessed: > > LABEL=d/d xfs > noatime,x-systemd.automount,x-systemd.idle-timeout=22 1 2 > /d/i/1.iso /d/l/1 iso9

Re: [systemd-devel] automount expiry breaks further automounts (was Re: why does bootctl default to /boot and not to /boot/efi?)

2016-06-04 Thread Michael Olbrich
On Thu, Jun 02, 2016 at 08:03:31AM +0300, Mantas Mikulėnas wrote: > On Wed, Jun 1, 2016 at 4:51 PM, Lennart Poettering > wrote: > > > On Wed, 01.06.16 09:15, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > > > I'd buy into it if vfat weren't so brittle – several times I had to use > > > syslinu

Re: [systemd-devel] [HEADSUP] systemd-222 around the corner

2015-07-07 Thread Michael Olbrich
On Tue, Jul 07, 2015 at 10:57:32AM +0200, Kay Sievers wrote: > On Tue, Jul 7, 2015 at 10:10 AM, Michael Olbrich > wrote: > > On Mon, Jul 06, 2015 at 07:54:41PM +0200, David Herrmann wrote: > >> We intend to release v222 tomorrow. If anyone has open issues that > >&

Re: [systemd-devel] [HEADSUP] systemd-222 around the corner

2015-07-07 Thread Michael Olbrich
Hi, On Mon, Jul 06, 2015 at 07:54:41PM +0200, David Herrmann wrote: > We intend to release v222 tomorrow. If anyone has open issues that > need to be in that release, please speak up. Right now, the release > consists almost exclusively of bug-fixes, and we want to get those > into distributions.

Re: [systemd-devel] no tar balls at release time

2015-06-23 Thread Michael Olbrich
On Mon, Jun 22, 2015 at 10:21:18PM -0400, Mike Gilbert wrote: > On Mon, Jun 22, 2015 at 7:30 PM, Lennart Poettering > wrote: > > On Tue, 23.06.15 01:21, Kay Sievers (k...@vrfy.org) wrote: > > > >> We currently considering to stop creating release tar balls. > >> > >> For build systems which still

Re: [systemd-devel] Minimum required gcc version?

2015-06-18 Thread Michael Olbrich
Hi, On Thu, Jun 18, 2015 at 03:20:04PM +0200, Lennart Poettering wrote: > On Thu, 18.06.15 14:29, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > Do we have a minimum required gcc version? The README just lists gcc > > without any version. However the current git fails to bui

[systemd-devel] Minimum required gcc version?

2015-06-18 Thread Michael Olbrich
Hi, Do we have a minimum required gcc version? The README just lists gcc without any version. However the current git fails to build with gcc-4.7: In this version, gcc produces -Wshadow warnings for variables with the same name as a defined function (e.g. 'now' in several functions in src/core/dev

Re: [systemd-devel] [HEADSUP] Intend to release 221 by the end of the week

2015-06-18 Thread Michael Olbrich
On Mon, Jun 15, 2015 at 05:07:05PM +0200, Lennart Poettering wrote: > People asked for a heads-up on this: I intend to prepare v221 by the > end of this week. Thanks! > It's a good time to start testing what's currently in git! > > If you take this as hint to start your auto-builder however, th

Re: [systemd-devel] [PATCH] random-util: guard including sys/auxv.h with the corresponding ifdef check

2015-06-02 Thread Michael Olbrich
On Tue, Jun 02, 2015 at 02:09:36PM +0200, Umut Tezduyar Lindskog wrote: > http://lists.freedesktop.org/archives/systemd-devel/2015-May/032473.html Oh, I missed that patch. I need to read the mails more carefully :-) Michael > On Tue, Jun 2, 2015 at 11:07 AM, Michael Olbrich &g

[systemd-devel] [PATCH] missing: add more btrfs defines

2015-06-02 Thread Michael Olbrich
--- src/shared/missing.h | 28 1 file changed, 28 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index 919400949138..be7f6186fcfb 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -269,6 +269,11 @@ struct btrfs_qgroup_inherit {

[systemd-devel] [PATCH] random-util: guard including sys/auxv.h with the corresponding ifdef check

2015-06-02 Thread Michael Olbrich
--- src/shared/random-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/random-util.c b/src/shared/random-util.c index 88f5182508e7..b230044f5099 100644 --- a/src/shared/random-util.c +++ b/src/shared/random-util.c @@ -23,7 +23,9 @@ #include #include #include +#ifdef HA

[systemd-devel] [PATCH] missing: add more IFLA_VXLAN_* defines

2015-05-25 Thread Michael Olbrich
Otherwise building faild with kernel headers < v3.16 --- configure.ac | 2 +- src/shared/missing.h | 11 +-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 48cedb5ab61a..0818dd80cf0c 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [systemd-devel] [PATCH] tmpfiles: try to handle read-only file systems gracefully

2015-05-06 Thread Michael Olbrich
On Wed, May 06, 2015 at 04:11:57AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Apr 30, 2015 at 08:50:38PM +0200, Michael Olbrich wrote: > > On read-only filesystems trying to create the target will not fail with > > EEXIST but with EROFS. Handle EROFS by checking if the

[systemd-devel] [PATCH] tmpfiles: try to handle read-only file systems gracefully

2015-04-30 Thread Michael Olbrich
On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. Handle EROFS by checking if the target already exists, and if empty when truncating. This avoids reporting errors if tmpfiles doesn't actually needs to do anything. --- This is a rework of a patch I wrot

[systemd-devel] [PATCH] tmpfiles: remember errno before it might be overwritten

2015-04-30 Thread Michael Olbrich
--- I'm not sure if this is really necessary right now, but that might change in the future. Saving errno before calling another function is always a good idea. Michael src/tmpfiles/tmpfiles.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/sr

[systemd-devel] [PATCH] shared/utmp-wtmp: fix copy/paste error

2015-04-30 Thread Michael Olbrich
--- src/shared/utmp-wtmp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/utmp-wtmp.h b/src/shared/utmp-wtmp.h index 6ac2c7b1c768..5d26ba6fb1d0 100644 --- a/src/shared/utmp-wtmp.h +++ b/src/shared/utmp-wtmp.h @@ -65,7 +65,7 @@ static inline int utmp_wall(

Re: [systemd-devel] [PATCH v2] automount: add expire support

2015-04-21 Thread Michael Olbrich
On Tue, Apr 21, 2015 at 08:45:30PM +0200, Lennart Poettering wrote: > On Tue, 14.04.15 22:01, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > I added some more logging (so that automount_dispatch_expire() can > never fail without this being logged) and applied it! > >

[systemd-devel] [PATCH v2] automount: add expire support

2015-04-14 Thread Michael Olbrich
--- Changes in v2: - addressed comments - check every MAX(a->timeout_idle_usec/10, USEC_PER_SEC) instead of every 5 seconds man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 221

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-14 Thread Michael Olbrich
On Thu, Apr 02, 2015 at 12:54:00PM +0200, Lennart Poettering wrote: > On Sun, 22.03.15 13:36, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > Love this work! Thanks. [...] > > + > > +if (a->expire_event_source) { > > +

[systemd-devel] [PATCH] automount: add expire support

2015-03-22 Thread Michael Olbrich
--- man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 209 -- src/core/automount.h | 6 +- src/core/dbus-automount.c | 1 + src/core/load-fragment-

Re: [systemd-devel] experiments with 'minimal build'

2015-03-21 Thread Michael Olbrich
On Thu, Mar 19, 2015 at 11:37:41PM -0700, Alison Chaiken wrote: > Jeff Waugh: > >The last + is +SYSVINIT, but there doesn't appear to be a configure option > >to disable sysvinit compatibility anymore. > > I was wondering about that myself. Try --with-sysvinit-path="" --with-sysvrcnd-path="". Tha

Re: [systemd-devel] [PATCH] missing.h: add more btrfs types and defines

2015-03-19 Thread Michael Olbrich
On Thu, Mar 19, 2015 at 02:05:00PM +0100, David Herrmann wrote: > On Wed, Mar 18, 2015 at 2:04 PM, Michael Olbrich > wrote: > > it seems we're getting a lot of btrfs stuff here. Maybe we should ship a > > copy of btrfs.h instead? > > All these definitions where in

[systemd-devel] [PATCH] missing.h: add more btrfs types and defines

2015-03-18 Thread Michael Olbrich
--- Hi, it seems we're getting a lot of btrfs stuff here. Maybe we should ship a copy of btrfs.h instead? Michael src/shared/missing.h | 151 +++ 1 file changed, 151 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index 80

[systemd-devel] [PATCH] missing.h: add NDA_*

2015-03-09 Thread Michael Olbrich
This is necessary to build with older kernel headers. NDA_VLAN was introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10 --- configure.ac | 4 +++- src/shared/missing.h | 16 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configu

[systemd-devel] unaligned write in dhcp_identifier_set_iaid

2015-02-24 Thread Michael Olbrich
Hi, there is an unaligned write in dhcp_identifier_set_iaid() and I'm not quite sure what the correct fix is: int dhcp_identifier_set_iaid(int ifindex, uint8_t *mac, size_t mac_len, uint32_t *_id) { [...] *_id = (id & 0x) ^ (id >> 32); [...] } And this is called with: r = dhcp_i

[systemd-devel] [PATCH] systemctl: don't update the reboot parameter if none is given

2015-02-08 Thread Michael Olbrich
Otherwise systemd-reboot.service will remove the parameter that was set before. This was broken in commit "b986229efe2cc96157aa14c37bab7843311bbef1 systemctl: bugfix for systemctl reboot command with argument" --- This is more a hack than anything else, but I'm not sure who to fix this otherwise.

[systemd-devel] [PATCH] config_parse_set_status: put signals in the correct set

2015-01-30 Thread Michael Olbrich
This was broken when the code was rearranged in "1e2fd62d70ff core/load-fragment.c: correct argument sign and split up long lines" --- src/core/load-fragment.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 516

[systemd-devel] [PATCH] missing: define correct syscall numbers for memfd_create() and getrandom() on aarch64

2015-01-26 Thread Michael Olbrich
--- Hi, I've tested getrandom(): With 384 the kernel dumps a warning, because the syscall does not exist. With 278 the syscall tracer tells me that it's called when I run e.g. journalctl, so that looks good. I've not tested memfd_create() but it's defined right below getrandom() in asm-generic/un

Re: [systemd-devel] Build errors with lto and compat-libs

2014-08-28 Thread Michael Olbrich
On Tue, Aug 26, 2014 at 09:42:38PM +0200, Lennart Poettering wrote: > On Tue, 26.08.14 15:15, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > On Mon, Aug 18, 2014 at 03:48:09PM +0200, Lennart Poettering wrote: > > > On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pen

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-26 Thread Michael Olbrich
On Thu, Aug 21, 2014 at 01:51:50PM +0200, Michal Sekletar wrote: > On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: > > BPF_XOR was introduced in kernel 3.7 > > --- > > > > This fixes compiling systemd for me. I'm not sure about the implication

Re: [systemd-devel] Build errors with lto and compat-libs

2014-08-26 Thread Michael Olbrich
On Mon, Aug 18, 2014 at 03:48:09PM +0200, Lennart Poettering wrote: > On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > With --enable-compat-libs building fails like this: > > > > CCLD libsystemd-journal.la > > [...] > > /

[systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-21 Thread Michael Olbrich
BPF_XOR was introduced in kernel 3.7 --- This fixes compiling systemd for me. I'm not sure about the implications of this. I'm not sure what happens if the code using it is executed on a linux kernel < 3.7 Michael src/shared/missing.h | 4 1 file changed, 4 insertions(+) diff --git a/src/

[systemd-devel] Build errors with lto and compat-libs

2014-08-17 Thread Michael Olbrich
Hi, With --enable-compat-libs building fails like this: CCLD libsystemd-journal.la [...] /tmp/ccISOiYU.ltrans1.ltrans.o: In function `sd_journal_process': ccISOiYU.ltrans1.o:(.text+0x0): multiple definition of `sd_journal_process' libsystemd_journal_internal_la-sd-journal.o (symbol from plu

[systemd-devel] [PATCH 2/2] tmpfiles: explicitly check for existing files

2014-08-17 Thread Michael Olbrich
On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. --- Some more cases that fail on read-only filesystems. src/tmpfiles/tmpfiles.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles

[systemd-devel] [PATCHv2 1/2] tmpfiles: only execute chmod()/chown() when needed

2014-08-17 Thread Michael Olbrich
This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system --- Changes since v1: - remember if stat() was successful and use it everywhere. The original code checked for 'stat() >= 0'. Any reason for that

Re: [systemd-devel] Changing configurations with networkd

2014-08-15 Thread Michael Olbrich
On Thu, Aug 14, 2014 at 05:38:05PM +0200, Lennart Poettering wrote: > On Fri, 25.07.14 09:48, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > What I'm _not_ seeing, and what usually comes when anything else changes in > > the network configuration is: > > sy

Re: [systemd-devel] [PATCH] resolved: don't fail if IPv6 is not available

2014-08-14 Thread Michael Olbrich
On Wed, Aug 13, 2014 at 03:04:20PM +0200, Lennart Poettering wrote: > I applied a different patch now that makes sure we either get the full > IPv6 support or none at all, and doesn't generate a warning. > > Please have a look, if this fixes things for you. This work now. However I had to revert

[systemd-devel] [PATCH] resolved: don't fail if IPv6 is not available

2014-08-13 Thread Michael Olbrich
--- src/resolve/resolved-manager.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-manager.c b/src/resolve/resolved-manager.c index a2de2ed..7063af5 100644 --- a/src/resolve/resolved-manager.c +++ b/src/resolve/resolved-manager.c @@ -429,7 +429,9 @@

[systemd-devel] systemd-resolved fails without IPv6

2014-08-12 Thread Michael Olbrich
Hi, Without IPv6 systemd-resolved fails to start with: Failed to start manager: Address family not supported by protocol strace tells me this is the errno from socket(): [...] socket(PF_INET6, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = -1 EAFNOSUPPORT (Address family not supported by

Re: [systemd-devel] assert() when restarting systemd-networkd

2014-08-12 Thread Michael Olbrich
On Wed, Jul 30, 2014 at 06:09:44PM +0200, Tom Gundersen wrote: > On Sun, Jul 20, 2014 at 3:12 PM, Michael Olbrich > wrote: > > with the current git master (v215-293-g4e6029435111) restarting > > systemd-networkd triggers an assert() here: > > > > In netdev_join

Re: [systemd-devel] [patch] #include src/shared/missing.h in src/shared/util.h for missing struct file_handle definition

2014-08-01 Thread Michael Olbrich
On Fri, Aug 01, 2014 at 06:37:51PM +0300, Samuli Suominen wrote: > On 01/08/14 18:31, Simon McVittie wrote: > > On 01/08/14 15:53, Simon McVittie wrote: > >> Best-practice in Autotools projects seems to be to include config.h at > >> the very top of every .c file, whether it is currently needed or

Re: [systemd-devel] [PATCH] tmpfiles: only execute chmod()/chown() when needed

2014-07-31 Thread Michael Olbrich
On Fri, Jul 11, 2014 at 03:05:05PM +0200, Michael Olbrich wrote: > This avoids errors like this, when the paths are already there with the > correct permissions and owner: > > chmod(/var/spool) failed: Read-only file system Ping. These warnings are rather annoying and they make it

Re: [systemd-devel] Changing configurations with networkd

2014-07-25 Thread Michael Olbrich
Hi, On Fri, Jul 25, 2014 at 11:00:27AM +0200, Brendan Hide wrote: > On 24/07/14 14:05, Marcel Holtmann wrote: > >[snip] > >>... you already are getting > >>assigned the correct IP address at first, and then only later does > >>this change. What is causing your DHCP server to send out a different >

Re: [systemd-devel] Changing configurations with networkd

2014-07-25 Thread Michael Olbrich
Hi, On Thu, Jul 24, 2014 at 11:58:15PM +0200, Tom Gundersen wrote: > On Thu, Jul 24, 2014 at 10:54 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Thu, Jul 24, 2014 at 09:18:14PM +0200, Tom Gundersen wrote: > >> A quick fix would be to set > >> > >> /proc/sys/net/ipv4/conf/all/promote_secondaries

Re: [systemd-devel] Changing configurations with networkd

2014-07-24 Thread Michael Olbrich
On Thu, Jul 24, 2014 at 02:05:24PM +0200, Marcel Holtmann wrote: > > Right, I spoke too quickly. What I don't want is to preserve state > > between reboots, preserving it between restarts of networkd would > > indeed be fine. We already serialize the dhcp leases to /run, so I'd > > be happy to take

Re: [systemd-devel] Changing configurations with networkd

2014-07-24 Thread Michael Olbrich
On Wed, Jul 23, 2014 at 04:46:26PM +0200, Marcel Holtmann wrote: > Hi Michael, > > >>> I think the lease should be remembered and reused in this case. > >> > >> Hm, this sounds like a bug somewhere. When the new discover is sent > >> out it should send the same identifying information to the serv

Re: [systemd-devel] Changing configurations with networkd

2014-07-23 Thread Michael Olbrich
On Wed, Jul 23, 2014 at 12:47:37PM +0200, Tom Gundersen wrote: > On Wed, Jul 23, 2014 at 9:50 AM, Michael Olbrich > wrote: > > I've been experimenting with systemd-networkd to see where it fits my > > use-cases. I'm looking for some insight if the issues I'm seein

[systemd-devel] Changing configurations with networkd

2014-07-23 Thread Michael Olbrich
Hi, I've been experimenting with systemd-networkd to see where it fits my use-cases. I'm looking for some insight if the issues I'm seeing are bugs, features just not implemented yet or if my use-case is out of scope for networkd. The most common use-case I have is rather simple: One ethernet inte

[systemd-devel] assert() when restarting systemd-networkd

2014-07-20 Thread Michael Olbrich
Hi, with the current git master (v215-293-g4e6029435111) restarting systemd-networkd triggers an assert() here: In netdev_join_handler(): assert(IN_SET(link->state, LINK_STATE_ENSLAVING, LINK_STATE_FAILED, LINK_STATE_LINGER)); gdb tells me that link->state is LINK_S

[systemd-devel] [PATCH] install: systemd-timesyncd.service is enabled by sysinit.target

2014-07-17 Thread Michael Olbrich
systemd-timesyncd.service has a "WantedBy=sysinit.target" so the initially generated link should match that. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index db846ad..d1e3b0b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4507,7 +4

Re: [systemd-devel] [PATCH] tmpfiles: only execute chmod()/chown() when needed

2014-07-16 Thread Michael Olbrich
On Fri, Jul 11, 2014 at 03:52:21PM -0700, Colin Walters wrote: > On Fri, Jul 11, 2014, at 03:04 PM, Dave Reisner wrote: > > No way. This precludes tmpfiles from creating directories in /run. > > Yeah that suggestion would break other stuff too, ignore it. > > This does get into the ostree commit

[systemd-devel] [PATCH] units/serial-getty@.service: use the default RestartSec

2014-07-15 Thread Michael Olbrich
For pluggable ttys such as USB serial devices, the getty is restarted and exits in a loop until the remove event reaches systemd. Under certain circumstances the restart loop can overload the system in a way that prevents the remove event from reaching systemd for a long time (e.g. at least several

Re: [systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

2014-07-11 Thread Michael Olbrich
On Fri, Jul 11, 2014 at 04:01:32PM +0200, Lennart Poettering wrote: > On Fri, 11.07.14 15:43, Dan Horák (d...@danny.cz) wrote: > > > Hmm, the sources currently use three different ways to detect > > > endianess: > > > > > > 1) WORDS_BIGENDIAN (which appears to be an autoconf thing actually, > > >

Re: [systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

2014-07-11 Thread Michael Olbrich
On Fri, Jul 11, 2014 at 03:27:56PM +0200, Lennart Poettering wrote: > On Fri, 11.07.14 15:04, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > gcc does not define WORDS_BIGENDIAN for big-endian PowerPC. It defines > > __BIG_ENDIAN__ instead. So also check for __BIG_ENDIAN

[systemd-devel] [PATCH] tmpfiles: only execute chmod()/chown() when needed

2014-07-11 Thread Michael Olbrich
This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system --- src/tmpfiles/tmpfiles.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/tmpfile

[systemd-devel] [PATCH] architecture: fix building for big-endian PowerPC with gcc

2014-07-11 Thread Michael Olbrich
gcc does not define WORDS_BIGENDIAN for big-endian PowerPC. It defines __BIG_ENDIAN__ instead. So also check for __BIG_ENDIAN__ to determine if the system is big-endian. --- src/shared/architecture.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/architecture.h

[systemd-devel] [PATCH] install: enable timesyncd by default

2014-06-25 Thread Michael Olbrich
This treats it similarly to networkd, resolved and others and it matches what 90-systemd.preset does. --- Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile.am b/Makefile.am index 4b292b2..bfef1c3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -4301,6 +4301,9 @@ rootlibexec

[systemd-devel] systemd-networkd-wait-online and network.target

2014-06-25 Thread Michael Olbrich
Hi, Commit 58e027023b47b32e42cf93dd4a629b869ee1ef25 'units: order network-online.target after network.target' added "Before=network.target" dependency to systemd-networkd-wait-online.service. Is that correct? If I understand the documentation correctly, then network.target should not be delayed. M

[systemd-devel] [PATCH v2 2/2] service: rename StartLimitAction enum to FailureAction

2014-04-24 Thread Michael Olbrich
It's used for the FailureAction property as well. --- Changes since v1: - rebased on latest master - also rename things in src/test/test-tables.c src/core/dbus-service.c | 6 +++--- src/core/load-fragment-gperf.gperf.m4 | 4 ++-- src/core/load-fragment.c | 4 ++-- sr

[systemd-devel] [PATCH v2 1/2] service: add FailureAction= option

2014-04-24 Thread Michael Olbrich
It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- Changes since v1: - rebased on latest master man/systemd.service.xml | 11 ++ src/core/dbus-service.c | 1 + src/core/load-fragment-gperf.gperf.m4 | 1 +

[systemd-devel] [PATCH 2/2] service: rename StartLimitAction enum to FailureAction

2014-04-14 Thread Michael Olbrich
It's used for the FailureAction property as well. --- src/core/dbus-service.c | 6 +++--- src/core/load-fragment-gperf.gperf.m4 | 4 ++-- src/core/load-fragment.c | 4 ++-- src/core/load-fragment.h | 2 +- src/core/service.c| 28 +

[systemd-devel] [PATCH 1/2] service: add FailureAction= option

2014-04-14 Thread Michael Olbrich
It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- man/systemd.service.xml | 11 +++ src/core/dbus-service.c | 1 + src/core/load-fragment-gperf.gperf.m4 | 1 + src/core/service.c| 35 ++

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

2014-04-12 Thread Michael Olbrich
On Fri, Apr 11, 2014 at 04:07:46PM +0200, Lennart Poettering wrote: > On Fri, 11.04.14 09:48, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > > +else if (allow_restart && > > > > > > I would drop the "else" here, I think. Is ther

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

2014-04-11 Thread Michael Olbrich
On Fri, Apr 11, 2014 at 03:34:42AM +0200, Lennart Poettering wrote: > On Wed, 26.03.14 10:02, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > It has the same possible values as StartLimitAction= and is executed > > immediately if a service fails. > > I think the e

Re: [systemd-devel] [PATCH 1/2] systemctl: delete REBOOT_PARAM_FILE if no parameter is specified

2014-04-10 Thread Michael Olbrich
On Tue, Mar 25, 2014 at 02:15:44PM +0100, Michael Olbrich wrote: > And move it to sperate function. Ping! No comments at all? Michael > --- > src/shared/util.c | 16 > src/shared/util.h | 2 ++ > src/systemctl/systemctl.c | 9 +++-- > 3

[systemd-devel] systemd v212 build error

2014-03-28 Thread Michael Olbrich
Hi, compiling systemd v212 fails here with: [...] src/libsystemd/sd-rtnl/rtnl-message.c: In function 'sd_rtnl_message_append_u8': src/libsystemd/sd-rtnl/rtnl-message.c:462:38: error: 'IFLA_IPTUN_TTL' undeclared (first use in this function) src/libsystemd/sd-rtnl/rtnl-message.c:462:38: note: each

Re: [systemd-devel] [RFC PATCH] service: add FailureAction= option

2014-03-26 Thread Michael Olbrich
On Wed, Mar 26, 2014 at 10:19:53AM +, "Jóhann B. Guðmundsson" wrote: > On 03/26/2014 09:02 AM, Michael Olbrich wrote: > >It has the same possible values as StartLimitAction= and is executed > >immediately if a service fails. > >--- > > > >Hi Lennart

[systemd-devel] [RFC PATCH] service: add FailureAction= option

2014-03-26 Thread Michael Olbrich
It has the same possible values as StartLimitAction= and is executed immediately if a service fails. --- Hi Lennart, Something like this maybe? I'm not quite sure about the condition in service_enter_dead(). I don't think the action should be executed when the service is explicitly stopped. Maybe

Re: [systemd-devel] [RFC PATCH] service: add Restart option to execute StartLimitAction immediately

2014-03-25 Thread Michael Olbrich
Hi, On Mon, Mar 24, 2014 at 08:30:09PM +0100, Lennart Poettering wrote: > On Thu, 20.03.14 12:52, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > The idea is to reboot immediately when a service crashes or the watchdog > > triggers. This is useful in embedded scenarios whe

[systemd-devel] [PATCH 2/2] service: add support for reboot argument when triggered by StartLimitAction=

2014-03-25 Thread Michael Olbrich
When rebooting with systemctl, an optional argument can be passed to the reboot system call. This makes it possible the specify the argument in a service file and use it when the service triggers a restart. This is useful to distinguish between manual reboots and reboots caused by failing services.

[systemd-devel] [PATCH 1/2] systemctl: delete REBOOT_PARAM_FILE if no parameter is specified

2014-03-25 Thread Michael Olbrich
And move it to sperate function. --- src/shared/util.c | 16 src/shared/util.h | 2 ++ src/systemctl/systemctl.c | 9 +++-- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/src/shared/util.c b/src/shared/util.c index ffe6624..0260d17 100644 ---

[systemd-devel] [PATCH] service: add support for reboot argument when triggered by StartLimitAction=

2014-03-21 Thread Michael Olbrich
When rebooting with systemctl, an optional argument can be passed to the reboot system call. This makes it possible the specify the argument in a service file and use it when the service triggers a restart. This is useful to distinguish between manual reboots and reboots caused by failing services.

[systemd-devel] [RFC PATCH] service: add Restart option to execute StartLimitAction immediately

2014-03-20 Thread Michael Olbrich
--- Hi, The idea is to reboot immediately when a service crashes or the watchdog triggers. This is useful in embedded scenarios when there is only one important service. There are use-cases where rebooting immediately instead of trying to restart the application first makes sense. The environment

[systemd-devel] [PATCH] networkd: fix typo

2014-03-14 Thread Michael Olbrich
It's HAVE_SPLIT_USR not HAVE_SPLIT_USER --- src/network/networkd-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd-manager.c b/src/network/networkd-manager.c index c730e71..ea414b1 100644 --- a/src/network/networkd-manager.c +++ b/src/network/networ

Re: [systemd-devel] [patch] Fix AC_PATH_PROG usage in configure.ac for systems with (still) bin vs. sbin distiction

2014-03-10 Thread Michael Olbrich
On Mon, Mar 10, 2014 at 02:13:38PM +0200, Samuli Suominen wrote: > On 10/03/14 13:23, Michael Olbrich wrote: > > On Sun, Mar 09, 2014 at 08:49:58PM +0100, Michael Biebl wrote: > >> 2014-03-08 8:52 GMT+01:00 Samuli Suominen : > >>> If eg. setcap is in /sbin and use

Re: [systemd-devel] [patch] Fix AC_PATH_PROG usage in configure.ac for systems with (still) bin vs. sbin distiction

2014-03-10 Thread Michael Olbrich
On Sun, Mar 09, 2014 at 08:49:58PM +0100, Michael Biebl wrote: > 2014-03-08 8:52 GMT+01:00 Samuli Suominen : > > If eg. setcap is in /sbin and user is building as a normal user without > > $PATH having /sbin, the build system > > will default to /usr/sbin/setcap as it's defined in AC_PATH_PROG and

Re: [systemd-devel] [PATCH RFC] namespace: make sure ReadWriteDirectories are actually writable

2013-12-27 Thread Michael Olbrich
On Fri, Dec 27, 2013 at 05:52:16PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Dec 27, 2013 at 10:18:30AM +0100, Michael Olbrich wrote: > > Currently adding directories to ReadWriteDirectories= only restores the > > original mount flags. So e.g. setting ReadOnlyDirec

[systemd-devel] [PATCH RFC] namespace: make sure ReadWriteDirectories are actually writable

2013-12-27 Thread Michael Olbrich
Currently adding directories to ReadWriteDirectories= only restores the original mount flags. So e.g. setting ReadOnlyDirectories=/usr and ReadWriteDirectories=/usr/local works as expected if the underlying file system was writable. However, setting ReadWriteDirectories= has no effect if the underl

Re: [systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

2013-07-17 Thread Michael Olbrich
Hi, On Wed, Jul 17, 2013 at 03:53:09AM +0200, Lennart Poettering wrote: > On Wed, 12.06.13 01:22, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > If ExecStopPost= is defined then it is executed after SIGKILL. Otherwise > > another round of SIGTERM/SIGSTOP is start

Re: [systemd-devel] [PATCH] service: don't enter a second SIGTERM/SIGKILL cycle if no ExecStopPost= process is defined

2013-06-21 Thread Michael Olbrich
On Wed, Jun 12, 2013 at 08:45:35AM +0200, Michael Olbrich wrote: > It won't help if the main process is still there and there is no new > process to kill. > --- > > Hi, > > The second SIGTERM/SIGKILL is to kill ExecStopPost= if necessary, right? In > that case, th

[systemd-devel] [PATCH] service: don't enter a second SIGTERM/SIGKILL cycle if no ExecStopPost= process is defined

2013-06-11 Thread Michael Olbrich
It won't help if the main process is still there and there is no new process to kill. --- Hi, The second SIGTERM/SIGKILL is to kill ExecStopPost= if necessary, right? In that case, this is a better solution. Michael src/core/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [systemd-devel] start/stop messages when activating a target?

2013-06-11 Thread Michael Olbrich
Hi, On Wed, Jun 12, 2013 at 07:02:34AM +0400, Andrey Borzenkov wrote: > В Wed, 12 Jun 2013 01:32:37 +0200 > Michael Olbrich пишет: > > > Hi, > > > > When booting or during shutdown systemd prints the start stop messages for > > the services. Is it possible to g

[systemd-devel] start/stop messages when activating a target?

2013-06-11 Thread Michael Olbrich
Hi, When booting or during shutdown systemd prints the start stop messages for the services. Is it possible to get those messages when activating a target with systemctl? Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions

[systemd-devel] [PATCH] service: don't try to kill the service more than once when the watchdog timeout hits

2013-06-11 Thread Michael Olbrich
If ExecStopPost= is defined then it is executed after SIGKILL. Otherwise another round of SIGTERM/SIGSTOP is started which is rather useless when the watchdog timeout hits. So go directly to the final SIGKILL if ExecStopPost= is not defined. --- Hi, I did some more testing with this. I think this

Re: [systemd-devel] Solution proposal for bug 56109

2013-05-19 Thread Michael Olbrich
Hi, On Thu, May 16, 2013 at 06:23:15PM +0200, markoho...@freenet.de wrote: > I recently stumbled over the bug with the watchdog mechanism that has already > been reported to free desktop bugzilla (56109). >   > I analyzed the bug and came to a simple solution for solving it. >   > First, what I t

[systemd-devel] [PATCH] service: kill processes with SIGKILL on watchdog failure

2013-05-19 Thread Michael Olbrich
Just calling service_enter_dead() does not kill any processes. As a result, the old process may still be running when the new one is started. After a watchdog failure the service is in an undefined state. Using the normal shutdown mechanism makes no sense. Instead all processes are just killed and

[systemd-devel] Is the format of hwdb.bin platform independent?

2013-05-15 Thread Michael Olbrich
Hi, I'm using udev/systemd in embedded scenarios and I don't like generating hwdb.bin on the target hardware. So I built a host udevadm to create it. It is save to do that? Generating hwdb.bin on x86_64 and using it on ARM seems to work, but what about endianness? Regards, Michael -- Pengutroni

[systemd-devel] build problems without largefile support

2013-05-15 Thread Michael Olbrich
Hi, I tried to compile systemd with "--disable-largefile" and I got this: [...] src/shared/util.c: In function 'parse_bytes': src/shared/util.c:2270:17: error: overflow in implicit constant conversion [-Werror=overflow] src/shared/util.c:2271:17: error: overflow in implicit constant conversion [

[systemd-devel] [PATCH] ratelimit: fix off-by-one

2013-02-12 Thread Michael Olbrich
The current code might make sense during startup for service restart limiting: With burst=1 after starting num is 1, so the next ('first') restart is still accepted ( 1 <= 1). However, once interval has expired, num is 1 after the first restart, so the second restart is also accepted. This change

Re: [systemd-devel] Suggestion on StartLimitAction=

2013-02-03 Thread Michael Olbrich
On Fri, Feb 01, 2013 at 03:22:49PM +0100, Allmeroth, Robert wrote: > On embedded systems it is sometimes not very useful to call shutdown scripts > or reboot(2) in case of a watchdog failure / failed service (re)starting, > e.g. FS/Flash corruption, FS driver failure, special HW init failure > >

[systemd-devel] [PATCH 2/2] service: make sure the watchdog timer is not restarted while stopping

2013-01-23 Thread Michael Olbrich
A watchdog notification may be handled after the watchdog timer was stopped while stopping the service. As a result the timer is restarted and the service may be restarted as well. The watchdog timestamp is initially set during startup in service_enter_start_post() and cleared when the timer is sto

[systemd-devel] [PATCH 1/2] service: really stop watchdog timer when stopping

2013-01-23 Thread Michael Olbrich
For services without ExecStop= the state SERVICE_STOP is never entered. as a result the watchdog timer is not stopped and the service is restarted (if it is configuered to restart). Stopping the watchdog timer for SERVICE_STOP_SIGTERM as well fixes this. --- src/core/service.c |2 +- 1 file ch

Re: [systemd-devel] [HEADS-UP] systemd down/upstream meeting at FOSDEM?

2013-01-23 Thread Michael Olbrich
Hi, On Tue, Jan 22, 2013 at 11:11:22PM +0100, Lennart Poettering wrote: > I just learned that a number of systemd downstream and upstream folks > are attending FOSDEM. We'll at least have Michael Biebl, Tollef Fog > Heen, Colin Guthrie, Kay Sievers, Harald Hoyer and myself around. > > We were won

[systemd-devel] [PATCH] make sure __NR_name_to_handle_at is correctly defined

2012-10-18 Thread Michael Olbrich
341 is only valid for x86, so don't use it for other architectures. Add the correct numbers for ARM and PowerPC while at it. --- src/shared/missing.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/shared/missing.h b/src/shared/missing.h index 1a31066..1965

[systemd-devel] build error

2012-10-18 Thread Michael Olbrich
Hi, The current systemd from git (v194-102-gd671da8) fails to build with: make[2]: *** No rule to make target `man/sd_journal_query_unique.3', needed by `all-am'. Stop. make[2]: *** Waiting for unfinished jobs I think man/sd_journal_query_unique.xml should have been added in 3c1668d journa

Re: [systemd-devel] journald leaking maps?

2012-10-12 Thread Michael Olbrich
On Fri, Oct 12, 2012 at 03:58:06PM +0100, Colin Guthrie wrote: > 'Twas brillig, and Michael Olbrich at 12/10/12 09:52 did gyre and gimble: > > On Fri, Oct 12, 2012 at 04:31:46AM -0400, Dave Reisner wrote: > >> On Fri, Oct 12, 2012 at 09:19:08AM +0100, Colin Guthrie wrote: &

  1   2   3   >