Re: [systemd-devel] [PATCH 17/17] networkd: add dhcp server support

2014-05-26 Thread Marcel Holtmann
Hi Cristian, When enabled in [Network] it will set up a dhcp server on the interface, listening on one of its statically configured IPv4 addresses and with a fixed size pool of leases determined from it. Hi Tom, before looking at the code, a couple of general questions: - does the DHCP

Re: [systemd-devel] [PATCH] networkd: Introduce tuntap device

2014-06-24 Thread Marcel Holtmann
Hi Tom, This patch introduces tuntap support to networkd. Example conf file : tuntap.netdev [NetDev] Name=tuntap-test Kind=tuntap [TUNTAP] Hm, maybe call this TunTap instead? Mode=tap OneQueue=true MultiQueue=true PacketInfo=true I wonder if it might be better separate in

Re: [systemd-devel] [PATCH] Add support for DHCP static route options in networkd

2014-06-27 Thread Marcel Holtmann
Hi Lennart, I am tempted to say that we should try to apply as much information from DHCP as we can by default, but make sure it doesn't become a security problem. i.e. we should probably use metrics or so so that manual routes always win, or routes to other interfaces. I think using

Re: [systemd-devel] Changing configurations with networkd

2014-07-23 Thread Marcel Holtmann
Hi Michael, I think the lease should be remembered and reused in this case. Hm, this sounds like a bug somewhere. When the new discover is sent out it should send the same identifying information to the server, and hence be given the same lease back again. Wireshark should tell you if the

Re: [systemd-devel] Changing configurations with networkd

2014-07-24 Thread Marcel Holtmann
Hi Tom, I think the lease should be remembered and reused in this case. Hm, this sounds like a bug somewhere. When the new discover is sent out it should send the same identifying information to the server, and hence be given the same lease back again. Wireshark should tell you if the

Re: [systemd-devel] networkd Promiscuous mode

2014-08-13 Thread Marcel Holtmann
Hi Lennart, There seems to be no way in systemd-networkd to put a link in Promiscuous mode. This is needed to make macvlan work correctly (Otherwise it receives no traffic with its mac address as the destination). If I am not mistaken this could be a boolean in *.link files. Sounds

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-13 Thread Marcel Holtmann
Hi Lennart, Now that networkd can send the systems hostname to the dhcp server, I would find it useful to have an option to override the hostname that gets sent. In my use case, I would like to setup a number of macvlans with different hostnames. Something as simple as [DHCP]

Re: [systemd-devel] Networkd dhcp hostname override

2014-08-14 Thread Marcel Holtmann
Hi Dan, Now that networkd can send the systems hostname to the dhcp server, I would find it useful to have an option to override the hostname that gets sent. In my use case, I would like to setup a number of macvlans with different hostnames. Something as simple as [DHCP]

[systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-15 Thread Marcel Holtmann
To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/handle.c b/handle.c

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-15 Thread Marcel Holtmann
Hi Daniel, To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [systemd-devel] [PATCH kdbus] handle: Return POLLOUT | POLLWRNORM mask when no messages are pending

2014-08-18 Thread Marcel Holtmann
Hi Lennart, To facility the feature of doing an asynchronous sending of messages when the bus is idle, make sure to return POLLOUT | POLLWRNORM from kdbus_handle_poll. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- handle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Marcel Holtmann
Hi Miroslav, To have timedated/timedatectl managing the right NTP service on distributions like Fedora. I don't really think that timedated should manage an NTP server like ntpd/chrony. I'm talking about NTP clients, not servers. Writing a good NTP client is the difficult part, making

[systemd-devel] [PATCH] build-sys: gpt-auto-generator depends on HAVE_BLKID

2013-09-07 Thread Marcel Holtmann
--- Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index fd38e82..5654ad3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1708,6 +1708,7 @@ bin_PROGRAMS += \ bootctl endif +if HAVE_BLKID #

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-06 Thread Marcel Holtmann
Hi Auke, This daemon listens for and configures network devices tagged with 'systemd-networkd'. By default, no devices are tagged so this daemon can safely run in parallel with existing network daemons/scripts. Networks are configured in /etc/systemd/network/*.network. The first .network

Re: [systemd-devel] [RFC][PATCH] networkd: add a basic network daemon

2013-11-06 Thread Marcel Holtmann
Hi Lennart, +struct Link { +uint64_t ifindex; Hmm is this really an uint64_t? if_nametoindex(3) suggestes it's an unsigned? actually using if_nametoindex() is bad idea as well. That should be turned into an async RTNL call as well. We better just cache the ifname to ifindex

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Marcel Holtmann
Hi Greg, This patch set implements a DHCPv4 client library named libsystemd-dhcp to be used with systemd-network. Nice stuff. Where did this code come from, conman? If so, for some reason I thought that it would be easier to make a library of the existing conman dhcp code and have both

Re: [systemd-devel] systemd-networkd questions

2013-11-13 Thread Marcel Holtmann
Hi Bill, Without criticizing any of the existing solutions, some of the things that motivated my interest in this is that I think we need: something easily configured via plain configuration files by a sysadmin, something that would take a limited amount of space (including its dependencies)

Re: [systemd-devel] [PATCH 00/28] Initial DHCP v4 library implementation

2013-11-13 Thread Marcel Holtmann
Hi Colin, that is the long term plan. Once ConnMan is switching over to use libsystemd-bus and kdbus, we are switching over to using the systemd event loop instead of GLib main loop But I think the long term architecturally correct place for the core system main loop is glibc, not

Re: [systemd-devel] [PATCH 01/28] dhcp: Add DHCP protocol structures and initial defines

2013-11-13 Thread Marcel Holtmann
Hi Lennart, +#define BOOTREQUEST 1 +#define BOOTREPLY 2 + +#define DHCP_DISCOVER 1 +#define DHCP_OFFER 2 +#define DHCP_REQUEST3 +#define DHCP_DECLINE

Re: [systemd-devel] [PATCH 01/28] dhcp: Add DHCP protocol structures and initial defines

2013-11-13 Thread Marcel Holtmann
Hi Zbyszek, +#define BOOTREQUEST 1 +#define BOOTREPLY 2 + +#define DHCP_DISCOVER 1 +#define DHCP_OFFER 2 +#define DHCP_REQUEST3 +#define DHCP_DECLINE

Re: [systemd-devel] [PATCH 01/28] dhcp: Add DHCP protocol structures and initial defines

2013-11-13 Thread Marcel Holtmann
Hi Lennart, +#define BOOTREQUEST 1 +#define BOOTREPLY 2 + +#define DHCP_DISCOVER 1 +#define DHCP_OFFER 2 +#define DHCP_REQUEST3 +#define DHCP_DECLINE

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-10 Thread Marcel Holtmann
Hi Lennart, +uint32_t ciaddr; +uint32_t yiaddr; +uint32_t siaddr; +uint32_t giaddr; Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order, right? which is just synoymous to big endian... Or even, if you now use struct in_addr elsewhere

[systemd-devel] [PATCH] hashmap: Remove unused auxv variable

2013-12-10 Thread Marcel Holtmann
CC src/shared/hashmap.lo src/shared/hashmap.c: In function 'hashmap_new': src/shared/hashmap.c:188:15: warning: unused variable 'auxv' [-Wunused-variable] void *auxv; ^ --- src/shared/hashmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/shared/hashmap.c

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-10 Thread Marcel Holtmann
Hi Daniel, Reindentation is done to fit systemd --- Makefile.am | 23 + src/libsystemd-asyncns/asyncns.c | 1513 + src/libsystemd-asyncns/asyncns.h | 163 src/libsystemd-asyncns/test-asyncns.c | 178 4 files

Re: [systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

2013-12-12 Thread Marcel Holtmann
Hi Patrik, I agree with Zbigniew: this should probably be in src/libsystemd-dhcp/, so that this is similar to libsystemd-bus/, libsystemd-id128/ and so on... Sent a patch for that, and in the process of creating an account on freedesktop.org. As that will most probably take some time,

Re: [systemd-devel] [PATCH] dhcp: Move src/dhcp to src/libsystemd-dhcp

2013-12-12 Thread Marcel Holtmann
Hi Patrik, --- Makefile.am | 42 +- src/dhcp/Makefile |1 - src/dhcp/client.c | 1002 - src/dhcp/internal.h | 41 - src/dhcp/network.c

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

[systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Marcel Holtmann
CC src/shared/logs-show.lo src/shared/logs-show.c: In function 'get_boot_id_for_machine': src/shared/logs-show.c:1153:9: warning: implicit declaration of function 'socketpair' [-Wimplicit-function-declaration] if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sock) 0) ^

Re: [systemd-devel] [PATCH] logs-show.c: Fix missing sys/socket.h include

2013-12-12 Thread Marcel Holtmann
Hi Zbyszek, diff --git a/src/shared/logs-show.c b/src/shared/logs-show.c index c99fc7569429..0e3fd3de2630 100644 --- a/src/shared/logs-show.c +++ b/src/shared/logs-show.c @@ -23,6 +23,7 @@ #include assert.h #include errno.h #include sys/poll.h +#include sys/socket.h #include string.h

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Andrey, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

Re: [systemd-devel] [RFC] Initial libsystemd-asyncns commit

2013-12-12 Thread Marcel Holtmann
Hi Lennart, why do we have to spawn threads or do forks for DNS. This looks all pretty expensive. In ConnMan for example we just wrote our own async DNS using a mainloop. Works perfectly fine and is dirt cheap. Well, we don't fork threads/processes for each call but reuse them. What

Re: [systemd-devel] [RFC] networkd/udev: match on 'ethernet' devices

2014-01-03 Thread Marcel Holtmann
Hi Tom, I just pushed a change[0] which allows the match syntax Type=ethernet to match on network devices without a DEVTYPE. We had a discussion on IRC whether we should call it Type=wired or Type=ethernet. I think the former may be more intuitive, but the latter seems to be more in line

Re: [systemd-devel] [RFC] networkd/udev: match on 'ethernet' devices

2014-01-03 Thread Marcel Holtmann
Hi Tom, we can easily update ConnMan to handle DEVTYPE= and DEVTYPE=ethernet. That is an easy change and will keep things working. As I explained in the other reply, the main reason for DEVTYPE=something is to detect that it is a network device that needs a management entity before it

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Marcel Holtmann
-by: Tom Gundersen t...@jklm.no Cc: Marcel Holtmann mar...@holtmann.org Cc: Greg KH gre...@linuxfoundation.org --- Hi Greg and Marcel, This patch seems to do the right thing for me. Any comments before I send it off to LKML? I suppose it may make sense to hide this behind a kernel option

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-04 Thread Marcel Holtmann
-by: Tom Gundersen t...@jklm.no Cc: Marcel Holtmann mar...@holtmann.org Cc: Greg KH gre...@linuxfoundation.org --- Hi Greg and Marcel, This patch seems to do the right thing for me. Any comments before I send it off to LKML? I suppose it may make sense to hide this behind a kernel option

Re: [systemd-devel] [RFC][PATCH] net: set default DEVTYPE for all ethernet based devices

2014-01-05 Thread Marcel Holtmann
-by: Tom Gundersen t...@jklm.no Cc: Marcel Holtmann mar...@holtmann.org Cc: Greg KH gre...@linuxfoundation.org --- Hi Greg and Marcel, This patch seems to do the right thing for me. Any comments before I send it off to LKML? I suppose it may make sense to hide this behind a kernel

Re: [systemd-devel] networkd: Loosing nic's driver set functionality

2014-01-22 Thread Marcel Holtmann
Hi Umut, Making RTM_GETLINK and RTM_SETLINK asynchronously is causing RTM_SETLINK to remove the nic's functionality. In my case, I am loosing IFF_MULTICAST after networkd sets the interface up. I am not sure if 5d4795f37229 can solve the problem but the only documentation I found was

Re: [systemd-devel] networking services management idea

2012-08-02 Thread Marcel Holtmann
Hi Chris, Unless the services take long to start, you'll have a much better time with socket activation. With socket activation, the service won't just wait until network availability to come online; the service will wait until an actual request to come online. Also check out my other

[systemd-devel] [PATCH] hwdb: Add database for Bluetooth company identifiers

2012-12-28 Thread Marcel Holtmann
--- Makefile.am | 1 + hwdb/20-bluetooth-vendor-product.hwdb | 541 ++ 2 files changed, 542 insertions(+) create mode 100644 hwdb/20-bluetooth-vendor-product.hwdb diff --git a/Makefile.am b/Makefile.am index 477b3a6..94ae549 100644 ---

Re: [systemd-devel] [PATCH] hwdb: Add database for Bluetooth company identifiers

2012-12-28 Thread Marcel Holtmann
Hi Tom, diff --git a/hwdb/20-bluetooth-vendor-product.hwdb b/hwdb/20-bluetooth-vendor-product.hwdb new file mode 100644 index 000..c8cb322 --- /dev/null +++ b/hwdb/20-bluetooth-vendor-product.hwdb @@ -0,0 +1,541 @@ +# This file is part of systemd. +# +# Data imported

Re: [PATCH] Allow compile without IPv6.

2010-09-08 Thread Marcel Holtmann
Hi Gustavo, I think new projects from 2010 should not have ipv4-only. This time should be over, finally. And people should get used to see ipv6 everywhere, and we should try to break the chicken-egg thing wherever possible. :) I can see the use for a systemd without any IP networking,

Re: [PATCH] Allow compile without IPv6.

2010-09-08 Thread Marcel Holtmann
Hi Gustavo, I think new projects from 2010 should not have ipv4-only. This time should be over, finally. And people should get used to see ipv6 everywhere, and we should try to break the chicken-egg thing wherever possible. :) I can see the use for a systemd without any IP

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Marcel Holtmann
Hi Miroslav, and writing a good DHCP client was supposedly also really hard. Guess what we have done that twice now and both of our clients are better than everything else out there. And guess what, we did the same for NTP. Are you saying timesyncd is already better than chronyd or ntpd?

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-27 Thread Marcel Holtmann
Hi Miroslav, ConnMan is a single daemon solution doing NTP, DHCP and DNS all in one place. Any sort of callouts are costing time. And that is time that has a visible user impact. There is nothing that justifies to have a bit more nanosecond accuracy of synchronized time than making the user

Re: [systemd-devel] watchdog feature highly ineffecient / using too much CPU

2014-09-13 Thread Marcel Holtmann
Hi Michael, So, lets look at the bluetoothd code: watchdog_usec = getenv(WATCHDOG_USEC); seconds = atoi(watchdog_usec) / (1000 * 1000); watchdog = g_timeout_add_seconds_full(G_PRIORITY_HIGH, seconds / 2,

Re: [systemd-devel] Implementing remote wake-up for Bluetooth

2014-09-20 Thread Marcel Holtmann
Hi Bastien, I wanted to add a toggle box like the one MacOS X has had for a long while, allowing users to wake up their system using a Bluetooth keyboard. The procedure is here: https://github.com/lwfinger/rtl8723au_bt/blob/master/readme.txt We could also always allow remote wake-up

Re: [systemd-devel] Systemd-nspawn -- Canot add interface to container

2014-09-25 Thread Marcel Holtmann
Hi James, I'm having another issue with private networking in systemd-nspawn. This one I'm not so certain is a bug, but probably some kind of mistake on my part. Base on my reading of the systemd-nspawn man page though, I can't figure out what the problem is. Basically, all I'm tring to do

Re: [systemd-devel] Systemd-nspawn -- Canot add interface to container

2014-10-02 Thread Marcel Holtmann
Hi Lennart, I'm having another issue with private networking in systemd-nspawn. This one I'm not so certain is a bug, but probably some kind of mistake on my part. Base on my reading of the systemd-nspawn man page though, I can't figure out what the problem is. Basically, all I'm tring

Re: [systemd-devel] Systemd-nspawn -- Canot add interface to container

2014-10-02 Thread Marcel Holtmann
Hi Lennart, this nl80211 is based on generic netlink, you would need to do a lot to just add simple support for it. Also for all network interfaces that have complex physical devices as base (including Bluetooth) it is never that dead simple. Well, sooner or later I figure sd-rtnl will

Re: [systemd-devel] [question] networkd: Any support for hooks?

2014-10-08 Thread Marcel Holtmann
Hi Cameron, ifupdown [1], NetworkManager, and WICD all support hooks for when a network interface is configured or deconfigured (before and after these actions). Are there any plans to support something along these lines? If so, what will that look like? If there are no plans, how do

Re: [systemd-devel] Systemd-networkd -- Cannot acquire DHCP lease on bridge interface

2014-10-23 Thread Marcel Holtmann
Hi Tom, Trying unicast, waiting some time and then trying broadcast, if a DHCP offer is not sent within that time limit, seems like a fair thing to do. My 2 cents. Yeah, it seems this is what we should do. I guess it makes sense to make RequestBroadcast=yes|no|automatic, and default to

Re: [systemd-devel] [BUG] too many rfkill services

2014-11-20 Thread Marcel Holtmann
Hi Lennart, That's normal behavior in the case of a platform rfkill device and a device-specific rfkill device. The platform rfkill functionality can sometimes (often?) cut power to the device through BIOS and GPIOs, and it will drop off the USB or PCI bus. But the device itself can also

Re: [systemd-devel] networkd: Support setting mtu / mac address by interface name

2014-12-05 Thread Marcel Holtmann
Hi Lennart, Moreover, if we give people this feature I'm pretty sure we'll get lots of people expecting it to work also for any other sort of name and getting confused when it doesn't. Well, this is something we can fix by documentation, no? Or maybe name the match option differently,

Re: [systemd-devel] [PATCH] hwdb: add sdio identifiers for Broadcom WLAN cards

2014-12-21 Thread Marcel Holtmann
Hi Arend, This patch adds the sdio identifiers known to be supported by the brcmfmac open-source driver. Cc: Marcel Holtmann mar...@holtmann.org Signed-off-by: Arend van Spriel ar...@broadcom.com there are some commits with Signed-off-by lines, but in general they are not in use. So don't

Re: [systemd-devel] [PATCH] hwdb: ship ids-update.pl sdio.ids in the release tarballs.

2015-03-16 Thread Marcel Holtmann
Hi Dimitri, This makes it easier to apply stable branch patches on top of the release tarball. --- Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 856accb..0ed35ac 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3877,7

Re: [systemd-devel] [PATCH] hwdb: ship ids-update.pl sdio.ids in the release tarballs.

2015-03-19 Thread Marcel Holtmann
Hi Michael, On 16 March 2015 at 23:15, Marcel Holtmann mar...@holtmann.org wrote: Hi Dimitri, Just tell patch or git to skip the hunks modifying ids-update.pl and sdio.ids. Problem solved. I'll apply the patch, but with a slightly different motivation. [L]GPL requires commercial

Re: [systemd-devel] [PATCH] hwdb: ship ids-update.pl sdio.ids in the release tarballs.

2015-03-19 Thread Marcel Holtmann
Hi Zbyszek, On 16 March 2015 at 23:15, Marcel Holtmann mar...@holtmann.org wrote: Hi Dimitri, This makes it easier to apply stable branch patches on top of the release tarball. --- Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.am b

Re: [systemd-devel] [PATCH] hwdb: ship ids-update.pl sdio.ids in the release tarballs.

2015-03-20 Thread Marcel Holtmann
Hi Zybszek, On 16 March 2015 at 23:15, Marcel Holtmann mar...@holtmann.org wrote: Hi Dimitri, Just tell patch or git to skip the hunks modifying ids-update.pl and sdio.ids. Problem solved. I'll apply the patch, but with a slightly different motivation. [L]GPL requires commercial

Re: [systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-27 Thread Marcel Holtmann
Hi Kay, CC src/boot/efi/splash.o src/boot/efi/splash.c: In function ‘graphics_splash’: src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ of ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers] EFI_GRAPHICS_OUTPUT_BLT_PIXEL pixel = { };

Re: [systemd-devel] [PATCH] hwdb: add sdio identifiers for Broadcom WLAN cards

2015-02-26 Thread Marcel Holtmann
Hi Arend, This patch adds the sdio identifiers known to be supported by the brcmfmac open-source driver. Cc: Marcel Holtmann mar...@holtmann.org Signed-off-by: Arend van Spriel ar...@broadcom.com I remove the signed-off-by line since it is not standard practice here and then applied

[systemd-devel] [PATCH] boot: efi - move background pixel variable into different scope

2015-02-26 Thread Marcel Holtmann
CC src/boot/efi/splash.o src/boot/efi/splash.c: In function ‘graphics_splash’: src/boot/efi/splash.c:256:9: warning: missing initializer for field ‘Blue’ of ‘EFI_GRAPHICS_OUTPUT_BLT_PIXEL’ [-Wmissing-field-initializers] EFI_GRAPHICS_OUTPUT_BLT_PIXEL pixel = { }; ^ In

Re: [systemd-devel] [PATCH] boot: efi - fix missing include

2015-02-26 Thread Marcel Holtmann
Hi Zbyszek, src/boot/efi/splash.c:312:9: warning: implicit declaration of function ‘graphics_mode’ [-Wimplicit-function-declaration] err = graphics_mode(TRUE); ^ Just push such trivial ones directly. okay, pushed. I couldn't tell if this was intentional because of

Re: [systemd-devel] Will *.network replace resolv.conf? What about Options single-request?

2015-05-15 Thread Marcel Holtmann
Hi Lennart, On Mon, May 4, 2015 at 2:57 PM, Christian Brunotte c...@lathspell.de wrote: systemd.network(5) with Options like DNS= and Domains= looks like /etc/resolv.conf will soon be superfluous. In many setups, yes, but we will not aim at bug-for-bug compatibility or anything like that.

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-13 Thread Marcel Holtmann
Hi Tomasz, Have you looked into MuJS instead of duktape? http://mujs.com/ It has a C api similar to Lua, with all state encapsulated in an opaque structure, that you interface with via a virtual stack. It could be easily tested. I did so the PAC related code is contained in a specific

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Marcel Holtmann
Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ + src/proxy-discovery/duktape.c \ These files are not included in the

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-13 Thread Marcel Holtmann
Hi Zbyszek, --- a/Makefile.am +++ b/Makefile.am @@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \ systemd-proxy-discoveryd systemd_proxy_discoveryd_SOURCES = \ + src/proxy-discovery/duktape.h \ + src/proxy-discovery/duktape.c \ These files are not included in the

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-12 Thread Marcel Holtmann
Hi Zbyszek, As it has been discussed in the systemd hackfest during the Linux Conference Europe, one daemon could centralize the management of all network proxy configurations. Idea is something user can do per-application (like in firefox for instance) or broader (per-DM like in Gnome), user

Re: [systemd-devel] [RFC 2/6] proxy-discoveryd: Add the basics for parsing the default configuration

2015-04-12 Thread Marcel Holtmann
Hi Lennart, The config file will be in /etc/systemd/proxy/filename.conf It currently only load Proxy parts, with the key PAC. Rest is ignored. The PAC keyword is a path to a .pac file (a specific js script for proxy configuration). Only one PAC based proxy configuration will be loaded at

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-12 Thread Marcel Holtmann
Hi Lennart, As it has been discussed in the systemd hackfest during the Linux Conference Europe, one daemon could centralize the management of all network proxy configurations. Idea is something user can do per-application (like in firefox for instance) or broader (per-DM like in Gnome),

Re: [systemd-devel] [RFC 0/6] A network proxy management daemon, systemd-proxy-discoveryd

2015-04-12 Thread Marcel Holtmann
Hi Lennart, As it has been discussed in the systemd hackfest during the Linux Conference Europe, one daemon could centralize the management of all network proxy configurations. Idea is something user can do per-application (like in firefox for instance) or broader (per-DM like in Gnome), user

Re: [systemd-devel] [RFC 5/6] proxy-discoveryd: Add the basic parts for handling DBus methods

2015-04-12 Thread Marcel Holtmann
Hi Lennart, + +static int method_find_proxy(sd_bus *bus, sd_bus_message *message, void *userdata, sd_bus_error *error) { +_cleanup_free_ char *p = strdup(DIRECT); Please don't mix variable declarations and function invocations in one line (also see CODING_STYLE). Also, missing

Re: [systemd-devel] [RFC 4/6] proxy-discoveryd: Execute the PAC based proxy in a thread

2015-04-12 Thread Marcel Holtmann
Hi Lennart, sd-bus is not thread-safe. You cannot send messages from different threads at the same time... Why precisely do you need threads here? Because the PAC programs might be slow? the Javascript execution is normally blocking and it can do whatever it wants. If it wants to draw a

Re: [systemd-devel] [RFC 2/6] proxy-discoveryd: Add the basics for parsing the default configuration

2015-04-10 Thread Marcel Holtmann
Hi Lennart, The config file will be in /etc/systemd/proxy/filename.conf It currently only load Proxy parts, with the key PAC. Rest is ignored. The PAC keyword is a path to a .pac file (a specific js script for proxy configuration). Only one PAC based proxy configuration will be loaded at

Re: [systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

2015-04-10 Thread Marcel Holtmann
Hi Lennart, +struct PAC { +duk_context *ctx; +}; + +static int get_addresses_from_interface(int ifindex, union in_addr_union *address) { +struct ifreq ifr = {}; +int sk; + +sk = socket(AF_INET, SOCK_DGRAM, 0); +if (sk 0) +

Re: [systemd-devel] [RFC 4/6] proxy-discoveryd: Execute the PAC based proxy in a thread

2015-04-10 Thread Marcel Holtmann
Hi Lennart, +static void *run_thread(void *data) { +_cleanup_free_ struct proxy_parameters *params = NULL; +_cleanup_pac_free_ struct PAC *pac = NULL; +_cleanup_free_ char *result = NULL; +const char *url, *host; + +params = data; + +if

Re: [systemd-devel] [RFC 5/6] proxy-discoveryd: Add the basic parts for handling DBus methods

2015-04-10 Thread Marcel Holtmann
Hi Lennart, + +static int method_find_proxy(sd_bus *bus, sd_bus_message *message, void *userdata, sd_bus_error *error) { +_cleanup_free_ char *p = strdup(DIRECT); Please don't mix variable declarations and function invocations in one line (also see CODING_STYLE). Also, missing

Re: [systemd-devel] powering on bluetooth after suspend - required services aren't ready

2015-09-26 Thread Marcel Holtmann
Hi Lukas, > When a system wakes from suspend, the Bluetooth adapter needs to be > explicitly powered on. This can be conveniently done by a systemd > service file, as described for example on Archlinux wiki [1] (the > systemd service file at the bottom of the section). > > The hciconfig binary

Re: [systemd-devel] Static IP address on wandering Wi-Fi client

2019-06-17 Thread Marcel Holtmann
Hi Lennart, >> Is there any way to tell systemd-networkd to use one .network file or >> another depending on which SSID the Wi-Fi interface is connected to? > > This does not currently exist, but it was always the intention to add > this. So far nobody did the work though. > > Most likely this

Re: [systemd-devel] Static IP address on wandering Wi-Fi client

2019-06-18 Thread Marcel Holtmann
Hi Bruce, > I'm not so sure about handing the IP configuration to the service that > is managing the link level. What then do we do with Ethernet? Do we > build an iwd equivalent to set up the routes, etc. for the Ethernet > connections? What I like about what I've seen with systemd-networkd and

Re: [systemd-devel] Static IP address on wandering Wi-Fi client

2019-06-18 Thread Marcel Holtmann
Hi Johann, >> And frankly IP configuration needs to move into the network technology >> daemons like iwd for example. > What's the argument here for that reasoning as in why not consolidate all > network configuration ( ethernet/wifi/vrrp/vpn's etc.. ) to a single place ( > networkd )? > >