Re: [tboot-devel] Incorrect command line handling with GRUB 1.97 and above

2010-07-28 Thread Cihula, Joseph
> Sent: Thursday, July 22, 2010 8:01 AM > To: tboot-devel@lists.sourceforge.net > Subject: Re: [tboot-devel] Incorrect command line handling with GRUB 1.97 and > above > > Hi! > > I forgot to mention that the initialization of g_log_targets in printk.c is > pointless. > g_

Re: [tboot-devel] Incorrect command line handling with GRUB 1.97 and above

2010-07-22 Thread Michael Gissing
Hi! I forgot to mention that the initialization of g_log_targets in printk.c is pointless. g_log_targets is always overwritten by get_tboot_log_targets() because get_option_val() will return "serial" if logging isn't specified via command line. I suggest to remove "serial" from g_tboot_cmdlin

[tboot-devel] Incorrect command line handling with GRUB 1.97 and above

2010-07-15 Thread Michael Gissing
Hi! GRUB2 changed its behavior on how to deal with command lines[1] starting with version 1.97. There's also a debian bug[2] filed. GRUB2 now discards the first element (the filename) before storing the command line in mbi->cmdline. Since TBoot always calls skip_filename(), g_cmdline loses firs