Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-27 Thread Guy Harris via tcpdump-workers 
--- Begin Message ---
On Dec 16, 2020, at 8:09 PM, Yao, Jiewen via tcpdump-workers 
 wrote:

> We did a prototype for the SpdmDump tool 
> (https://github.com/jyao1/openspdm/blob/master/Doc/SpdmDump.md). We can 
> generate a PCAP file and parse it offline.
> In our prototype, we use below definition:
> #define LINKTYPE_MCTP  290  // 0x0122
> #define LINKTYPE_PCI_DOE   291  // 0x0123
> If you can assign same number, it will be great.
> If different number is assigned, we will change our implementation 
> accordingly.

Different numbers will definitely be assigned, as 290 is already in use (in 
Wireshark, for example).  (Not everything was updated to reflect that; I've 
fixed that.)

You will probably be assigned 291 for LINKTYPE_MCTP and 292 for 
LINKTYPE_PCI_DOE; you should update your prototype for that for now.--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-25 Thread Michael Richardson via tcpdump-workers 
--- Begin Message ---
Yao, Jiewen  wrote:
> Thank you.  I will file a Pull-Request.

> The DOE header definition can be found
> 
https://github.com/jyao1/openspdm/blob/master/Include/IndustryStandard/PciDoeBinding.h
> It starts from PCI_DOE_DATA_OBJECT_HEADER.

That sounds like enough of a definition to me.

--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-25 Thread Yao, Jiewen via tcpdump-workers 
--- Begin Message ---
Thank you.
I will file a Pull-Request.

The DOE header definition can be found 
https://github.com/jyao1/openspdm/blob/master/Include/IndustryStandard/PciDoeBinding.h
It starts from PCI_DOE_DATA_OBJECT_HEADER.

> -Original Message-
> From: Michael Richardson 
> Sent: Monday, January 25, 2021 11:21 PM
> To: Yao, Jiewen 
> Cc: tcpdump-workers@lists.tcpdump.org
> Subject: Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link
> type
> 
> Yao, Jiewen via tcpdump-workers  wrote:
> > Hello Any response ?
> 
> > Thank you Yao Jiewen
> 
> ...
> Hi, sorry abotu that.
> 
> > Hi I write this email to request to below 2 link types.
> 
> 
> >   1.  MCTP
> 
> > Management Component Transport Protocol (MCTP) is an industry standard
> > defined by Distributed Management Task Force (DMTF) Platform
> Management
> > Communication Interface (PMCI) working group
> > (https://www.dmtf.org/standards/pmci)
> 
> > DSP0236
> >
> (https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.
> 1.pdf)
> > is the Management Component Transport Protocol (MCTP) Base
> > Specification. It defines the MCTP transport header.  DSP0239
> >
> (https://www.dmtf.org/sites/default/files/standards/documents/DSP0239_1.7.
> 0.pdf)
> > defines the Management Component Transport Protocol (MCTP) IDs and
> > Codes. It defines the MCTP message type in a MCTP packet payload.
> 
> > Proposal:
> 
> > LINKTYPE_ name LINKTYPE_ value Corresponding DLT_ name Description
> > LINKTYPE_MCTP XXX DLT_MCTP MCTP packet is defined in DMTF PMCI
> working
> > group Management Component Transport Protocol (MCTP) Base
> >
> Specification(https://www.dmtf.org/sites/default/files/standards/documents/D
> SP0236_1.3.1.pdf)
> > 8.1 MCTP packet fields. It starts with MCTP transport header in Figure
> > 4 - Generic message fields.
> 
> These descriptions look great.
> Why not follow https://github.com/the-tcpdump-
> group/libpcap/blob/master/doc/DLT_ALLOCATE_HOWTO.md
> and send a pull request?
> 
> >   1.  PCI_DOE
> 
> > PCI Data Object Exchange (DOE) is an industry standard defined by
> > PCI-SIG (https://pcisig.com/) Data Object Exchange (DOE)
> > ECN
> > (https://members.pcisig.com/wg/PCI-SIG/document/14143).
> 
> This link is behind some kind of paywall.
> Maybe there is a public definition we can refer to?
> 
> > Proposal:
> 
> > LINKTYPE_ name LINKTYPE_ value Corresponding DLT_ name Description
> > LINKTYPE_PCI_DOE XXX DLT_PCI_DOE PCI Data Object Exchange (DOE) is
> > defined in PCI-SIG Data Object Exchange (DOE) ECN
> > (https://members.pcisig.com/wg/PCI-SIG/document/14143) 6.xx.1 Data
> > Objects. It starts with DOE Data Object Header 1 in Figure 6-x1: DOE
> > Data Object Format.
> 
> 
> 
> > The reason I submit this request is because we are implementing a
> > "SpdmDump" tool to dump the SPDM message defined in DMTF PMCI
> Security
> > Protocol and Data Model (SPDM) Specification DSP0274
> >
> (https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.1.
> 0.pdf).
> > SPDM is similar to network Transport Layer Security (TLS) protocol. It
> > is a transport layer protocol.  The MCTP and the PCI_DOE are the
> > transport layer binding to send message to hardware device (MCTP
> > capable device or PCI_DOE capable device).
> 
> > We did a prototype for the SpdmDump tool
> > (https://github.com/jyao1/openspdm/blob/master/Doc/SpdmDump.md).
> We can
> > generate a PCAP file and parse it offline.  In our prototype, we use
> > below definition: #define LINKTYPE_MCTP 290 // 0x0122 #define
> > LINKTYPE_PCI_DOE 291 // 0x0123 If you can assign same number, it will
> > be great.  If different number is assigned, we will change our
> > implementation accordingly.
> 
> > Thank you Yao Jiewen
> 
> 
> 
> > ___ tcpdump-workers
> mailing
> > list tcpdump-workers@lists.tcpdump.org
> > https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-25 Thread Michael Richardson via tcpdump-workers 
--- Begin Message ---
Yao, Jiewen via tcpdump-workers  wrote:
> Hello Any response ?

> Thank you Yao Jiewen

...
Hi, sorry abotu that.

> Hi I write this email to request to below 2 link types.


>   1.  MCTP

> Management Component Transport Protocol (MCTP) is an industry standard
> defined by Distributed Management Task Force (DMTF) Platform Management
> Communication Interface (PMCI) working group
> (https://www.dmtf.org/standards/pmci)

> DSP0236
> 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf)
> is the Management Component Transport Protocol (MCTP) Base
> Specification. It defines the MCTP transport header.  DSP0239
> 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0239_1.7.0.pdf)
> defines the Management Component Transport Protocol (MCTP) IDs and
> Codes. It defines the MCTP message type in a MCTP packet payload.

> Proposal:

> LINKTYPE_ name LINKTYPE_ value Corresponding DLT_ name Description
> LINKTYPE_MCTP XXX DLT_MCTP MCTP packet is defined in DMTF PMCI working
> group Management Component Transport Protocol (MCTP) Base
> 
Specification(https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf)
> 8.1 MCTP packet fields. It starts with MCTP transport header in Figure
> 4 - Generic message fields.

These descriptions look great.
Why not follow 
https://github.com/the-tcpdump-group/libpcap/blob/master/doc/DLT_ALLOCATE_HOWTO.md
and send a pull request?

>   1.  PCI_DOE

> PCI Data Object Exchange (DOE) is an industry standard defined by
> PCI-SIG (https://pcisig.com/) Data Object Exchange (DOE)
> ECN
> (https://members.pcisig.com/wg/PCI-SIG/document/14143).

This link is behind some kind of paywall.
Maybe there is a public definition we can refer to?

> Proposal:

> LINKTYPE_ name LINKTYPE_ value Corresponding DLT_ name Description
> LINKTYPE_PCI_DOE XXX DLT_PCI_DOE PCI Data Object Exchange (DOE) is
> defined in PCI-SIG Data Object Exchange (DOE) ECN
> (https://members.pcisig.com/wg/PCI-SIG/document/14143) 6.xx.1 Data
> Objects. It starts with DOE Data Object Header 1 in Figure 6-x1: DOE
> Data Object Format.



> The reason I submit this request is because we are implementing a
> "SpdmDump" tool to dump the SPDM message defined in DMTF PMCI Security
> Protocol and Data Model (SPDM) Specification DSP0274
> 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.1.0.pdf).
> SPDM is similar to network Transport Layer Security (TLS) protocol. It
> is a transport layer protocol.  The MCTP and the PCI_DOE are the
> transport layer binding to send message to hardware device (MCTP
> capable device or PCI_DOE capable device).

> We did a prototype for the SpdmDump tool
> (https://github.com/jyao1/openspdm/blob/master/Doc/SpdmDump.md). We can
> generate a PCAP file and parse it offline.  In our prototype, we use
> below definition: #define LINKTYPE_MCTP 290 // 0x0122 #define
> LINKTYPE_PCI_DOE 291 // 0x0123 If you can assign same number, it will
> be great.  If different number is assigned, we will change our
> implementation accordingly.

> Thank you Yao Jiewen



> ___ tcpdump-workers mailing
> list tcpdump-workers@lists.tcpdump.org
> https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-25 Thread Yao, Jiewen via tcpdump-workers 
--- Begin Message ---
Comment below:

> -Original Message-
> From: Guy Harris 
> Sent: Monday, January 25, 2021 10:40 AM
> To: Yao, Jiewen 
> Cc: tcpdump-workers@lists.tcpdump.org
> Subject: Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link
> type
> 
> On Dec 16, 2020, at 8:09 PM, Yao, Jiewen via tcpdump-workers  work...@lists.tcpdump.org> wrote:
> 
> > I write this email to request to below 2 link types.
> >
> >
> >  1.  MCTP
> 
>   ...
> 
> > MCTP packet is defined in DMTF PMCI working group Management
> Component Transport Protocol (MCTP) Base
> Specification(https://www.dmtf.org/sites/default/files/standards/documents/D
> SP0236_1.3.1.pdf) 8.1 MCTP packet fields. It starts with MCTP transport header
> in Figure 4 - Generic message fields.
> 
> So this is for MCTP messages, independent of the physical layer?
[Jiewen] That is correct.

> 
> Presumably the not-a-multiple-of-8-bits fields in Table 1 go from the 
> high-order
> bits to the low-order bits, so that the upper 4 bits of the first byte are 
> the RSVD
> field and the lower 4 bits of the first byte are the Hdr version?
[Jiewen] That is correct.

> 
> >  1.  PCI_DOE
> >
> > PCI Data Object Exchange (DOE) is an industry standard defined by PCI-SIG
> (https://pcisig.com/) Data Object Exchange (DOE)
> ECN
> (https://members.pcisig.com/wg/PCI-SIG/document/14143).
> 
>   ...
> 
> > PCI Data Object Exchange (DOE) is defined in PCI-SIG Data Object Exchange
> (DOE) ECN (https://members.pcisig.com/wg/PCI-SIG/document/14143) 6.xx.1
> Data Objects. It starts with DOE Data Object Header 1 in Figure 6-x1: DOE Data
> Object Format.
> 
> Unfortunately, I'm not a member of the PCI SIG, so I don't have an account to
> log in to in order to read that document.

[Jiewen] So, how can I help on this?



--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-24 Thread Guy Harris via tcpdump-workers 
--- Begin Message ---
On Dec 16, 2020, at 8:09 PM, Yao, Jiewen via tcpdump-workers 
 wrote:

> I write this email to request to below 2 link types.
> 
> 
>  1.  MCTP

...

> MCTP packet is defined in DMTF PMCI working group Management Component 
> Transport Protocol (MCTP) Base 
> Specification(https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf)
>  8.1 MCTP packet fields. It starts with MCTP transport header in Figure 4 - 
> Generic message fields.

So this is for MCTP messages, independent of the physical layer?

Presumably the not-a-multiple-of-8-bits fields in Table 1 go from the 
high-order bits to the low-order bits, so that the upper 4 bits of the first 
byte are the RSVD field and the lower 4 bits of the first byte are the Hdr 
version?

>  1.  PCI_DOE
> 
> PCI Data Object Exchange (DOE) is an industry standard defined by PCI-SIG 
> (https://pcisig.com/) Data Object Exchange (DOE) 
> ECN 
> (https://members.pcisig.com/wg/PCI-SIG/document/14143).

...

> PCI Data Object Exchange (DOE) is defined in PCI-SIG Data Object Exchange 
> (DOE) ECN (https://members.pcisig.com/wg/PCI-SIG/document/14143) 6.xx.1 Data 
> Objects. It starts with DOE Data Object Header 1 in Figure 6-x1: DOE Data 
> Object Format.

Unfortunately, I'm not a member of the PCI SIG, so I don't have an account to 
log in to in order to read that document.
--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Re: [tcpdump-workers] Request to add MCTP and PCI_DOE to PCAP link type

2021-01-23 Thread Yao, Jiewen via tcpdump-workers 
--- Begin Message ---
Hello
Any response ?

Thank you
Yao Jiewen

From: Yao, Jiewen 
Sent: Thursday, December 17, 2020 12:10 PM
To: tcpdump-workers@lists.tcpdump.org
Cc: Yao, Jiewen 
Subject: Request to add MCTP and PCI_DOE to PCAP link type

Hi
I write this email to request to below 2 link types.


  1.  MCTP

Management Component Transport Protocol (MCTP) is an industry standard defined 
by Distributed Management Task Force (DMTF) Platform Management Communication 
Interface (PMCI) working group (https://www.dmtf.org/standards/pmci)

DSP0236 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf)
 is the Management Component Transport Protocol (MCTP) Base Specification. It 
defines the MCTP transport header.
DSP0239 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0239_1.7.0.pdf)
 defines the Management Component Transport Protocol (MCTP) IDs and Codes. It 
defines the MCTP message type in a MCTP packet payload.

Proposal:

LINKTYPE_ name
LINKTYPE_ value
Corresponding DLT_ name
Description
LINKTYPE_MCTP
XXX
DLT_MCTP
MCTP packet is defined in DMTF PMCI working group Management Component 
Transport Protocol (MCTP) Base 
Specification(https://www.dmtf.org/sites/default/files/standards/documents/DSP0236_1.3.1.pdf)
 8.1 MCTP packet fields. It starts with MCTP transport header in Figure 4 - 
Generic message fields.



  1.  PCI_DOE

PCI Data Object Exchange (DOE) is an industry standard defined by PCI-SIG 
(https://pcisig.com/) Data Object Exchange (DOE) 
ECN 
(https://members.pcisig.com/wg/PCI-SIG/document/14143).


Proposal:

LINKTYPE_ name
LINKTYPE_ value
Corresponding DLT_ name
Description
LINKTYPE_PCI_DOE
XXX
DLT_PCI_DOE
PCI Data Object Exchange (DOE) is defined in PCI-SIG Data Object Exchange (DOE) 
ECN (https://members.pcisig.com/wg/PCI-SIG/document/14143) 6.xx.1 Data Objects. 
It starts with DOE Data Object Header 1 in Figure 6-x1: DOE Data Object Format.



The reason I submit this request is because we are implementing a "SpdmDump" 
tool to dump the SPDM message defined in DMTF PMCI Security Protocol and Data 
Model (SPDM) Specification DSP0274 
(https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.1.0.pdf).
SPDM is similar to network Transport Layer Security (TLS) protocol. It is a 
transport layer protocol.
The MCTP and the PCI_DOE are the transport layer binding to send message to 
hardware device (MCTP capable device or PCI_DOE capable device).

We did a prototype for the SpdmDump tool 
(https://github.com/jyao1/openspdm/blob/master/Doc/SpdmDump.md). We can 
generate a PCAP file and parse it offline.
In our prototype, we use below definition:
#define LINKTYPE_MCTP  290  // 0x0122
#define LINKTYPE_PCI_DOE   291  // 0x0123
If you can assign same number, it will be great.
If different number is assigned, we will change our implementation accordingly.

Thank you
Yao Jiewen



--- End Message ---
___
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers