Re: HID parser

2014-05-05 Thread Daniel Bolgheroni
On Sun, May 04, 2014 at 06:11:41PM +0200, Martin Pieuchot wrote: In December 2012 a user reported on misc@ that the Noppoo Mini Choc 84 USB keyboard does not work on OpenBSD [0]. More recently, mcbride@ and yasuoka@ contacted me because they have a mouse that is not properly recognized. Both

Re: malloc in libssl/src/apps

2014-05-05 Thread Joel Sing
On Mon, 5 May 2014, Jean-Philippe Ouellet wrote: On Mon, May 05, 2014 at 11:12:00AM +1000, Joel Sing wrote: - i = 0; if (arg-count == 0) { arg-count = 20; - arg-data = (char **)malloc(sizeof(char *) * arg-count); + arg-data = calloc(arg-count,

[Patch fuse] fusefs_link return code

2014-05-05 Thread Helg
This patch fixes a bug where fusefs_link does not return an error on subsequent invocations if a fuse filesystem does not implement hard links. As an aside, returning ENOSYS in this case is contrary to the link(2) man page (and different again to the Open Group) but consistent with the fuse

Re: There's no need for the link-layer address in the RB-tree...

2014-05-05 Thread Martin Pieuchot
On 25/04/14(Fri) 15:59, Martin Pieuchot wrote: On 25/04/14(Fri) 15:46, Martin Pieuchot wrote: [...] Regarding the tree, when Henning added ifa_add/del prior to its addition, he also used it for link-layer addresses. But ifa_ifwithaddr() was not dealing with link-layer addresses at that

Re: [Patch] Add router alert option to igmp packets

2014-05-05 Thread Martin Pieuchot
Hello Florian, On 26/04/14(Sat) 22:22, Florian Riehm wrote: On 04/26/14 20:35, Alexander Bluhm wrote: /* * To avoid byte-swapping the same value over and over again. */ FreeBSD has code matching this comment. In OpenBSD the code is gone and so should

not quite another erratum

2014-05-05 Thread Ted Unangst
A little background. Before we issue errata, we have to decide whether we should. That's usually pretty simple, but sometimes a bug looks exploitable when it isn't, or is exploitable when it looks benign. Clearly issuing zero errata isn't a workable solution, so we could issue errata for

wskbd(4) memory leak

2014-05-05 Thread Martin Pieuchot
We leave in a hotpluggable world. Let's free in detach() the memory allocated in attach(). While here I realize that M_TEMP might not be the best type to describe the keymap, M_DEVBUF maybe? Ok? Index: wskbd.c === RCS file:

Re: not quite another erratum

2014-05-05 Thread Theo de Raadt
The process which came to the conclusion below took about 15-20 hours of accumulated developer time over the weekend. I'm almost running out of fingers counting developers. I wish we had the resources so that we could dedicate people to this in a more serious way. At least if we could dedicate

uvm integer overflows

2014-05-05 Thread Mark Kettenis
Inspired by some commits in bitrig, I did an audit for potential integer overflows caused by converting a page number into an offset/size/address by shifting by PAGE_SHIFT. While doing so, I noticed that uvm_objwire/unwire really should really use voff_t instead of off_t. There is one potential

Optional PIN for login_yubikey.c

2014-05-05 Thread Jeff Clement
I'd like to propose an addition to login_yubikey.c to support an optional PIN. I think that using the Yubikey for authentication is worthwhile. The current implementation of login_yubikey.c, however, relies entirely on the one-time password. I think the system would be stronger combining the

Re: malloc in libssl/src/apps

2014-05-05 Thread Jean-Philippe Ouellet
On Mon, May 05, 2014 at 07:31:34PM +1000, Joel Sing wrote: This one is calloc, not reallocarray, so unless I'm seriously missing something obvious here, it is indeed zero'd, no? Run the following before and after your change: Ah, yep. Can't believe I missed that (along with all the other

Re: malloc in libssl/src/apps

2014-05-05 Thread Alexander Hall
On 05/06/14 00:10, Matthew Dempsky wrote: On Sun, May 4, 2014 at 8:26 PM, Jean-Philippe Ouellet jean-phili...@ouellet.biz wrote: On Sun, May 04, 2014 at 11:30:40PM +0200, Alexander Hall wrote: NULL theoretically could be != 0 Umm... short of something like: #undef NULL #define NULL

Re: malloc in libssl/src/apps

2014-05-05 Thread Matthew Dempsky
On Mon, May 5, 2014 at 3:56 PM, Alexander Hall alexan...@beard.se wrote: I believe a similar situation could appear with not explicitly initialized global or static declarations, e.g. in sbin/fsirand/fsirand.c: fsirand(char *device) { ... static char *inodebuf; This is

Questions about C (was: Re: malloc in libssl/src/apps)

2014-05-05 Thread Jérémie Courrèges-Anglas
Matthew Dempsky matt...@dempsky.org writes: On Mon, May 5, 2014 at 3:56 PM, Alexander Hall alexan...@beard.se wrote: I believe a similar situation could appear with not explicitly initialized global or static declarations, e.g. in sbin/fsirand/fsirand.c: fsirand(char *device) {

Re: malloc in libssl/src/apps

2014-05-05 Thread Alexander Hall
On May 6, 2014 1:34:01 AM CEST, Matthew Dempsky matt...@dempsky.org wrote: On Mon, May 5, 2014 at 3:56 PM, Alexander Hall alexan...@beard.se wrote: I believe a similar situation could appear with not explicitly initialized global or static declarations, e.g. in sbin/fsirand/fsirand.c: