On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
> On 9.9.2015. 10:10, Claudio Jeker wrote:
> > This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
> > Seems to work for me but don't expect any miracles.
> >
> > Please test
> >
>
> Hi,
>
> i am testing
On 10.9.2015. 9:47, Peter Hessler wrote:
> On 2015 Sep 09 (Wed) at 23:57:57 +0200 (+0200), Hrvoje Popovski wrote:
> :On 9.9.2015. 10:10, Claudio Jeker wrote:
> :> This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
> :> Seems to work for me but don't expect any miracles.
>
On Wed, Sep 9, 2015 at 9:43 PM, Lawrence Teo wrote:
> On Wed, Sep 09, 2015 at 11:17:55AM -0500, Brent Cook wrote:
>> On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller
>> wrote:
>> > On Wed, 09 Sep 2015 10:02:17 -0400, Lawrence Teo wrote:
>> >> In
make it so.. ok beck@
On Thu, Sep 10, 2015 at 1:06 AM, Brent Cook wrote:
> On Wed, Sep 9, 2015 at 9:43 PM, Lawrence Teo wrote:
>> On Wed, Sep 09, 2015 at 11:17:55AM -0500, Brent Cook wrote:
>>> On Wed, Sep 9, 2015 at 10:15 AM, Todd C. Miller
>>>
We're sure the parent is alive when a cloned route is removed from the
table because removing the parent kill all the children.
Ok?
Index: net/route.c
===
RCS file: /cvs/src/sys/net/route.c,v
retrieving revision 1.230
diff -u -p
On Thu, Sep 10, 2015 at 10:25:59AM +0200, Martin Pieuchot wrote:
> We're sure the parent is alive when a cloned route is removed from the
> table because removing the parent kill all the children.
>
> Ok?
OK
> Index: net/route.c
>
I think all of these except perhaps Coproc_id would be better as plain
int not int32_t.
The typedefs could probably die completely (definitely Tflag anyway) but
separate diff.
On Wed, Sep 09, 2015 at 08:27:14PM -0400, Michael McConville wrote:
> I may be totally off base here, but:
>
> INT32's
On 2015 Sep 09 (Wed) at 23:57:57 +0200 (+0200), Hrvoje Popovski wrote:
:On 9.9.2015. 10:10, Claudio Jeker wrote:
:> This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
:> Seems to work for me but don't expect any miracles.
:>
:> Please test
:>
:
:Hi,
:
:i am testing your
On 10.9.2015. 9:57, Claudio Jeker wrote:
> There are still some issues with this first version. Here a 2nd version
> that pushes the kernel lock even a bit further and tries to solve some of
> the problems between the interrupt handler and the ioctl code.
> There is still something not fully right
It would be more helpful to post the diff again rather than a link
buried in another thread.
Any oks for this?
Index: jobs.c
===
RCS file: /cvs/src/bin/ksh/jobs.c,v
retrieving revision 1.41
diff -u -p -r1.41 jobs.c
--- jobs.c
Currently NSD's compat functions for b64_pton and b64_ntop are always
used. Worse, they're the old versions which abort(). This is because
the library symbols are prefixed by __ (not just in OpenBSD) and are
only accessible as b64_xx when resolv.h is included.
First attempt at fixing this
On Thu, 10 Sep 2015 12:51:37 +0100, Nicholas Marriott wrote:
> It would be more helpful to post the diff again rather than a link
> buried in another thread.
>
> Any oks for this?
OK millert@
- todd
Does this look good? I'm not sure why these globals existed.
It looks like it's going to take a little more than search-and-replace
to remove null.
Index: c_ksh.c
===
RCS file: /cvs/src/bin/ksh/c_ksh.c,v
retrieving revision 1.36
ping
On 09/04/15 08:50, Martijn van Duren wrote:
Here's a slightly updated patch which makes sure that 0x0x
isn't possible
On 09/03/15 21:59, Martijn van Duren wrote:
Hello tech@,
I gave a look to getint in var.c, which turned out to roll out it's own
version of string to long conversion,
On 09/10/15 15:56, Michael McConville wrote:
Martijn van Duren wrote:
I already sent this diff on September 1st.[1] Pointed out in private
to and ok by nicm@
[1]http://marc.info/?l=openbsd-tech=144112883814618=2
Ah, awkward. I hadn't seen this.
Can you clarify why you used int instead of
On 10.9.2015. 9:57, Claudio Jeker wrote:
> On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
>> On 9.9.2015. 10:10, Claudio Jeker wrote:
>>> This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
>>> Seems to work for me but don't expect any miracles.
>>>
>>>
Martijn van Duren wrote:
> I already sent this diff on September 1st.[1] Pointed out in private
> to and ok by nicm@
>
> [1]http://marc.info/?l=openbsd-tech=144112883814618=2
Ah, awkward. I hadn't seen this.
Can you clarify why you used int instead of int32_t?
ping
Michael McConville wrote:
> The first is a pretty trivial change for clarity and correctness.
>
> The second probably isn't the best way to solve the problem long-term,
> but prevents a div-by-zero two lines later. I may have been affected by
> it when fscking a /dev/zero'd partition.
>
>
Does this look right?
Index: login_yubikey.c
===
RCS file: /cvs/src/libexec/login_yubikey/login_yubikey.c,v
retrieving revision 1.10
diff -u -p -r1.10 login_yubikey.c
--- login_yubikey.c 16 Jan 2015 06:39:50 - 1.10
+++
Michael McConville sccs.swarthmore.edu> writes:
> RCS file: /cvs/src/bin/ksh/c_ksh.c,v
> - shprintf(newline);
> + shprintf("\n");
In terms of portability, are you sure newline is \n on all platforms?
Alexey Suslikov wrote:
> Michael McConville sccs.swarthmore.edu> writes:
>
> > RCS file: /cvs/src/bin/ksh/c_ksh.c,v
>
>
>
> > - shprintf(newline);
> > + shprintf("\n");
>
> In terms of portability, are you sure newline is \n on all platforms?
I'm not. Do
On Thu, Sep 10, 2015 at 8:45 PM, Loganaden Velvindron
wrote:
> On Thu, Sep 10, 2015 at 6:36 PM, Michael McConville <
> mmcco...@sccs.swarthmore.edu> wrote:
>
>> These seem like they were definitely meant to be explicit zeroings.
>>
>> Hi,
>
> I'm not entirely sure about this.
Philip Guenther wrote:
> Loganaden Velvindron wrote:
> > Michael McConville wrote:
> >> These seem like they were definitely meant to be explicit zeroings.
> >
> > I'm not entirely sure about this. Since the variable (data) is used
> > before return, it would not be optimized away by the compiler.
On Thu, Sep 10, 2015 at 6:36 PM, Michael McConville <
mmcco...@sccs.swarthmore.edu> wrote:
> These seem like they were definitely meant to be explicit zeroings.
>
> Hi,
I'm not entirely sure about this. Since the variable (data) is used before
return, it would not be optimized away by the
These seem like they were definitely meant to be explicit zeroings.
Index: pfkey.c
===
RCS file: /cvs/src/usr.sbin/bgpd/pfkey.c,v
retrieving revision 1.44
diff -u -p -r1.44 pfkey.c
--- pfkey.c 10 Feb 2015 05:18:39 -
looks good to me, any other ok?
null is serious poo and really needs to go as well
On Thu, Sep 10, 2015 at 10:45:46AM -0400, Michael McConville wrote:
> Does this look good? I'm not sure why these globals existed.
>
> It looks like it's going to take a little more than search-and-replace
> to
> - * NOTE: INT32 may end up being more than 32 bits.
> /* Table flag type - needs > 16 and < 32 bits */
> -typedef INT32 Tflag;
awkward...
Hi
On Thu, Sep 10, 2015 at 04:33:07PM -0600, Todd C. Miller wrote:
> On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
>
> > looks good to me, any other ok?
> >
> > null is serious poo and really needs to go as well
>
> Beware! Some of these values are used in pointer comparisons
On Fri, Sep 11, 2015 at 12:11:07AM +0200, Hrvoje Popovski wrote:
> On 10.9.2015. 17:02, Hrvoje Popovski wrote:
> > On 10.9.2015. 9:57, Claudio Jeker wrote:
> >> On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
> >>> On 9.9.2015. 10:10, Claudio Jeker wrote:
> This is a port of
> The project goals are simply and plainly incompatible. Sqlite is
> too much about database featurism, accepting considerable bloat
> into the codebase, while mandoc needs to focus on minimalism and
A good fraction of these changes relate to the FTS5 code, which would
not be compiled in to
On 10.9.2015. 17:02, Hrvoje Popovski wrote:
> On 10.9.2015. 9:57, Claudio Jeker wrote:
>> On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
>>> On 9.9.2015. 10:10, Claudio Jeker wrote:
This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
Seems to work
Todd C. Miller wrote:
> On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
> > looks good to me, any other ok?
> >
> > null is serious poo and really needs to go as well
>
> Beware! Some of these values are used in pointer comparisons so
> I'm not sure it is same to remove them.
>
>
On Thu, 10 Sep 2015 23:43:15 +0100, Nicholas Marriott wrote:
> ok then?
OK for removing newline (and space too).
- todd
On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
> looks good to me, any other ok?
>
> null is serious poo and really needs to go as well
Beware! Some of these values are used in pointer comparisons so
I'm not sure it is same to remove them.
I don't see any comparisons with
On Thu, Sep 10, 2015 at 12:58:52AM +0200, Alexander Hall wrote:
> I'm going wide with this diff I've been pushing for quite some time now.
>
> Is *anyone* but me using rdump(8) + rmt(8)?
I use dump(8) for doing remote backup, but I don't use rmt(8), due to
plaintext storage on remote side.
>
Stuart Henderson wrote:
> Currently NSD's compat functions for b64_pton and b64_ntop are always
> used. Worse, they're the old versions which abort(). This is because
> the library symbols are prefixed by __ (not just in OpenBSD) and are
> only accessible as b64_xx when resolv.h is included.
>
>
Michael McConville wrote:
> Alexey Suslikov wrote:
> > Michael McConville sccs.swarthmore.edu> writes:
> >
> > > RCS file: /cvs/src/bin/ksh/c_ksh.c,v
> >
> >
> >
> > > - shprintf(newline);
> > > + shprintf("\n");
> >
> > In terms of portability, are you sure
On 3/09/2015, at 10:41 AM, Richard Procter wrote:
> [...] or for that matter just unit-test the pf_change() calls. I
> think I'll rustle up some of the later.
That was a useful exercise. The pf_change_*() code is fine.
However, pf_cksum_fixup_a() reliably faulted a couple of times
over 2E7
> Can you clarify why you used int instead of int32_t?
Considering that
- the comment around it said ``Find an integer type that is at least 32 bits''
- int may be less than 32 bits wide (C99 5.2.4.2.1)
- int32_t is not guaranteed to exist (C99 7.18.1.1p3)
The most appropriate type would be
in6_embedscope() needs to lose some weight. Remove the last argument.
In all but two calls NULL is passed and in the other 2 cases the ifp
is only used to maybe feed it to in6_selecthlim() to select the hoplimit
for the link. Since in6_embedscope() only works on link-local addresses
it does not
On Thu, Sep 10, 2015 at 02:36:41PM -0400, Michael McConville wrote:
> These seem like they were definitely meant to be explicit zeroings.
>
OK claudio@
>
> Index: pfkey.c
> ===
> RCS file: /cvs/src/usr.sbin/bgpd/pfkey.c,v
>
On Thu, 10 Sep 2015 13:07:17 -0400, Michael McConville wrote:
> Does this look right?
Yes.
- todd
I've written a patch to ensure that /etc/netstart executes ifconfig
inet6 autoconf, even when interfaces are specified as arguments.
I've updated my patch for revision 1.153 of /etc/netstart from the
revision 1.144 that my original patch was based on.
To the best of my judgement, this patch will
43 matches
Mail list logo