unveil manpage tweak 2

2018-09-25 Thread Michael Mikonos
Re-reading the unveil manual I found a typo which isn't flagged by a spell checker. Does anyone prefer just doing s/paths// though? Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.10 diff -u -p

getent: use more appropiate types/limits around strtonum()

2018-09-25 Thread Klemens Nanni
Replace `long long id' with appropiate types and names, use smaller limits where applicable and move variable declarations up out of loops. This makes the code clearer and a tad simpler while staying consistent across databases. Feedback? OK? Index: getent.c

Re: OpenBGPd Feature Request / Question if the Feature Request

2018-09-25 Thread Tom Smyth
Hello Gregory ,please find my responses in line On Tue 25 Sep 2018, 15:54 Gregory Edigarov, wrote: > > > the whole discussion here reminds me somewhat about my idea I wanted to > realize some time ago: > suppose we have an imaginary "fast" router, which does hardware > assisted forwarding, and

Re: [patch] Perl: update Scalar-List-Utils to 1.50

2018-09-25 Thread Andrew Hewus Fresh
On Tue, Sep 25, 2018 at 09:43:57PM +0100, Stuart Henderson wrote: > On 2018/09/25 19:02, Charlene Wendling wrote: > > Hi, > > > > I'm proposing here a diff to update Scalar-List-Utils to 1.50. > > > > It will be needed to import p5-List-AllUtils, that in turn would allow > > to import

Re: slow vim and malloc

2018-09-25 Thread Stuart Henderson
On 2018/09/25 22:24, Matthias Schmidt wrote: > hi Stuart, > > * Stuart Henderson wrote: > > > > These settings in .vimrc make it quite noticeable > > > > syn > > set foldmethod=syntax > > set foldlevelstart=1 > > Totally forget about this thread. I had the same issue and the > following

Re: getent: usage() is void

2018-09-25 Thread Todd C. Miller
On Tue, 25 Sep 2018 21:43:41 +0200, Klemens Nanni wrote: > OK? I think you should use __dead here too. E.g. static void __dead usage(void); - todd > Index: getent.c > === > RCS file: /cvs/src/usr.bin/getent/getent.c,v >

Re: [patch] Perl: update Scalar-List-Utils to 1.50

2018-09-25 Thread Stuart Henderson
On 2018/09/25 19:02, Charlene Wendling wrote: > Hi, > > I'm proposing here a diff to update Scalar-List-Utils to 1.50. > > It will be needed to import p5-List-AllUtils, that in turn would allow > to import p5-GeoIP2 (currently in -wip) and update others like > p5-Audio-MPD. > > The changelog

Re: slow vim and malloc

2018-09-25 Thread Matthias Schmidt
hi Stuart, * Stuart Henderson wrote: > > These settings in .vimrc make it quite noticeable > > syn > set foldmethod=syntax > set foldlevelstart=1 Totally forget about this thread. I had the same issue and the following options made vim + syntax highlighting at least a bit more usable for me.

Re: [patch] Add IPv6 description for `-T' option in netcat manual

2018-09-25 Thread Jason McIntyre
On Tue, Sep 25, 2018 at 09:11:42AM +0800, Nan Xiao wrote: > Hi tech@, > > According to netcat source code, the `-T' option not only takes effect > in IPv4 but also IPv6: > > if (Tflag != -1) { > if (af == AF_INET && setsockopt(s, IPPROTO_IP, > IP_TOS, ,

Re: Minor clarification in ttys(5) man page

2018-09-25 Thread Jason McIntyre
On Sun, Sep 23, 2018 at 06:00:23PM -0400, Katherine Rohl wrote: > You can reload the ttys file by sending SIGHUP to the init process. > init(8) mentions this but ttys(5) does not, which can be confusing for > users who don't know that. I've added a note to this effect to ttys(5) > referencing

getent: usage() is void

2018-09-25 Thread Klemens Nanni
OK? Index: getent.c === RCS file: /cvs/src/usr.bin/getent/getent.c,v retrieving revision 1.16 diff -u -p -r1.16 getent.c --- getent.c25 Sep 2018 06:48:48 - 1.16 +++ getent.c25 Sep 2018 19:41:04 - @@ -55,7 +55,7

[patch] Perl: update Scalar-List-Utils to 1.50

2018-09-25 Thread Charlene Wendling
Hi, I'm proposing here a diff to update Scalar-List-Utils to 1.50. It will be needed to import p5-List-AllUtils, that in turn would allow to import p5-GeoIP2 (currently in -wip) and update others like p5-Audio-MPD. The changelog indicates no backward incompatible changes between this version

Re: yacc + unveil

2018-09-25 Thread Michael Mikonos
On Tue, Sep 25, 2018 at 11:42:26PM +0800, Michael Mikonos wrote: > On Tue, Sep 25, 2018 at 05:25:54PM +0200, Sebastien Marie wrote: > > On Tue, Sep 25, 2018 at 11:15:43PM +0800, Michael Mikonos wrote: > > > On Tue, Sep 25, 2018 at 03:22:38PM +0100, Ricardo Mestre wrote: > > > > This is an example

Re: yacc + unveil

2018-09-25 Thread Michael Mikonos
On Tue, Sep 25, 2018 at 05:25:54PM +0200, Sebastien Marie wrote: > On Tue, Sep 25, 2018 at 11:15:43PM +0800, Michael Mikonos wrote: > > On Tue, Sep 25, 2018 at 03:22:38PM +0100, Ricardo Mestre wrote: > > > This is an example of better to start at just hoisting the code that > > > opens the many

Re: yacc + unveil

2018-09-25 Thread Sebastien Marie
On Tue, Sep 25, 2018 at 11:15:43PM +0800, Michael Mikonos wrote: > On Tue, Sep 25, 2018 at 03:22:38PM +0100, Ricardo Mestre wrote: > > This is an example of better to start at just hoisting the code that > > opens the many fds and put them all inside open_files(). After that it's > > just a matter

Re: yacc + unveil

2018-09-25 Thread Michael Mikonos
On Tue, Sep 25, 2018 at 03:22:38PM +0100, Ricardo Mestre wrote: > This is an example of better to start at just hoisting the code that > opens the many fds and put them all inside open_files(). After that it's > just a matter of calling pledge("stdio") and we are done. > > Of course that after

Re: OpenBGPd Feature Request / Question if the Feature Request

2018-09-25 Thread Gregory Edigarov
On 22.09.18 17:11, Tom Smyth wrote: Hello Stuart, Thanks for the feedback , I have responded to your feedback in line, On Sat, 22 Sep 2018 at 10:07, Stuart Henderson wrote: Interesting idea but I think the method you're suggesting puts you at higher risk of things *not* reaching their

Re: yacc + unveil

2018-09-25 Thread Ricardo Mestre
This is an example of better to start at just hoisting the code that opens the many fds and put them all inside open_files(). After that it's just a matter of calling pledge("stdio") and we are done. Of course that after this is done we can still make a list of all the files we need to open and

[patch]Modify the example code in write(2) manual

2018-09-25 Thread Nan Xiao
Hi tech@, I am reading write(2) manual, and come across the following example: for (off = 0; off < bsz; off += nw) if ((nw = write(d, buf + off, bsz - off)) == 0 || nw == -1) err(1, "write"); I am just wondering when the write(2) will return 0? If in some cases, it will

Re: yacc + unveil

2018-09-25 Thread Theo de Raadt
Theo de Raadt wrote: > Michael Mikonos wrote: > > > On Mon, Sep 24, 2018 at 10:53:47PM -0600, Theo de Raadt wrote: > > > Ugh. A diff which doens't check error returns. Averting my gaze > > > is similar to "no way". Hope you have another quarter, because you > > > need to try again > > > >

Re: yacc + unveil

2018-09-25 Thread Theo de Raadt
Michael Mikonos wrote: > On Mon, Sep 24, 2018 at 10:53:47PM -0600, Theo de Raadt wrote: > > Ugh. A diff which doens't check error returns. Averting my gaze > > is similar to "no way". Hope you have another quarter, because you > > need to try again > > Oops... new coin inserted. I decided to

Re: bgpd ROA validation

2018-09-25 Thread Job Snijders
On Tue, Sep 25, 2018 at 12:23:48PM +0200, Claudio Jeker wrote: > On Sat, Sep 22, 2018 at 09:48:24PM +, Job Snijders wrote: > > Seems we are getting very close. Some suggestions to simplify the > > experience for the end user. > > > > Let's start with supporting just one (unnamed) roa-set, so

Re: bgpd ROA validation

2018-09-25 Thread Claudio Jeker
On Sat, Sep 22, 2018 at 09:48:24PM +, Job Snijders wrote: > Hi claudio, > > Seems we are getting very close. Some suggestions to simplify the > experience for the end user. > > Let's start with supporting just one (unnamed) roa-set, so far I've > really not come across a use case where

Re: [patch] Add IPv6 description for `-T' option in netcat manual

2018-09-25 Thread Jason McIntyre
On Tue, Sep 25, 2018 at 03:25:51PM +0800, Nan Xiao wrote: > Hi Jason, > > According to IPv6(https://en.wikipedia.org/wiki/IPv6_packet) and IPv4 > TOS(https://en.wikipedia.org/wiki/Type_of_service), Traffic class and > TOS seem have the same structure: the first six bits are DS field and > the

Re: [patch] Add IPv6 description for `-T' option in netcat manual

2018-09-25 Thread Nan Xiao
Hi Jason, According to IPv6(https://en.wikipedia.org/wiki/IPv6_packet) and IPv4 TOS(https://en.wikipedia.org/wiki/Type_of_service), Traffic class and TOS seem have the same structure: the first six bits are DS field and the last two bits for Explicit Congestion Notification. Thanks! Best

Re: Minor clarification in ttys(5) man page

2018-09-25 Thread Jason McIntyre
On Sun, Sep 23, 2018 at 06:00:23PM -0400, Katherine Rohl wrote: > You can reload the ttys file by sending SIGHUP to the init process. > init(8) mentions this but ttys(5) does not, which can be confusing for > users who don't know that. I've added a note to this effect to ttys(5) > referencing

Re: [patch] Add IPv6 description for `-T' option in netcat manual

2018-09-25 Thread Jason McIntyre
On Tue, Sep 25, 2018 at 09:11:42AM +0800, Nan Xiao wrote: > Hi tech@, > morning. > According to netcat source code, the `-T' option not only takes effect > in IPv4 but also IPv6: > > if (Tflag != -1) { > if (af == AF_INET && setsockopt(s, IPPROTO_IP, >

unveil manpage tweak

2018-09-25 Thread Michael Mikonos
This patch aligns unveil.2 with pledge.2, so the unveil manual will explicitly mention errno is set. OK? Index: unveil.2 === RCS file: /cvs/src/lib/libc/sys/unveil.2,v retrieving revision 1.9 diff -u -p -u -r1.9 unveil.2 ---