Re: Case-sensitivity of timezone paths in the installer

2021-05-01 Thread Luigi30
Okay, thanks for the clarification. If it's by design, and not all implementations may be case-sensitive, should the installer clarify in case of a user not entering a valid timezone path that paths are case-sensitive? Right now I think it could be made a little clearer that it's looking for an

Re: Case-sensitivity of timezone paths in the installer

2021-05-01 Thread Theo de Raadt
Luigi30 wrote: > I noticed that timezone paths in the installer step that sets the system > timezone are case-sensitive to match the paths in /usr/share/zoneinfo. > (Specifically, it's set_timezone() in /usr/src/distrib/miniroot/install.sub.) > > It seems like the behavior should be more like:

Case-sensitivity of timezone paths in the installer

2021-05-01 Thread Luigi30
Hi, I noticed that timezone paths in the installer step that sets the system timezone are case-sensitive to match the paths in /usr/share/zoneinfo. (Specifically, it's set_timezone() in /usr/src/distrib/miniroot/install.sub.) It seems like the behavior should be more like: - Upon entering

Cleanup of err(1, "unveil") pattern? Diff for ps.c.

2021-05-01 Thread Ashton Fagg
Hi all, I saw a discussion on here a while ago about the use of patterns like: if (unveil(some_path, "r") == -1) err(1, "unveil"); And why that's maybe not preferable for debugging and troubleshooting purposes for programs which have multiple unveil calls (which happens fairly often).

added support for precompressed static files on httpd(so sorry about my other email that was unreadable)

2021-05-01 Thread alloca
This patch adds a serve_gzip option. When enabled, If the client requests path, then serve path.gz if it exists and the client accepts Content-Encoding: gzip. diff -up httpd.orig/config.c httpd/config.c --- httpd.orig/config.c Sat May 1 15:03:11 2021 +++ httpd/config.c Sat May 1 15:45:43 2021

added support for precompressed static files on httpd

2021-05-01 Thread alloca
This patch adds a serve_gzip option. When enabled, If the client requests path, then serve path.gz if it exists and the client accepts Content-Encoding: gzip. diff -up httpd.orig/config.c httpd/config.c --- httpd.orig/config.c Sat May 1 15:03:11 2021 +++ httpd/config.c Sat May 1 15:45:43 2021 @@

rcctl(8): use modern ksh semantics

2021-05-01 Thread Jordan Geoghegan
Hello, I've been perusing some of the ksh scripts within /usr/sbin/ and noticed some differences in coding style and shell syntax usage. Is there an "official" OpenBSD ksh style guide or a list of recommendations? For example, syspatch, sysupgrade and sysmerge all use double square brackets

Re: added support for precompressed static files on httpd(so sorry about my other email that was unreadable)

2021-05-01 Thread Dave Voutila
alloca writes: > This patch adds a serve_gzip option. When enabled, If the client requests > path, then serve path.gz if it exists and the client accepts > Content-Encoding: gzip. While I believe I understand your objective, your diff has numerous issues. It also seems you've either

Re: /etc/netstart argument handling

2021-05-01 Thread Tilo Stritzky
On 01/05/21 11:09 Andreas Kusalananda K�h�ri wrote: > On Fri, Apr 30, 2021 at 09:17:47PM +0200, Tilo Stritzky wrote: > > > > /etc/netstart contains the following getopts handler: > > > > while getopts ":n" opt; do > > > > That colon is just totally bogus, isn't it? > > The colon at the start of

Re: recv.2 patch

2021-05-01 Thread Theo de Raadt
Edgar Pettijohn wrote: > slight wording change. it doesn't return these values it sets errno to > these values... .Fn recv and .Fn recvfrom -may return the following error: +may fail if: .Bl -tag -width Er .It Bq Er EINVAL .Fa len I think it is more accurate the way it is, rather than

recv.2 patch

2021-05-01 Thread Edgar Pettijohn
slight wording change. it doesn't return these values it sets errno to these values... Index: recv.2 === RCS file: /cvs/src/lib/libc/sys/recv.2,v retrieving revision 1.47 diff -u -p -u -r1.47 recv.2 --- recv.2 11 Jan 2019

libagent: fix agentx_context_object_nfind

2021-05-01 Thread Martijn van Duren
The parameters for ax_oid_cmp are swapped. This fixes the few failing regress tests I just committed. OK? martijn@ Index: agentx.c === RCS file: /cvs/src/lib/libagentx/agentx.c,v retrieving revision 1.9 diff -u -p -r1.9 agentx.c

Re: Update the remaining SYSCTL_INT_READONLY cases

2021-05-01 Thread Vitaliy Makkoveev
> On 1 May 2021, at 19:08, Greg Steuck wrote: > > Vitaliy Makkoveev writes: > >> On Fri, Apr 30, 2021 at 10:14:31PM -0700, Greg Steuck wrote: >> Hi, you missing KERN_SYSVMSG, KERN_SYSVSEM, KERN_SYSVSHM variables. The >> rest diff is ok by me. > > Good catch. My search/replace pattern

Re: Update the remaining SYSCTL_INT_READONLY cases

2021-05-01 Thread Greg Steuck
Vitaliy Makkoveev writes: > On Fri, Apr 30, 2021 at 10:14:31PM -0700, Greg Steuck wrote: > Hi, you missing KERN_SYSVMSG, KERN_SYSVSEM, KERN_SYSVSHM variables. The > rest diff is ok by me. Good catch. My search/replace pattern wasn't good enough. Fixed and will commit. >> >> Unused, maybe

Re: shell manpage tweaks wrt getopt

2021-05-01 Thread Theo de Raadt
Christian Weisgerber wrote: > Marc Espie: > > > I would also actually be fairly happy if we changed drastically the way > > sh(1) and ksh(1) look. To me, sh(1) should be the (more or less) standard > > shell documentation, AND ksh(1) should contain the differences/extensions. > > I think that

Re: shell manpage tweaks wrt getopt

2021-05-01 Thread Christian Weisgerber
Marc Espie: > I would also actually be fairly happy if we changed drastically the way > sh(1) and ksh(1) look. To me, sh(1) should be the (more or less) standard > shell documentation, AND ksh(1) should contain the differences/extensions. I think that is a terrible idea. Historically the

Re: shell manpage tweaks wrt getopt

2021-05-01 Thread Jason McIntyre
On Sat, May 01, 2021 at 04:33:08PM +0200, Christian Weisgerber wrote: > Jason McIntyre: > > > - i'm ok with the getopt.1 and ksh.1 parts > > - i'm not ok with the addition to sh.1 > > > > no one has really given a good reason why they think it should go into > > sh.1. i've given a few why i

Re: Update the remaining SYSCTL_INT_READONLY cases

2021-05-01 Thread Vitaliy Makkoveev
On Fri, Apr 30, 2021 at 10:14:31PM -0700, Greg Steuck wrote: > Vitaliy Makkoveev writes: > > > On Thu, Apr 29, 2021 at 09:31:57AM -0700, Greg Steuck wrote: > >> Alexander Bluhm writes: > >> >> I like this too. I somehow got the impression that macros are severely > >> >> frowned upon and didn't

ftpd(8): remove useless islower(3) in upper()

2021-05-01 Thread Jan Klemkow
Hi, This cleanup diff, removes a useless if islower(3) from the loop. It is guarantee by toupper(3) that no character will be changed if its not a lower one. man toupper(3): The toupper() and toupper_l() functions convert a lower-case letter to the corresponding upper-case letter.

Re: shell manpage tweaks wrt getopt

2021-05-01 Thread Christian Weisgerber
Jason McIntyre: > - i'm ok with the getopt.1 and ksh.1 parts > - i'm not ok with the addition to sh.1 > > no one has really given a good reason why they think it should go into > sh.1. i've given a few why i think it should not. My understanding is that sh.1 is a subset of ksh.1, describing the

Re: /etc/netstart argument handling

2021-05-01 Thread Andreas Kusalananda Kähäri
On Fri, Apr 30, 2021 at 09:17:47PM +0200, Tilo Stritzky wrote: > > /etc/netstart contains the following getopts handler: > > while getopts ":n" opt; do > > That colon is just totally bogus, isn't it? The colon at the start of the optstring has the effect that makes the getopts utility silent

Re: rpki-client delay deletes also for RRDP repos

2021-05-01 Thread Theo de Raadt
Claudio Jeker wrote: > > So, that would suggest some sort of lockout against running multiple > > rpki-client with the correct termination strategy. I don't believe we > > have such a thing right now. We have the timeout, to ensure rpki-client > > doesn't run too long which may prevent

Re: softraid(4) crypto/raid1c refactoring

2021-05-01 Thread Matthias Schmidt
Hi Stefan, * Stefan Sperling wrote: > Refactor softraid crypto code to allow use of a discipline-specific data > structure for RAID1C volumes, as requested by jsing@ during review of my > initial RAID1C patch. > > This patch should effectively be a cosmetic change. > The whole point of this

Re: rpki-client delay deletes also for RRDP repos

2021-05-01 Thread Claudio Jeker
On Fri, Apr 30, 2021 at 10:58:25PM -0600, Theo de Raadt wrote: > Sebastian Benoit wrote: > > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.29 15:34:15 +0200: > > > Like for rsync repos files in the RRDP repos should be delayed until after > > > the validation finished. As with anything

Re: rpki-client delay deletes also for RRDP repos

2021-05-01 Thread Claudio Jeker
On Sat, May 01, 2021 at 12:14:22AM +0200, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.04.29 15:34:15 +0200: > > Like for rsync repos files in the RRDP repos should be delayed until after > > the validation finished. As with anything RPKI related there is little > >

unlock lseek(2)

2021-05-01 Thread Anton Lindqvist
Hi, In August 2019 I tried to unlock lseek(2) which failed since the vnode lock could not be acquired without holding the kernel lock back then, found the hard way. claudio@ recently[1] make it possible to acquire a vnode lock without holding the kernel lock. I therefore would like to give this