Re: panic(9): set panicstr atomically

2021-05-21 Thread Alexander Bluhm
On Fri, May 21, 2021 at 02:00:54PM -0500, Scott Cheloha wrote: > Given all of this, would it be better if secondary CPUs spin in > panic(9) instead of trying to print anything? The panic code should be as primitive as possible. The garbled output also tells me something. Two CPUs are failing

Re: Use atomic op for UVM map refcount

2021-05-21 Thread Mark Kettenis
> From: Philip Guenther > Date: Thu, 20 May 2021 23:45:46 -0900 > > On Wed, May 19, 2021 at 11:29 PM Martin Pieuchot wrote: > > On 19/05/21(Wed) 16:17, Mark Kettenis wrote: > > ... > > > There are the READ_ONCE() and WRITE_ONCE() macros. I'm not a big fan > > of those (since they add

Re: ftpd(8): constify internal functions

2021-05-21 Thread Jan Klemkow
ping? On Thu, May 13, 2021 at 04:44:56PM +0200, Jan Klemkow wrote: > ping? > > On Tue, May 04, 2021 at 10:50:50AM +0200, Jan Klemkow wrote: > > Hi, > > > > The following diff adds some missing consts for char * to the internal > > program functions. > > > > OK? > > > > bye, > > Jan > > > >

Re: ftpd(8): remove double fflush(3) calls

2021-05-21 Thread Jan Klemkow
ping? On Thu, May 13, 2021 at 04:44:23PM +0200, Jan Klemkow wrote: > ping? > > On Wed, May 05, 2021 at 04:42:49PM +0200, Jan Klemkow wrote: > > Hi, > > > > The function lreply() already calls fflush(3) on stdout. So, this calls > > are useless. > > > > OK? > > > > bye, > > Jan > > > >

Re: ftpd(8): remove useless islower(3) in upper()

2021-05-21 Thread Jan Klemkow
ping? On Thu, May 13, 2021 at 04:45:14PM +0200, Jan Klemkow wrote: > ping? > > On Sat, May 01, 2021 at 11:19:56AM +0200, Jan Klemkow wrote: > > Hi, > > > > This cleanup diff, removes a useless if islower(3) from the loop. It is > > guarantee by toupper(3) that no character will be changed if

Re: Use atomic op for UVM map refcount

2021-05-21 Thread Mark Kettenis
> From: Philip Guenther > Date: Thu, 20 May 2021 23:32:17 -0900 > > On Wed, May 19, 2021 at 5:19 AM Mark Kettenis > wrote: > > > Date: Tue, 18 May 2021 13:24:42 +0200 > > From: Martin Pieuchot > > ... > > > There's only a couple of 'volatile' usages in sys/sys. These > annotations >

Re: panic(9): set panicstr atomically

2021-05-21 Thread Scott Cheloha
On Sat, May 15, 2021 at 01:15:28PM +0200, Mark Kettenis wrote: > > Date: Sat, 15 May 2021 11:06:39 + > > From: Visa Hankala > > > > On Wed, May 12, 2021 at 07:08:39PM -0500, Scott Cheloha wrote: > > > In a separate mail thread, bluhm@ mentioned that panic(9) does not > > > cleanly handle

Re: xhci early enumeration

2021-05-21 Thread Patrick Wildt
Am Fri, May 21, 2021 at 07:24:59PM +0200 schrieb Mark Kettenis: > > Date: Fri, 21 May 2021 19:01:39 +0200 > > From: Patrick Wildt > > > > Am Fri, May 21, 2021 at 06:18:40PM +0200 schrieb Martin Pieuchot: > > > On 21/05/21(Fri) 10:48, Patrick Wildt wrote: > > > > Am Wed, May 19, 2021 at

Re: xhci early enumeration

2021-05-21 Thread Mark Kettenis
> Date: Fri, 21 May 2021 19:01:39 +0200 > From: Patrick Wildt > > Am Fri, May 21, 2021 at 06:18:40PM +0200 schrieb Martin Pieuchot: > > On 21/05/21(Fri) 10:48, Patrick Wildt wrote: > > > Am Wed, May 19, 2021 at 07:15:50AM + schrieb Christian Ludwig: > > > > The usb(4) driver allows to

Re: xhci early enumeration

2021-05-21 Thread Patrick Wildt
Am Fri, May 21, 2021 at 06:18:40PM +0200 schrieb Martin Pieuchot: > On 21/05/21(Fri) 10:48, Patrick Wildt wrote: > > Am Wed, May 19, 2021 at 07:15:50AM + schrieb Christian Ludwig: > > > The usb(4) driver allows to enumerate the bus early during boot by > > > setting its driver flags to 0x1 in

Re: [patch] tcpdump: Sync DNS types with IANA

2021-05-21 Thread Stuart Henderson
On 2021/05/20 08:36, Theo Buehler wrote: > On Thu, May 20, 2021 at 07:05:24AM +0100, Stuart Henderson wrote: > > When I have time (I'm hopeful for next week but not sure yet) I'll > > see how this goes with a ports bulk build. > > This diff changes usr.sbin/tcpdump/nameser.h rather than > I

Re: xhci early enumeration

2021-05-21 Thread Martin Pieuchot
On 21/05/21(Fri) 10:48, Patrick Wildt wrote: > Am Wed, May 19, 2021 at 07:15:50AM + schrieb Christian Ludwig: > > The usb(4) driver allows to enumerate the bus early during boot by > > setting its driver flags to 0x1 in UKC. This mechanism can enable a USB > > console keyboard early during

Re: ACPI aml_rwgsb() fix

2021-05-21 Thread Cesare Gargano
On Fri, May 21, 2021 at 06:03:49AM +0200, Theo Buehler wrote: > On Thu, May 20, 2021 at 12:19:37AM +0200, Mark Kettenis wrote: > > My last change to dsdt.c broke one or two of my cheap little Intel > > "Atom" laptops. Seems my interpretation of the ACPI standard wasn't > > quite right. I went

Re: xhci early enumeration

2021-05-21 Thread Patrick Wildt
Am Wed, May 19, 2021 at 07:15:50AM + schrieb Christian Ludwig: > The usb(4) driver allows to enumerate the bus early during boot by > setting its driver flags to 0x1 in UKC. This mechanism can enable a USB > console keyboard early during autoconf(9), which can come in handy at > times. This

Re: Use atomic op for UVM map refcount

2021-05-21 Thread Philip Guenther
On Wed, May 19, 2021 at 11:29 PM Martin Pieuchot wrote: > On 19/05/21(Wed) 16:17, Mark Kettenis wrote: > ... > > There are the READ_ONCE() and WRITE_ONCE() macros. I'm not a big fan > > of those (since they add clutter) but they do take care of dependency > > ordering issues that exist in the

Re: Use atomic op for UVM map refcount

2021-05-21 Thread Philip Guenther
On Wed, May 19, 2021 at 5:19 AM Mark Kettenis wrote: > > Date: Tue, 18 May 2021 13:24:42 +0200 > > From: Martin Pieuchot > ... > > There's only a couple of 'volatile' usages in sys/sys. These annotations > > do not explicitly indicate which piece of code requires it. Maybe it > would > > be