Re: ipsp_spd_inp in in_pcbconnect

2021-10-25 Thread Vitaliy Makkoveev
> On 26 Oct 2021, at 00:52, Alexander Bluhm wrote: > > Hi, > > The implementation of ipsp_spd_inp() is side effect free. It sets > the error output parameter and returns a tdb. Both are ignored in > in_pcbconnect(). So this code does nothing. > > ok? > ok mvs@ > bluhm > > Index:

ipsp_spd_inp in in_pcbconnect

2021-10-25 Thread Alexander Bluhm
Hi, The implementation of ipsp_spd_inp() is side effect free. It sets the error output parameter and returns a tdb. Both are ignored in in_pcbconnect(). So this code does nothing. ok? bluhm Index: netinet/in_pcb.c === RCS file:

Re: Dell R620 - latest snapshot

2021-10-25 Thread Hrvoje Popovski
On 25.10.2021. 22:58, Theo de Raadt wrote: > Can you checkout -current, and try this diff: > > It has one additional check for cpu_setperf being NULL, near the top of > setperf_auto() Hi, yes, with this diff box boot normally Tnx ..

Re: Dell R620 - latest snapshot

2021-10-25 Thread Theo de Raadt
Can you checkout -current, and try this diff: It has one additional check for cpu_setperf being NULL, near the top of setperf_auto() Index: dev/acpi/acpiac.c === RCS file: /cvs/src/sys/dev/acpi/acpiac.c,v retrieving revision 1.33

Dell R620 - latest snapshot

2021-10-25 Thread Hrvoje Popovski
Hi all, with latest snaphost from few minutes ago Dell R620 box panic while booting vmm0 at mainbus0: VMX/EPT dt: 445 probes attempt to execute user address 0x0 in supervisor mode kernel: page fault trap, code=0 Stopped at 0TIDPIDUID PRFLAGS PFLAGS CPU COMMAND

/usr/src/*bin: remove unused variables

2021-10-25 Thread Klemens Nanni
Patrick's "bootloader: remove unsued variables" mail reminded me about this diff I still have. M sbin/vnconfig/vnconfig.c M usr.sbin/pcidump/pcidump.c M usr.sbin/wsfontload/wsfontload.c M usr.bin/less/line.c M usr.bin/make/engine.c M

Re: ixl(4): add rx/tx checksum offloading

2021-10-25 Thread Jan Klemkow
On Fri, Oct 22, 2021 at 03:39:01PM +0200, Hrvoje Popovski wrote: > On 22.10.2021. 13:39, Jan Klemkow wrote: > > Thats because, you only see this flags, if the checksum offloading is > > enabled for "sending". I'm still working/debugging on the sending side. > > Thus, I just send a diff with the

Re: snmpd(8): Log correct engineid

2021-10-25 Thread Sebastian Benoit
ok Martijn van Duren(openbsd+t...@list.imperialat.at) on 2021.10.21 08:45:51 +0100: > ping > > On Sun, 2021-09-26 at 10:22 +0200, Martijn van Duren wrote: > > ober_get_nstring writes a pointer to buf and does not overwrite the > > content of buf itself. So pushing an array in there will result

Re: Add missing manpage for smtpd

2021-10-25 Thread Larry Hynes
Hi Crystal Kolipe wrote: > I sent this to bugs@ a while back, but it seems to have been missed. > > smtpd-filters.7 is not installed by default. > > --- usr.sbin/smtpd/smtpd/Makefile.distWed Apr 21 04:54:10 2021 > +++ usr.sbin/smtpd/smtpd/Makefile Mon Oct 25 11:54:39 2021 > @@

Re: rpki-client proc_parser cleanup

2021-10-25 Thread Theo Buehler
On Mon, Oct 25, 2021 at 07:50:46PM +0200, Claudio Jeker wrote: > Refactor this code and instead of passing various things around just use > globals. ok with two small nits: > @@ -560,14 +622,6 @@ proc_parser(int fd) > if ((pfd.revents & POLLHUP)) > break; >

tdb unlink locked

2021-10-25 Thread Alexander Bluhm
Hi, This fixes a panic mtx locking against myself I have introduced in my previous commit. ok? bluhm Index: net/pfkeyv2.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/pfkeyv2.c,v retrieving revision 1.220 diff -u -p -r1.220

ipsec(4): add sockopt to manage additional udpencap ports

2021-10-25 Thread Tobias Heider
UDP-encapsulaton has two common use-cases: to make ESP work with NATs and to circumvent firewalls. Currently we only support a single UDP-encap port at a time, that is globally configured via sysctl. With an iked server, having a single client using a non-standard port to circumvent a firewall

rpki-client proc_parser cleanup

2021-10-25 Thread Claudio Jeker
Refactor this code and instead of passing various things around just use globals. -- :wq Claudio Index: parser.c === RCS file: /cvs/src/usr.sbin/rpki-client/parser.c,v retrieving revision 1.16 diff -u -p -r1.16 parser.c ---

You have (2)One-Drive Document

2021-10-25 Thread Office drive
OneDrive - File Sent To: [EMail] You have (1) new pending file on Onedrive: PO (4092).238kb Please advise availability, Thank you View File - PO (4092) Copyright © 2021 OneDrive, All rights reserved. Microsoft Corporation Want to change how you receive these emails? You can update

Re: misspellings in i386/amd64 conf/GENERIC

2021-10-25 Thread Jason McIntyre
On Mon, Oct 25, 2021 at 04:37:16PM +0200, Janne Johansson wrote: > (Reported by Elyes Haouas on irc) > > gmail probably will mangle the diff, but the replacement is quite simple. > ok. jmc > > Index: amd64/conf/GENERIC > === >

Re: Add missing manpage for smtpd

2021-10-25 Thread Jason McIntyre
On Mon, Oct 25, 2021 at 04:12:17PM +0100, Larry Hynes wrote: > Hi > > Crystal Kolipe wrote: > > I sent this to bugs@ a while back, but it seems to have been missed. > > > > smtpd-filters.7 is not installed by default. > > > > --- usr.sbin/smtpd/smtpd/Makefile.dist Wed Apr 21 04:54:10 2021

Patch for 20 year old off by one bug

2021-10-25 Thread Crystal Kolipe
Another one I sent to bugs@ a while ago. I'm assuming that having 'i386' in the original subject line made everyone hit their 'd' key, without realizing that this affects amd64 too... The patch below fixes an off-by-one in /arch/amd64/stand/libsa/cmd_i386.c. The affected code path is handling

Re: bootloader: remove unsued variables

2021-10-25 Thread Mark Kettenis
> Date: Mon, 25 Oct 2021 16:44:48 +0200 > From: Patrick Wildt > > Hi, > > this fixes the build of sys/arch/amd64/stand with LLVM 13. > > ok? ok kettenis@ > diff --git a/sys/lib/libsa/netif.c b/sys/lib/libsa/netif.c > index d1a5e180291..79c6496878e 100644 > --- a/sys/lib/libsa/netif.c > +++

Add missing manpage for smtpd

2021-10-25 Thread Crystal Kolipe
I sent this to bugs@ a while back, but it seems to have been missed. smtpd-filters.7 is not installed by default. --- usr.sbin/smtpd/smtpd/Makefile.dist Wed Apr 21 04:54:10 2021 +++ usr.sbin/smtpd/smtpd/Makefile Mon Oct 25 11:54:39 2021 @@ -76,7 +76,7 @@ SRCS+= stat_ramstat.c

bootloader: remove unsued variables

2021-10-25 Thread Patrick Wildt
Hi, this fixes the build of sys/arch/amd64/stand with LLVM 13. ok? Patrick diff --git a/sys/lib/libsa/netif.c b/sys/lib/libsa/netif.c index d1a5e180291..79c6496878e 100644 --- a/sys/lib/libsa/netif.c +++ b/sys/lib/libsa/netif.c @@ -85,7 +85,7 @@ netif_match(struct netif *nif, void

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Jeremie Courreges-Anglas
On Mon, Oct 25 2021, Mark Kettenis wrote: >> From: Jeremie Courreges-Anglas >> Date: Mon, 25 Oct 2021 14:55:16 +0100 >> >> On Mon, Oct 25 2021, Mark Kettenis wrote: >> >> Date: Mon, 25 Oct 2021 12:37:41 +0200 (CEST) >> >> From: Mark Kettenis >> >> >> >> > Date: Mon, 25 Oct 2021 12:01:11

misspellings in i386/amd64 conf/GENERIC

2021-10-25 Thread Janne Johansson
(Reported by Elyes Haouas on irc) gmail probably will mangle the diff, but the replacement is quite simple. Index: amd64/conf/GENERIC === RCS file: /cvs/src/sys/arch/amd64/conf/GENERIC,v retrieving revision 1.503 diff -u -p -u

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Mark Kettenis
> From: Jeremie Courreges-Anglas > Date: Mon, 25 Oct 2021 14:55:16 +0100 > > On Mon, Oct 25 2021, Mark Kettenis wrote: > >> Date: Mon, 25 Oct 2021 12:37:41 +0200 (CEST) > >> From: Mark Kettenis > >> > >> > Date: Mon, 25 Oct 2021 12:01:11 +0200 > >> > From: Patrick Wildt > >> > > >> > Hi, >

ipsec tdb hash mutext

2021-10-25 Thread Alexander Bluhm
Hi, Protect the tdb hashes with a mutex. ok? bluhm Index: netinet/ip_ipsp.c === RCS file: /data/mirror/openbsd/cvs/src/sys/netinet/ip_ipsp.c,v retrieving revision 1.246 diff -u -p -r1.246 ip_ipsp.c --- netinet/ip_ipsp.c 13 Oct

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Jeremie Courreges-Anglas
On Mon, Oct 25 2021, Mark Kettenis wrote: >> Date: Mon, 25 Oct 2021 12:37:41 +0200 (CEST) >> From: Mark Kettenis >> >> > Date: Mon, 25 Oct 2021 12:01:11 +0200 >> > From: Patrick Wildt >> > >> > Hi, >> > >> > mortimer@ has this diff in his tree for LLVM 13. I actually haven't >> > tried to

Re: vi(1): fix use after free, sigabrt

2021-10-25 Thread Todd C . Miller
On Mon, 25 Oct 2021 09:13:40 -0400, Dave Voutila wrote: > I don't know the vi codebase, so I can't tell if this is the right way > to fix this. It's a minimal change, but I use vi mostly for quick edits > and commit messages so would appreciate anyone with more knowledge here > to chime in. With

Re: Stop mentioning ld(1) warning messages in mktemp.3 and tmpnam.3

2021-10-25 Thread Todd C . Miller
On Mon, 25 Oct 2021 12:48:01 +1100, Jonathan Gray wrote: > Shouldn't lld instead be changed to show warnings? That was my thinking as well. - todd

vi(1): fix use after free, sigabrt

2021-10-25 Thread Dave Voutila
As reported by kn@ on bugs [1], here's a fix for the issue. In short, if you start vi(1)/ex(1) with a named buffer that's not associated with an existing file and then run the ex_edit command (:e) with zero args, it frees strings for the name of the buffer and the temp file. At quit, the cleanup

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Mark Kettenis
> Date: Mon, 25 Oct 2021 12:37:41 +0200 (CEST) > From: Mark Kettenis > > > Date: Mon, 25 Oct 2021 12:01:11 +0200 > > From: Patrick Wildt > > > > Hi, > > > > mortimer@ has this diff in his tree for LLVM 13. I actually haven't > > tried to see if it works fine with LLVM 11, but I feel it needs

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Theo Buehler
On Mon, Oct 25, 2021 at 01:46:51PM +0200, Sebastien Marie wrote: > I have a working llvm13 here for building zig 0.9.0-dev. > > /usr/src/usr.bin/openssl/s_client.c:897:16: error: variable 'pbuf_off' set > but not used [-Werror,-Wunused-but-set-variable] > int pbuf_len, pbuf_off; >

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Sebastien Marie
On Mon, Oct 25, 2021 at 12:35:03PM +0100, Jeremie Courreges-Anglas wrote: > On Mon, Oct 25 2021, Theo Buehler wrote: > >> index 664a5200037..e33763e7420 100644 > >> --- a/usr.bin/openssl/Makefile > >> +++ b/usr.bin/openssl/Makefile > >> @@ -17,6 +17,7 @@ CFLAGS+= -Wuninitialized > >> CFLAGS+=

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Jeremie Courreges-Anglas
On Mon, Oct 25 2021, Theo Buehler wrote: >> index 664a5200037..e33763e7420 100644 >> --- a/usr.bin/openssl/Makefile >> +++ b/usr.bin/openssl/Makefile >> @@ -17,6 +17,7 @@ CFLAGS+= -Wuninitialized >> CFLAGS+= -Wunused >> .if ${COMPILER_VERSION:L} == "clang" >> CFLAGS+= -Werror >> +CFLAGS+=

Re: snmpd trap community problem

2021-10-25 Thread Stuart Henderson
On 2021/10/25 10:09, Martijn van Duren wrote: > Thanks for the detailed analysis. > > diff below should fix it. thanks, OK. I'm sure I tried that but maybe I missed the _ (SNMPV2 vs SNMP_V2).

Re: riscv64: ld.lld is too picky on ABI mismatch

2021-10-25 Thread Jeremie Courreges-Anglas
On Mon, Oct 25 2021, Patrick Wildt wrote: > Am Mon, Oct 25, 2021 at 11:43:55AM +0200 schrieb Mark Kettenis: >> > From: Jeremie Courreges-Anglas >> > Date: Sun, 24 Oct 2021 17:30:46 +0100 >> > >> > clang(1) defaults to FP ABI but ld(1) -melf64lriscv doesn't. This is >> > a problem as soon as a

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Mark Kettenis
> Date: Mon, 25 Oct 2021 12:01:11 +0200 > From: Patrick Wildt > > Hi, > > mortimer@ has this diff in his tree for LLVM 13. I actually haven't > tried to see if it works fine with LLVM 11, but I feel it needs to be > sent out and not just be blindly committed. > > If someone wants to take care

Re: some warnings in prep for LLVM 13

2021-10-25 Thread Theo Buehler
> index 664a5200037..e33763e7420 100644 > --- a/usr.bin/openssl/Makefile > +++ b/usr.bin/openssl/Makefile > @@ -17,6 +17,7 @@ CFLAGS+= -Wuninitialized > CFLAGS+= -Wunused > .if ${COMPILER_VERSION:L} == "clang" > CFLAGS+= -Werror > +CFLAGS+= -Wno-unused-but-set-variable This will break the

some warnings in prep for LLVM 13

2021-10-25 Thread Patrick Wildt
Hi, mortimer@ has this diff in his tree for LLVM 13. I actually haven't tried to see if it works fine with LLVM 11, but I feel it needs to be sent out and not just be blindly committed. If someone wants to take care of this, it would be nice, so I can take care of the remaining parts of sending

Re: riscv64: ld.lld is too picky on ABI mismatch

2021-10-25 Thread Patrick Wildt
Am Mon, Oct 25, 2021 at 11:43:55AM +0200 schrieb Mark Kettenis: > > From: Jeremie Courreges-Anglas > > Date: Sun, 24 Oct 2021 17:30:46 +0100 > > > > clang(1) defaults to FP ABI but ld(1) -melf64lriscv doesn't. This is > > a problem as soon as a port tries to use raw ld(1) -b binary to embed > >

Re: riscv64: ld.lld is too picky on ABI mismatch

2021-10-25 Thread Mark Kettenis
> From: Jeremie Courreges-Anglas > Date: Sun, 24 Oct 2021 17:30:46 +0100 > > clang(1) defaults to FP ABI but ld(1) -melf64lriscv doesn't. This is > a problem as soon as a port tries to use raw ld(1) -b binary to embed > data in a .o file. > > Downgrading this hard error to a warning seems more

Re: snmpd trap community problem

2021-10-25 Thread Martijn van Duren
Thanks for the detailed analysis. diff below should fix it. martijn@ On Sun, 2021-10-24 at 22:44 +0100, Stuart Henderson wrote: > ooops, sorry not trondd, it was jhuldtgren who spotted it! > > On 2021/10/24 22:26, Stuart Henderson wrote: > > trondd noticed a startup problem with snmpd on

sndio: initial bits for multiple devices support, please test

2021-10-25 Thread Alexandre Ratchov
Hi, Current sndiod logic supports one device only: If two -f are used then two independent instances of the whole server are created, each with its own set of clients, options, controls, and so on. This diff shifts sndiod towards a more flexible (and conceptually simpler) model: - clients